* The class JpegOrTiffHandler was renamed ExifBitmapHandler.
* (bug 29443) Special:Undelete should use JavaScript to invert all checkboxes
without reloading the page
+* (bug 29325) Setting $wgStrictFileExtensions to false gives incorrect warning
=== API changes in 1.19 ===
* BREAKING CHANGE: action=watch now requires POST and token.
* @param $details Array: result of UploadBase::verifyUpload
*/
protected function processVerificationError( $details ) {
- global $wgFileExtensions;
+ global $wgFileExtensions, $wgLang;
switch( $details['status'] ) {
break;
case UploadBase::FILETYPE_BADTYPE:
$msg = wfMessage( 'filetype-banned-type' );
- $sep = wfMsg( 'comma-separator' );
if ( isset( $details['blacklistedExt'] ) ) {
- $msg->params( implode( $sep, $details['blacklistedExt'] ) );
+ $msg->params( $wgLang->commaList( $details['blacklistedExt'] ) );
} else {
$msg->params( $details['finalExt'] );
}
- $msg->params( implode( $sep, $wgFileExtensions ),
+ $msg->params( $wgLang->commaList( $wgFileExtensions ),
count( $wgFileExtensions ) );
// Add PLURAL support for the first parameter. This results
* @return Array of warnings
*/
public function checkWarnings() {
+ global $wgLang;
+
$warnings = array();
$localFile = $this->getLocalFile();
global $wgCheckFileExtensions, $wgFileExtensions;
if ( $wgCheckFileExtensions ) {
if ( !$this->checkFileExtension( $this->mFinalExtension, $wgFileExtensions ) ) {
- $warnings['filetype-unwanted-type'] = $this->mFinalExtension;
+ $warnings['filetype-unwanted-type'] = array( $this->mFinalExtension,
+ $wgLang->commaList( $wgFileExtensions ) );
}
}