phpcs: Fix Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore violations
authorTimo Tijhof <krinklemail@gmail.com>
Thu, 11 Apr 2013 05:29:05 +0000 (07:29 +0200)
committerKrinkle <krinklemail@gmail.com>
Thu, 11 Apr 2013 07:34:41 +0000 (07:34 +0000)
commitacb292d7332ea9b18ce91ad9ccb4af259f01c6d7
tree17d475495cdb551ec3af89780b34cc94e565d5ce
parenta2c673490ceaf4d9d12e7528553e51fef52841c0
phpcs: Fix Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore violations

ERROR: Closing brace must be on a line by itself
Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore

- For non-empty scopes it means the closing brace must be on a separate
  line. This is already the case in most classes in some cases the "lazy
  closing" is still used.
  array(
   'x' ); // Moved } to next line
  function () { return 'x'; } // Moved } to next line
  case 1:
    stuff; break; // Moved break to next line
- For empty function it serves as a visual distinction between there not
  being a scope block / function body and there being an empty function
  body.
  function foo(); // No body
  function foo() {} // Empty body - violation
  function bar() { // Empty body corrected
  }

Change-Id: I0310ec379c6d41cc7d483671994d027a49f32164
15 files changed:
includes/Action.php
includes/Block.php
includes/Category.php
includes/Exception.php
includes/db/Database.php
includes/db/DatabaseMssql.php
includes/db/DatabasePostgres.php
includes/db/DatabaseUtility.php
includes/db/LBFactory.php
includes/installer/WebInstallerPage.php
includes/templates/Usercreate.php
includes/templates/Userlogin.php
includes/upload/UploadBase.php
includes/upload/UploadFromChunks.php
includes/upload/UploadFromUrl.php