jeroendedauw [Wed, 21 Jan 2015 00:30:14 +0000 (01:30 +0100)]
Document alternative to deprecated function
Change-Id: I89ae5f5062f8e3eb8dac38d7efcca7723d6b62b1
Krinkle [Tue, 20 Jan 2015 23:56:17 +0000 (23:56 +0000)]
Revert "resourceloader: Omit empty parameters from mw.loader.implement calls"
Works as intended, but didn't account for the first implement() parameter
being omitted client-side. Revert until that is accounted for, then re-try after
that fix is rolled out for > 1 week.
This reverts commit
4ce0c0da42acfbcc5c68527834f85436efd0ebc1.
Change-Id: I36c1619991663c0303636d1d3f037b0021ac79bf
Timo Tijhof [Tue, 9 Dec 2014 01:17:53 +0000 (01:17 +0000)]
resourceloader: Omit empty parameters from mw.loader.implement calls
Follows-up
ebeb297236.
Also:
* Add tests for ResourceLoader::makeLoaderImplementScript().
* Apply ResourceLoader::trimArray to makeLoaderImplementScript (new in
c0c221bf).
As always, the client (updated in Ie32e7d6a3c) is backward-compatible with old
(cached) load.php module responses. However, the old client is not compatible
new load.php responses after this commit.
That's generally not an issue, as we don't cache the client very long (~ 5 min).
However people with their browser open and mw.loader clients initialised can
still make new module requests (e.g. modules loaded on-demand, such as when
previewing edits, clicking buttons etc.). That can easily be several hours after
initial page load. As such, client/server bound changes should always be
back-compat and deployed a reasonable time apart to reduce chances of active
sessions making subsequent requests. Ideally we'd find some solution to this in
the long-term, but handling this at all is better than what we usually do...
For deployment: Ensure this is deployed several days after Ie32e7d6a3c09f.
Change-Id: Ic8d7efe49b5d45e3f95a2f04e3a26a014b10af16
Timo Tijhof [Tue, 20 Jan 2015 22:24:33 +0000 (14:24 -0800)]
UserLogin: Don't rely on jQuery prop('tabindex') to map to tabIndex
Follows-up I9b03d519af43d.
There is a hardcoded set of exceptions in jQuery core right now
that map these common mistakes for back-compat. But this is
undocumented/unsupported legacy behaviour for a very small subset
of properties.
Change-Id: I9cfef0bc6a088e4c0a632b3673df460d26477c37
Brad Jorsch [Tue, 20 Jan 2015 21:15:36 +0000 (13:15 -0800)]
API: Fix setting of wpIgnoreBlankSummary in action=edit
EditPage checks this using getBool(), not getCheck(), so empty string is
interpreted as false.
Also clean up a long-obsolete comment.
Bug: T87188
Change-Id: I18f376cefad44295874d7b1cd760ba6fc966be29
Translation updater bot [Tue, 20 Jan 2015 20:34:27 +0000 (21:34 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I845680e24225a0e9491e61efd1455675eb397b20
Sumit Asthana [Tue, 13 Jan 2015 21:02:36 +0000 (02:32 +0530)]
Templates:Captcha position modified,extend functionality added to QuickTemplate
The ConfirmEdit extension presently inserts captcha in the header of Usercreate
and Userlogin templates. The js,if enabled places the captcha before submit
button. A separate 'extrafields' placeholder for captcha is added just before
submit button in Usercreate.php so that captcha position remains consistent,
even if js is disabled. An extend method added to QuickTemplate to append any
data to existing field, rather than setting it with fresh data. Particular use
for 'extrafields' in Usercreate and Userlogin.
Bug: T85192
Change-Id: I82c68814e79cbc5aa250a308862c59fcbb6fd527
Federico Leva [Tue, 20 Jan 2015 09:11:05 +0000 (10:11 +0100)]
Add newline at end of languages/messages/MessagesBgn.php
Change-Id: Ibd95ebb1eaf37e9fafc572818e86be05b839dbb2
Federico Leva [Tue, 20 Jan 2015 08:52:22 +0000 (09:52 +0100)]
Add language fallback for Western Balochi (bgn)
* As on translatewiki.net.
* Added to Names.php with
919dbbfcdd7900c7d213ed1a60e60bc920fdee09
Change-Id: I9648a1e326ea742ad74f2b1265e59599c4201b5c
Bartosz Dziewoński [Tue, 20 Jan 2015 07:33:31 +0000 (23:33 -0800)]
Add new Polish translation for DEFAULTSORT magic word
This has been done on translatewiki ages ago [1], I was under the
impression that this is updated with the regular localisation updates, but
apparently not so. The Polish Wikipedia community would like to have
started using the new translation a week ago [2], so let's expedite this
please.
[1] https://translatewiki.net/w/i.php?title=MediaWiki%3ASp-translate-data-MagicWords%2Fpl&diff=
5944044&oldid=
5711187
[2] https://pl.wikipedia.org/wiki/Wikipedia:Kawiarenka/Kwestie_techniczne#DEFAULTSORT_-_mo.C5.BCe_przet.C5.82umaczy.C4.87.3F
Change-Id: I52f9f5962d3b52d7a5e9b16915f7dedabeecd142
Matthew Flaschen [Fri, 10 Oct 2014 01:41:08 +0000 (21:41 -0400)]
LSG: Break module list into text file for readability
Change-Id: I3d66bcacf99da7eecc91a421c521dc650ed9cf82
jenkins-bot [Mon, 19 Jan 2015 22:52:52 +0000 (22:52 +0000)]
Merge "Stop using mw-ui-big on login form buttons"
Translation updater bot [Mon, 19 Jan 2015 20:37:35 +0000 (21:37 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I16b3a2ee08dd95acd0a8ba9edfb42d214abf1aee
jenkins-bot [Mon, 19 Jan 2015 17:08:17 +0000 (17:08 +0000)]
Merge "Revision: mark getRaw*() methods as deprecated"
Translation updater bot [Sun, 18 Jan 2015 20:45:50 +0000 (21:45 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I8fb2ad3395c3dab471bd1b3dfce103f3d98623a2
Ricordisamoa [Tue, 9 Dec 2014 19:16:50 +0000 (19:16 +0000)]
Revision: mark getRaw*() methods as deprecated
Revision->getRawUser()
=> Revision->getUser( Revision::RAW )
Revision->getRawUserText()
=> Revision->getUserText( Revision::RAW )
Revision->getRawComment()
=> Revision->getComment( Revision::RAW )
The body of Revision->getRawUserText() has been moved
into Revision->getUserText().
Every usage has been replaced.
Change-Id: Ic6fbfbc0507dcf88072fcb2a2e2364ae1436dce7
Aaron Schulz [Fri, 16 Jan 2015 23:28:38 +0000 (15:28 -0800)]
Added some job queue comments
Change-Id: If42b982ac339cc6aaf56ef2ed6c78867b83d2e56
Translation updater bot [Sat, 17 Jan 2015 22:20:43 +0000 (23:20 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Icdecf03a42a08ce43210b632fd15f7d09795332e
Niklas Laxström [Sat, 17 Jan 2015 20:34:38 +0000 (21:34 +0100)]
Add bgn to Names.php
It recently passed the threshold and translations were committed:
https://translatewiki.net/wiki/Translating:MediaWiki/New_languages
Change-Id: I2a217b70baf6961c3c7bd7b3a90fbb104238a74f
Aaron Schulz [Sat, 17 Jan 2015 07:05:02 +0000 (23:05 -0800)]
Made JobRunner bail if wfReadOnly() is true
Change-Id: I97ef66718bf4033768cd820b42521af31539b3f6
jdlrobson [Fri, 16 Jan 2015 22:39:00 +0000 (14:39 -0800)]
Stop using mw-ui-big on login form buttons
This is inconsistent with mobile and is one of the blockers from us
using this form rather than our own on a mobile device.
Also mw-ui-big is a terrible class name and we should be deprecating its
usage.
Change-Id: I56e93429431690cf1b9ef043620b36148e3b4a7a
Timo Tijhof [Fri, 16 Jan 2015 03:25:15 +0000 (19:25 -0800)]
JsonContent: Support non-object values as root structure
* Remove is_object restriction from isValid.
* Implement rootValueTable to support rendering of other
root structures.
Also:
* Minor method documentation tweaks.
* Document why quotes are not escaped for strings in value cells.
Bug: T86270
Change-Id: Ic1d10393912fcefa22d675fd4aa2baf437d2a05a
Translation updater bot [Fri, 16 Jan 2015 19:48:55 +0000 (20:48 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Iac5da9911687d649dec3c748d2b2b5b04469f245
Aaron Schulz [Mon, 12 Jan 2015 20:05:17 +0000 (12:05 -0800)]
Avoid fatal error with profiler in Maintenance.php
Error Message: "Fatal error: Class name must be a valid object or a string"
Change-Id: Ia21f4d2c45aaaa12a270dd0fda7274008736a899
Kunal Mehta [Fri, 16 Jan 2015 17:24:02 +0000 (09:24 -0800)]
Add another Br[yi][oa]n to CREDITS
Change-Id: I2f3a5f813bb195f10930af6a7373dcaad96c18a0
Jaroslav Škarvada [Wed, 5 Mar 2014 11:03:17 +0000 (12:03 +0100)]
Fix HTTPS protocol detection
According to PHP documentation:
http://www.php.net/manual/en/reserved.variables.server.php
The $_SERVER['HTTPS'] is set to a non-empty value if the script was queried
through the HTTPS protocol. There is also note that for ISAPI with IIS, the
value is set to 'off' if the request was not made through the HTTPS protocol.
To follow the PHP documentation the $_SERVER['HTTPS'] == 'on' doesn't seem
to be the correct way how to detect the HTTPS protocol (there maybe e.g. '1'
instead of 'on').
Bug: 46511
Change-Id: I5675fed9b7d54711b96b25702181112ef3692f3c
Timo Tijhof [Fri, 16 Jan 2015 01:55:00 +0000 (17:55 -0800)]
jquery.tablesorter: Fix "capabilities" typo in comment
Change-Id: Iea1a2956c8927bc29c904569ae594f6978aa8868
James D. Forrester [Fri, 16 Jan 2015 00:06:44 +0000 (16:06 -0800)]
Update OOjs UI to v0.6.3
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.6.3/History.md
Change-Id: If0fc682b3a7f186d53ca70fdb66dded66a7f4814
Translation updater bot [Thu, 15 Jan 2015 21:27:34 +0000 (22:27 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib5e195c508863f6b9d75e0984a3c608b65deb609
Federico Leva [Thu, 8 Jan 2015 17:09:09 +0000 (18:09 +0100)]
Typofix in wrapWikiMsg() comment, smoother sentence
Change-Id: Ic0ebc94cec68ee1515d4c98d49b26a6f9148e95e
jenkins-bot [Thu, 15 Jan 2015 18:52:40 +0000 (18:52 +0000)]
Merge "Userlogin.php: Tweaks and corrections"
jenkins-bot [Thu, 15 Jan 2015 18:49:50 +0000 (18:49 +0000)]
Merge "Article: Show error message when Revision::getContent() fails"
Bartosz Dziewoński [Thu, 15 Jan 2015 18:30:14 +0000 (10:30 -0800)]
Userlogin.php: Tweaks and corrections
* Correct nesting of the block generating "Forgot your password?" link
– it would be mistakenly only generated if the user could create an
account.
* Use ->escaped() rather than ->parse() for 'userlogin-resetpassword-link',
as it is used inside a link and allowing wikitext could lead to
undesirable side-effects.
* Remove unused $extraAttrs variable.
* Remove pointless 'size' => '20' for some fields (they are displayed
full-width using CSS).
* Remove pointless .mw-ui-block class, as its styles are always used
for buttons in a VForm.
* Prettify code for hidden fields generation.
Change-Id: If749620bf2eaf58f815cae559383e1a1c842b870
jenkins-bot [Thu, 15 Jan 2015 18:44:28 +0000 (18:44 +0000)]
Merge "Add tests for Sanitizer::escapeHtmlAllowEntities"
Siebrand Mazeland [Wed, 14 Jan 2015 19:10:12 +0000 (20:10 +0100)]
file name -> filename
Change-Id: I2b39501b95745b04f3c8f2c5df893c066e5e7867
Kunal Mehta [Thu, 15 Jan 2015 17:25:56 +0000 (09:25 -0800)]
ParserOutputTest: Fix @covers tags
Change-Id: I4460f0474174a95558301a0e0a261a962dc66bee
Kevin Israel [Mon, 15 Sep 2014 09:44:35 +0000 (05:44 -0400)]
Article: Show error message when Revision::getContent() fails
It already checks for other errors though not this specific one
(e.g. missing text row or external storage row).
Change-Id: Id9eed4bd3d8241d445b15948f1544040394012c3
jenkins-bot [Thu, 15 Jan 2015 00:08:01 +0000 (00:08 +0000)]
Merge "HTMLFormField: Don't abuse mClass for VForms"
Marius Hoch [Wed, 14 Jan 2015 23:22:06 +0000 (00:22 +0100)]
Add tests for Sanitizer::escapeHtmlAllowEntities
Change-Id: I84a1328559d57a424aa77a6d89f837615feffc13
Bartosz Dziewoński [Wed, 14 Jan 2015 23:00:39 +0000 (15:00 -0800)]
HTMLFormField: Don't abuse mClass for VForms
Various fields use this differently than I thought, breaking things.
Let's add a separate variable.
Change-Id: Ia974a42c2a905cbc9e8405d9f03c10c8ad692864
Gabriel Wicke [Wed, 14 Jan 2015 22:06:01 +0000 (14:06 -0800)]
Fix array index for oldid parameter
This caused an incorrect oldid parameter to be passed to parsoid on html2wt
conversion, resulting in dirty diffs.
Change-Id: If140bbc94f280f9ec5a1c9f6d9c3b4e7a46e1917
jenkins-bot [Wed, 14 Jan 2015 21:26:11 +0000 (21:26 +0000)]
Merge "Set stat cache when getting local copy files in Swift"
Translation updater bot [Wed, 14 Jan 2015 21:15:43 +0000 (22:15 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I7e0c73a076713d6e2f4a317456e2bffb9a1a77f4
jenkins-bot [Wed, 14 Jan 2015 20:54:39 +0000 (20:54 +0000)]
Merge "Disable styling for checkboxes and radios on non-js browsers"
Bartosz Dziewoński [Wed, 14 Jan 2015 20:26:37 +0000 (20:26 +0000)]
Merge "mediawiki.action.view.redirect: Don't unset wgInternalRedirectTargetUrl"
jenkins-bot [Wed, 14 Jan 2015 20:07:42 +0000 (20:07 +0000)]
Merge "Use Config in SpecialUpload::getInitialPageText"
Bartosz Dziewoński [Wed, 14 Jan 2015 19:43:47 +0000 (11:43 -0800)]
mediawiki.action.view.redirect: Don't unset wgInternalRedirectTargetUrl
Follows-up
c49bd9cb14a9af678.
No good reason to do it. Dunno why I did it this way.
Change-Id: I9d80492b7ef6c1790c8dcb4a6861f263c450bd6a
m4tx [Sat, 3 Jan 2015 00:25:30 +0000 (01:25 +0100)]
Use Config in SpecialUpload::getInitialPageText
Change-Id: I7edfe23278acff8d3089d9ad23b588f937d9e337
Bartosz Dziewoński [Wed, 14 Jan 2015 19:49:27 +0000 (11:49 -0800)]
Release notes for
f338a1cf
Change-Id: Iecf07aea6384b41d4ca4f115ea80644e7ca0bcac
jenkins-bot [Wed, 14 Jan 2015 19:55:56 +0000 (19:55 +0000)]
Merge "Release notes for
1dd14dce and
b3830611"
Bartosz Dziewoński [Wed, 14 Jan 2015 19:40:12 +0000 (11:40 -0800)]
Release notes for
1dd14dce and
b3830611
Change-Id: I0b933560d7df17246ea91b80ff1cd57abb61ad1b
Bartosz Dziewoński [Wed, 24 Dec 2014 17:21:32 +0000 (18:21 +0100)]
HTMLForm: Separate VForm code to a subclass
…and in general, work with the existing HTMLForm design for defining
display formats, rather than against it.
Breaking changes:
* HTMLForm::isVForm() is now deprecated.
* You can no longer do this:
$form = new HTMLForm( … );
$form->setDisplayFormat( 'vform' ); // throws exception
Instead, do this:
$form = HTMLForm::factory( 'vform', … );
When using FormSpecialPage, override the new getDisplayFormat() method
instead of calling $form->setDisplayFormat() in the alterForm() method.
(Other display formats are not affected, only 'vform'.)
Bug fixes:
* Correctly suppress empty labels for VForm fields
* Correctly disable <fieldset/> wrappers for VForms
Other benefits:
* Reduce code duplication related to $getFieldHtmlMethod
* Introduce HTMLForm::factory() method for constructing HTMLForms
Related cleanup:
* Correctly style 'reset' buttons in MediaWiki UI mode
* Label $wgHTMLFormAllowTableFormat as a mobile-specific hack
* Display checkboxes normally in MediaWiki UI mode (removed weird
override that only broke things). Also, always render checkboxes
in VForms as .mw-ui-checkbox.
* self:: → static::
Bug: T85285
Change-Id: I086a84f1c8cc6a16710709b7806c7f5f96462b32
jenkins-bot [Wed, 14 Jan 2015 18:19:29 +0000 (18:19 +0000)]
Merge "Add plural support for message config-no-db in the installer"
jenkins-bot [Wed, 14 Jan 2015 16:44:38 +0000 (16:44 +0000)]
Merge "Add Timing-Allow-Origin header for cross-domain API responses"
umherirrender [Wed, 14 Jan 2015 16:29:59 +0000 (17:29 +0100)]
Add plural support for message config-no-db in the installer
The message config-no-db contains a comma separated list of items.
Adding the count of this list allows use of plural for better i18n.
Change-Id: I07ccbd3f664709d1a6234cb1e268ff8d7ddfabd9
Aaron Schulz [Mon, 12 Jan 2015 21:39:24 +0000 (13:39 -0800)]
Made SqlDataUpdate use lazy DB connections
Change-Id: Ic041f620f27e1e8012586542ac6dc60657461d04
Timo Tijhof [Thu, 8 Jan 2015 20:33:47 +0000 (20:33 +0000)]
tests: Move npm-test to repo root
This is way overdue as it isn't experimental anymore.
Keeping it in a non-standard subdirectory makes it harder to
discover for people. And makes it harder to run from Jenkins
since this is already being ran on every commit.
Related to
70f3919.
Change-Id: Iaf5cf65616f82640145fbb6395c36129428602ca
jenkins-bot [Wed, 14 Jan 2015 00:16:26 +0000 (00:16 +0000)]
Merge "Allow mobile for jquery.throttle-debounce"
jenkins-bot [Wed, 14 Jan 2015 00:15:16 +0000 (00:15 +0000)]
Merge "installer: Don't generate $wgDefaultSkin='' when no skins are present during installation"
Gergő Tisza [Sun, 11 Jan 2015 07:55:40 +0000 (23:55 -0800)]
Add Timing-Allow-Origin header for cross-domain API responses
This makes it possible to get detailed network timing information
via ResourceTiming.
Change-Id: Ie88d4354285420014c0f1612446ba94fc2a8c68f
Matthew Flaschen [Tue, 13 Jan 2015 23:29:22 +0000 (18:29 -0500)]
Allow mobile for jquery.throttle-debounce
This will allow Flow to use core's module:
Ia59e14dc8d7838cfe237b99ee59053529a7235fa
Change-Id: Ia6502da0e10dfa91732b7ac7ac9921dc5cfd218c
jenkins-bot [Tue, 13 Jan 2015 23:07:49 +0000 (23:07 +0000)]
Merge "mediawiki.js: Clean up and improve documentation"
jenkins-bot [Tue, 13 Jan 2015 23:03:49 +0000 (23:03 +0000)]
Merge "mediawiki.test.js: Document wgSiteName can't be mocked"
jenkins-bot [Tue, 13 Jan 2015 23:03:41 +0000 (23:03 +0000)]
Merge "mw.loader: Remove support for IE6"
Timo Tijhof [Tue, 13 Jan 2015 07:09:04 +0000 (23:09 -0800)]
mediawiki.js: Clean up and improve documentation
* Consistently phrase one-line captions in the imperative mood.
* Consistently start parameter descriptions with a capital letter.
* Document a few missing parameters and callback parameters.
* Rewrite mw.Map example.
* Merge duplicate @return tags in mw.Map#set (only the first one
is parsed by JSDuck).
* Fix mw.loader#registry code example. In order for the indented
text to be parsed as a code block, an empty is required.
* Improve IE-support comments with more details.
* Remove redundant String() cast in newStyleTag(). Per its signature,
it only supports strings. Other values don't make sense.
Change-Id: Iaaeaea4869f7869f5f4d29b27d11c0b05aad2ef5
Bartosz Dziewoński [Sat, 10 Jan 2015 02:55:38 +0000 (03:55 +0100)]
installer: Don't generate $wgDefaultSkin='' when no skins are present during installation
The bug only affects people installing from Git, not tarball releases.
* Make sure getDefaultSkin() never returns null and just uses 'vector'
when no skins are available (so the user just has to install it).
* Produce a hidden input field to pass the generated value to the next
installer page.
Change-Id: I025f1aeb182a818de59a42df01591e01fc9e6236
Timo Tijhof [Tue, 13 Jan 2015 07:05:19 +0000 (23:05 -0800)]
mediawiki.test.js: Document wgSiteName can't be mocked
Can't make it use mw.config value via setup/teardown because
the src module caches it at load, which means the site's live
config value is used...
Change-Id: Ie941fa138273ec01ab3dc93ea7d75c1da75c5ee9
Timo Tijhof [Sun, 11 Jan 2015 15:43:35 +0000 (07:43 -0800)]
mw.loader: Remove support for IE6
The client loader doesn't run in IE6.
Since MediaWiki 1.24, the startup module provides IE6 a
javascriptless environment.
Change-Id: I16628e21d6a89a31dc65baf4a22c6fb31dde2535
Translation updater bot [Tue, 13 Jan 2015 20:45:04 +0000 (21:45 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Id6b7c7c05c7a9d42f2cac2f7fd32cfbe415a9b0e
jenkins-bot [Tue, 13 Jan 2015 19:44:35 +0000 (19:44 +0000)]
Merge "Run the ImagePageShowTOC hook before adding the 'metadata' link"
Bahodir Mansurov [Tue, 13 Jan 2015 19:22:44 +0000 (14:22 -0500)]
Disable styling for checkboxes and radios on non-js browsers
Change-Id: I0b9691daa61fddb484b6adff759f4413d201ae03
jenkins-bot [Tue, 13 Jan 2015 19:25:23 +0000 (19:25 +0000)]
Merge "mw.Map: Check presence of value argument in set()"
jenkins-bot [Tue, 13 Jan 2015 19:25:20 +0000 (19:25 +0000)]
Merge "mediawiki.js: Move mw.format definition to where it's exposed"
jenkins-bot [Tue, 13 Jan 2015 19:25:17 +0000 (19:25 +0000)]
Merge "jsduck: Update references to renamed resources/ directories"
jenkins-bot [Tue, 13 Jan 2015 19:14:46 +0000 (19:14 +0000)]
Merge "Move DeferredStringifier into libs, add tests"
Kunal Mehta [Sun, 11 Jan 2015 01:52:37 +0000 (17:52 -0800)]
Move DeferredStringifier into libs, add tests
Change-Id: I384d1a3854e957315584d30ec58c48c02fee6a2c
Kunal Mehta [Tue, 13 Jan 2015 18:25:41 +0000 (10:25 -0800)]
Add missing @covers tag
Change-Id: I491929e3d77688bf07640db4218ef99d6b888a82
jenkins-bot [Tue, 13 Jan 2015 16:11:25 +0000 (16:11 +0000)]
Merge "Add User::equals"
jenkins-bot [Tue, 13 Jan 2015 15:55:27 +0000 (15:55 +0000)]
Merge "Add plural support for message upload-permitted on Special:Upload"
umherirrender [Mon, 12 Jan 2015 18:41:23 +0000 (19:41 +0100)]
Add plural support for message upload-permitted on Special:Upload
The messages upload-permitted, upload-preferred and upload-prohibited
containing a comma separated list of items. Adding the count of this
list allows use of plural for better i18n.
Change-Id: I3fb09db4788bff6ea89731f77848d78fb33dd493
Niklas Laxström [Thu, 11 Dec 2014 08:59:28 +0000 (09:59 +0100)]
Add User::equals
Seems stupid omission. Title has one. Why do I need to think how
to determine how to users objects point to the same user. Allows
more expressive code.
Also fixes a bug in multiple places where users "0" and "00" were
considered equal.
Change-Id: I682392e564b332b77ab489f2ad394fa2d28098a5
Timo Tijhof [Sun, 11 Jan 2015 14:03:34 +0000 (06:03 -0800)]
mw.Map: Check presence of value argument in set()
Add back the `arguments.length > 1` check (accidentally removed
in
24f84b0). Otherwise it inadvertently uses the `value`
parameter, causing it to set undefined as the value.
There was already a test ensuring undefined can be set as value,
but a test to ensure it doesn't default to undefined was missing.
Change-Id: I4c69f0c11f165640a9b387a72c77c48eb6aa9e72
Timo Tijhof [Sun, 11 Jan 2015 13:21:13 +0000 (05:21 -0800)]
mediawiki.js: Move mw.format definition to where it's exposed
No need for it to be a local and public method at the same time.
The Message#parser can just use the public one.
Change-Id: I57e040cda6da57cda447ea83f5b9b6b28b538158
Timo Tijhof [Sun, 11 Jan 2015 13:18:58 +0000 (05:18 -0800)]
jsduck: Update references to renamed resources/ directories
The inline examples in the generated documentation due to a
404 Not Found for the javascript files.
1. Run $ ./maintenance/mwjsduck-gen
2. View http://localhost/w/docs/js/#!/api/mw.Map
3. Try "Live Preview"
Change-Id: Ic44f029c789042d82ec14e35d385f9ccc59959aa
This, that and the other [Sat, 30 Aug 2014 05:18:46 +0000 (15:18 +1000)]
Don't auto-select first alphabetical item in import subproject list
Currently when you load Special:Import, the first subproject in
alphabetical order gets selected. Instead, the first subproject in the
list should be selected by default (i.e. no <option> element should be
given the "selected" attribute).
Change-Id: I442a9afadc75f42f63d8c9c32ee2920374ceb26d
Kunal Mehta [Sun, 11 Jan 2015 04:17:36 +0000 (20:17 -0800)]
Handle more cases in convertExtensionToRegistration.php
* Handle constructs like $wgResourceModules += array(...)
* Support $wgMessagesDirs['FooBar'] = array(...)
* Handle stripping paths where it is the current directory
* Use FormatJson::ALL_OK when writing the file
Bug: T86311
Change-Id: I9434f6634fd6e460a5c2f6dac95c9065da35a51a
Kunal Mehta [Sun, 11 Jan 2015 04:12:01 +0000 (20:12 -0800)]
registration: Add ConfigRegistry to the extension.json schema
Change-Id: I6918215e3b5b2dd4c993d8a8767dc3ce998bd5ed
Timo Tijhof [Tue, 2 Dec 2014 22:41:00 +0000 (22:41 +0000)]
exception: Hide suppressed errors in 'error' log, flag in 'error-json'
Follows-up
399ba2f.
Bug: T75619
Bug: T45086
Change-Id: I1f312660c058a3940bf1e9425f86cfd531121ba3
jenkins-bot [Tue, 13 Jan 2015 00:20:14 +0000 (00:20 +0000)]
Merge "Tweaked the message for non-MW exceptions"
jenkins-bot [Mon, 12 Jan 2015 23:46:10 +0000 (23:46 +0000)]
Merge "Skip cache hint about 0 seconds on Special:ActiveUsers"
Brad Jorsch [Mon, 12 Jan 2015 21:46:18 +0000 (16:46 -0500)]
Don't call $wgOut->disable() from wfHttpError if $wgOut isn't set up yet
For example, if the database cannot be connected to, the language is
something other than 'en', and the l10n cache is LCStoreDB, then the
call to Language::factory() in Setup.php line 604 will do it when it's
trying to get the fallback list.
Bug: T86398
Change-Id: Ia0e9ea440dcc4c8ab7bab1f33802aeff487eb3f0
Translation updater bot [Mon, 12 Jan 2015 21:09:28 +0000 (22:09 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I8622b53bb08154439b751c93d0b218f12f892c24
jenkins-bot [Mon, 12 Jan 2015 20:02:56 +0000 (20:02 +0000)]
Merge "Check $wgCheckFileExtensions on client side on Special:Upload"
umherirrender [Mon, 12 Jan 2015 19:27:53 +0000 (20:27 +0100)]
Check $wgCheckFileExtensions on client side on Special:Upload
Setting $wgCheckFileExtensions to false but having
$wgStrictFileExtensions still on true will reject unknown file
extensions on Special:Upload with javascript.
Bug: T25583
Change-Id: I260107bb5c3206044f766d308572ad27378715bb
jenkins-bot [Mon, 12 Jan 2015 19:09:40 +0000 (19:09 +0000)]
Merge "mediawiki.action.edit.stash: set timeout to 4 seconds"
Translation updater bot [Sun, 11 Jan 2015 20:56:59 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I557d9716255fa29881eef5909cfd9bf5c02e352c
Bartosz Dziewoński [Sun, 11 Jan 2015 20:14:03 +0000 (21:14 +0100)]
Add *.orig to .gitignore
People and tools sometimes accidentally commit these, let's make it
more difficult to do.
Follow-up to
abb4271a. NO ONE SAW THIS EMBARASSING MISTAKE.
Change-Id: If5f427586814c304b30e5783a59f33814bfeaa54
Bartosz Dziewoński [Sun, 11 Jan 2015 17:04:16 +0000 (18:04 +0100)]
Add .*.orig to .gitignore
People and tools sometimes accidentally commit these, let's make it
more difficult to do.
Change-Id: I05574d46186642940054aaecec055723c7ade8ac
Scimonster [Sun, 11 Jan 2015 16:11:43 +0000 (16:11 +0000)]
Escape unsafe messages in CategoryViewer.php
Bug: T85864
GCI: http://www.google-melange.com/gci/task/view/google/gci2014/
5811264311787520
Change-Id: Ie59fb389b804f031b761f93f2c91a548742326ab
jenkins-bot [Sun, 11 Jan 2015 13:25:49 +0000 (13:25 +0000)]
Merge "Surround edit notices with appropriate classes"