Leo Koppelkamm [Tue, 12 Jul 2011 09:42:07 +0000 (09:42 +0000)]
Followup r91871 per CR. Write back the actually executed action to . Ping r57415
Tim Starling [Tue, 12 Jul 2011 08:08:58 +0000 (08:08 +0000)]
Non-concurrent pop_type() since the $row === false case was being hit 99% of the time on WMF in a backlog situation.
Brion Vibber [Tue, 12 Jul 2011 00:25:20 +0000 (00:25 +0000)]
Followup r91833 -- use Sanitizer::escapeId's 'noninitial' option when generating sanitized ID for a sidebar entry; the actual id is prefixed with 'n-'; this fix makes the items behave like the folder sections ('p-', already escaped this way)
Aaron Schulz [Tue, 12 Jul 2011 00:09:37 +0000 (00:09 +0000)]
Added $wgAutopromoteOnceLogInRC variable (bug 29655)
Brion Vibber [Mon, 11 Jul 2011 23:51:21 +0000 (23:51 +0000)]
followup r91869: validate id chars for incoming prefs tabs in hash ([\w-]+ is sufficient for our needs here)
Brion Vibber [Mon, 11 Jul 2011 23:41:49 +0000 (23:41 +0000)]
Revert r91870, r91873 -- seems to be trying to remove the 'view' action on diff views; diffs are a subset of regular page views, like old page views, and don't have a separate action.
Aaron Schulz [Mon, 11 Jul 2011 22:17:15 +0000 (22:17 +0000)]
Added explicit parse() call to wfMessage object
Brion Vibber [Mon, 11 Jul 2011 21:39:06 +0000 (21:39 +0000)]
Followup to r91608: reduce impact of bug 29784 (high jsmin+ memory usage during parsing) by skipping JS validation on modules backed by files. Unless you're developing them, these will usually be stable, and large individual files like the pre-bundled jQuery can hit memory limits much sooner than we like.
Validation on JS from wiki pages is still on by default ($wgResourceLoaderValidateJS = true).
Validation on static files can be re-enabled by setting $wgResourceLoaderValidateStaticJS = true (defaults false).
Brion Vibber [Mon, 11 Jul 2011 21:09:45 +0000 (21:09 +0000)]
Add jsparse.php maintenance script to run given JavaScript files through JSMin+'s JS parser for syntax validity checks.
This also confirms JSMin+'s fairly abysmal memory usage on large complex files. :) Pass --memory-limit to set to arbitrary values to see where it dies on your file. ;)
Raimond Spekking [Mon, 11 Jul 2011 19:37:00 +0000 (19:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-11 19:26:00 UTC)
Bryan Tong Minh [Mon, 11 Jul 2011 18:38:26 +0000 (18:38 +0000)]
Follow-up r91895: Call parent destructor as well, just to be safe.
Bryan Tong Minh [Mon, 11 Jul 2011 18:36:29 +0000 (18:36 +0000)]
Add unit tests for $wgGroupPermissions/$wgRevokePermissions
Brion Vibber [Mon, 11 Jul 2011 18:14:33 +0000 (18:14 +0000)]
Followup r91844: fix jquery.byteLimit test cases on IE6, IE7
str[i] doesn't work on these older browsers; use str.charAt(i) instead.
Niklas Laxström [Mon, 11 Jul 2011 18:05:32 +0000 (18:05 +0000)]
ping r91875
Brion Vibber [Mon, 11 Jul 2011 17:53:52 +0000 (17:53 +0000)]
* (bug 29804) Fix byte-length-limited fields to check the length of to-be-added char instead of hardcoding a possible length of 3.
Since the Unicode code point of the character being inserted is passed with the keypress event, we can simply turn it into a string and toss it into jquery.byteLength to calculate the length in bytes.
Also fixed a broken test case that had the wrong number of expected chars.
Note that this will probably still not work right in many circumstances -- pastes, anything dealing with selection, and it's entirely possible that individual 'keypress' events might be totally unreliable when dealing with funky input methods.
Robin Pepermans [Mon, 11 Jul 2011 17:01:44 +0000 (17:01 +0000)]
Jarry1250 = Harry Burt, per Reedy on r91886
Robin Pepermans [Mon, 11 Jul 2011 16:53:31 +0000 (16:53 +0000)]
(bug 29797) Error: "Tried to load block with invalid type" when subpages are disabled for user pages.
Patch by Jarry1250
Brian Wolff [Mon, 11 Jul 2011 16:42:15 +0000 (16:42 +0000)]
(follow-up r90256) Unit tests.
Niklas Laxström [Mon, 11 Jul 2011 12:23:39 +0000 (12:23 +0000)]
* (bug 16699) {{#language:}} accepts second parameter to specify the language in
which the language name is wanted. Coverage depends on the cldr extension.
Leo Koppelkamm [Mon, 11 Jul 2011 11:05:24 +0000 (11:05 +0000)]
r91870 : Got tricked into believing it was action=diff instead of action=historysubmit
Leo Koppelkamm [Mon, 11 Jul 2011 10:57:01 +0000 (10:57 +0000)]
Add action-* class to body. Bug 4438. Based on patch by Subfader
Leo Koppelkamm [Mon, 11 Jul 2011 10:54:05 +0000 (10:54 +0000)]
wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a &action parameter. Bug 25800
Leo Koppelkamm [Mon, 11 Jul 2011 09:54:40 +0000 (09:54 +0000)]
use tab name, not tab index for anchors on Special:Preferences. Bug 29672 . Patch by Jarry1250. Ping r91757
Alexandre Emsenhuber [Mon, 11 Jul 2011 08:46:37 +0000 (08:46 +0000)]
Call Linker methods statically and removed the $mSkin member
Alexandre Emsenhuber [Mon, 11 Jul 2011 08:27:07 +0000 (08:27 +0000)]
Override UsersPager::getTitle() in ActiveUsersPager
Alexandre Emsenhuber [Mon, 11 Jul 2011 08:17:26 +0000 (08:17 +0000)]
Use getPageTitle() to set the page title instead of doing it manually
Alexandre Emsenhuber [Mon, 11 Jul 2011 07:56:22 +0000 (07:56 +0000)]
Removed print and render actions from the check:
* print was removed in 86373
* render does not reach this point since it simply output the content without any part of the skin
Robin Pepermans [Mon, 11 Jul 2011 00:39:41 +0000 (00:39 +0000)]
BetterDirectionality fixes:
* SkinTemplate: also set <div class="mw-content-ltr/rtl"> when action = historysubmit, so a diff displays correctly when you clicked on the "compare selected revisions" button on the history page
* ImagePage: set a dir attribute (according to the site content language) for the user comment in the file history
* FlaggedRevs: use CSS class sitedir-ltr/rtl instead of ambiguous rtl class
Sam Reed [Sun, 10 Jul 2011 23:26:13 +0000 (23:26 +0000)]
Amend RELEASE-NOTES-1.19 for r91845
Krinkle [Sun, 10 Jul 2011 21:17:28 +0000 (21:17 +0000)]
Update jQuery from 1.6.1 to 1.6.2 (maintenance/bugfix release)
* Release notes: http://blog.jquery.com/2011/06/30/jquery-162-released/
* Source: http://code.jquery.com/jquery-1.6.2.js
* Requested in bug 29773
Krinkle [Sun, 10 Jul 2011 21:01:24 +0000 (21:01 +0000)]
Add test suite for jquery.byteLimit:
- Tests to verify that the byteLength does not exceed the byteLimit when inserting more characters
- Tests to verify that it doesn't prevent too early (ie. if limit is 10 and we insert 20 characters, there should be 10 characters in the input field).
This test suite has exposed that the latter is currently broken. jquery.byteLimit is preventing characters to be added as soon as byteLength(currentValue) + 3 is more than the given limit.
(Follows-up r86698, r91148)
Krinkle [Sun, 10 Jul 2011 19:10:51 +0000 (19:10 +0000)]
Centralize QUnit customizations for MediaWiki:
- Rename 'awesome.js' to 'defineTestCallback.js' (more descriptive)
- Move all runner customizations into 'testrunner.js'
- Move all customization files into /data
- Fix bug in jquery.qunit.completenesstest that sometimes caused the element to be re-created if it was ran again from the console.
- Centralize additional assertion helpers in testrunner.js
Alexandre Emsenhuber [Sun, 10 Jul 2011 18:12:11 +0000 (18:12 +0000)]
* Changed dynamic calls to Linker methods into static ones
* Also preferably pass a Language object instead of a Skin one or boolean indicating whether it's for content. No other calls to these methods in core or extensions.
Rotem Liss [Sun, 10 Jul 2011 17:48:44 +0000 (17:48 +0000)]
Localization update for he.
Krinkle [Sun, 10 Jul 2011 15:27:31 +0000 (15:27 +0000)]
Removing @broken comment. Not anymore, they don't as of r91388.
- (Follows-up 91387)
Leo Koppelkamm [Sun, 10 Jul 2011 14:56:55 +0000 (14:56 +0000)]
Escape sidebar ID's. Bug 18688
Ariel Glenn [Sun, 10 Jul 2011 14:20:17 +0000 (14:20 +0000)]
fix issues after failed renameUser; this script will ask for lots of confirmation, better safe than sorry.
Leo Koppelkamm [Sun, 10 Jul 2011 13:19:19 +0000 (13:19 +0000)]
Add a font-size to .redirectText in Vector and fix the vertical alignment of the arrow. Bug 26544
Alexandre Emsenhuber [Sun, 10 Jul 2011 07:33:29 +0000 (07:33 +0000)]
Disable feed mode when including the page. I know that there is already r87705 to address this, but this one is needed for the future.
Alexandre Emsenhuber [Sun, 10 Jul 2011 06:45:40 +0000 (06:45 +0000)]
Stylised ParserOptions.php
Robin Pepermans [Sat, 9 Jul 2011 21:13:57 +0000 (21:13 +0000)]
Bug 29792: notice undefined index 'other' due to my commit r91803
Raimond Spekking [Sat, 9 Jul 2011 20:12:43 +0000 (20:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-09 19:33:00 UTC)
Alexandre Emsenhuber [Sat, 9 Jul 2011 19:38:58 +0000 (19:38 +0000)]
Added Request::setLang() and RequestContext::setSkin(); the latter will clone the object and set the context on it.
Robin Pepermans [Sat, 9 Jul 2011 19:33:58 +0000 (19:33 +0000)]
Allow the 'other' parameter for HTMLForm selectorother: it is used in SpecialBlock.php::getFormFields() (and maybe in more files)
Alexandre Emsenhuber [Sat, 9 Jul 2011 18:57:33 +0000 (18:57 +0000)]
Call doMarkPatrolled() on the RecentChange object instead of calling RecentChange::markPatrolled() that will create a second instance
Robin Pepermans [Sat, 9 Jul 2011 12:54:42 +0000 (12:54 +0000)]
Follow-up r91770: only translate when possible
Bryan Tong Minh [Sat, 9 Jul 2011 10:31:09 +0000 (10:31 +0000)]
Follow-up r88054: register the file if a hook changed the target file.
Alexandre Emsenhuber [Sat, 9 Jul 2011 09:17:35 +0000 (09:17 +0000)]
Pass the User object to RecentChange::doMarkPatrolled() instead of relying on $wgUser
Alexandre Emsenhuber [Sat, 9 Jul 2011 09:01:50 +0000 (09:01 +0000)]
Fix for r91651: don't escape HTML
Sam Reed [Sat, 9 Jul 2011 03:49:25 +0000 (03:49 +0000)]
Fix whitespace, documentation
Sam Reed [Sat, 9 Jul 2011 03:47:43 +0000 (03:47 +0000)]
* (bug 28630) Add iwlinks, langlinks, redirect to RefreshLinks::deleteLinksFromNonexistent
Sam Reed [Sat, 9 Jul 2011 03:43:22 +0000 (03:43 +0000)]
Followup r86183 and per bug 28628
Might awell make refreshLinks remove dead iwlinks from the table
Robin Pepermans [Sat, 9 Jul 2011 01:03:48 +0000 (01:03 +0000)]
Inline CSS is bad in itself and bad for RTL support (why was there even a message containing CSS?)
Robin Pepermans [Fri, 8 Jul 2011 23:36:35 +0000 (23:36 +0000)]
Translate the block expiry date
I wonder why this hasn't been done yet...
Chad Horohoe [Fri, 8 Jul 2011 22:15:29 +0000 (22:15 +0000)]
Wow major typo, r91763
Chad Horohoe [Fri, 8 Jul 2011 22:08:19 +0000 (22:08 +0000)]
Use estimateRowCount() in CleanupTable rather than select count(*) which will take forevvvveeeerrrrr on tables like image or page. It's only used for estimating progress, so a little estimating is ok :)
Krinkle [Fri, 8 Jul 2011 21:32:30 +0000 (21:32 +0000)]
Undo browser defaults (underline/strike) for the <del> and <ins> DairikiDiff inserts. Fixes bug 29779
Krinkle [Fri, 8 Jul 2011 21:29:24 +0000 (21:29 +0000)]
Reverting r91756 per CR and bug 26470
Krinkle [Fri, 8 Jul 2011 21:28:54 +0000 (21:28 +0000)]
Selfrevert r91759. Messed up working-copy
Krinkle [Fri, 8 Jul 2011 21:27:44 +0000 (21:27 +0000)]
Reverting r91756 per CR and bug 26470
Leo Koppelkamm [Fri, 8 Jul 2011 21:12:10 +0000 (21:12 +0000)]
HTMLForm: Add option to output a title for a fieldset & activate it for Special:Pref. Preliminary work for Bug 29672
Leo Koppelkamm [Fri, 8 Jul 2011 20:34:08 +0000 (20:34 +0000)]
Bug 26470 : Add checkered background image for transparent images on hover
Leo Koppelkamm [Fri, 8 Jul 2011 20:17:46 +0000 (20:17 +0000)]
redoing r91673 . Second step: Actually moving the files
Leo Koppelkamm [Fri, 8 Jul 2011 19:01:13 +0000 (19:01 +0000)]
r86603 : Updatin last call to mediawiki.legacy.edit and removing the module
Alexandre Emsenhuber [Fri, 8 Jul 2011 18:20:09 +0000 (18:20 +0000)]
Fix for r78786: make Special:Wantedpages includable again
Alexandre Emsenhuber [Fri, 8 Jul 2011 18:17:02 +0000 (18:17 +0000)]
Removed some error suppression operators
Mark A. Hershberger [Fri, 8 Jul 2011 18:08:30 +0000 (18:08 +0000)]
Fixes Bug #28838 — remove CSS references to div.editsection which grep
confirms isn't currently in use.
Leo Koppelkamm [Fri, 8 Jul 2011 17:59:42 +0000 (17:59 +0000)]
Moving skins/common/diff.css to mediawiki.action.history.diff.css and updating some old comments in the process. Also moved one vendor-prefixed attribute in fron of the standard one. Extension follow in a second
Krinkle [Fri, 8 Jul 2011 17:45:26 +0000 (17:45 +0000)]
Reverting r91642 per CR and pending review need-patch/patch in bug 29755
Leo Koppelkamm [Fri, 8 Jul 2011 17:20:56 +0000 (17:20 +0000)]
r91734: Do the same for search.css and remove module from resources.php
Leo Koppelkamm [Fri, 8 Jul 2011 17:07:11 +0000 (17:07 +0000)]
Migrate skins/common/search.js functionality to mediawiki.special.search.js. Make JS unobtrusive.
Alexandre Emsenhuber [Fri, 8 Jul 2011 16:18:31 +0000 (16:18 +0000)]
Create a new RequestContext to use its OutputPage and Skin members instead of messing with global ones
Leo Koppelkamm [Fri, 8 Jul 2011 15:19:44 +0000 (15:19 +0000)]
demon is right, Mac is much more common nowadays. r91646
Leo Koppelkamm [Fri, 8 Jul 2011 14:59:20 +0000 (14:59 +0000)]
Rewrite mwsuggest.js using j.ui.autocomplete. This gets rid of a lot of the little kinks of the previously implemenation: The suggestion list now contains regular anchors which can be openened in new indows or separate tabs. The carret doesn't jump around anymore when using the arrow keys to select an item. This should make it much easier to eventually merge Vectors simple search & mwsuggest.
Chad Horohoe [Fri, 8 Jul 2011 14:25:01 +0000 (14:25 +0000)]
Revert r91263 (fixing $wgScriptPath for cli installer). Completely breaks the web installer for two important reasons:
* $wgScriptPath always has a default value of '/wiki', so the getVar() check will always be true and skip the environment check
* Also began returning true in the SCRIPT_NAME which would mean $wgScriptPath never got set
Breakage spotted by LewisCawte on IRC, thanks!
Leo Koppelkamm [Fri, 8 Jul 2011 13:50:11 +0000 (13:50 +0000)]
Update j.ui.autocomplete which partially broke due to jQuery update in r89866
Leo Koppelkamm [Fri, 8 Jul 2011 13:32:06 +0000 (13:32 +0000)]
Redo r91721: Backport jQuery UI CSS fix for weird Webkit reflow bug. See https://github.com/jquery/jquery-ui/commit/
a090faa833cf5b40105bb4aa74bca7ac39366fe9/
Leo Koppelkamm [Fri, 8 Jul 2011 13:27:40 +0000 (13:27 +0000)]
Revert botched commit r91721
Leo Koppelkamm [Fri, 8 Jul 2011 13:24:05 +0000 (13:24 +0000)]
Backport jQuery UI CSS fix for weird Webkit reflow bug. See https://github.com/jquery/jquery-ui/commit/
a090faa833cf5b40105bb4aa74bca7ac39366fe9/
Jure Kajzer [Fri, 8 Jul 2011 12:28:59 +0000 (12:28 +0000)]
* DatabaseOracle.php binds variables, so using $val = 'NULL' breaks certain maint. scripts
Alexandre Emsenhuber [Fri, 8 Jul 2011 07:02:23 +0000 (07:02 +0000)]
Follow-up r91657: missed this one
Antoine Musso [Fri, 8 Jul 2011 06:52:05 +0000 (06:52 +0000)]
revert r91673 : lost of history
Robin Pepermans [Thu, 7 Jul 2011 21:07:51 +0000 (21:07 +0000)]
Fix r91685: add space at the right place.
(Also removing unused variable in protectedtitles.)
Mark A. Hershberger [Thu, 7 Jul 2011 20:58:04 +0000 (20:58 +0000)]
Bug #29752: add back a space that SPQRobin missed.
Alexandre Emsenhuber [Thu, 7 Jul 2011 20:17:55 +0000 (20:17 +0000)]
* Fixed comment
* Wrap arround RequestContext::msg() instead of doing that all that stuff once more
Leo Koppelkamm [Thu, 7 Jul 2011 19:59:06 +0000 (19:59 +0000)]
Moving cologneblue.css and nostalgia.css into their own folder
Leo Koppelkamm [Thu, 7 Jul 2011 19:47:16 +0000 (19:47 +0000)]
r74966: Deleting unused rtl.css
Mark A. Hershberger [Thu, 7 Jul 2011 19:11:25 +0000 (19:11 +0000)]
Fixes Bug#17866
Minimal check that we have more than an empty string before sending and email. NikeRabbit asked me about LQT sending email to users w/o email addresses and this looked like one good place to add a check.
Roan Kattouw [Thu, 7 Jul 2011 18:26:24 +0000 (18:26 +0000)]
(bug 29497) To support protocol-relative URLs in external links, add '//' to $wgUrlProtocols and remove a useless \b in the bracketed external link regex in the parser that prevented the former from working outright. With this change, things like [//example.com/wiki/Foo Bar] are now supported, and [[{fullurl:Foo|action=edit}} Bar] no longer breaks if $wgServer is set to '//example.com' but produces a protocol-relative link instead. Protocol-relative URLs in free text are not picked up and turned into [1] links like URLs with protcols are; this is probably due to another \b somewhere, but I think this is a good thing.
Mark A. Hershberger [Thu, 7 Jul 2011 18:03:46 +0000 (18:03 +0000)]
Set envelope sender to the same as the From: address when PEAR mail is used. This is so that mail “bounces” to the expected place.
Note that this only works when $wgSMTP is set and (as a result) the PEAR mailer is used.
When $wgSMTP is not set, the envelope sender is set using $wgAdditionalMailParams set to something like “-f from@example.com”. Someone should create some Envelope sender sanity in how the envelope sender is set.
Suggestion: if $wgAdditionalMailParams is not set, then use $wgEmergencyContact to create “-f $wgEmergencyContact” for php mailer and to set the Return-Path header for PEAR mailer. I used “From:” for Return-Path here because it seemed most sensible.
See also: http://pear.php.net/bugs/bug.php?id=5017
Krinkle [Thu, 7 Jul 2011 17:52:55 +0000 (17:52 +0000)]
Removing calls to deprecated functionality in favor of the new versions. Old version worked fine but shouldn't be used.
Follows-up:
* r75275: Introduced the updateTooltipAccessKeys function in the new library but didn't call it on document ready and left the deprecated one in the onloadhook-run in wikibits.js untouched
* r75287: Introduced jquery.checkboxShiftClick and called on-load but left the load call for the legacy version untouched. Depending on the load order at any given time it may not have been used.
Also reordering the if-else case in mw.util.updateTooltipAccessKeys to allow a call without arguments ("undefined instanceof Foo" throws exception)
Mark A. Hershberger [Thu, 7 Jul 2011 17:43:31 +0000 (17:43 +0000)]
w/s fixup before patch
Alexandre Emsenhuber [Thu, 7 Jul 2011 17:42:19 +0000 (17:42 +0000)]
* Don't use isset() to check only for null
* Also pass the Title object in RequestContext::msg()
Alexandre Emsenhuber [Thu, 7 Jul 2011 17:34:15 +0000 (17:34 +0000)]
Override IndexPager::getTitle() in ImageListPager, this is the only class subclassing TablePager that don't do that in core
Alexandre Emsenhuber [Thu, 7 Jul 2011 17:25:35 +0000 (17:25 +0000)]
Removed usage of error suppression operator
Brion Vibber [Thu, 7 Jul 2011 17:17:06 +0000 (17:17 +0000)]
Partial (?) fix for bug 29753 -- wrong Firefox version comparison for non-Mac Firefox 2+ accesskey tooltip. However, this code IS NOT YET USED which is very suspicious. An earlier version of this code is wikibits.js is still being used for some reason, which indicates a maintenance problem.
Chad Horohoe [Thu, 7 Jul 2011 16:59:25 +0000 (16:59 +0000)]
(bug 27410) The tag filter on a history page should be within a <label> element. Patch by The Evil IP Address.
Also remove inclusion protection for the 800th time: if a file only has classes, you don't need to do this :)
Chad Horohoe [Thu, 7 Jul 2011 16:52:47 +0000 (16:52 +0000)]
Reduce some duplication
Robin Pepermans [Thu, 7 Jul 2011 16:15:27 +0000 (16:15 +0000)]
(Update for r91646) Use mw-content-ltr/rtl so bullet list shows properly where user direction != site direction. Also add lang & dir attribute, and fix typo in shared.css.
Leo Koppelkamm [Thu, 7 Jul 2011 15:59:42 +0000 (15:59 +0000)]
Rephrasing msg clearyourcache per Bug 27550 : Adding Chrome, moving up IE, making it a bulltetd list. Thanks Amir E. Aharoni