Bryan Tong Minh [Fri, 15 Jul 2011 17:13:24 +0000 (17:13 +0000)]
Add words.txt for us Windows users. This is a random selection of 1000 words from gnuwin32 miscfiles package
Fail more gracefully in RandomImageGenerator
Chad Horohoe [Fri, 15 Jul 2011 16:59:38 +0000 (16:59 +0000)]
Slightly more informative error message when passed a bogus key (rather than property of non-object)
Chad Horohoe [Fri, 15 Jul 2011 15:54:14 +0000 (15:54 +0000)]
Stylize
Bryan Tong Minh [Fri, 15 Jul 2011 15:13:18 +0000 (15:13 +0000)]
Follow-up r79845: Fix rotation. Turns out that we need to pass the pre-rotation dimensions to convert.exe. Also added tests.
Leo Koppelkamm [Fri, 15 Jul 2011 15:06:58 +0000 (15:06 +0000)]
r92054 : Fix wordwrap by using inline-block. This has the nice sideeffect of fixing an Opera background image bug as well. Remove categories from print, they're not especially useful on paper. (Also give footer some space)
Alexandre Emsenhuber [Fri, 15 Jul 2011 14:28:24 +0000 (14:28 +0000)]
Per Nikerabbit, follow-up to r92231: removed unreachable code
Jure Kajzer [Fri, 15 Jul 2011 12:44:31 +0000 (12:44 +0000)]
* maintenance script to switch FK references if using wgSharedDB
Leo Koppelkamm [Fri, 15 Jul 2011 11:12:07 +0000 (11:12 +0000)]
AjaxCategories: move self init to mw.util.init; start with qunit
Antoine Musso [Fri, 15 Jul 2011 09:45:57 +0000 (09:45 +0000)]
NS_MAIN can locally have subpages enabled
This workaround test if any local change has been made, if so the test
will be skipped.
fu r82577
Alexandre Emsenhuber [Fri, 15 Jul 2011 08:42:25 +0000 (08:42 +0000)]
* Use local context instead of global variables
* Removed parameters that could be replaced by context
* Call Linker methods statically
* Removed two unused methods: countWatchlist() and showItemCount()
* The parameter of SpecialEditWatch::buildTools() is now unused
Chad Horohoe [Fri, 15 Jul 2011 05:32:57 +0000 (05:32 +0000)]
Fix for r92187
Roan Kattouw [Fri, 15 Jul 2011 02:21:52 +0000 (02:21 +0000)]
Followup r91672: remove commented-out reference to removed file (rtl.css)
Aaron Schulz [Fri, 15 Jul 2011 00:48:02 +0000 (00:48 +0000)]
Follow-up r92220: changed autoblock handling to use PerformRetroactiveAutoblock hook instead of a global. Also made CheckUser always override autoblocks (no config).
Aaron Schulz [Fri, 15 Jul 2011 00:05:50 +0000 (00:05 +0000)]
* Removed angry autoblock code - unused by anything
* Added $wgAutoblockHandlers variable for alternative autoblock handling functions
* Gave CheckUser a potential $wgAutoblockHandlers function (bug 29330)
Ian Baker [Thu, 14 Jul 2011 23:01:00 +0000 (23:01 +0000)]
properly handle the case where a file disappears during the uploadwizard process
remove database records for files that move out of the stash
Ian Baker [Thu, 14 Jul 2011 21:33:09 +0000 (21:33 +0000)]
fixed a condition where re-uploading a file that's already stashed causes breakage. This mirrors the previous session-based behavior as closely as possible.
Leo Koppelkamm [Thu, 14 Jul 2011 20:48:01 +0000 (20:48 +0000)]
AjaxCategories: More interface polish
Chad Horohoe [Thu, 14 Jul 2011 20:38:28 +0000 (20:38 +0000)]
Kill AjaxFunctions.php. The only thing using this was FCKEditor, so I moved js_unescape() over to it.
Roan: "So what does it do?"
Me: "Converts stuff encoded with JS's escape() back into a normal string, according to the docs."
Roan: "That sounds like a workaround for bad design"
Chad Horohoe [Thu, 14 Jul 2011 20:19:59 +0000 (20:19 +0000)]
Various cleanups to ExternalEdit. Documentation, code style, removed some unused variables, removed silly 'm' prefix, etc.
Raimond Spekking [Thu, 14 Jul 2011 20:12:43 +0000 (20:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-14 19:36:00 UTC)
Ping r92057: Full export of core and ext-installer
Chad Horohoe [Thu, 14 Jul 2011 17:48:41 +0000 (17:48 +0000)]
Use the context's response for header() calls in checkMaxLag()
Aaron Schulz [Thu, 14 Jul 2011 17:39:04 +0000 (17:39 +0000)]
Made WikiPage::factory a bit more dummy proof
Leo Koppelkamm [Thu, 14 Jul 2011 17:26:32 +0000 (17:26 +0000)]
Fix expandableField.js dependencies
Leo Koppelkamm [Thu, 14 Jul 2011 17:14:39 +0000 (17:14 +0000)]
AjaxCategories: Add basic hook functionality. Can be used by sites for stuff like {{uncategorized}} templates etc.
Leo Koppelkamm [Thu, 14 Jul 2011 16:00:07 +0000 (16:00 +0000)]
AjaxCategories: Yay! MultiEdit mode working. May need more polish. Ping r92112
Leo Koppelkamm [Thu, 14 Jul 2011 15:00:33 +0000 (15:00 +0000)]
AjaxCategories:
* Lay foundation for MultiEdit mode
* Add releasenotes
* Fix typo in function name
* Change error msg per CR
Ping r92062
Leo Koppelkamm [Thu, 14 Jul 2011 13:01:07 +0000 (13:01 +0000)]
r91949 : EditWatchlist assumed that action was always empty for view
Leo Koppelkamm [Thu, 14 Jul 2011 12:49:39 +0000 (12:49 +0000)]
Restructure tab code of mediawiki.special.preferences.js . * 10 levels of indent, really? * Follow up r91869: Instead of setting the title, and later parsing it out and setting id from it, just set the id directly. * Hashes are now in the form #prefsection-personal. This means that they now work in browser with deactivated JS as well.
Leo Koppelkamm [Thu, 14 Jul 2011 11:42:14 +0000 (11:42 +0000)]
r92054 : Remove leftover space
Leo Koppelkamm [Thu, 14 Jul 2011 11:36:50 +0000 (11:36 +0000)]
AjaxCategories:
* Restructuring to allow both private and public functions/objects.
* Add an error when category alread present, instead of quitting silently.
* Add documentation to most functions.
* Remove hardcoded api.php (Thanks Krinkle)
Ping r92062
Robin Pepermans [Thu, 14 Jul 2011 01:13:11 +0000 (01:13 +0000)]
* Fix r80248: login language links included a newline in the URL (%0D) so the links didn't work
* (Also make linkKnown() to use Linker)
Krinkle [Wed, 13 Jul 2011 23:57:11 +0000 (23:57 +0000)]
Fixes for jquery.localize unit test IE6,IE7,IE8:
- localize doesn't offically support "self" modification, only for children via find(). Which is why most were wrapped in a <div> (otherwise find('[title-msg]') won't find it). Now adding a <div> around the others as well to be consistent, and hopefully fix the breakage on testswarm in IE6-8
Krinkle [Wed, 13 Jul 2011 23:31:48 +0000 (23:31 +0000)]
Fix broken test introduced in r92113 for Gecko-browsers.
- Checking text() and attr() separately instead of comparing the resulting HTML (which was problematic due to browsers putting attributes in a different order)
Chad Horohoe [Wed, 13 Jul 2011 23:26:52 +0000 (23:26 +0000)]
(bug 26360) $wgSessionHandler was overriding system settings unconditionally. Regression I introduced a little over 2 years ago with r49370.
Robin Pepermans [Wed, 13 Jul 2011 23:02:22 +0000 (23:02 +0000)]
Follow-up r92068: add 'qqx' to dummy language codes per Nikerabbit
Aaron Schulz [Wed, 13 Jul 2011 22:59:55 +0000 (22:59 +0000)]
Avoid notice on profile close errors
Aaron Schulz [Wed, 13 Jul 2011 22:57:04 +0000 (22:57 +0000)]
Fixed profiling error
Krinkle [Wed, 13 Jul 2011 22:46:17 +0000 (22:46 +0000)]
New jquery.getAttrs module
- A cross-browser compatible way of getting a direct key/value object of attributes
- Will help making comparisons such as in r92113 easier and work cross-browser
Krinkle [Wed, 13 Jul 2011 22:37:51 +0000 (22:37 +0000)]
Unit tests for jquery.localize
(Follow-up r92069)
Also fixing a bug in jquery.localize. Previously it did mw.msg(key, [p1, p2, ...]); (passing an array as second argument), however mw.msg doesn't take an array as second argument, instead the second argument is the first in a list of optional variadic arguments. (like mw.msg(key, p1, p2, ..);
In cases were only 1 variable is passed, this didn't brake the test as [p1].toString() === p1. Fixing by using .apply instead and creating an array of arguments, starting with the key (unshifted) and if available adding parameters.
All these tests appear to be broken in Gecko-browsers because it uses a different attribute order (WebKit moslty in order of touch, Gecko mostly alphabetical, Trident/Presto engine different too). They are reported because the elements are compared as strings. I'll fix this in a better way when I think of one (soon!)
Leo Koppelkamm [Wed, 13 Jul 2011 22:36:03 +0000 (22:36 +0000)]
Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs
Leo Koppelkamm [Wed, 13 Jul 2011 22:15:11 +0000 (22:15 +0000)]
Readd ajaxCategories from r58959 . This is just a preparation for my next commit, so that the file's history is preserved
Chad Horohoe [Wed, 13 Jul 2011 22:14:19 +0000 (22:14 +0000)]
(bug 29558) Add config var to disable update.php. Did this by checking $wgMiserMode and bailing unless --iknowwhatimdoing
Aaron Schulz [Wed, 13 Jul 2011 22:11:53 +0000 (22:11 +0000)]
Pointless w/s tweaks :)
Aaron Schulz [Wed, 13 Jul 2011 22:10:20 +0000 (22:10 +0000)]
* Removed function_exists check in MWTidy, proc_open is on any PHP at out minimum PHP version
* Show warnings if we can't run tidy for some reason (bug 27889)
* Moved $wgDebugTidy check (changing the value from null would break MWTidy::tidy())
* Fixed some outdated comment
* Made a few w/s changes
Alexandre Emsenhuber [Wed, 13 Jul 2011 20:16:14 +0000 (20:16 +0000)]
* Added some tests for FauxResponse class
* Made some fixes to that class and removed one unused variable
Raimond Spekking [Wed, 13 Jul 2011 19:43:11 +0000 (19:43 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-13 19:30:00 UTC)
Ping r92057: Full export of core and ext-installer
Aaron Schulz [Wed, 13 Jul 2011 19:14:18 +0000 (19:14 +0000)]
Added 'fromdbmaster' param option to WikiPage::loadPageData()
Ian Baker [Wed, 13 Jul 2011 19:08:51 +0000 (19:08 +0000)]
Added us_status column for future expansion re Bryan's suggestion
Implemented changes suggested in code review on r92009:
constructor bug handling passed repo/stash
up-to-date timestamp generation
fetching db handle from repo
iterating over select results according to convention
changed uploadstash.us_media_type to enum to mirror image.img_media_type
removed (most) new references to $wgUser, instead using ApiBase::createContext to find the user
Brion Vibber [Wed, 13 Jul 2011 18:38:57 +0000 (18:38 +0000)]
* (bug 29808) Special:PasswordRest now sorts into the 'users' section on Special:Specialpages
One-line patch by Rusty Burchfield - https://bugzilla.wikimedia.org/attachment.cgi?id=8771
Aaron Schulz [Wed, 13 Jul 2011 18:30:47 +0000 (18:30 +0000)]
* Changed MediaWiki:main to use WikiPage
* Cleaned up MediaWiki function visibilities
Aaron Schulz [Wed, 13 Jul 2011 18:05:44 +0000 (18:05 +0000)]
* Broke long Wiki.php lines
* Added getValueNames() function to WebRequest.php
Robin Pepermans [Wed, 13 Jul 2011 17:58:27 +0000 (17:58 +0000)]
Follow-up r92068: svn:eol-style:native, and use round bracket
Krinkle [Wed, 13 Jul 2011 17:57:30 +0000 (17:57 +0000)]
jquery.localize:
* Added support for message parameters in jquery.localize since I needed that in order to replace $1 with sitename in MoodBar.
See:
Bug 29868 - Add support for passing parameters to mw.msg in jquery.localize
Robin Pepermans [Wed, 13 Jul 2011 17:46:13 +0000 (17:46 +0000)]
(bug 15802) An easy way to look up messages: language qqx which returns the message keys
(It doesn't show up in preferences, but you can use ?uselang=qqx)
Patch by Conrad Irwin (slightly modified)
Purodha B Blissenbach [Wed, 13 Jul 2011 15:57:26 +0000 (15:57 +0000)]
Fix for r85876 by doing away with a potentially invalid user name parameter behind slash in Special:EmailUser
Robin Pepermans [Wed, 13 Jul 2011 13:33:37 +0000 (13:33 +0000)]
Follow-up r92054: dir attributes are no longer needed (displays it incorrectly when user direction != content direction)
Raimond Spekking [Wed, 13 Jul 2011 13:28:37 +0000 (13:28 +0000)]
Followup r92012: Fix grammar, update meintenance scripts
Purodha B Blissenbach [Wed, 13 Jul 2011 13:10:35 +0000 (13:10 +0000)]
[bug 29737] "MediaWiki:Qbsettings-directionality" should refer to script, not language.
Purodha B Blissenbach [Wed, 13 Jul 2011 11:53:04 +0000 (11:53 +0000)]
(bug 120781) Move 'mainpagetext' messages to installer's .i18n file.
Leo Koppelkamm [Wed, 13 Jul 2011 10:41:21 +0000 (10:41 +0000)]
Render category links as an HTML list. Bug 12261. Based on patch by Thana & Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct
Chad Horohoe [Wed, 13 Jul 2011 01:55:49 +0000 (01:55 +0000)]
Forgot to change my default header, followup r92045
Chad Horohoe [Wed, 13 Jul 2011 01:54:40 +0000 (01:54 +0000)]
Add some tests for wfExpandUrl. Definitely not complete (needs some for protocol relativeness)
Roan Kattouw [Wed, 13 Jul 2011 01:27:07 +0000 (01:27 +0000)]
Per wikitech-l, run a bunch of URLs in the API output through wfExpandUrl(), so they become fully-qualified even if they were originally protocol-relative
Ian Baker [Wed, 13 Jul 2011 00:38:04 +0000 (00:38 +0000)]
Added index for abandoned uploads maintenance script
Roan Kattouw [Wed, 13 Jul 2011 00:27:40 +0000 (00:27 +0000)]
Use wfUrlProtocols() in ApiFormatBase instead of simply imploding $wgUrlProtocols and expecting that to work
Ian Baker [Wed, 13 Jul 2011 00:21:02 +0000 (00:21 +0000)]
changing smallint to int for image sizes, re bug 26179 comment 13
Ian Baker [Wed, 13 Jul 2011 00:11:02 +0000 (00:11 +0000)]
Added maintenance script for cleaning up abandoned uploads
Added methods for working with UploadStash without authenticating, for maintenance script
Roan Kattouw [Wed, 13 Jul 2011 00:03:27 +0000 (00:03 +0000)]
Now that wfParseUrl() can handle protocol-relative URLs, make wfExpandUrl() work in cases where it's fed a protocol-relative URL and $wgServer is also protocol-relative.
Roan Kattouw [Tue, 12 Jul 2011 23:52:43 +0000 (23:52 +0000)]
Extend wfParseUrl() to handle protocol-relative URLs. parse_url() doesn't handle these either so it needs more workaround logic
Aaron Schulz [Tue, 12 Jul 2011 22:04:21 +0000 (22:04 +0000)]
Fixed r92012 comment
Aaron Schulz [Tue, 12 Jul 2011 21:58:23 +0000 (21:58 +0000)]
* Made (un)watch action show a form if the token is bad/missing (this handles unwatch links given in emails)
* Changed misleading watch/unwatch subtitle msgs
Robin Pepermans [Tue, 12 Jul 2011 21:28:44 +0000 (21:28 +0000)]
Do r91966 in a different way, per Brion: use unicode-bidi:embed; instead of white-space:nowrap;
Robin Pepermans [Tue, 12 Jul 2011 21:15:09 +0000 (21:15 +0000)]
Fix r91772: left should be right (copy-paste error)
Ian Baker [Tue, 12 Jul 2011 21:11:43 +0000 (21:11 +0000)]
Refactored UploadStash and related classes to use the database for file metadata storage instead of the session, see bug 26179
Tweaked the UploadWizard to work properly with the new backend code, updated tests
Roan Kattouw [Tue, 12 Jul 2011 20:56:56 +0000 (20:56 +0000)]
Parser tests for protocol-relative URLs, for r91663 and r92005
Roan Kattouw [Tue, 12 Jul 2011 20:55:05 +0000 (20:55 +0000)]
Fix r14202 (!!): this validates the protocol against the regex for the second time (preg_split has already made sure it matches wfUrlProtocols() so no need), and uses strpos() to validate against a regex (that's just wrong). I'm removing it not because it's useless but because it breaks for URL protocols that don't contain a ':' ('//' in my case) for no reason at all. Found out about this when writing parser tests for it (will commit these in a minute), so yay tests!
Aaron Schulz [Tue, 12 Jul 2011 20:32:09 +0000 (20:32 +0000)]
Follow-up r91997, moved newFromTitle() function to WikiPage.php and renamed to factory(). This avoids an extra class.
Raimond Spekking [Tue, 12 Jul 2011 20:05:07 +0000 (20:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-12 19:38:00 UTC)
Aaron Schulz [Tue, 12 Jul 2011 20:05:02 +0000 (20:05 +0000)]
Fixed failing XML tests (on windows) due to newline vs carriage return discrepancy...ugh
Sam Reed [Tue, 12 Jul 2011 19:59:35 +0000 (19:59 +0000)]
Documentation
Mark A. Hershberger [Tue, 12 Jul 2011 19:09:20 +0000 (19:09 +0000)]
followup r91985 — remove duplication of code per ^demon's suggestion.
Mark A. Hershberger [Tue, 12 Jul 2011 18:44:15 +0000 (18:44 +0000)]
Bug #29807 — Special:PasswordReset listed on Special:SpecialPages when Authplugin allowPasswordChange() is false
After my spanking last week, I've gone over the patch more closely this time.
Mark A. Hershberger [Tue, 12 Jul 2011 18:22:53 +0000 (18:22 +0000)]
eol w/s before commiting real patch
Chad Horohoe [Tue, 12 Jul 2011 18:02:16 +0000 (18:02 +0000)]
Followup r91832: move maintenance script from core to Renameuser extension.
Aaron Schulz [Tue, 12 Jul 2011 18:01:16 +0000 (18:01 +0000)]
Added WikiPageFactory class with newFromTitle() function
Alexandre Emsenhuber [Tue, 12 Jul 2011 17:22:23 +0000 (17:22 +0000)]
* Added token to watch links
* Call Linker methods statically
Brion Vibber [Tue, 12 Jul 2011 17:21:15 +0000 (17:21 +0000)]
Revert r91973 " Bug 24254: Output JS var wgCategories on other actions than view as well"
This code just looks really wrong -- it seems to be stuffing things into OutputPage::getCategories() which seems clearly designed to only return a set of categories that have been previously set by something else; rather than a lazy loader it also seems to fetch them every time. Nor does it even check if the article exists before loading from the DB -- and in general it looks like it doesn't really fit in with other code. It also only lists itself as altering wgCategories, but it's changing what's in the OutputPage itself so this may affect other things.
Leo Koppelkamm [Tue, 12 Jul 2011 16:53:46 +0000 (16:53 +0000)]
Bug 24254: Output JS var wgCategories on other actions than view as well. Bug 24254
Alexandre Emsenhuber [Tue, 12 Jul 2011 15:38:07 +0000 (15:38 +0000)]
* In EditPage.php: don't add the separator if getCancelLink() returns an empty string
* In TalkHere extension: override getCancelLink() instead of having mangleEditForm() hack
Ariel Glenn [Tue, 12 Jul 2011 15:01:58 +0000 (15:01 +0000)]
libxml >= 2.7.3 ha a 10mb cap on the size of a text node and the LIBXML_PARSEHUGE lets us override that, needed for lucid since there are a few revs in the db larger than that limit
Robin Pepermans [Tue, 12 Jul 2011 14:58:58 +0000 (14:58 +0000)]
(bug 12205) Bidirectional names in action=credits are split and displayed incorrectly when wrapped to the next line.
Alexandre Emsenhuber [Tue, 12 Jul 2011 12:42:57 +0000 (12:42 +0000)]
Use createContext() instead of using the global context
Alexandre Emsenhuber [Tue, 12 Jul 2011 12:35:06 +0000 (12:35 +0000)]
Use the local context instead of global variables
Leo Koppelkamm [Tue, 12 Jul 2011 11:53:58 +0000 (11:53 +0000)]
Revert r91942, r91943 & reimplement. wgActions doesn't contain all possible actions!
Leo Koppelkamm [Tue, 12 Jul 2011 10:19:08 +0000 (10:19 +0000)]
r91943. Add global.
Leo Koppelkamm [Tue, 12 Jul 2011 09:58:15 +0000 (09:58 +0000)]
r91942: Add nosuchaction also if action not in
Leo Koppelkamm [Tue, 12 Jul 2011 09:42:07 +0000 (09:42 +0000)]
Followup r91871 per CR. Write back the actually executed action to . Ping r57415
Tim Starling [Tue, 12 Jul 2011 08:08:58 +0000 (08:08 +0000)]
Non-concurrent pop_type() since the $row === false case was being hit 99% of the time on WMF in a backlog situation.
Brion Vibber [Tue, 12 Jul 2011 00:25:20 +0000 (00:25 +0000)]
Followup r91833 -- use Sanitizer::escapeId's 'noninitial' option when generating sanitized ID for a sidebar entry; the actual id is prefixed with 'n-'; this fix makes the items behave like the folder sections ('p-', already escaped this way)
Aaron Schulz [Tue, 12 Jul 2011 00:09:37 +0000 (00:09 +0000)]
Added $wgAutopromoteOnceLogInRC variable (bug 29655)