From f435e8258286850dadaf1bce45b36708ecb4c65e Mon Sep 17 00:00:00 2001 From: Jan Drewniak Date: Wed, 12 Jun 2019 13:02:12 +0200 Subject: [PATCH] Removes updateIfHeightChanged override on rcfilters This override causes the rcfilter dropdown menu to be incorrectly positioned when the height of the "tag box" changes, i.e. when a tag is added and an additional row is created. This override was originally added as part of T198399 in commit a9fc286, but given bb15314 prevents the resize event from firing on pageload, that change should mitigate the performance impact of this function. Bug: T225499 Change-Id: I4a296c7d3c277d5415144aee6434b63a5035d275 --- .../src/mediawiki.rcfilters/ui/FilterTagMultiselectWidget.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/ui/FilterTagMultiselectWidget.js b/resources/src/mediawiki.rcfilters/ui/FilterTagMultiselectWidget.js index 085e22b0ac..ab75653db7 100644 --- a/resources/src/mediawiki.rcfilters/ui/FilterTagMultiselectWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/FilterTagMultiselectWidget.js @@ -267,11 +267,6 @@ OO.inheritClass( FilterTagMultiselectWidget, OO.ui.MenuTagMultiselectWidget ); /* Methods */ -/** - * Override parent method to avoid unnecessary resize events. - */ -FilterTagMultiselectWidget.prototype.updateIfHeightChanged = function () { }; - /** * Respond to view select widget choose event * -- 2.20.1