From d6e6f2f885152f5cde9cac29fddc0d847f229d8b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Wed, 14 Dec 2016 14:33:13 +0100 Subject: [PATCH] mediawiki.special.apisandbox: Avoid bitwise tricks when checking for integers In addition to being more obvious than `n | 0`, `Math.floor( n )` also works correctly for numbers outside of 32-bit int range. Change-Id: I254457500e141c0dd4e28c707fb4a00c1b04c272 --- .../src/mediawiki.special/mediawiki.special.apisandbox.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js index 60155fd50a..43321fe236 100644 --- a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js +++ b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js @@ -408,8 +408,7 @@ } else { n = +value; return !isNaN( n ) && isFinite( n ) && - // eslint-disable-next-line no-bitwise - ( n | 0 ) === n && + Math.floor( n ) === n && n >= pi.min && n <= pi.apiSandboxMax; } } ); -- 2.20.1