From 606f2783c168e66142cba639c230e3e0c5332cf6 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Tue, 14 Aug 2018 19:24:51 +0100 Subject: [PATCH] build: Update eslint-config-wikimedia to 0.7.2 Change-Id: Ibdf9cc013e1265ef461169ec2227652eaf917900 --- package.json | 4 ++-- .../mediawiki.rcfilters/mw.rcfilters.Controller.js | 4 ++-- tests/qunit/.eslintrc.json | 11 +++-------- 3 files changed, 7 insertions(+), 12 deletions(-) diff --git a/package.json b/package.json index 070fad8f5f..adfc2f85db 100644 --- a/package.json +++ b/package.json @@ -11,8 +11,8 @@ "devDependencies": { "deepmerge": "1.3.2", "eslint": "5.0.1", - "eslint-config-wikimedia": "0.6.0", - "eslint-plugin-qunit": "3.2.1", + "eslint-config-wikimedia": "0.7.2", + "eslint-plugin-qunit": "3.3.1", "grunt": "1.0.3", "grunt-banana-checker": "0.6.0", "grunt-contrib-copy": "1.0.0", diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js index 52438ca42b..5af001e1c3 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js @@ -337,8 +337,8 @@ /** * Create filter data from a number, for the filters that are numerical value * - * @param {Number} num Number - * @param {Number} numForDisplay Number for the label + * @param {number} num Number + * @param {number} numForDisplay Number for the label * @return {Object} Filter data */ mw.rcfilters.Controller.prototype._createFilterDataFromNumber = function ( num, numForDisplay ) { diff --git a/tests/qunit/.eslintrc.json b/tests/qunit/.eslintrc.json index e6d251146b..a1bd20abd1 100644 --- a/tests/qunit/.eslintrc.json +++ b/tests/qunit/.eslintrc.json @@ -1,8 +1,7 @@ { "extends": [ - "../../.eslintrc.json", - "plugin:qunit/recommended", - "plugin:qunit/two" + "wikimedia/qunit", + "../../.eslintrc.json" ], "env": { "qunit": true @@ -14,11 +13,7 @@ "operator-linebreak": 0, "quote-props": [ "error", "as-needed" ], "valid-jsdoc": 0, - "qunit/no-assert-equal": "error", - "qunit/no-early-return": "error", - "qunit/no-negated-ok": "error", "qunit/require-expect": 0, "qunit/resolve-async": 0 - }, - "plugins": [ "qunit" ] + } } -- 2.20.1