Jeroen De Dauw [Tue, 20 Jul 2010 11:17:36 +0000 (11:17 +0000)]
Doc and style improvements
Jeroen De Dauw [Tue, 20 Jul 2010 11:08:30 +0000 (11:08 +0000)]
Clarified field and method visibility
Jeroen De Dauw [Tue, 20 Jul 2010 11:00:51 +0000 (11:00 +0000)]
Re-did r69590
Tim Starling [Tue, 20 Jul 2010 10:28:00 +0000 (10:28 +0000)]
* Fixed "link" parameter in image links with "thumb" parameter, previously the link parameter was just ignored. The fix required the relevant code to be factored out so both makeImageLink2() and makeThumbLink2() could use it.
* Fixed the coding style and escaping of some nearby code. The lack of escaping on $url would have caused invalid HTML (bare ampersand) if ugly URLs were combined with page parameters.
Tim Starling [Tue, 20 Jul 2010 10:10:24 +0000 (10:10 +0000)]
Uncommented the DROP TABLE queries for parsertest_*, accidentally commented out in r40020.
Tim Starling [Tue, 20 Jul 2010 10:06:41 +0000 (10:06 +0000)]
Applying the text changes to the file as in r69589, to complete the rename from InstallerDBType to DatabaseInstaller.
Tim Starling [Tue, 20 Jul 2010 10:03:27 +0000 (10:03 +0000)]
Continued cleanup of r69589: adding DatabaseInstaller.php, copied from InstallerDBType.php@69588.
Tim Starling [Tue, 20 Jul 2010 10:01:34 +0000 (10:01 +0000)]
Cleanup for r69589 etc., deleting the file so I can copy it again.
Jeroen De Dauw [Tue, 20 Jul 2010 09:49:41 +0000 (09:49 +0000)]
Follow up to r69589
Jeroen De Dauw [Tue, 20 Jul 2010 09:49:07 +0000 (09:49 +0000)]
Follow up to r69589
Jeroen De Dauw [Tue, 20 Jul 2010 09:41:52 +0000 (09:41 +0000)]
Clarified field and method visibility
Jeroen De Dauw [Tue, 20 Jul 2010 09:30:33 +0000 (09:30 +0000)]
Renamed InstallerDBType to DatabaseInstaller
Roan Kattouw [Tue, 20 Jul 2010 09:26:56 +0000 (09:26 +0000)]
Followup to r69587: forgot to hit Save *facepalm*
Roan Kattouw [Tue, 20 Jul 2010 09:24:26 +0000 (09:24 +0000)]
Followup to r69237: clarify documentation to avoid confusion with title normalization, minor style tweak
Roan Kattouw [Tue, 20 Jul 2010 09:23:37 +0000 (09:23 +0000)]
Kill two functions in Parser that have been ununused forever, add a clarifying comment elsewhere.
Peter Potrowl [Tue, 20 Jul 2010 08:47:06 +0000 (08:47 +0000)]
Solving an issue in r69542
Raimond Spekking [Tue, 20 Jul 2010 07:34:39 +0000 (07:34 +0000)]
Remove useless <hr />. If someone wants to highlight this warning it can be better done with CSS.
OverlordQ [Tue, 20 Jul 2010 06:02:09 +0000 (06:02 +0000)]
Followup to r69580, did I mention MySQL sucks?
OverlordQ [Tue, 20 Jul 2010 05:59:51 +0000 (05:59 +0000)]
Followup to r69542, since the new installer doesn't support PG, this is going into updaters.inc
Tim Starling [Tue, 20 Jul 2010 02:17:18 +0000 (02:17 +0000)]
Fix URL for $GLOBALS overwrite vulnerability.
Platonides [Mon, 19 Jul 2010 23:08:52 +0000 (23:08 +0000)]
Update the old magic with new one.
Not only should this have used setContainsOldMagic() instead of manually modifying the member,
the outdated magic reduced the caching time to one hour even if you just used something like
{{currentmonth}}, which is hinted to one day.
This is the only usage of old magic, we could remove it but perhaps it is used by some extension?
Roan Kattouw [Mon, 19 Jul 2010 20:46:29 +0000 (20:46 +0000)]
Fix r69539: use $this->skin->stylename instead of $this->stylename, fix the path and access globals the right way
Raimond Spekking [Mon, 19 Jul 2010 19:23:15 +0000 (19:23 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-19 19:11:00 UTC)
Ariel Glenn [Mon, 19 Jul 2010 18:36:52 +0000 (18:36 +0000)]
clean up space/tab stuff
Roan Kattouw [Mon, 19 Jul 2010 15:15:41 +0000 (15:15 +0000)]
Fix typo
Roan Kattouw [Mon, 19 Jul 2010 15:13:41 +0000 (15:13 +0000)]
Followup to r69546: defer sending of notification by 15 minutes
Daniel Kinzler [Mon, 19 Jul 2010 14:35:20 +0000 (14:35 +0000)]
make image page respect different sizes of individual frames, as suggested by Markus Glaser.
Chad Horohoe [Mon, 19 Jul 2010 14:05:57 +0000 (14:05 +0000)]
Remove 1.6 compat thingies
Roan Kattouw [Mon, 19 Jul 2010 14:00:51 +0000 (14:00 +0000)]
(bug 24398) Make addwiki.php send a notification e-mail to newprojects@lists.wikimedia.org . Needs addition of fourth parameter for domain name, will document at wikitechwiki
Danny B [Mon, 19 Jul 2010 13:15:45 +0000 (13:15 +0000)]
* #siteSub (tagline) isn't headline -> replaced by div (partial fix to bug 457)
Danny B [Mon, 19 Jul 2010 12:31:35 +0000 (12:31 +0000)]
* 2009 -> 2010
Roan Kattouw [Mon, 19 Jul 2010 11:55:30 +0000 (11:55 +0000)]
Add iw_api and iw_wikiid fields to the interwiki table, plus rudimentary support in Interwiki.php and Title.php . Code written by peter17 in the iwtransclusion branch. This revision is a partial merge of r68170, r68448, r69480, r69540 and r69541
Danny B [Mon, 19 Jul 2010 10:58:12 +0000 (10:58 +0000)]
Follow up to r69538: Use $stylename member instead of hardcoding vector.
Danny B [Mon, 19 Jul 2010 10:52:01 +0000 (10:52 +0000)]
* (bug 24401) SimpleSearch: No button/text indicating 'Search' if image is disabled
Roan Kattouw [Mon, 19 Jul 2010 08:19:54 +0000 (08:19 +0000)]
Reverse-merge r69521 from 1.16wmf4: fix OpenSearch caching
Brian Wolff [Mon, 19 Jul 2010 05:57:23 +0000 (05:57 +0000)]
Fix fatal error from undefined $wgParser.
Jeroen De Dauw [Mon, 19 Jul 2010 04:23:39 +0000 (04:23 +0000)]
Removed redundant array_reverse I found 3 months back
Jeroen De Dauw [Mon, 19 Jul 2010 04:18:51 +0000 (04:18 +0000)]
Follow up to r69528 (forgot to commit this file)
Jeroen De Dauw [Mon, 19 Jul 2010 04:15:38 +0000 (04:15 +0000)]
Clarified field and method visibility
Jeroen De Dauw [Mon, 19 Jul 2010 04:05:44 +0000 (04:05 +0000)]
Split WebInstallerPage and deriving classes from WebInstaller.php to WebInstallerPage.php
Jeroen De Dauw [Mon, 19 Jul 2010 03:16:54 +0000 (03:16 +0000)]
Clarified field and method visibility
Jeroen De Dauw [Mon, 19 Jul 2010 02:41:54 +0000 (02:41 +0000)]
Clarified field and method visibility
Platonides [Sun, 18 Jul 2010 21:40:49 +0000 (21:40 +0000)]
Follow up r69508. Mention both functions.
Platonides [Sun, 18 Jul 2010 21:31:52 +0000 (21:31 +0000)]
(Bug 24436) Move cssjanus to maintenance folder
Raimond Spekking [Sun, 18 Jul 2010 19:37:51 +0000 (19:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-18 19:30:00 UTC)
Mark A. Hershberger [Sun, 18 Jul 2010 18:52:05 +0000 (18:52 +0000)]
* re r69332, r64217: complete removal of WikiSysop for CLI installer
* Incorporate new Installer::performInstallation() function
* Update SQLite schema tables to insert data to updatelog correctly
Rotem Liss [Sun, 18 Jul 2010 18:41:00 +0000 (18:41 +0000)]
Localization update for he.
Platonides [Sun, 18 Jul 2010 18:38:58 +0000 (18:38 +0000)]
Use $stylename member instead of hardcoding vector.
Alexandre Emsenhuber [Sun, 18 Jul 2010 17:37:00 +0000 (17:37 +0000)]
Follow-up r69475: also correct the name in RELEASE-NOTES
Platonides [Sun, 18 Jul 2010 13:52:30 +0000 (13:52 +0000)]
Fix comment. There's no tempfile function in php.
Alexandre Emsenhuber [Sun, 18 Jul 2010 13:18:01 +0000 (13:18 +0000)]
Fixed some doxygen warnings
Alexandre Emsenhuber [Sun, 18 Jul 2010 13:16:18 +0000 (13:16 +0000)]
Removed error suppression operators (per bug 24159)
Alexandre Emsenhuber [Sun, 18 Jul 2010 12:55:11 +0000 (12:55 +0000)]
Fixed errors in HTML5 mode
Alexandre Emsenhuber [Sun, 18 Jul 2010 12:10:39 +0000 (12:10 +0000)]
* Modified Special:Log to extend SpecialPage
* Use FormOptions
Danny B [Sun, 18 Jul 2010 10:11:01 +0000 (10:11 +0000)]
* leftover from r69500
Danny B [Sun, 18 Jul 2010 09:56:32 +0000 (09:56 +0000)]
* missing messages for r68992
Alexandre Emsenhuber [Sun, 18 Jul 2010 09:36:56 +0000 (09:36 +0000)]
Let Title::newFromIDs() select all fields and use Title::newFromRow() since we already are in the "page" table
OverlordQ [Sun, 18 Jul 2010 08:13:53 +0000 (08:13 +0000)]
Follow to r68544 make sure the right test recorder actually gets ran
Niklas Laxström [Sun, 18 Jul 2010 07:15:27 +0000 (07:15 +0000)]
Made active users concept have some meaning by decoupling it from recent changes length.
Introduced wgActiveUserDays, which defaults to 30 days as used on wmf.
This way the number can be more easily compared between wikis.
We no longer lie to users if the actual rc length is longer than the limit.
Brian Wolff [Sat, 17 Jul 2010 23:29:20 +0000 (23:29 +0000)]
Let wfTimestamp recognize negative unix timestamp values
Raimond Spekking [Sat, 17 Jul 2010 22:25:18 +0000 (22:25 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-17 22:09:00 UTC)
Alexandre Emsenhuber [Sat, 17 Jul 2010 20:13:49 +0000 (20:13 +0000)]
* Fixed some doxygen warnings
* removed $len and $redirect parameters from addLink() and addLinkObj() since they're not used
Alexandre Emsenhuber [Sat, 17 Jul 2010 19:04:07 +0000 (19:04 +0000)]
Make includable special pages extend IncludableSpecialPage so that it's easier to see the ones that are includable
Alexandre Emsenhuber [Sat, 17 Jul 2010 18:32:15 +0000 (18:32 +0000)]
* Modified Special:Blockme to subclass UnlistedSpecialPage
* Use content language to get the user name in the "proxyblocker" and added it in $wgReservedUsernames
Siebrand Mazeland [Sat, 17 Jul 2010 18:13:03 +0000 (18:13 +0000)]
Localisation updates for namespaces and special page aliases from translatewiki.net
Alexandre Emsenhuber [Sat, 17 Jul 2010 17:38:02 +0000 (17:38 +0000)]
Corrected fatal errors introduced in r68999 (oops!)
Adam Miller [Sat, 17 Jul 2010 17:21:46 +0000 (17:21 +0000)]
Accompanies r69481. Style changes for the new search placeholder text
Chad Horohoe [Sat, 17 Jul 2010 12:55:52 +0000 (12:55 +0000)]
Refactor some more of the ugly b/c update logic out of updaters.inc
Chad Horohoe [Sat, 17 Jul 2010 12:15:42 +0000 (12:15 +0000)]
Make this protected like everything else
Chad Horohoe [Sat, 17 Jul 2010 12:11:23 +0000 (12:11 +0000)]
Add stub OracleUpdater
Alexandre Emsenhuber [Sat, 17 Jul 2010 11:59:20 +0000 (11:59 +0000)]
Per Simetrical, fix for r69270: correct class name
Adam Miller [Fri, 16 Jul 2010 22:21:31 +0000 (22:21 +0000)]
Watch/Unwatch - fix for bug 24247. Updating the link text to match the icon
Platonides [Fri, 16 Jul 2010 21:55:39 +0000 (21:55 +0000)]
Make addPortletLink() work even if the ul is not there.
Insert the new ul into the last div if there's one (typically a <div class="menu">), directly in the portlet otherwise.
Raimond Spekking [Fri, 16 Jul 2010 19:09:07 +0000 (19:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-16 19:01:00 UTC)
Jack Phoenix [Fri, 16 Jul 2010 14:57:30 +0000 (14:57 +0000)]
ajaxwatch.js: coding style tweaks
Derk-Jan Hartman [Fri, 16 Jul 2010 14:04:54 +0000 (14:04 +0000)]
Follow up to r66383. When init of skin fails, make sure to init Vector instead of Monobook now.
Derk-Jan Hartman [Fri, 16 Jul 2010 13:57:03 +0000 (13:57 +0000)]
When we have a bogus useskin value, fallback to $wgDefaultSkin if that value is sane. Fallback to hardcoded "vector" default if $wgDefaultSkin is bogus. Users who still have amathyst selected as their skin preference, should now get vector instead of monobook. Follow up to r66383.
Niklas Laxström [Fri, 16 Jul 2010 11:38:10 +0000 (11:38 +0000)]
Fix method name in a comment
Niklas Laxström [Fri, 16 Jul 2010 07:24:45 +0000 (07:24 +0000)]
Revert part of r69412 which causes fatal errors
X! [Thu, 15 Jul 2010 22:39:48 +0000 (22:39 +0000)]
Move FakeResultWrapper to Database.php, allowing more special pages and extensions than just Special:Allmessages to use a ResultWrapper-specific class (TablePager comes to mind)
Ariel Glenn [Thu, 15 Jul 2010 21:25:31 +0000 (21:25 +0000)]
intval ( $id ) once in caller instead of in all the getTextXXX functions
Raimond Spekking [Thu, 15 Jul 2010 19:32:38 +0000 (19:32 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-15 19:22:00 UTC)
Platonides [Thu, 15 Jul 2010 18:30:49 +0000 (18:30 +0000)]
Recover EditUser extension and put it up to date with the new preferences.
Mark A. Hershberger [Thu, 15 Jul 2010 16:27:27 +0000 (16:27 +0000)]
Add cleanupChanneled() method to clean the channel consistently.
Roan Kattouw [Thu, 15 Jul 2010 09:25:58 +0000 (09:25 +0000)]
Apply r69357 to trunk; was a fix for trunk but got committed to REL1_16
Mark A. Hershberger [Thu, 15 Jul 2010 01:15:55 +0000 (01:15 +0000)]
re r69339 use the actual function: s/hasCache/haveCache/
Chad Horohoe [Wed, 14 Jul 2010 23:07:05 +0000 (23:07 +0000)]
Fix flush(). Need ob_flush()
Mark A. Hershberger [Wed, 14 Jul 2010 22:44:19 +0000 (22:44 +0000)]
re r67320: output a newline if we switch from channeled to unchanneled output
Mark A. Hershberger [Wed, 14 Jul 2010 21:46:52 +0000 (21:46 +0000)]
follow up r69339:
* Add a missing setVaryCookie for consistency
* don't cache result when token is given in ApiFeedWatchlist
Mark A. Hershberger [Wed, 14 Jul 2010 21:00:09 +0000 (21:00 +0000)]
follow up r69339: Add a missing setVaryCookie for consistency and to avoid user X with skin Y getting the response marked up for skin B.
Raimond Spekking [Wed, 14 Jul 2010 20:12:19 +0000 (20:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-14 19:53:00 UTC)
Platonides [Wed, 14 Jul 2010 19:19:16 +0000 (19:19 +0000)]
Remove extra space.
Roan Kattouw [Wed, 14 Jul 2010 19:00:54 +0000 (19:00 +0000)]
API: Make output containing private or user-specific data uncacheable for logged-in users by setting Vary: Cookie or Cache-Control: private, whichever is appropriate. Fixes instances in core and WMF-deployed extensions only. Without this change, the output of requests like ?action=query&list=recentchanges&rcprop=patrolled&smaxage=3600 would be cached in Squid and viewable for anyone using the same URL, even if they don't have patrol rights. Other, more serious exploits are also possible. Also avoid using $wgUser in one place, kill some unused global $wgUser; instances and tweak a comment.
Aryeh Gregor [Wed, 14 Jul 2010 18:50:32 +0000 (18:50 +0000)]
Remove 'minordefault' preference completely
See bug 24313. The preference encourages people to mark changes minor
by mistake, but it's better to have minor changes not marked minor than
non-minor changes marked minor. enwiki users at [[Help talk:Minor
edit]] seemed to think it was a good idea. Plus, I'm always in favor of
removing user preferences where possible.
The only likely fallout of note is some bot operators who didn't notice
this suddenly find their bot not marking anything minor. I doubt it
will cause major problems, though.
Trevor Parscal [Wed, 14 Jul 2010 18:31:29 +0000 (18:31 +0000)]
By flipping '"Courier New", monospace' to 'monospace, "Courier New"', we can get the beneifts of allowing the user's monospace font override to still be used. Improves on r69335 which is itself an improvement on r65391.
Trevor Parscal [Wed, 14 Jul 2010 17:50:51 +0000 (17:50 +0000)]
Improves on the technique used in r65391 to fix the font-size issues in Firefox, Chrome and Safari caused by using "monospace" as a font-family. The old approach was to use "monospace, sans-serif", which worked but was reported to actually fall-back on the sans-serif variant. Some research has shown that using '"Courier New", monospace' resolves the issue on all browsers without risking falling back to proportionally spaced fonts.
Chad Horohoe [Wed, 14 Jul 2010 17:42:52 +0000 (17:42 +0000)]
Fix nitpick complaint on r61809
Mark A. Hershberger [Wed, 14 Jul 2010 17:34:18 +0000 (17:34 +0000)]
* revert r61258
* check if iconv extension is loaded and, if so, use it in UtfNormal::cleanUp()
Chad Horohoe [Wed, 14 Jul 2010 17:28:08 +0000 (17:28 +0000)]
Revert r64217 (WikiSysop is back, and now (s)he's localisable) per comments on review
Adam Miller [Wed, 14 Jul 2010 15:06:52 +0000 (15:06 +0000)]
style version bump for r69317