Tim Starling [Mon, 22 Dec 2008 12:31:15 +0000 (12:31 +0000)]
Make the SQL search subclasses less nerve-wracking to read, by using makeList() instead of implode(), addQuotes() instead of strencode(), and by documenting the fact that parseQuery() is intentionally returning an SQL fragment to be included into a query without further escaping. No actual vulnerabilities fixed, due to effective UI-side validation, so this is just to minimise reviewer anxiety.
Raimond Spekking [Mon, 22 Dec 2008 12:07:12 +0000 (12:07 +0000)]
Fix PHP Notice: Undefined variable: toolLinks in /var/www/w/includes/specials/SpecialIpblocklist.php on line 451
Thanks to Siebrand
Ilmari Karonen [Mon, 22 Dec 2008 11:45:54 +0000 (11:45 +0000)]
Add "id" attribute to section anchors, per discussion on wikitech-l.
Siebrand Mazeland [Mon, 22 Dec 2008 10:29:53 +0000 (10:29 +0000)]
Localisation updates from Betawiki
Aaron Schulz [Mon, 22 Dec 2008 09:07:53 +0000 (09:07 +0000)]
Tweaks from profiling
Aaron Schulz [Mon, 22 Dec 2008 07:35:56 +0000 (07:35 +0000)]
Avoid extra page_touched query
Roan Kattouw [Sun, 21 Dec 2008 22:35:52 +0000 (22:35 +0000)]
(bug 16748) Null revisions are stored in the DB with rev_len=NULL. Patch by Paul Copperman
Aaron Schulz [Sun, 21 Dec 2008 21:31:06 +0000 (21:31 +0000)]
*Replace crappy BeforeWatchlist hook
*Updated LQT accordingly
*Will add flaggedrevs function to this shortly
Aryeh Gregor [Sun, 21 Dec 2008 20:22:50 +0000 (20:22 +0000)]
Break long line for diff comprehensibility
Should cause no functional change.
Alexandre Emsenhuber [Sun, 21 Dec 2008 18:35:27 +0000 (18:35 +0000)]
html -> wikitext in table headers
Siebrand Mazeland [Sun, 21 Dec 2008 13:23:29 +0000 (13:23 +0000)]
Localisation updates for core messages from Betawiki (2008-12-21 14:18 CET)
Aaron Schulz [Sun, 21 Dec 2008 09:33:04 +0000 (09:33 +0000)]
Add isNewPage() method
Aaron Schulz [Sun, 21 Dec 2008 08:49:45 +0000 (08:49 +0000)]
Improve markpatrolled hook
Roan Kattouw [Sun, 21 Dec 2008 00:21:01 +0000 (00:21 +0000)]
API: Fix weird ==/=== bug in API help: a possible value of zero is interpreted as "can be empty".
Roan Kattouw [Sat, 20 Dec 2008 23:54:04 +0000 (23:54 +0000)]
API: (bug 16730) Added apprfiltercascade parameter to list=allpages to filter cascade-protected pages
Roan Kattouw [Sat, 20 Dec 2008 23:49:16 +0000 (23:49 +0000)]
Fix up r44860, use $wgContLang instead.
Roan Kattouw [Sat, 20 Dec 2008 23:20:15 +0000 (23:20 +0000)]
API: (bug 16726) siprop=namespacealiases should also list localized aliases
Alexandre Emsenhuber [Sat, 20 Dec 2008 20:59:06 +0000 (20:59 +0000)]
Use $wgInterwikiExpiry to set the expiry time of interwiki cache
Roan Kattouw [Sat, 20 Dec 2008 20:00:07 +0000 (20:00 +0000)]
API: Fixing issue mentioned on bug 16129 comment #3: for certain inputs, action=parse dies with an internal error whining about $wgTitle not being set in OutputPage::parse(). This commit works around this by setting $wgTitle, but the parser and its friends should really leave $wgTitle alone, because people might want to parse non-$wgTitle titles, which the Parser::parse() docs suggest is possible (and it should be), but apparently isn't.
Siebrand Mazeland [Sat, 20 Dec 2008 18:56:43 +0000 (18:56 +0000)]
Localisation updates for core messages from Betawiki
Aaron Schulz [Sat, 20 Dec 2008 18:40:52 +0000 (18:40 +0000)]
Typo
Siebrand Mazeland [Sat, 20 Dec 2008 18:24:14 +0000 (18:24 +0000)]
Localisation updates. Import from tl.wikipedia.org.
Aaron Schulz [Sat, 20 Dec 2008 08:36:14 +0000 (08:36 +0000)]
Minor code cleanup
Aaron Schulz [Sat, 20 Dec 2008 08:25:39 +0000 (08:25 +0000)]
* Tweaks from profiling
* Remove extract() call
* Break some lines
Tim Starling [Sat, 20 Dec 2008 08:13:21 +0000 (08:13 +0000)]
Fixes as per bug 15895 comment 7.
Aaron Schulz [Sat, 20 Dec 2008 07:46:45 +0000 (07:46 +0000)]
Removed redundant mExtra init
Aaron Schulz [Sat, 20 Dec 2008 02:19:33 +0000 (02:19 +0000)]
(bug 16689) wfDebugLog writes an error in Apache error.log
Brion Vibber [Sat, 20 Dec 2008 02:16:39 +0000 (02:16 +0000)]
* (bug 16612) Fixed "noprint" class for Modern skin print style
Jack Phoenix [Sat, 20 Dec 2008 02:02:55 +0000 (02:02 +0000)]
adding Nathaniel Herman into CREDITS (r44084, r44213)
Aaron Schulz [Sat, 20 Dec 2008 01:19:54 +0000 (01:19 +0000)]
Don't call getCheckboxes() statically anymore
Aaron Schulz [Sat, 20 Dec 2008 01:15:40 +0000 (01:15 +0000)]
Add EditPageBeforeEditChecks hook for bug 16713
Brion Vibber [Sat, 20 Dec 2008 00:28:34 +0000 (00:28 +0000)]
* (bug 16712) Special:NewFiles updated to use "newer"/"older" paging messages for clarity over "previous/next"
Aaron Schulz [Sat, 20 Dec 2008 00:01:34 +0000 (00:01 +0000)]
Delay $wgContLang unstubbing
Ryan Schmidt [Fri, 19 Dec 2008 23:18:44 +0000 (23:18 +0000)]
* adding two hooks UserCryptPassword and UserComparePasswords to allow extensions to change how passwords are hashed in the database
Aaron Schulz [Fri, 19 Dec 2008 22:32:36 +0000 (22:32 +0000)]
Code style tweaks
Ryan Schmidt [Fri, 19 Dec 2008 22:29:13 +0000 (22:29 +0000)]
* Fix fatal error due to missing method when User::isValidPassword returns false
Siebrand Mazeland [Fri, 19 Dec 2008 21:50:52 +0000 (21:50 +0000)]
Localisation updates for core messages from Betawiki (2008-12-19 22:45 CET)
Rotem Liss [Fri, 19 Dec 2008 18:34:04 +0000 (18:34 +0000)]
Localization update for he, and fixes for links in en.
Rotem Liss [Fri, 19 Dec 2008 16:38:04 +0000 (16:38 +0000)]
Localization update for he.
Aaron Schulz [Fri, 19 Dec 2008 14:51:42 +0000 (14:51 +0000)]
Store negative results in cache
Aaron Schulz [Fri, 19 Dec 2008 09:21:20 +0000 (09:21 +0000)]
Tweaks from profiling
Niklas Laxström [Fri, 19 Dec 2008 08:54:51 +0000 (08:54 +0000)]
* Springle some parsemag to the sidebar and tagline per bug 16669
Tim Starling [Fri, 19 Dec 2008 08:43:26 +0000 (08:43 +0000)]
Stats on the blob_orphans table, to make sure we're not losing anything by dropping the tracked orphans.
Aaron Schulz [Fri, 19 Dec 2008 08:16:05 +0000 (08:16 +0000)]
short-circuit update call
Aaron Schulz [Fri, 19 Dec 2008 07:37:07 +0000 (07:37 +0000)]
Remove LogPage require
Brion Vibber [Fri, 19 Dec 2008 02:03:36 +0000 (02:03 +0000)]
* (bug 11733) Fixed parameter validation in importTextFile.php
Brion Vibber [Fri, 19 Dec 2008 01:50:07 +0000 (01:50 +0000)]
* (bug 15027) Internet domain names and IP addresses can now be indexed and searched sensibly with the default MySQL search backend.
Previously things like "192.168.1.1" couldn't be searched very cleanly in the MySQL backend for two reasons:
* First, the periods were stripped out. This resulted in it being broken into multiple short words: "192 168 1 1", leading at best to false positives and general weirdness.
* Second, for IP addresses these were shorter than the default minimum word length of 4 and thus didn't even get indexed!
The addition of padding for short words let them at least get indexed, but they still didn't turn up cleanly due to the word split. Now allowing periods through to the indexed text, and encoding periods that appear within a compound word so they get caught more cleanly.
Also made a tweak so highlighting works a bit better on word boundaries -- eg "192.168.1.1" no longer hits a highlight match for "192.168.1.100". However it's still not 100% handling some cases with the periods. Sigh.
Aryeh Gregor [Thu, 18 Dec 2008 23:24:00 +0000 (23:24 +0000)]
Enable \cancel and \cancelto in texvc
This works on Hardy, but may break all math support in the event that
some platform doesn't have support for \cancel. I don't know much
OCaml or LaTeX, so I'm not sure how to make it import the package only
if it exists or something similarly useful.
If this gets reverted, though, at least I'll have committed it and
won't have to keep the diff in git stash forever. :)
Clearly this requires a texvc recompile in any event.
Aaron Schulz [Thu, 18 Dec 2008 23:09:49 +0000 (23:09 +0000)]
Streamline links a bit
Raimond Spekking [Thu, 18 Dec 2008 21:48:06 +0000 (21:48 +0000)]
Bump $wgStyleVersion per r44774/r44782
Aaron Schulz [Thu, 18 Dec 2008 21:30:40 +0000 (21:30 +0000)]
Fix for r44775: remove debug line
Roan Kattouw [Thu, 18 Dec 2008 21:23:02 +0000 (21:23 +0000)]
Break long line in RELEASE-NOTES
Aaron Schulz [Thu, 18 Dec 2008 21:15:20 +0000 (21:15 +0000)]
Make quickbar fill in extra bottom bit
Aaron Schulz [Thu, 18 Dec 2008 20:50:28 +0000 (20:50 +0000)]
Remove some less-useful redundant links from sidebar
Siebrand Mazeland [Thu, 18 Dec 2008 20:38:33 +0000 (20:38 +0000)]
Localisation updates for core messages from Betawiki (2008-12-18 21:28 CET)
Aaron Schulz [Thu, 18 Dec 2008 20:36:02 +0000 (20:36 +0000)]
Fix odd syntax that made XHTML error
Alexandre Emsenhuber [Thu, 18 Dec 2008 19:45:58 +0000 (19:45 +0000)]
Moving check for "$rc_type == RC_LOG" before check for special pages since log entries can now have a tagert in NS_SPECIAL, this happens for log item deletion (rev_deleted stuff) and thus breaking recent changes display, (see the current version of test.wikipedia.org/wiki/Special:RecentChanges, where the deletion log appears as "block log" since the last entry is hiding an item from the block log)
Aryeh Gregor [Thu, 18 Dec 2008 18:16:09 +0000 (18:16 +0000)]
(bug 16459) Use native getElementsByClassName
Patch by Derk-Jan Hartman. Seems not to break table sorting in Firefox
3, and he's tested it in other browsers, including IE6. (Of course it
falls back to ordinary JS if the native version is unavailable.)
Robert Stojnić [Thu, 18 Dec 2008 18:01:06 +0000 (18:01 +0000)]
New search UI tweaks:
* Show namespace checkboxes only for advanced search. Showing these for "Project Pages" searches
does provide information for advanced users, but clutters UI for everyone else. User should be able to
refer to help pages to find out which namespace are in "Project Pages" and these are also in tooltip
* put "did you mean.." inside the fieldset for increased visibility
* missing 'advanced' req param was making advanced form behave strangely, fixed
* remove "browse pages with this prefix", clutters, sometimes shows up, sometimes not. User cannot tell why
if not familiar with namespaces and logic behind the it (e.g. it shows only when one namespace is selected)
* correct placement of external search box when search is disabled
* make search messages consistent for new and existing pages
Roan Kattouw [Thu, 18 Dec 2008 15:00:07 +0000 (15:00 +0000)]
API: Fix up r44676: convert underscores to spaces in canonical names.
Siebrand Mazeland [Thu, 18 Dec 2008 12:27:39 +0000 (12:27 +0000)]
(bug 16698) Fixed typo in NS_FILE_TALK
Siebrand Mazeland [Thu, 18 Dec 2008 11:59:48 +0000 (11:59 +0000)]
(bug 15670)-ish: Update fallback from Hindi to Bengali. Assamese and Bengali share the same script, and the languages are spoken in the same region, albeit mainly in different countries (India and Bangladesh respectively).
Siebrand Mazeland [Thu, 18 Dec 2008 11:42:16 +0000 (11:42 +0000)]
(bug 16696) remove duplicate namespace definitions in MessagesLij.php
Siebrand Mazeland [Thu, 18 Dec 2008 00:34:57 +0000 (00:34 +0000)]
Localisation updates from Betawiki
Siebrand Mazeland [Wed, 17 Dec 2008 23:45:11 +0000 (23:45 +0000)]
Localisation updates for core messages from Betawiki (2008-12-18 00:40 CET)
Aaron Schulz [Wed, 17 Dec 2008 20:03:55 +0000 (20:03 +0000)]
Remove bug report link
Alexandre Emsenhuber [Wed, 17 Dec 2008 18:22:47 +0000 (18:22 +0000)]
Fix tests so that they can work with Configure extension or some other special config
Alexandre Emsenhuber [Wed, 17 Dec 2008 17:27:43 +0000 (17:27 +0000)]
* Short circuit EmailNotification::notify() to not call EmailNotification::commonMessageKeys() if there're no users to notify. This is a hack to work arround the following exception:
A database query syntax error has occurred.
The last attempted database query was:
"SELECT gu_id, lu_wiki, gu_salt, gu_password,gu_auth_token, gu_locked,gu_hidden,gu_registration,gu_email,gu_email_authenticated FROM `parsertest_globaluser` LEFT OUTER JOIN `parsertest_localuser` ON gu_name=lu_name AND lu_wiki='test2wiki-parsertest_' WHERE gu_name='127.0.0.1'"
from within function "Database::safeQuery".
MySQL returned error "1146: Table 'centralauth.parsertest_globaluser' doesn't exist (127.0.0.1)"
* Whitespaces fixes
Roan Kattouw [Wed, 17 Dec 2008 16:34:01 +0000 (16:34 +0000)]
API: Crusade against extract(). Left one extract() call alone in ApiQueryBacklinks.php because I don't have a better alternative for it.
Roan Kattouw [Wed, 17 Dec 2008 15:35:57 +0000 (15:35 +0000)]
Revert r44716 (added user,excludeuser to watchlist,recentchanges): can't commit this just yet because not all WMF servers have the user_text index just yet, see also bug 14200
Raimond Spekking [Wed, 17 Dec 2008 15:01:06 +0000 (15:01 +0000)]
Prettify files tab of Special:Preferences a bit
Roan Kattouw [Wed, 17 Dec 2008 14:50:48 +0000 (14:50 +0000)]
API: (bug 16527) Added user and excludeuser parameters to list=watchlist,recentchanges
Niklas Laxström [Wed, 17 Dec 2008 14:07:07 +0000 (14:07 +0000)]
* Shut this up
Raimond Spekking [Wed, 17 Dec 2008 13:54:32 +0000 (13:54 +0000)]
Fix hardcoded "last month" in statistic message for acitve users.
This is wrong because the number of active users is count in SiteStats::cacheUpdate from recentchanges table.
Default of $wgRCMaxAge is 7 days not 30 days.
Niklas Laxström [Wed, 17 Dec 2008 11:24:52 +0000 (11:24 +0000)]
* Fix for bug 16687
Tim Starling [Wed, 17 Dec 2008 07:42:46 +0000 (07:42 +0000)]
Is this needed? Probably not, but it doesn't hurt. The connection is only used for reading, so the commitMasterChanges() is technically unnecessary but harmless. Without closeAll(), the connection will be held open until the script terminates, but that's probably pretty soon in this case.
Aaron Schulz [Wed, 17 Dec 2008 07:17:59 +0000 (07:17 +0000)]
Use more thorough Title->userCan('patrol')
David McCabe [Wed, 17 Dec 2008 07:08:16 +0000 (07:08 +0000)]
UserMailer bigtime refactor. Please test.
David McCabe [Wed, 17 Dec 2008 07:05:42 +0000 (07:05 +0000)]
wfInvoke documentation fix
David McCabe [Wed, 17 Dec 2008 07:00:18 +0000 (07:00 +0000)]
Factored wfInvoke out of wfRunHooks. This time without breakage. (I think.)
Aaron Schulz [Wed, 17 Dec 2008 01:35:40 +0000 (01:35 +0000)]
Add fragment to nav links to set location
Danny B [Wed, 17 Dec 2008 01:18:47 +0000 (01:18 +0000)]
* footer separator fix per tools.ietf.org/html/rfc3676#section-4.3
Brion Vibber [Wed, 17 Dec 2008 00:05:55 +0000 (00:05 +0000)]
Reverting r44681 "Throw in quick hack $wgRateLimitsExcludedIPs so we don't have to do a live hack every time somebody runs an exciting event where they're going to register a lot of accounts."
r44592 (bug 7492) seems to cover this case with an extension to autopromote settings. Future on-wiki stuff still would be nice...
Andrew Garrett [Wed, 17 Dec 2008 00:00:55 +0000 (00:00 +0000)]
Fix broken and double escaping in r44657.
Brion Vibber [Tue, 16 Dec 2008 23:57:21 +0000 (23:57 +0000)]
Cleanup r44683 -- fix E_NOTICE bug in MWNamespace::getCanonicalName() instead of replicating the function. :)
(Also note -- using MWNamespace instead of Namespace for PHP 5.3 compat.)
Siebrand Mazeland [Tue, 16 Dec 2008 22:56:38 +0000 (22:56 +0000)]
Localisation updates from Betawiki
Siebrand Mazeland [Tue, 16 Dec 2008 22:06:25 +0000 (22:06 +0000)]
Localisation updates for core messages from Betawiki (2008-12-16 22:56 CET)
Brion Vibber [Tue, 16 Dec 2008 21:56:44 +0000 (21:56 +0000)]
Update $wgSVGConverters default command lines to send both width and height to ImageMagick convert
Aaron Schulz [Tue, 16 Dec 2008 20:45:03 +0000 (20:45 +0000)]
(bug 16648) 'FlaggedRevs #mw-data-after-content overflows quickbar w/ standard classic skin'
Alex Z [Tue, 16 Dec 2008 19:59:37 +0000 (19:59 +0000)]
Fix for r44676, fix E_NOTICE from having no canonical name associated with a namespace (ns 0), move RELEASE-NOTES entry to API section and clarify.
Aaron Schulz [Tue, 16 Dec 2008 19:20:35 +0000 (19:20 +0000)]
*Add missing 'reblock' check and message setting
*Move right checks to typeAction to make the code prettier
Brion Vibber [Tue, 16 Dec 2008 18:43:42 +0000 (18:43 +0000)]
Throw in quick hack $wgRateLimitsExcludedIPs so we don't have to do a live hack
every time somebody runs an exciting event where they're going to register
a lot of accounts.
Should be killed and replaced with an on-wiki system for approvals or temporary lifting of limits as a sort of anti-block.
Alexandre Emsenhuber [Tue, 16 Dec 2008 17:26:36 +0000 (17:26 +0000)]
und -> and ;)
Alexandre Emsenhuber [Tue, 16 Dec 2008 17:21:42 +0000 (17:21 +0000)]
Use wfGetLangObj()
X! [Tue, 16 Dec 2008 17:19:05 +0000 (17:19 +0000)]
* (bug 16672) Add canonical parameter to meta=siteinfo&siprop=namespaces|namespacealiases.
Chad Horohoe [Tue, 16 Dec 2008 14:07:58 +0000 (14:07 +0000)]
Add two new XML methods for building tables (buildTable and buildTableRow). Accepts associative arrays where the key is the row/cell id and the value is its value. Non-string keys are skipped.
Raimond Spekking [Tue, 16 Dec 2008 13:03:19 +0000 (13:03 +0000)]
Follow up for r44669: simplfy code. Thanks to IAlex and Nikerabbit
Raimond Spekking [Tue, 16 Dec 2008 12:42:53 +0000 (12:42 +0000)]
* Add PLURAL support for 'undeletepagetext'
* Remove commented out line
* Add a space between input field and submit button
Alexandre Emsenhuber [Tue, 16 Dec 2008 11:41:51 +0000 (11:41 +0000)]
Fix for r44657: correct usage of SpecialPage::getTitleFor()
Siebrand Mazeland [Tue, 16 Dec 2008 08:54:42 +0000 (08:54 +0000)]
Fix syntax errors in r44658.