Thomas Gries [Thu, 11 Aug 2011 20:47:25 +0000 (20:47 +0000)]
correction of Mixed tabs and spaces (2 tabs and 4 spaces), should use just tabs for indentation
Raimond Spekking [Thu, 11 Aug 2011 20:12:53 +0000 (20:12 +0000)]
Localisation update for core and extension messages from translatewiki.net (2011-08-11 19:50:00)
Robin Pepermans [Thu, 11 Aug 2011 20:03:53 +0000 (20:03 +0000)]
remove stuff accidentally committed in r94279
Robin Pepermans [Thu, 11 Aug 2011 19:58:23 +0000 (19:58 +0000)]
* CategoryPage.php: fix the "category-empty" message per comment on r91518, it was outside the bodyContent. And do not convert interface text.
* Parser.php: Apparently that was a much bigger bug: do not convert interface text going through the parser either.
* Preferences.php: Do not convert the user signature.
For this bug in action, see e.g. http://sr.wikipedia.org/sr-ec/Посебно:Подешавањ?uselang=en (e.g. "Username" -> "Усернаме")
Mark A. Hershberger [Thu, 11 Aug 2011 19:51:51 +0000 (19:51 +0000)]
Fix Bug #30322 “SVG metadata is read incorrectly” by applying supplied patch
Krinkle [Thu, 11 Aug 2011 19:14:34 +0000 (19:14 +0000)]
Solve undefined-message problem by removing it all together. I've moved the .containsCat() check to before the $link.length/createCatLink code, now it's always defined.
(Follows-up r93351, r94268)
Sam Reed [Thu, 11 Aug 2011 19:10:22 +0000 (19:10 +0000)]
I think 3 and a half years is long enough for the redirection to be left around
Krinkle [Thu, 11 Aug 2011 19:01:39 +0000 (19:01 +0000)]
ajaxCategories fixes based on review in r93351 CR:
* Using typeof check in clean()
* Use mw.Title to get page title from fullpagename instead of split(':')
* replaceNowikis() and restoreNowikis()
- Improve documentation
- Moved dash in the UNIQUEKEY to between the id and the incrementing integer, and made it start with an empty string (so that all following concatenations are toString'ed).
* makeCaseInsensitive(): Moved the wgCaseSensitiveNamespaces-check out and wrapped it around the caller instead. Also cached the outcome of "Is category namespace sensitive ?".
* createButton(): text-argument is indeed text, not html. Applying html-escaping.
* resolveRedirects():
- Replace access to private property _name of mw.Title with function getMainText().
* handleCategoryAdd() and handleEditLink():
- Restructure title-handling (no local replace() calls and clean(), let mw.Title handle it)
- Renaming arguments and documenting them better
- Renaming local variables and removing redundant parts
- Preserving sortkey as sortkey as long as possible without the pipe
- Calling the combination of sortkey and leading pipe 'suffix' instead of, also, sortkey.
* createCatLink():
- Remove the sanitizing here, the string passed is already clean as it comes from mw.Title now
- Using .text() instead of .append( which is .html-like), category names can contain special characters.
* containsCat():
- Using $.each instead of [].filter. Stopping after first match.
* buildRegex(): Allow whitespace before namespace colon, and allow whitespace after category name (but before ]] and |..]])
Additional changes not for any function in particular:
* Literally return null in $.map callbacks.
* Using the existence-system of mw.Title instead of passing around booleans everywhere
** Removed 'exists' argument from the resolveRedirects() and handleCategoryAdd() functions, instead checking .exists() of the mw.Title object.
* Passing and using mw.Title objects where possible instead of converting back and forth between strings and objects etc.
* Using "TitleObj.getUrl()" instead of "catUrl( titleString )". Removed now unused catUrl() function.
* To improve readability, renamed local uses of 'var that = this' to 'var ajaxcat = this'.
* Syntax error fixes (.parent -> .parent())
* Merging var statements
* Renamed generic members of 'stash' from 'stash.summaries' to 'stash.dialogDescriptions' and 'stash.shortSum' to 'stash.editSummaries'. dialogDescription is always HTML (input should be escaped before hand)
Victor Vasiliev [Thu, 11 Aug 2011 17:21:31 +0000 (17:21 +0000)]
Allow extensions to add pages with non-wikitext display by adding two new
hooks (generalizing the code already used for CSS/JS pages).
Robin Pepermans [Thu, 11 Aug 2011 14:52:57 +0000 (14:52 +0000)]
Add 2 @since and add documentation for PageContentLanguage hook
Roan Kattouw [Thu, 11 Aug 2011 14:47:18 +0000 (14:47 +0000)]
Fix a few comment typos noticed when doing JS review
Krinkle [Thu, 11 Aug 2011 14:28:16 +0000 (14:28 +0000)]
Add module definition for jquery.qunit.completenessTest and set position to top for jquery.qunit (right now it's manually loaded with a <script> tag, but once it's loaded dynamically it should be loaded from top because of the styling and the hooks that it makes available).
Alexandre Emsenhuber [Thu, 11 Aug 2011 14:13:03 +0000 (14:13 +0000)]
Make SpecialRecentchangesTest pass
Alexandre Emsenhuber [Thu, 11 Aug 2011 13:57:15 +0000 (13:57 +0000)]
We have startParse() for that
Sam Reed [Thu, 11 Aug 2011 12:49:30 +0000 (12:49 +0000)]
Followup r93211, add log_timestamp to end of the index
Krinkle [Thu, 11 Aug 2011 12:42:31 +0000 (12:42 +0000)]
Oh, right.
IE6/7 doesn't support that.
( Thanks TestSwarm, http://toolserver.org/~krinkle/testswarm/job/289/ )
Changing to a normal raises().
(Follows-up r94237)
Krinkle [Thu, 11 Aug 2011 12:36:00 +0000 (12:36 +0000)]
mediawiki.Title fix for IE.
In normal browsers the matches-array contains null/undefined if there's no match, IE returns an empty string.
Changing the checks to really validate that it's a non-empty string, which means that from now on mw.Title will also throw an error on "new mw.Title('');", which makes it consistent with the PHP backend (Title::newFromText('') return null instead of an object).
Adding unit test to make sure this behavior is tracked from now on.
The _name and _ext properties are either left to their default (null) or set to a valid value.
So reverting the checks from r94066, and instead checking for empty string inside the byteLimit callback, that way mw.Title will not get the empty string in the first place.
(Follows-up r94066 CR)
Krinkle [Thu, 11 Aug 2011 11:09:53 +0000 (11:09 +0000)]
Follow-up r93383: api param is 'namespace', not 'namespaces'.
Roan Kattouw [Thu, 11 Aug 2011 10:33:22 +0000 (10:33 +0000)]
Followup r85025, r85166, r93233: use strict comparison per CR comment, because "0" != "00" is false
Krinkle [Thu, 11 Aug 2011 04:09:34 +0000 (04:09 +0000)]
Rename mw.uri to mw.Uri + minor fixes:
* Renaming mw.uri to mw.Uri (since it's a constructor)
* Leaked global variable 'g' in _parse() fixed
* Removing unused local variable '_this' in getQueryString()
* Fix documentation (jQuery 'setAttr' should be 'attar')
* Making non-private variables with '@private' comment, private (or "local").
* Using strict undefined comparison (shorter and faster, [[JSPERF]])
* Moving Resources definition from MediaWiki Page section to MediaWiki main section (to reflect directory structure)
* Coding style conventions (mixed spaces and tabs, line wrapping, double/single quotes)
* Remove passing mediaWiki to mw argument (mw is a global alias)
* Passes JSHint
* Removing 404 errors from UploadWizard/test/jasmine/SpecRunner.html
(Follows-up r93781 's move)
Krinkle [Thu, 11 Aug 2011 03:22:25 +0000 (03:22 +0000)]
Allow web access to jasmine directory (just like QUnit)
Krinkle [Thu, 11 Aug 2011 03:19:29 +0000 (03:19 +0000)]
Coding style commit
* Colon placement
* Trailing whitespace
* Spaces to tabs
* No need for separate var if it's just a single var (waste of space)
* Strict comparison to undefined
Krinkle [Thu, 11 Aug 2011 03:12:12 +0000 (03:12 +0000)]
Renaming jquery.mwPrototypes to jquery.mwExtension
* Originally they were a few prototypes on the native String object, however they were converted to be (static) members extending the jQuery object. Calling them prototypes is confusing. A grep search on /trunk/ didn't reveal any direct uses of this module (it's loaded by default through mediawiki.util's dependencies)
Sam Reed [Thu, 11 Aug 2011 00:17:58 +0000 (00:17 +0000)]
Followup r94211
Bug 30315 - Declaration of FauxResponse::setcookie() should be compatible with that of WebResponse::setcookie()
Chad Horohoe [Wed, 10 Aug 2011 23:29:08 +0000 (23:29 +0000)]
(bug 30192) Old thumbnails not properly purged. Unlike the bug suggests, we don't need to also purge from LocalFile::purgeCache(), since that code path ends up calling purgeHistory() anyway.
A lot of this could probably be protected...not much calls these outside of FileRepo code other than File::purgeCache()
Chad Horohoe [Wed, 10 Aug 2011 23:27:10 +0000 (23:27 +0000)]
Allow overriding $wgCookiePrefix and $wgCookieDomain in WebResponse::setcookie() so I can stop crying when I look at things like CentralAuth and CentralNotice
Robin Pepermans [Wed, 10 Aug 2011 22:19:57 +0000 (22:19 +0000)]
Re-add historysubmit, removed in r92984. This broke directionality support when viewing diffs.
Roan Kattouw [Wed, 10 Aug 2011 21:15:57 +0000 (21:15 +0000)]
Merge r93797 to trunk, in a somewhat modified form: clamp expiries for memcached to 30 days, higher values give trouble apparently
Alexandre Emsenhuber [Wed, 10 Aug 2011 19:34:23 +0000 (19:34 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
Aaron Schulz [Wed, 10 Aug 2011 18:32:22 +0000 (18:32 +0000)]
Made moveToInternal() check result of Article::insertOn (related to bug 26223)
Chad Horohoe [Wed, 10 Aug 2011 17:29:08 +0000 (17:29 +0000)]
release notes for r94171, checked in from the wrong directory
Chad Horohoe [Wed, 10 Aug 2011 17:28:25 +0000 (17:28 +0000)]
(bug 30219) NoLocalSettings.php broken on Windows servers. Per Tim on r70711, can't use pathinfo() on url's since the slashes don't match.
Chad Horohoe [Wed, 10 Aug 2011 15:35:03 +0000 (15:35 +0000)]
Various profiler tweaks:
* Add some debugging output to bad profiler config
* Make member variables all protected, nothing uses them outside of Profiler and its subclasses
* Allow setting $mProfilerID from the config
Roan Kattouw [Wed, 10 Aug 2011 14:23:25 +0000 (14:23 +0000)]
(bug 30074) Moving user JS subpages resulted in JS errors because #REDIRECT [[Foo]] is invalid JS. Fix this by refusing to load redirect pages in ResourceLoaderWikiModule. Patch by John Du Hart
Thomas Gries [Wed, 10 Aug 2011 05:58:21 +0000 (05:58 +0000)]
reverting my unintended change in DefaultSettings.php
Thomas Gries [Wed, 10 Aug 2011 05:45:41 +0000 (05:45 +0000)]
adding label atttributes for confirm checkboxes in SpecialLockdb and SpecialUnlockdb. Fix for bug30299 .
Alexandre Emsenhuber [Tue, 9 Aug 2011 20:09:30 +0000 (20:09 +0000)]
Fix doc: wfLoadAllMessages() doesn't exists
Aaron Schulz [Tue, 9 Aug 2011 18:36:20 +0000 (18:36 +0000)]
Reverted r91871 per CR: mediawiki.org/wiki/Special:Code/MediaWiki/91871#c19474
Also, the related getAction() changes were already reverted.
Aaron Schulz [Tue, 9 Aug 2011 18:30:09 +0000 (18:30 +0000)]
Follow-up r92065: call userForm dynamically. Also made userForm protected as no one else calls it and it's not static anymore.
Chad Horohoe [Tue, 9 Aug 2011 16:13:56 +0000 (16:13 +0000)]
Move the fuzz test into @group Broken so it will shut up about being incomplete
Chad Horohoe [Tue, 9 Aug 2011 14:57:55 +0000 (14:57 +0000)]
Drop unused and unset $wgRightsCode from generated LocalSettings.php
Chad Horohoe [Tue, 9 Aug 2011 13:59:36 +0000 (13:59 +0000)]
(bug 30264) MediaWiki installer uses require, de facto is require_once
Chad Horohoe [Tue, 9 Aug 2011 13:30:01 +0000 (13:30 +0000)]
Followup r92643: refer to the passed object as $parser, not $this
Alexandre Emsenhuber [Mon, 8 Aug 2011 21:07:17 +0000 (21:07 +0000)]
Use local context instead of global variables
Raimond Spekking [Mon, 8 Aug 2011 17:47:17 +0000 (17:47 +0000)]
Localisation update for core and extension messages from translatewiki.net (2011-08-08 17:15:00)
Sam Reed [Mon, 8 Aug 2011 17:34:37 +0000 (17:34 +0000)]
* (bug 28159) Change interwiki name of language kbd to Адыгэбзэ
Krinkle [Mon, 8 Aug 2011 17:02:29 +0000 (17:02 +0000)]
Adding support for a callback to jquery.byteLimit
* Fixes (bug 29455) Add support for a filter callback function in jQuery byteLimit plugin.
* Adding unit tests for it
* Changing if-statements in mw.Title's helper functions for regular expression matches. It should check wether the value is not null or undefined. Before it was just a plain if-statement which meant that an empty string would also return false, which made the new byteLimit's tests fail (mw.Title.getMain() expects _name to be a valid string when it does ucFirst() and substr() etc.)
Sam Reed [Mon, 8 Aug 2011 16:20:17 +0000 (16:20 +0000)]
Followup r88488, moved some of the prep work in it that was for r88493
Only apply code if needs to be added (more like SpecialWatchlist)
Chad Horohoe [Mon, 8 Aug 2011 16:08:48 +0000 (16:08 +0000)]
Mostly revert r89400: not needed since Brion fixed the tests in other ways
Rotem Liss [Mon, 8 Aug 2011 12:48:19 +0000 (12:48 +0000)]
Reverting part of r94011 (in MessagesHe.php): The new alias for Special:ChangePassword is the same as Special:PasswordReset, and means "reset" and not "change".
Krinkle [Mon, 8 Aug 2011 11:11:02 +0000 (11:11 +0000)]
Clean up mediawiki.Title test suite:
* Remove unused variable i and blti
* Change expected to a string instead of a number
** This removes the need for all the comments after 'expected' explaining the choice for that number
* Add assertion to verify exact output of the string, rather than just it's length
* Rename useLimit to hasLimit
Alexandre Emsenhuber [Sun, 7 Aug 2011 14:41:19 +0000 (14:41 +0000)]
Use local context instead of global variables
Alexandre Emsenhuber [Sun, 7 Aug 2011 14:29:28 +0000 (14:29 +0000)]
Temporaray revert of r94031; forgot that this was depending of some other work on my working copy
Alexandre Emsenhuber [Sun, 7 Aug 2011 12:28:58 +0000 (12:28 +0000)]
Readd basic headers and <html>...</html> arround error contents that was removed in r90993. This caused display errors of UTF-8 characters due to the lack of these things in a DBConnectionError exception.
Max Semenik [Sun, 7 Aug 2011 08:08:36 +0000 (08:08 +0000)]
Fixed sidebar tests on Windows. Can't use PHP_EOL here because \r\n is used only in SVN checkouts and not in tarballs
Alexandre Emsenhuber [Sat, 6 Aug 2011 20:39:15 +0000 (20:39 +0000)]
Made code more readable by moving the check about user being last editor when an edit conflicts occurs near related checks; also removed some variables that were used only once
Alexandre Emsenhuber [Sat, 6 Aug 2011 19:41:49 +0000 (19:41 +0000)]
* Moved action=history to use an Action subclass
* Removed obsolete aliases PageHistory and PageHistoryPager; unused
* Maintained backward compatibility with HistoryPage; extensions using it will still work
* Use local context instead of global variables
* Removed calls to OutputPage::setPageTitleActionText() and OutputPage::setSyndicated(), the first one does nothing and the second one is overriden by the setFeedAppendQuery() call just below
* Call Linker methods statically
* Fixed bug where feedEmpty() was not called on empty history since casting a ResultWrapper object to boolean always returns true even when there's no row
Max Semenik [Sat, 6 Aug 2011 16:39:59 +0000 (16:39 +0000)]
Warn user if mod_security is present
Sam Reed [Sat, 6 Aug 2011 12:18:15 +0000 (12:18 +0000)]
Partial revert to r94024
Only 2 lines in Vector needed reverting, not the whole revision
Brion Vibber [Sat, 6 Aug 2011 12:06:11 +0000 (12:06 +0000)]
Revert r89123 -- caused bug 30259 (switched correct calls with incorrect calls because of some interpretation of 'deprecation', causing invalid HTML output and breakage of watch tab on edit page)
Siebrand Mazeland [Sat, 6 Aug 2011 09:35:25 +0000 (09:35 +0000)]
Localisation updates for magic words from translatewiki.net.
Siebrand Mazeland [Sat, 6 Aug 2011 09:21:05 +0000 (09:21 +0000)]
Localisation updates for namespace names from translatewiki.net.
Siebrand Mazeland [Sat, 6 Aug 2011 08:35:42 +0000 (08:35 +0000)]
Localisation updates for special page aliases from translatewiki.net.
Sam Reed [Sat, 6 Aug 2011 00:24:18 +0000 (00:24 +0000)]
Documentation!
Chad Horohoe [Fri, 5 Aug 2011 21:47:37 +0000 (21:47 +0000)]
Standardize comments, wrap lines at 80 chars
Chad Horohoe [Fri, 5 Aug 2011 17:03:35 +0000 (17:03 +0000)]
Reverting r84309 (New pages log doesn't remove/update item after suppression redirect). Per the patch author and committer's own admission, this doesn't seem like the correct fix. I haven't dug into it deeply, but I tend to agree. Reverting to the status quo rather than have this make it into a release half-baked. Reopening bug 17463 so this can get some more discussion (also this definitely needed RELEASE-NOTES)
Sam Reed [Fri, 5 Aug 2011 16:05:41 +0000 (16:05 +0000)]
Whitespace and comment updates
Alexandre Emsenhuber [Fri, 5 Aug 2011 15:17:19 +0000 (15:17 +0000)]
* Call Linker methods statically
* Use INSERT IGNORE for the site_stats row (as for the interwiki entries); was throwing query error about duplicate row on my installation
Alexandre Emsenhuber [Fri, 5 Aug 2011 15:10:08 +0000 (15:10 +0000)]
$wgLanguageCode applies to $wgContLang, not $wgLang. This was breaking the test suite by dying with a "nooo!" in when reaching LanguageConverterTest.
Alexandre Emsenhuber [Fri, 5 Aug 2011 14:58:37 +0000 (14:58 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
Sam Reed [Fri, 5 Aug 2011 14:55:53 +0000 (14:55 +0000)]
Followup r93905 per comment on bug 30230
Make text parameter of ApiExpandTemplates required
Raimond Spekking [Fri, 5 Aug 2011 14:40:09 +0000 (14:40 +0000)]
Localisation update for core and extension messages from translatewiki.net (2011-08-05 14:15:00)
Sam Reed [Fri, 5 Aug 2011 13:34:22 +0000 (13:34 +0000)]
* (bug 18634) Create API to fetch MediaWiki's language fallback tree structure
Patch by "merl"
Tested with pt-br, seems to work fine, listing pt and en for the fallback languages
Sam Reed [Fri, 5 Aug 2011 13:07:09 +0000 (13:07 +0000)]
Some annotation for (bug 29907) action=parse only fetches from the parser cache, it does not store to it
Mark A. Hershberger [Fri, 5 Aug 2011 12:40:49 +0000 (12:40 +0000)]
re: r93889: clarify that only registered users get movefile right by default.
Sam Reed [Fri, 5 Aug 2011 12:29:39 +0000 (12:29 +0000)]
Add @since to Revision::newFromRow per Nikerabbit
Follows up r93935
Jan Gerber [Fri, 5 Aug 2011 08:49:43 +0000 (08:49 +0000)]
dont use deprecated function WebRequest::getFileSize
Aaron Schulz [Fri, 5 Aug 2011 02:36:59 +0000 (02:36 +0000)]
$wgVersionNumber renamed to $wmfVersionNumber
Sam Reed [Fri, 5 Aug 2011 00:33:03 +0000 (00:33 +0000)]
Add documentation
Minor whitespace/brace additions
Aaron Schulz [Thu, 4 Aug 2011 23:33:50 +0000 (23:33 +0000)]
Removed interwiki list per r89431 CR
Sam Reed [Thu, 4 Aug 2011 23:26:53 +0000 (23:26 +0000)]
Followup r89564
Switch from newFromTitle to the new newFromRow in r93935
Sam Reed [Thu, 4 Aug 2011 23:25:34 +0000 (23:25 +0000)]
Adding Revision::newFromRow() function as alias for new Revision()
More consistent with how we do stuff everywhere else
Chad Horohoe [Thu, 4 Aug 2011 23:14:17 +0000 (23:14 +0000)]
Partial fix for r88772: no need for IGNORE on site_stats, just interwiki
Chad Horohoe [Thu, 4 Aug 2011 23:00:02 +0000 (23:00 +0000)]
Fix profiling in Article::getParserOutput()
Chad Horohoe [Thu, 4 Aug 2011 22:34:26 +0000 (22:34 +0000)]
Followup r93928: forgot to remove this
Chad Horohoe [Thu, 4 Aug 2011 22:33:04 +0000 (22:33 +0000)]
Fixes for r92251:
* Move Imagick check into getImageWriteMethod(), adjust exception catching. Previously this was bailing on the test if you have convert but not the PHP Imagick extension. Now all these tests are passing for me again.
* Rm unused member variable, whitespace, etc
Sam Reed [Thu, 4 Aug 2011 22:21:40 +0000 (22:21 +0000)]
st47 == Dan Collins
So might aswell just leave the real name credits
Sam Reed [Thu, 4 Aug 2011 22:20:52 +0000 (22:20 +0000)]
* (bug 17119) class Parser: senseless use of non-existing regexp back reference
Patch made by Dan Collins,, based on text placed by "seth"
Chad Horohoe [Thu, 4 Aug 2011 22:06:05 +0000 (22:06 +0000)]
Followup r93921: missed something from testing
Chad Horohoe [Thu, 4 Aug 2011 21:54:45 +0000 (21:54 +0000)]
Move UNORM_ related defines inside of UtfNormal. $globalScope--;
Ian Baker [Thu, 4 Aug 2011 21:19:08 +0000 (21:19 +0000)]
Fixed bug where global wgUploadStashMaxAge wasn't used, removed redundant defaults. Followup to r93476
Chad Horohoe [Thu, 4 Aug 2011 21:04:59 +0000 (21:04 +0000)]
Self-revert r91453: not a well thought out addition to the EditPage::showEditForm:initial hook
Chad Horohoe [Thu, 4 Aug 2011 21:00:40 +0000 (21:00 +0000)]
Followup r88270: comment out globals so I can resolve the fixme. Throw an exception here so nobody tries using it anyway
Aaron Schulz [Thu, 4 Aug 2011 20:57:20 +0000 (20:57 +0000)]
Reverted r91548 per CR
Chad Horohoe [Thu, 4 Aug 2011 20:55:20 +0000 (20:55 +0000)]
Remove no-op initialise from configuration. Nothing outside of Ext:Configure needs/uses it
Ian Baker [Thu, 4 Aug 2011 20:52:40 +0000 (20:52 +0000)]
Adding new jquery plugins to Resources.php so they'll be available through ResourceLoader, followup to r93908
Ian Baker [Thu, 4 Aug 2011 20:43:58 +0000 (20:43 +0000)]
Adding jquery plugins that UploadWizard and jQueryMsg need for Jasmine tests
Sam Reed [Thu, 4 Aug 2011 20:04:09 +0000 (20:04 +0000)]
* (bug 30230) action=expandtemplates should not silently override invalid title inputs
Aaron Schulz [Thu, 4 Aug 2011 17:43:06 +0000 (17:43 +0000)]
Added filearchive check to isInactiveAccount()
Alexandre Emsenhuber [Thu, 4 Aug 2011 15:48:36 +0000 (15:48 +0000)]
* Use local context instead of global variables
* Call Linker methods statically