Raimond Spekking [Wed, 23 Feb 2011 20:29:27 +0000 (20:29 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-23 20:13:00 UTC)
Alexandre Emsenhuber [Wed, 23 Feb 2011 20:23:35 +0000 (20:23 +0000)]
Factorise common code:
* Made appendQuery() use appendQueryArray() by using wfCgiToArray()
* Introduced getQueryValues() to get values passed in the query string; FauxRequest will return an empty array when faking a POST request
Antoine Musso [Wed, 23 Feb 2011 19:56:33 +0000 (19:56 +0000)]
Minor typos
(Trow -> Throw, Sens->sense), follow up CR on r82577
Chad Horohoe [Wed, 23 Feb 2011 17:54:45 +0000 (17:54 +0000)]
(bug 25855) Installer does not validate Memcached server settings
Alexandre Emsenhuber [Wed, 23 Feb 2011 17:54:02 +0000 (17:54 +0000)]
Use $wgRequest to get and set session items instead of $_SESSION (as for cookies)
Chad Horohoe [Wed, 23 Feb 2011 17:22:09 +0000 (17:22 +0000)]
Move doclink pages to the left sidebar, rather than the right.
The right should be steps :)
Chad Horohoe [Wed, 23 Feb 2011 16:48:11 +0000 (16:48 +0000)]
Partial revert r81779, $wgHooks is needed. Also add $wgAutoloadClasses
Chad Horohoe [Wed, 23 Feb 2011 16:42:42 +0000 (16:42 +0000)]
Followup r81534, use addQuotes() instead
Max Semenik [Wed, 23 Feb 2011 16:27:50 +0000 (16:27 +0000)]
Tweak message from r82676
Chad Horohoe [Wed, 23 Feb 2011 16:18:51 +0000 (16:18 +0000)]
Don't allow the user to create DB users with no passwords, it's not good practice.
We can't stop them from using users that already have empty passwords, but we can refuse to create it ;-)
Chad Horohoe [Wed, 23 Feb 2011 16:01:22 +0000 (16:01 +0000)]
Various Postgres fixes (bug 26612 stuff)
* Remove last of $wgDBuser-specific settings like timezone, datestyle and search_path. This is all handled by open() :D
* Only set search_path if the schema exists (rather than just set to some random string), fall back to 'public' otherwise
* Only call setupUser() if we need to _CreateDBAccount, otherwise it returns immediately and confuses you (no functional change)
* Implement selectDB() for Postgres, basically call open() with a new DB name
* Try to fix setupDatabase() for this "user must be owner of relation" error I'm getting when the $wgDBuser exists (have tried with roles granted && no roles granted). I get no errors at all when
Roan Kattouw [Wed, 23 Feb 2011 15:54:19 +0000 (15:54 +0000)]
Followup r82550: define variables passed by reference to preg_match() beforehand, to prevent E_NOTICEs
Chad Horohoe [Wed, 23 Feb 2011 14:26:45 +0000 (14:26 +0000)]
Fix backwards canCreateAccounts() check, remove setting search_path for $wgDBuser, since this is set per-session on open()
Chad Horohoe [Wed, 23 Feb 2011 13:53:47 +0000 (13:53 +0000)]
Rm unused member variable
Chad Horohoe [Wed, 23 Feb 2011 13:51:00 +0000 (13:51 +0000)]
Per bug 26612, set datestyle and timezone in open() rather than relying on $wgDBuser having specific settings.
Sam Reed [Wed, 23 Feb 2011 12:56:46 +0000 (12:56 +0000)]
Followup r82659
Comment out the USE INDEX, it creates a query error as the query is built wrongly.
Will report as a bug.
Will revert to previous behaviour of not forcing any index
Sam Reed [Wed, 23 Feb 2011 12:35:41 +0000 (12:35 +0000)]
Ununsed variables
Documentation and explicit definitions
Max Semenik [Wed, 23 Feb 2011 12:35:11 +0000 (12:35 +0000)]
(bug 20244) Installer does not validate SQLite database directory for stable path.
This is a must for 1.17 so adding a note to HISTORY instead of RELEASE-NOTES
Sam Reed [Wed, 23 Feb 2011 12:27:06 +0000 (12:27 +0000)]
Fixup SpecialListusers, $useIndex wasn't being used in the query, so make it be
Max Semenik [Wed, 23 Feb 2011 08:06:11 +0000 (08:06 +0000)]
Very basic JavaScriiptDistiller tests, needs serious expansion
Max Semenik [Wed, 23 Feb 2011 07:28:15 +0000 (07:28 +0000)]
Revert coloring from r79117: doesn't work on Windows
Tim Starling [Wed, 23 Feb 2011 06:58:15 +0000 (06:58 +0000)]
* Rewrote StripState to not use ReplacementArray. The memory usage of FSS was excessive when there were many (>10k) strip items. I used preg_replace_callback(), which is slower than strtr() in the simplest case, but much faster than it when the markers have different lengths, which they usually do.
* It was not necessary to preserve the $stripState->general->setPair() interface since it wasn't used by any extensions.
* Moved StripState to its own file.
* Refactored serialiseHalfParsedText() and unserialiseHalfParsedText() so that the bulk of the functionality is in the relevant modules, instead of using scary direct access to object member variables. Made it support the new StripState. It seemed like a lot of work to go to to support an "emergency optimisation" feature in Cite. Cite updates will be in a subsequent commit.
* Fixed spelling of serialiseHalfParsedText() and unserialiseHalfParsedText(), there is unavoidable interface breakage anyway, due to cache object versioning.
* Moved transparent tags to their own function, as requested in a fixme comment.
* Added documentation for markerSkipCallback().
* Removed OnlyIncludeReplacer, unused since MW 1.12.
Sam Reed [Tue, 22 Feb 2011 23:40:48 +0000 (23:40 +0000)]
Followup r82641, set default for 2nd param
Fix caller in SpecialLinkSearch.php
Sam Reed [Tue, 22 Feb 2011 23:26:53 +0000 (23:26 +0000)]
Remove now redundant comment after r82641
Sam Reed [Tue, 22 Feb 2011 23:22:09 +0000 (23:22 +0000)]
Followup r78786, per complaints on r82636, revert parameter ordering
Mark doQuery as deprecated/not the suggested run point
Add a couple of braces
Raimond Spekking [Tue, 22 Feb 2011 21:52:34 +0000 (21:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-22 21:13:00 UTC)
Max Semenik [Tue, 22 Feb 2011 17:15:48 +0000 (17:15 +0000)]
Follow-up r82504: use JS redirection only for IE, I don't like how it looks at least in Opera (sometimes images are not loaded)
Ryan Schmidt [Tue, 22 Feb 2011 16:39:17 +0000 (16:39 +0000)]
* random redirect-related fixes:
** automatically add redirect=no to all links on the redirect page in Article::viewRedirect.
** properly check if redirects are enabled if $wgMaxRedirects < 1 (moved check from Title::newFromRedirectArray to Title::newFromRedirectInternal).
Sam Reed [Tue, 22 Feb 2011 15:33:02 +0000 (15:33 +0000)]
* (bug 27633) Add characters to linkTrail for Potuguese (pt and pt-br)
Add RELEASE-NOTES for r82547
Platonides [Tue, 22 Feb 2011 15:09:41 +0000 (15:09 +0000)]
Remove trailing ?>
Platonides [Tue, 22 Feb 2011 15:05:08 +0000 (15:05 +0000)]
Rename startExternalParse() when used for internal usage, per r80818 CR.
Platonides [Tue, 22 Feb 2011 10:26:00 +0000 (10:26 +0000)]
Merge r67177 from 1.16wmf4
Platonides [Mon, 21 Feb 2011 23:19:26 +0000 (23:19 +0000)]
maintenance/commandLine.inc loads DefaultSettings, LocalSettings and then runs Setup.php
As Setup.php assigns variables based on the cache config, bootstrap.php was late on reseting them, as some objects were already created.
So we could end up with a SqlBagOStuff created there, which when later accessed (such as trying to invalidate the cache for a user) would
-as any non-sqlite SqlBagOStuff- open a new db connection. Which is precisely what we shall not be done when dealing with temporary tables
(and would indeed fail miserably due to not finding unittest_objectcache table).
In summary, reenabling temporary tables disabled in r79411.
Antoine Musso [Mon, 21 Feb 2011 22:56:16 +0000 (22:56 +0000)]
remove hardcoded local path
Platonides [Mon, 21 Feb 2011 22:36:35 +0000 (22:36 +0000)]
Follow up r80205 magic, so that you can also use require.
Antoine Musso [Mon, 21 Feb 2011 22:17:06 +0000 (22:17 +0000)]
improve namespace related methods
MWNamespace::getTalk() could give erroneus results when using it on specials
namespaces (NS_MEDIA, NS_SPECIAL). It now use MWNamespace::isMethodValidFor()
which will throw an exception if a special namespace was given.
MWNamespace::getSubject() is now returning identity for specials namespaces.
New MWNamespace::getAssociated() used to find out the subject page of a talk
page and vice versa. Special namespaces will results in an exception.
TESTS:
Added tests for almost complete code coverage. Functions relying on global
$wgCanonicalNamespaces are still incomplete though.
MWNamespace::isMovable() needs more assertions.
Tests results (ignoring incomplete tests output):
$ php phpunit.php --filter MWNamespace
PHPUnit 3.5.10 by Sebastian Bergmann.
.........IIIII..........
Time: 1 second, Memory: 31.75Mb
OK, but incomplete or skipped tests!
Tests: 24, Assertions: 99, Incomplete: 5.
Krinkle [Mon, 21 Feb 2011 21:24:09 +0000 (21:24 +0000)]
Add missing to mw.config
Raimond Spekking [Mon, 21 Feb 2011 20:36:18 +0000 (20:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-21 20:13:00 UTC)
Krinkle [Mon, 21 Feb 2011 20:36:07 +0000 (20:36 +0000)]
Follow-up r73270. Moving the attribute check down to the point where it's for sure not a string or undefined. (caused 'cant call getAttribute member function on non-object el [undefined]'. Also add a check to verify that el is a dom element and not just not indefined
Sam Reed [Mon, 21 Feb 2011 19:48:15 +0000 (19:48 +0000)]
* (bug 27616) Add userid of blocked user and blocker to list=blocks
Also tweak comment about "blocking admin". Non admins can block if they have the right... Sooo, "user" is more appropriate
Sam Reed [Mon, 21 Feb 2011 19:34:57 +0000 (19:34 +0000)]
* (bug 27611) list=blocks: Use ipb_by_text instead of join with user table
Save a table join when looking up blocks (yay!)
Minor issue, for blocks where users have been renamed, we get their old name (Not a big deal IMHO)
Sam Reed [Mon, 21 Feb 2011 19:12:13 +0000 (19:12 +0000)]
De-escaping $ at end of linkTrail regexes dating back from r15823 and beyond
Sam Reed [Mon, 21 Feb 2011 19:02:55 +0000 (19:02 +0000)]
Per Hashar on r82547, u modifier needed on regexes
Sam Reed [Mon, 21 Feb 2011 17:12:33 +0000 (17:12 +0000)]
Fixup and add another return type
Sam Reed [Mon, 21 Feb 2011 17:03:18 +0000 (17:03 +0000)]
Some more member variable type hints
Tim Starling [Mon, 21 Feb 2011 14:17:50 +0000 (14:17 +0000)]
Rewrote LanguageConverter::autoConvert() to make it use preg_match() with an offset instead of preg_split(). Reduces memory usage for my test case ([[台灣演員列表]]) to a negligible amount. This should eliminate the most common cause of OOMs on Wikimedia. Produces the exact same output for that test case for the zh -> zh-tw, parser tests pass, seems to work.
Sam Reed [Mon, 21 Feb 2011 13:33:10 +0000 (13:33 +0000)]
Add basic linktrail to SH and SL
Derk-Jan Hartman [Sun, 20 Feb 2011 21:31:15 +0000 (21:31 +0000)]
Gallery's perrow was overwriting the original style= attribute.
Raimond Spekking [Sun, 20 Feb 2011 20:52:59 +0000 (20:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-20 20:02:00 UTC)
Roan Kattouw [Sun, 20 Feb 2011 19:27:03 +0000 (19:27 +0000)]
(bug 27355) Guard against context being null, this happens when wikiEditor disables itself in unsupported browsers and was causing a JS error
Jack Phoenix [Sun, 20 Feb 2011 19:04:58 +0000 (19:04 +0000)]
spaces, added some braces to DairikiDiff.php
Platonides [Sun, 20 Feb 2011 17:52:09 +0000 (17:52 +0000)]
Spaces to tabs
Antoine Musso [Sun, 20 Feb 2011 17:44:37 +0000 (17:44 +0000)]
Force wgDebugTimestamps false
Test GlobalTest::testDebugFunctionTest() does not take into account the setting
$wgDebugTimestamps = true. Setting it false makes sure the tests pass though
not testing the settings :(
Roan Kattouw [Sun, 20 Feb 2011 17:24:42 +0000 (17:24 +0000)]
(bug 27468) Move private styles out to their own section, so they override everything except user styles. Moved from one makeResourceLoaderLink() call with array_merge() to multiple calls, because makeResourceLoaderLink() orders the modules, then groups them, so the input order is not preserved. Also fixed an issue in makeResourceLoaderLink() where the $uery variable was reused in each iteration but not cleared, allowing pollution to occur in theory (doesn't seem to have happened in practice, though).
Max Semenik [Sun, 20 Feb 2011 16:53:49 +0000 (16:53 +0000)]
Revert errorneous line removal in r82439
Alexandre Emsenhuber [Sun, 20 Feb 2011 16:36:13 +0000 (16:36 +0000)]
wfMsgReal() -> wfMsgExt()
Alexandre Emsenhuber [Sun, 20 Feb 2011 16:28:13 +0000 (16:28 +0000)]
Per Tim Starling, follow-up r76252: move WikiDiff.php to DairikiDiff.php to not confuse with the wikidiff extension
Alexandre Emsenhuber [Sun, 20 Feb 2011 15:03:25 +0000 (15:03 +0000)]
Per Platonides; follow-up r78201: add "stubthreshold" to ParserOptions; also provides a proper fix to r81765
Sam Reed [Sun, 20 Feb 2011 13:59:40 +0000 (13:59 +0000)]
Followup r82509, prefix the code for urlwidth too
Sam Reed [Sun, 20 Feb 2011 13:51:24 +0000 (13:51 +0000)]
Remove error duplication in ApiQueryStashImageInfo by using non hardcoded prefix in ApiQueryImageInfo
Sam Reed [Sun, 20 Feb 2011 13:50:15 +0000 (13:50 +0000)]
Per comment on r82477, update output for prop=statimageinfo
Sam Reed [Sun, 20 Feb 2011 13:33:42 +0000 (13:33 +0000)]
More explicit variable definitions, function documentation
Max Semenik [Sun, 20 Feb 2011 08:29:25 +0000 (08:29 +0000)]
Bug 26683: Unable to download index.php from localhost message displayed at complete page in IE7 & IE8
Platonides [Sun, 20 Feb 2011 00:44:33 +0000 (00:44 +0000)]
Fix ArticleTablesTest after r81528. It needs to set both $wgLanguageCode and $wgContLang.
Added setUp() and teardown()
Platonides [Sun, 20 Feb 2011 00:27:01 +0000 (00:27 +0000)]
Break the self-reference between parser and preprocessor, so they can be counting collected.
Saved a couple of Mb in the destructive make (126.25Mb -> 124.25Mb).
Platonides [Sun, 20 Feb 2011 00:13:26 +0000 (00:13 +0000)]
Save and restore $wgHooks in NewParserTest.
ParserGetVariableValueTs hook still being set to ParserTest::getFakeTimestamp was the reason for the crazy failures of MagicVariableTest inside phpunit that I was seeing.
Krinkle [Sun, 20 Feb 2011 00:12:24 +0000 (00:12 +0000)]
bug 27146
Krinkle [Sat, 19 Feb 2011 23:52:11 +0000 (23:52 +0000)]
mw.loader.implement now calls script without setting mw to mediaWiki since this is already globally avaiable
* Also shortens a few wrapper functions the same way
* Partial revert of r82496. Apparantly mw-alias is not available in startUp module. TODO: Find out why ?
(See also r82496 commit message)
Krinkle [Sat, 19 Feb 2011 22:59:44 +0000 (22:59 +0000)]
Using the mw alias for mediaWiki in core. Saves bandwidth and makes sense (there's no point in a wrapper function for ($,mw) if we use jQuery and mediaWiki inside of it).
TODO: Since the alias is globally available from the start, the 'mw' argument in the wrapper is redundant, so that should be removed at some point as well.
Krinkle [Sat, 19 Feb 2011 22:44:49 +0000 (22:44 +0000)]
(bug 3112) Adding colors for active and visited external links.
This is in-core for internal links and red links, but there's no visual clue of active and visited links for external links.
Normal external: #36b;
/* Added: */
Active external: #b63;
Visited external: #636;
These two colors (orange and purple -ish) are in the same saturation/brightness as the blue for normal (inactive/unvisited) external links.
Since these visual clues were also lacking in external links to interwikis I've replaced that override with similar colors as well.
Sam Reed [Sat, 19 Feb 2011 22:18:39 +0000 (22:18 +0000)]
And some more function level documentation
Sam Reed [Sat, 19 Feb 2011 22:08:26 +0000 (22:08 +0000)]
More function documentation
Rotem Liss [Sat, 19 Feb 2011 22:01:05 +0000 (22:01 +0000)]
Localization update for he.
Sam Reed [Sat, 19 Feb 2011 21:56:54 +0000 (21:56 +0000)]
More function documentation
Sam Reed [Sat, 19 Feb 2011 21:44:20 +0000 (21:44 +0000)]
Explicitally define variables
Sam Reed [Sat, 19 Feb 2011 21:34:44 +0000 (21:34 +0000)]
Explicitally define some variables
Bracify file
Sam Reed [Sat, 19 Feb 2011 21:16:47 +0000 (21:16 +0000)]
Improve method documentation
Few bits of fixup
Derk-Jan Hartman [Sat, 19 Feb 2011 21:03:52 +0000 (21:03 +0000)]
Don't use getCheck, because the opts array is reused to generate the query for the RSS/Atom feed.
getCheck checks for presence, not for true/false, so that was why rss feeds behaved as if
deletedOnly was set.
Follow up to r65651
Fixes bug #27546
Raimond Spekking [Sat, 19 Feb 2011 20:56:36 +0000 (20:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-19 20:30:00 UTC)
Derk-Jan Hartman [Sat, 19 Feb 2011 20:35:51 +0000 (20:35 +0000)]
All functions of the importer have $title, origTitle, but processTitle() returned $title, origTitle.
This caused confusion and a misusage of the processTitle() result.
Follow up to r66267.
Fixes bug 27486
Platonides [Sat, 19 Feb 2011 20:16:54 +0000 (20:16 +0000)]
(Bug 27539) Allow attributes beginning with a digit in wiktext tag parameters.
Its removal in r70849 breaks ProofreadPage extension.
Restricted r82475 relaxation to just numbers.
Added tests.
This only affects wikitext (tag hooks).
MW_ATTRIBS_REGEX is only used through decodeTagAttributes() calls.
fixTagAttributes() calls decodeTagAttributes(), and would be nastier to
fix, since it is called with HTML parameters (eg. by removeHTMLtags)
but such incorrect parameters grabbed would be removed by validateTagAttributes()
Alexandre Emsenhuber [Sat, 19 Feb 2011 20:06:50 +0000 (20:06 +0000)]
* (bug 27560) Search queries no longer fail in walloon language
Sam Reed [Sat, 19 Feb 2011 19:52:08 +0000 (19:52 +0000)]
* (bug 27554) Update api information text to reflect change in bug 26125
Sean Colombo [Sat, 19 Feb 2011 19:25:26 +0000 (19:25 +0000)]
Relaxed the allowed format of parser tag attributes as per bug 27539. One side-effect is that this will fix the widely-used pagelist tag which has "1to10" as an attribute name.
Roan Kattouw [Sat, 19 Feb 2011 19:21:52 +0000 (19:21 +0000)]
Revert r74387: it may not fix the IE8 jumping bug in all cases, but it definitely fixes it in most cases. Reverting a partial fix for not being perfect, then never coming up with a full fix is not acceptable.
Mark A. Hershberger [Sat, 19 Feb 2011 19:18:02 +0000 (19:18 +0000)]
(Bug #27467) preload can leave UNIQ
Patch to fix from P.Copp
Alexandre Emsenhuber [Sat, 19 Feb 2011 19:15:45 +0000 (19:15 +0000)]
Follow-up r82452: need to transform entries sinces some wiki like to use variables or parser functions in the sidebar
Krinkle [Sat, 19 Feb 2011 17:46:30 +0000 (17:46 +0000)]
Improving jquery.makeCollapsible & small fixed mw.util
* Making makeCollapsible more DRY.
* Small optimalizations and fixes in mw.util
Roan Kattouw [Sat, 19 Feb 2011 17:07:05 +0000 (17:07 +0000)]
(bug 27302) Avoid unnecessary requests for user and site modules if the relevant wiki pages don't exist.
Done by adding isKnownEmpty() to ResourceLoaderModule and overriding it to check for page existence in ResourceLoaderWikiModule. Needed to rearrange some code in OutputPage::makeResourceLoaderLink() to have the emptiness check and dropping of modules work properly. Also factored the page_touched check in ResourceLoaderWikiModule::getModifiedTime() out to a separate method (getTitleMtimes()) and moved in-object caching there as well, so getModifiedTime() and isKnownEmpty() share code and caching for their timestamp/existence checks.
This does not account for the case where e.g. a user has user CSS but no user JS: I had implemented this by checking for $context->getOnly() in getTitleMtimes(), but then realized it's not safe to do this in a function called by getModifiedTime(): it causes the timestamp list in the startup module to only take scripts in account for wiki modules, because the startup module has &only=scripts set
Platonides [Sat, 19 Feb 2011 17:00:34 +0000 (17:00 +0000)]
Remove unused global.
Platonides [Sat, 19 Feb 2011 16:59:34 +0000 (16:59 +0000)]
Follow up r82091, which uses the local file constant SERVICES_JSON_LOOSE_TYPE.
Roan Kattouw [Sat, 19 Feb 2011 16:48:05 +0000 (16:48 +0000)]
Fix logic error in r73204 (!) causing ResourceLoaderContext::getHash() to always return null
Max Semenik [Sat, 19 Feb 2011 16:25:02 +0000 (16:25 +0000)]
Partial revert my accidental revert of r82366 in r82445.
Derk-Jan Hartman [Sat, 19 Feb 2011 15:42:02 +0000 (15:42 +0000)]
Close the xmlreader when we are done with it.
Roan Kattouw [Sat, 19 Feb 2011 14:58:16 +0000 (14:58 +0000)]
(bug 27328) Redo r82218 properly, expanding URLs with absolute paths
Roan Kattouw [Sat, 19 Feb 2011 14:46:49 +0000 (14:46 +0000)]
Revert r82218 , doesn't fix absolute path URLs but breaks them. Will fix properly in next commit
Alexandre Emsenhuber [Sat, 19 Feb 2011 14:40:56 +0000 (14:40 +0000)]
* Use OutputPage::getSyndicationLinks() to build feed links
* Ported r82395 to legacy skins (possible double "printable" parameter in URL and hidden dependency of $wgTitle)
Alexandre Emsenhuber [Sat, 19 Feb 2011 13:39:09 +0000 (13:39 +0000)]
* Use $this->mTitle instead of $wgTitle
* Put back the wfMsgForContentNoTrans() added in r66835 but reverted in r68707 since wfMsgForContent() is breaking the {{...}} syntax
Alexandre Emsenhuber [Sat, 19 Feb 2011 13:09:17 +0000 (13:09 +0000)]
Merged retrieval of request URL and header from WebRequest and Setup.php to avoid duplicate code and reduced the number of wfDebug() calls in Setup.php.
The only side effect is that headers name are in uppercase in the debug log.
Alexandre Emsenhuber [Sat, 19 Feb 2011 12:31:50 +0000 (12:31 +0000)]
We have a OutputPage object; so use it to get the Title object instead of $wgTitle