jenkins-bot [Thu, 19 Sep 2013 23:08:21 +0000 (23:08 +0000)]
Merge "Collect stats about RL cache hit rate"
Max Semenik [Thu, 19 Sep 2013 23:02:59 +0000 (16:02 -0700)]
Collect stats about RL cache hit rate
Change-Id: I7cf2f2248f60b0e686e90faf9cb9989b723c88d1
aude [Thu, 19 Sep 2013 19:06:10 +0000 (19:06 +0000)]
Pass context to Action::factory
Fixes a PHP Notice that was introduced on every page (follows-up
01d81d88)
Bug: 54344
Change-Id: I24f01c7244089e73b0cf2e0af37c365f9dd051b2
Aaron Schulz [Thu, 19 Sep 2013 19:51:16 +0000 (12:51 -0700)]
Reduce use of FORCE INDEX in LogPager
* This currently hurts some change tag queries by orders of mangitude.
MySQL/Maria query planning is also a fair bit smarter than it used to
be. Lastly, WMF table statistics are better maintained now.
Change-Id: I4d0ac7a35c9cec6b47771aae718b44bfc03bdfbe
Translation updater bot [Thu, 19 Sep 2013 19:25:04 +0000 (19:25 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ifc090ee9782be50af70146738908549ca31b6f96
jenkins-bot [Thu, 19 Sep 2013 17:39:02 +0000 (17:39 +0000)]
Merge "Reduce complexity of SiteSQLStore saveSites method"
Ori Livneh [Thu, 19 Sep 2013 17:11:38 +0000 (10:11 -0700)]
Allow RedisConnectionPool to be used with HHVM's Redis library
As of commit
2811e9d, HHVM includes a pure-PHP Redis client library with
method-for-method compatibility with phpredis: <http://git.io/ylDAyQ>.
RedisConnectionPool appears to work well with it save for the
extension_loaded() check. Practically a freebie!
Bug: 54158
Change-Id: I3ac12293a51a45e8f6a61a35bff7a3c063e16964
Timo Tijhof [Thu, 19 Sep 2013 16:39:34 +0000 (18:39 +0200)]
doc: Fix grammar in GitInfo documentation comment
Change-Id: I67da49398f1281b83700884475d364f6b30c05c8
jenkins-bot [Thu, 19 Sep 2013 16:12:39 +0000 (16:12 +0000)]
Merge "Adapt StringUtils::isUtf8 to the top of Unicode at U+10FFFF"
daniel [Thu, 19 Sep 2013 10:56:42 +0000 (12:56 +0200)]
Fix initialization of Context in Action class.
When Action::getActionName calls Action::factory, $context
must be passed explicitly, since WikiPage does not have a getContext()
method (only Article does).
As a failsafe in Article::getContext(), use $this->page->getContext()
only if $this->page is an Article. If $this->context is null and $this->page
is not an article, fall back to RequestContext::getMain()
Change-Id: I6d8db29dfd1aaa68f3de4f8f418841205c2379af
Timo Tijhof [Thu, 19 Sep 2013 08:12:56 +0000 (10:12 +0200)]
jquery.suggestions: Fix up trailing comments from
2f5125e8
Change-Id: I8f2f8a9f1e0da3e460928003b56a2c99668473da
MatmaRex [Tue, 27 Aug 2013 13:26:06 +0000 (15:26 +0200)]
Factor out ChangeTags::tagUsageStatistics() from SpecialTags
It's prettier if we keep all explicit DB queries to those tables
in one place.
Change-Id: I85b6854e26ffc656b990079d463a085ba39556df
Ori Livneh [Wed, 18 Sep 2013 09:09:11 +0000 (02:09 -0700)]
CSSMin: factor out image encoding into encodeImageAsDataURI method
The code for encoding suitable images as base64 data URIs was previously part
of the remap method of CSSMin, which greps CSS files for /* @embed */
annotations. This patch moves it into its own method, encodeImageAsDataURI.
Change-Id: I6f57116c6a6c18ff9d4e28760dd484ea2c8fc493
Kevin Israel [Mon, 16 Sep 2013 03:29:04 +0000 (23:29 -0400)]
Adapt StringUtils::isUtf8 to the top of Unicode at U+10FFFF
RFC 3629 defines the legal range of characters as U+0000..U+10FFFF
and forbids overlong forms (encodings of a character that use more
bytes than necessary). Let's make StringUtils::isUtf8() match the
specification.
* Changed the maximum value in the pure PHP code path and added a
check for overlong forms.
* Added another check, specific to PHP 5.3's mbstring extension,
for values above U+10FFFF.
* Fixed the mbstring test errors in PHP 5.4 using changes to
StringUtilsTest by Platonides <platonides@gmail.com>.
* Uncommented some other tests that could fail because of the
missing check for overlong forms.
* Added additional tests for extra continuation bytes, overlong
sequences/forms, and values in the UTF-16 surrogate range.
The changes to the function were so extensive that I might as
well say I rewrote it.
Bug: 43679
Change-Id: I56ae496d17ffc3747550e06a72dacab3ac55da61
jenkins-bot [Wed, 18 Sep 2013 21:20:19 +0000 (21:20 +0000)]
Merge "Separate RevDel logic from UI"
aude [Wed, 18 Sep 2013 20:28:14 +0000 (22:28 +0200)]
Reduce complexity of SiteSQLStore saveSites method
split code that generates an ORMRow from a Site object
Change-Id: Ie1f7ed834a33befb43536355ad2b9b98a13d4c79
jenkins-bot [Wed, 18 Sep 2013 20:02:06 +0000 (20:02 +0000)]
Merge "Add gzdecode fallback to GlobalFunctions"
Translation updater bot [Wed, 18 Sep 2013 19:23:17 +0000 (19:23 +0000)]
Merge "Localisation updates from translatewiki.net."
jenkins-bot [Wed, 18 Sep 2013 19:11:04 +0000 (19:11 +0000)]
Merge "Changed tableName so it returns uppercased table names (+prefix) Changed tableExists so it returns boolean (and closes resource when it's done in case it fails)"
jenkins-bot [Wed, 18 Sep 2013 19:10:52 +0000 (19:10 +0000)]
Merge "Changed quoting function for oracleDB."
Translation updater bot [Wed, 18 Sep 2013 18:59:56 +0000 (18:59 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ia363d8fc374b04d948cb0b6599269f9c0e1c4117
Aaron Schulz [Tue, 17 Sep 2013 22:23:44 +0000 (15:23 -0700)]
Fixed check of BagOStuff set() return value in mctest
Change-Id: I6e69cdc24b9b40132641205cb40f64bb5db45f70
Brad Jorsch [Wed, 26 Jun 2013 20:48:53 +0000 (16:48 -0400)]
Separate RevDel logic from UI
Move functions implementing the actual revision deletion out of
SpecialRevisiondelete, so they can be used from elsewhere (e.g.
ApiRevisiondelete).
Change-Id: Id0f6b1c8dab474bdfd802c07b211885d398c94e5
jenkins-bot [Wed, 18 Sep 2013 17:01:20 +0000 (17:01 +0000)]
Merge "Use wfResetOutputBuffers in ResourceLoader"
jenkins-bot [Wed, 18 Sep 2013 16:54:21 +0000 (16:54 +0000)]
Merge "Fully log exceptions within ResourceLoader (including traces)"
jenkins-bot [Wed, 18 Sep 2013 16:52:35 +0000 (16:52 +0000)]
Merge "RefreshLinksJob: Replace use of empty() with explicit check"
jenkins-bot [Wed, 18 Sep 2013 16:45:46 +0000 (16:45 +0000)]
Merge "mediawiki.api: Simplify done/fail calls by chaining"
Timo Tijhof [Wed, 18 Sep 2013 16:37:06 +0000 (18:37 +0200)]
mediawiki.api: Simplify done/fail calls by chaining
Change-Id: Ic0c1928708612d31abcd6c5c7184f68b2e7c1a76
Aaron Schulz [Fri, 6 Sep 2013 18:52:34 +0000 (11:52 -0700)]
Fully log exceptions within ResourceLoader (including traces)
Change-Id: Icb479c76cd855244429fe65b29667783dcca8f53
Timo Tijhof [Fri, 2 Aug 2013 02:03:11 +0000 (04:03 +0200)]
legacy upload.js: Clean up and remove from jshintignore
* Coding style:
- Braces
- Single quotes
- Dot instead of bracket access for properties
* Fixed various implied global/static variables, most significantly
the for-loop variable 'cached' etc.
* Changed == '' to ! since === '' will require it to be a string
and == '' returns true for almost anything that is falsy, no
good way to choose a strict alternative.
* Changed setAttribute('disabled', ..) to using .property instead.
* Using setTimeout as a global instead of as a window property.
* Using other globals from wikibits.js through window property,
as they are defined.
* Use a closure instead of string eval() in setTimeout().
* Made local equivalents for some global variables for access
inside the closure.
* Don't create functions in a loop. Moved the onchange function
outside the loop and re-used it for each one (safe in this case,
and more efficient).
* Call setTimeout/clearTimeout as global, no need for the window
object as host.
Change-Id: I9df912ee48d30c189394bf07f5e49014220f36a3
Marius Hoch [Fri, 19 Jul 2013 01:21:38 +0000 (03:21 +0200)]
Use wfResetOutputBuffers in ResourceLoader
No need to replicate its logic there.
Bug: 46836
Change-Id: I0c6ad90c327e39b9bc35fc3a9ecab39487a1d8b5
jenkins-bot [Wed, 18 Sep 2013 12:01:57 +0000 (12:01 +0000)]
Merge "jquery.makeCollapsible: Use promise().done instead of when().then"
jenkins-bot [Wed, 18 Sep 2013 11:52:37 +0000 (11:52 +0000)]
Merge "doc: Clean up documentation for StringUtils classes"
Timo Tijhof [Tue, 17 Sep 2013 07:48:05 +0000 (09:48 +0200)]
doc: Clean up documentation for StringUtils classes
Change-Id: Ie016c1d1686c9dce7944864e77e6c3bdf001d8c3
Timo Tijhof [Wed, 18 Sep 2013 04:47:11 +0000 (06:47 +0200)]
jquery.makeCollapsible: Use promise().done instead of when().then
Follows up
b340bd4f6b.
They both work, but in this case there is no need to use $.when
since there is only 1 promise. And there is no need for the
filtering proxy of Promise#then either, a straight done is enough.
$.when( $foo ).then( callback )
$.when( $foo ).done( callback )
$foo.promise().done( callback )
Change-Id: I4df755a32c124481ca690078191a735d2e2b511a
Timo Tijhof [Wed, 18 Sep 2013 04:38:36 +0000 (06:38 +0200)]
Sanitizer: Remove redundant @private tags
Follows-up
64dcaf4e8a.
Change-Id: Ib6f406e4881e7c7ba39cdb132ffb95f4c1a19209
Timo Tijhof [Wed, 18 Sep 2013 04:34:32 +0000 (06:34 +0200)]
RefreshLinksJob: Replace use of empty() with explicit check
Using empty() is a maintenance nightmare as it completely removes
any meaning of what the author intends to check for (whether the
variable exists at all, it being set to an empty array, 0, '0' etc.)
Follows-up I445e10da122e5f24e589 which changed it from isset()
to !empty() with commit message of checking for false.
Change-Id: I561f03b0526685f51138d723f9eb7196725e0b93
jenkins-bot [Wed, 18 Sep 2013 04:14:44 +0000 (04:14 +0000)]
Merge "Make CSSMin::getMimeType public rather than protected"
Ori Livneh [Wed, 18 Sep 2013 03:58:39 +0000 (20:58 -0700)]
Make CSSMin::getMimeType public rather than protected
There's no reason why it should be protected. People sometimes use
'protected' to mean 'ancillary to the main purpose of the class', but
'protected' comes with the added cost of making the class API less
flexible. I intend to call this method in a future revision of Id052a04dd2,
but I think it should be public regardless.
Change-Id: I56365df3152df1180ce73de98202e3a91def1485
jenkins-bot [Wed, 18 Sep 2013 00:07:57 +0000 (00:07 +0000)]
Merge "Store boolean values as integers with SQLite"
Jackmcbarn [Tue, 17 Sep 2013 22:54:59 +0000 (18:54 -0400)]
Store boolean values as integers with SQLite
Since SQLite doesn't have a boolean type, and doesn't enforce types, make
sure booleans get stored as integers, to prevent undesirable behavior,
such as false values being stored as empty strings.
Change-Id: I2a96065826412fa25f98ec298d806e73ebe155ba
Timo Tijhof [Tue, 17 Sep 2013 10:26:12 +0000 (12:26 +0200)]
Add gzdecode fallback to GlobalFunctions
* Follows-up I6383e933b.
* Replaced existing usage of `gzinflate( substr( $data, 10, -8 ) );`
with `gzdecode( $data )`.
Change-Id: Ie2916584f92ff72c7d7ddca73acf1c94dda38cca
jenkins-bot [Tue, 17 Sep 2013 20:48:59 +0000 (20:48 +0000)]
Merge "Clean up legacy protect.js & remove from .jshintignore"
Ori Livneh [Thu, 29 Aug 2013 17:11:56 +0000 (10:11 -0700)]
Clean up legacy protect.js & remove from .jshintignore
- Declare all variables w/single var statement.
- Un-quote property names.
- Braces / whitespace / quoting / strict equality checks.
Change-Id: Iaabd3bbaeb10a661adf53dc9ad39813b14661f77
Translation updater bot [Tue, 17 Sep 2013 19:37:18 +0000 (19:37 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I87722e0db8d910030b237290b78e7f8e4e7c59dc
jenkins-bot [Tue, 17 Sep 2013 17:48:06 +0000 (17:48 +0000)]
Merge "Protect against non-arrays when fetching headers"
Chad Horohoe [Tue, 17 Sep 2013 01:10:47 +0000 (18:10 -0700)]
Protect against non-arrays when fetching headers
PHP documentation says this can theoretically return false on failure.
HHVM actually returns null when running from the command line, so
this does protect against that.
Change-Id: I0d75b8ed209128a9667ce1e7189597ae9ebc8af6
jenkins-bot [Tue, 17 Sep 2013 17:22:44 +0000 (17:22 +0000)]
Merge "Guard against non-object returns from File::getHander()"
jenkins-bot [Tue, 17 Sep 2013 17:20:22 +0000 (17:20 +0000)]
Merge "Show the revision ID on error message when content is missing on difference page"
jenkins-bot [Tue, 17 Sep 2013 17:16:23 +0000 (17:16 +0000)]
Merge "Removed unneeded else branches in DifferenceEngine"
jenkins-bot [Tue, 17 Sep 2013 17:14:26 +0000 (17:14 +0000)]
Merge "mediawiki.user: Clean up documentation and minor optimisation"
Timo Tijhof [Mon, 15 Jul 2013 09:56:37 +0000 (11:56 +0200)]
mediawiki.user: Clean up documentation and minor optimisation
* Optimise mw.user#id implementation.
* Make documentation more consistent (describe the intent instead
of the exhibited behaviour, e.g. "Get foo" instead of "Gets foo",
like most other JS documentation does already).
Change-Id: If9e5dcb7cfed27785c4a15bc3492868f083517f3
jenkins-bot [Tue, 17 Sep 2013 15:52:27 +0000 (15:52 +0000)]
Merge "Add TitleMove hook"
Jan Gerber [Thu, 12 Sep 2013 10:13:21 +0000 (10:13 +0000)]
Add TitleMove hook
some things need access to the old file before its moved,
adding hook to allow extensions to do something before
file is moved.
Change-Id: Ic5e659abc79c41e3331d42074e7f21eec9b9ba7c
Alexandre Emsenhuber [Thu, 25 Jul 2013 15:34:20 +0000 (17:34 +0200)]
Show the revision ID on error message when content is missing on difference page
Currently if the revision exists but its content is not found, it will make
loadText() return false; which in turn will make a call to showMissingRevision()
from showDiff(). However since the revision exists; it will not match the
condition in showMissingRevision() and thus an error message will appear without
any revision ID.
Change-Id: Idd8a5f20a3c082a3b02bd77557e0f4dc4c66e876
Alexandre Emsenhuber [Sun, 25 Aug 2013 07:26:20 +0000 (09:26 +0200)]
Removed unneeded else branches in DifferenceEngine
The "if" always exit, so there is no need to use else branches;
also added blank lines for better readability.
Change-Id: I7d8321652a90fbba99e53fa0c1fe018492883b8a
Bryan Davis [Thu, 5 Sep 2013 20:46:38 +0000 (14:46 -0600)]
Guard against non-object returns from File::getHander()
MediaHandler::getHandler() can return false when a handler cannot be
determined for the given file's derived mime type. This change adds
guards to invocations that I could find that did not properly check for
this potential return result.
Bug: 53820
Change-Id: I8c0165311cc75f9920ac30ce2b38ccd207439198
Alexandre Emsenhuber [Tue, 17 Sep 2013 06:45:24 +0000 (08:45 +0200)]
Rebuild MessagesEn.php
Change-Id: Ic91207589544ec2a7c0ca844ac51fac11a0e542f
jenkins-bot [Mon, 16 Sep 2013 22:03:13 +0000 (22:03 +0000)]
Merge "Sync up with Parsoid parserTests."
jenkins-bot [Mon, 16 Sep 2013 20:15:53 +0000 (20:15 +0000)]
Merge "Minor bugfix to IP::prettifyIP."
C. Scott Ananian [Mon, 16 Sep 2013 20:14:20 +0000 (16:14 -0400)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
8da66db733e02a5a886a62075ab9d9e9c6db6e3a
Change-Id: I0b429b4affbacb4ed97718bce8ba9c886d268216
Translation updater bot [Mon, 16 Sep 2013 19:37:44 +0000 (19:37 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Mon, 16 Sep 2013 19:27:42 +0000 (19:27 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I01c4d11140387c16202ffa9c15cc358cf035a455
jenkins-bot [Mon, 16 Sep 2013 19:22:29 +0000 (19:22 +0000)]
Merge "Don't ask users to mark own page creations as patrolled"
MatmaRex [Sat, 24 Aug 2013 13:21:33 +0000 (15:21 +0200)]
Remove 'mediawiki.legacy.wikiprintable' module
It's a relic of simpler times, no longer used by any core skin. The
'mediawiki.legacy.commonPrint' module can be used instead.
(SkinTemplate-based skins do it automatically.)
* The 'mediawiki.legacy.wikiprintable' module has been removed.
* The skins/common/wikiprintable.css file has been deleted.
* Skin#commonPrintStylesheet has been deprecated; its return value is
ignored.
Dependency: I96e66ff8905416bea906d40cdd72ba646399191b
Change-Id: Icbcebc8f539f7786d037b717d262684e9931aca6
Translation updater bot [Sun, 15 Sep 2013 19:49:06 +0000 (19:49 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I1f5fe0b2664bc67e8f3fb2e56558834f2f1a427c
jenkins-bot [Sun, 15 Sep 2013 19:42:44 +0000 (19:42 +0000)]
Merge "Drop unnecessary CSS selectors for a.external[href^="gopher://"]"
jenkins-bot [Sun, 15 Sep 2013 19:41:00 +0000 (19:41 +0000)]
Merge "mediawiki.util: Detect Iceweasel for accesskeys"
jenkins-bot [Sun, 15 Sep 2013 19:38:54 +0000 (19:38 +0000)]
Merge "Add optional message to define default description for Upload"
Kevin Israel [Thu, 8 Aug 2013 03:18:34 +0000 (23:18 -0400)]
Remove remaining calls to MWInit methods
... as well as the require_once statements in includes/WebStart.php
and maintenance/doMaintenance.php, now that the autoloader lists
MWInit (since r85807 /
c68957c5e3ada65806294bc9bc5938aa18c6e50c).
Also removed code paths in maintenance/userDupes.inc that seem to be
dead (class_exists( 'Revision' ) should always be true) and useless
global/require_once statements in languages/Language.php.
Follows-up Ic3e769f1fbad4f7ad26dd819406796fee48c6b45.
Change-Id: I48fd6810fdb923b3065ae98024912eb18d394415
jenkins-bot [Sun, 15 Sep 2013 18:38:44 +0000 (18:38 +0000)]
Merge "Web installer: correctly show note for I4ecd0659"
Kevin Israel [Mon, 2 Sep 2013 22:12:45 +0000 (18:12 -0400)]
Web installer: correctly show note for I4ecd0659
InstallDocFormatter didn't escape the double underscores in
__TOC__. I also noticed that wfEscapeWikiText had a similar
bug, which I reported as bug 53658 (fixed separately).
Change-Id: Ib5346b9c234f1c5ef361cc4357352b09def5dc25
Bartosz Dziewoński [Sun, 15 Sep 2013 17:40:37 +0000 (19:40 +0200)]
Drop unnecessary CSS selectors for a.external[href^="gopher://"]
* They don't do anything anyway - gopher:// links are not styled by
anything else, so they'd just get the same styles as regular
external links.
* They cause problems in browsers not supporting the attribute
selector (like IE6), as the browser drops the entire rule, as
required by the CSS specification.
Also removed some code in monobook/IE60Fixes.css which seems to be
simply a workaround for the issue described above.
Bug: 31495
Change-Id: Ib33d47d5372dd73097bdcef8d00ebd073f6bbd68
Bartosz Dziewoński [Sun, 15 Sep 2013 16:41:17 +0000 (18:41 +0200)]
mediawiki.util: Detect Iceweasel for accesskeys
Bug: 54015
Change-Id: I105f22756c5df32aef2e4581f5f0d8e3db059dfc
jenkins-bot [Sat, 14 Sep 2013 15:02:02 +0000 (15:02 +0000)]
Merge "Always pass user to LogPage::addEntry"
Translation updater bot [Fri, 13 Sep 2013 21:08:14 +0000 (21:08 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Id3cc828ebb6b0c06ea052977fcabeec78cacd606
umherirrender [Fri, 13 Sep 2013 19:14:36 +0000 (21:14 +0200)]
Always pass user to LogPage::addEntry
This avoids getting $wgUser in LogPage::addEntry
Change-Id: Ie105cef4ebc3d69aeaef5ee40ce6ee0087a74c69
jenkins-bot [Fri, 13 Sep 2013 13:54:06 +0000 (13:54 +0000)]
Merge "Consistently follow conventions for documenting parameters"
Ori Livneh [Fri, 13 Sep 2013 04:50:45 +0000 (21:50 -0700)]
Consistently follow conventions for documenting parameters
Per MW:CC/PHP, the type goes before the variable name, and built-in types are
not uppercase.
Change-Id: Ibb753acd9529ace3579d57654adc47673fa49719
jenkins-bot [Thu, 12 Sep 2013 23:48:36 +0000 (23:48 +0000)]
Merge "wfMkdirParents: recover from mkdir race condition"
Elliott Eggleston [Thu, 12 Sep 2013 22:55:45 +0000 (18:55 -0400)]
wfMkdirParents: recover from mkdir race condition
If mkdir fails, check again to see if dir has been created
since our initial check, and return true if so.
Also, in initial check, only return true if $dir is really
a directory, not a file.
Bug: 49391
Change-Id: I2b331669fae70948ce79ba1477c05968a3095c3d
jenkins-bot [Thu, 12 Sep 2013 23:24:31 +0000 (23:24 +0000)]
Merge "Make line breaks in <blockquote> behave like <div> (bug 6200)."
Translation updater bot [Thu, 12 Sep 2013 19:40:06 +0000 (19:40 +0000)]
Merge "Localisation updates from translatewiki.net."
jenkins-bot [Thu, 12 Sep 2013 19:22:15 +0000 (19:22 +0000)]
Merge "Remove "Misc" tab from Special:Preferences"
Translation updater bot [Thu, 12 Sep 2013 19:22:12 +0000 (19:22 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I96c07ba05dd7466f54cd6f3cef315705fc716588
jenkins-bot [Thu, 12 Sep 2013 19:17:43 +0000 (19:17 +0000)]
Merge "SpecialPrefixindex: Try not to generate unclickable links"
jenkins-bot [Thu, 12 Sep 2013 19:13:24 +0000 (19:13 +0000)]
Merge "jquery.tablesorter: Support genitive month names"
Jdlrobson [Thu, 12 Sep 2013 17:45:25 +0000 (17:45 +0000)]
Merge "Adding support for query string params to mw.util.wikiGetlink"
C. Scott Ananian [Thu, 12 Sep 2013 15:17:42 +0000 (08:17 -0700)]
Minor bugfix to IP::prettifyIP.
The offset returned by preg_match with the PREG_OFFSET_CAPTURE is an
absolute position in the string. You shouldn't *add* it to the
current position in order to advance past the match.
Change-Id: I3631c34e02d9b830bf841bf960855626fbc88eb0
C. Scott Ananian [Tue, 6 Aug 2013 19:22:18 +0000 (15:22 -0400)]
Make line breaks in <blockquote> behave like <div> (bug 6200).
This is an old, old bug: the earliest filed dup is bug 1857, on 2005-04-10.
See bug 51086 for a modern discussion, and bug 52763 for some non-obvious
consequences: indented text inside a blockquote must not trigger
creation of a <pre> block (unlike <div>).
This patch should bring the PHP parser and Parsoid closer together.
This also fixes (or works around) bug 15491, which is really a bug in tidy.
But because <blockquote> content is typically wrapped with <p> tags now,
we don't trigger the tidy bug (see
https://bugzilla.wikimedia.org/show_bug.cgi?id=15491#c7 for details).
Credit to Aryeh Gregor (https://bugzilla.wikimedia.org/show_bug.cgi?id=6200#c8)
and Vitaliy Filippov (https://bugzilla.wikimedia.org/show_bug.cgi?id=6200#c37)
for almost-correct patches for this bug, which saved me a bunch of effort.
Thanks to Subramanya Sastry for pointing out bug 52763 and preventing a
bunch of broken articles on enwiki.
Bug: 6200
Bug: 15491
Bug: 52763
Change-Id: I3696d4ab7b8ad6ebccf8483d6da1722353c1697d
jenkins-bot [Thu, 12 Sep 2013 09:41:08 +0000 (09:41 +0000)]
Merge "Clarify "unknown gender" option is a non-answer and resort"
jenkins-bot [Thu, 12 Sep 2013 09:39:37 +0000 (09:39 +0000)]
Merge "Fix English gender-unknown message"
Tim Starling [Thu, 12 Sep 2013 02:57:16 +0000 (12:57 +1000)]
Fix English gender-unknown message
Fix for I81f02f03: the verb "detail" means to give details, i.e. to
say more than a single word in response to a question. It does not make
sense in this context.
Bug: 53311
Change-Id: Ifddf5c9a07dc62bc22dd0a3d2986e41a55b8ef33
C. Scott Ananian [Sat, 24 Aug 2013 17:25:54 +0000 (19:25 +0200)]
Optimize Parser::doQuotes().
Performance improvements to doQuotes(), since it is a hot function.
Co-authored-by: Tyler Anthony Romeo <tylerromeo@gmail.com>
Change-Id: If78d4372a2acd78d58b020385da400978716cbf5
Aaron Schulz [Wed, 11 Sep 2013 21:47:11 +0000 (14:47 -0700)]
Made HTMLForm wrap the submit buttons in a container for styling
Change-Id: I6510493a80c18ba5a466a16e3ca39396f9a60f60
jenkins-bot [Wed, 11 Sep 2013 21:17:01 +0000 (21:17 +0000)]
Merge "API: Enforce limit max in ApiQueryBacklinks"
Brad Jorsch [Wed, 11 Sep 2013 20:57:09 +0000 (13:57 -0700)]
API: Enforce limit max in ApiQueryBacklinks
Change-Id: Id0f0943771e3593c30563469df4820437ded9a99
kaldari [Wed, 11 Sep 2013 17:52:14 +0000 (10:52 -0700)]
Adding support for query string params to mw.util.wikiGetlink
This will enable us to easily migrate MobileFrontend from
using M.pageApi.getPageUrl (mobile custom version) to
mw.util.wikiGetlink.
Includes a unit test.
Change-Id: I5224a0910a822f1c3b1b34f505dbcdf879052b39
Brad Jorsch [Wed, 11 Sep 2013 19:55:15 +0000 (12:55 -0700)]
Add StubObject::unstub, and use it for $wgAuth->getUserInstance()
PHP's __call magic method can't handle functions with reference
parameters correctly,[1] which means that we need to manually unstub
StubObjects before calling such a method. Or you could use call-time
pass by reference with call_user_func_array, which is rather backwards
and verbose.
This change adds a convenience function to do this, and applies it to
the two calls which brought it to my attention.
[1]: https://bugs.php.net/bug.php?id=40694,
https://bugs.php.net/bug.php?id=62455
Change-Id: I74a0c04bf358e164f753b82fbefbd6205d9b2451
Translation updater bot [Wed, 11 Sep 2013 19:35:51 +0000 (19:35 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I7f09413ca5fd56cc4a0fc8b806464495577c101e