Aaron Schulz [Thu, 27 Oct 2011 01:36:57 +0000 (01:36 +0000)]
Disabled "bad image" tests which made totally broken assumptions about how/when the bad_image_list message is loaded. This caused failures with r100883. More direct tests were added in r100915.
Aaron Schulz [Thu, 27 Oct 2011 01:35:04 +0000 (01:35 +0000)]
Minor code style cleanups
Aaron Schulz [Thu, 27 Oct 2011 01:19:34 +0000 (01:19 +0000)]
Fixed braceSubstitution() to only profile templates rather than all kinds of possibly long strings of text to parse. It was dumping the whole text as the name of the profiling entry.
John Du Hart [Thu, 27 Oct 2011 01:13:19 +0000 (01:13 +0000)]
Followup r100905, cleanup per CR and fixes the overriding of the main RequestContext
John Du Hart [Thu, 27 Oct 2011 01:06:50 +0000 (01:06 +0000)]
Followup r100905, fixed the ApiTests
Sam Reed [Thu, 27 Oct 2011 00:46:17 +0000 (00:46 +0000)]
Documentation
Deprecated code updates
Aaron Schulz [Thu, 27 Oct 2011 00:23:23 +0000 (00:23 +0000)]
* Allow passing in a blacklist into wfIsBadImage()
* Added wfIsBadImage() unit tests
John Du Hart [Wed, 26 Oct 2011 23:34:31 +0000 (23:34 +0000)]
Followup 100905, fixing usages of getContext()
John Du Hart [Wed, 26 Oct 2011 23:27:01 +0000 (23:27 +0000)]
Adding context to the API
This will probably break something somewhere so when it does please yell at me on IRC and I'll fix it.
Aaron Schulz [Wed, 26 Oct 2011 21:48:04 +0000 (21:48 +0000)]
Fixed process cache for bad images when the list is empty
Roan Kattouw [Wed, 26 Oct 2011 20:58:29 +0000 (20:58 +0000)]
Make indentation consistent in HTMLForm doc comment
Mark A. Hershberger [Wed, 26 Oct 2011 20:50:16 +0000 (20:50 +0000)]
Patch from Erwin Dokter Bug #31547 — “Category links need less spacing and better wrapping”
Applying since the this was already tried at enwiki. http://en.wikipedia.org/w/index.php?&diff=prev&oldid=
454764019
John Du Hart [Wed, 26 Oct 2011 19:39:56 +0000 (19:39 +0000)]
Followup r100847, ApiMain now respects $wgShowHostnames
Raimond Spekking [Wed, 26 Oct 2011 19:30:37 +0000 (19:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net
John Du Hart [Wed, 26 Oct 2011 19:04:46 +0000 (19:04 +0000)]
Small todo note about ApiMain
Sean Colombo [Wed, 26 Oct 2011 19:04:12 +0000 (19:04 +0000)]
Releasenotes for wgQueryPageDefaultLimit - followup for r100761.
Antoine Musso [Wed, 26 Oct 2011 13:39:43 +0000 (13:39 +0000)]
script to parse wikitext from CLI
Wikitext can be given by stdin or using a file. The wikitext will be parsed
using 'CLIParser' as a title. This can be overriden with --title option.
Example1:
$ php parse.php --title foo
''[[foo]]''^D
<p><i><strong class="selflink">foo</strong></i>
</p>
Example2:
$ echo "'''bold'''" > /tmp/foo
$ php parse.php --file /tmp/foo
<p><b>bold</b>
</p>$
Example3:
$ cat /tmp/foo | php parse.php
<p><b>bold</b>
</p>$
Aaron Schulz [Wed, 26 Oct 2011 06:22:25 +0000 (06:22 +0000)]
Split out checkExecutePermissions() function from userCanExecute() in FormSpecialPage. The former handles actual execute() calls and throws exceptions, the later inherits its purpose from SpecialPage. It just checks the page restriction to see if a user generally *could* execute. This avoids the breakage that came up in r100723 where Special:SpecialPages was throwing permission errors due to the getUsablePages() call.
Aaron Schulz [Wed, 26 Oct 2011 05:12:07 +0000 (05:12 +0000)]
Fixed 'Fatal error: Cannot access protected property Revision::$mDeleted in C:\wamp\www\MW_trunk\includes\revisiondelete\RevisionDelete.php on line 146'
Sam Reed [Wed, 26 Oct 2011 04:22:10 +0000 (04:22 +0000)]
Move DjVuImage to media/DjVuImage.php
Sam Reed [Wed, 26 Oct 2011 04:15:54 +0000 (04:15 +0000)]
Leave a fixme comment on context stuff
Sam Reed [Wed, 26 Oct 2011 04:15:09 +0000 (04:15 +0000)]
More documentation!
Aaron Schulz [Wed, 26 Oct 2011 04:13:05 +0000 (04:13 +0000)]
FU r100535:
* Added thumb-handler.php5 file
* Moved 404.php to thumb-handler.php as wfDisplay404Error()
* Removed excess short-circuiting error cases in thumb-handler.php
* Moved cURL extension check to the top of the file
* Improved sample $thgThumbHashFragment regex value
* Cleaned up wfStreamThumbViaCurl() error handling code a bit
Sam Reed [Wed, 26 Oct 2011 03:45:13 +0000 (03:45 +0000)]
Add, update, tweak documentation
Fix document comment blocks
Tweak some returns
Sam Reed [Wed, 26 Oct 2011 03:44:47 +0000 (03:44 +0000)]
Add, update, tweak documentation
Fix document comment blocks
Tweak some returns
Mark A. Hershberger [Wed, 26 Oct 2011 02:56:27 +0000 (02:56 +0000)]
some eol w/s
Mark A. Hershberger [Wed, 26 Oct 2011 02:56:04 +0000 (02:56 +0000)]
Bug 31948 - Special:Contributions doesn't remember tagfilter in
options form
Patch from MrBlueSky.
Sean Colombo [Tue, 25 Oct 2011 23:18:00 +0000 (23:18 +0000)]
Followup to r97033 - removed wgWhatlinksherelimit and started the conversion to wgQueryPageDefaultLimit, but didn't see too many places using a default of 50.
Platonides [Tue, 25 Oct 2011 22:18:33 +0000 (22:18 +0000)]
If the page contains __NOEDITSECTION__, it will never have edit sections, so don't create markers. Follow-up r99250.
Fix for bug 31647: Regression: __NOEDITSECTION__ is ignored when the page is read from the parser cache
Alexandre Emsenhuber [Tue, 25 Oct 2011 18:20:44 +0000 (18:20 +0000)]
Port Special:Lockdb and Special:Unlockdb to HTMLForm using FormSpecialPage
Aaron Schulz [Tue, 25 Oct 2011 18:19:26 +0000 (18:19 +0000)]
* Removed $wgRCShowChangedSize check in sp:Contributions for size diffs since this isn't RC
* Replaced revision size information on history pages with size diff to be consistent with other places
Alexandre Emsenhuber [Tue, 25 Oct 2011 18:14:30 +0000 (18:14 +0000)]
Unstub $wgLang if still stubbed before storing it; avoid storing a StubUserLang instance in ParserOptions and errors when getting the object (per report of Lockal on IRC)
Aaron Schulz [Tue, 25 Oct 2011 17:19:28 +0000 (17:19 +0000)]
Added temporary LocalFilePurgeThumbnails hook for bug 27641
Roan Kattouw [Tue, 25 Oct 2011 14:41:58 +0000 (14:41 +0000)]
(bug 31514) Followup r99031: allow clicking of links in table headers in a different way that doesn't break expand/collapse links.
Aaron Schulz [Tue, 25 Oct 2011 05:20:01 +0000 (05:20 +0000)]
Marked purgeThumbList() protected
Brion Vibber [Mon, 24 Oct 2011 22:28:09 +0000 (22:28 +0000)]
Followup r100391: fix caret position test case on Opera, Firefox 3.5/3.6/4.0/5.0
Opera (through 11.52 at least) & Firefox prior to 6.0 set the caret initially to the end of the textarea, which gave a mismatch. All we really need is to know we got a sane value, so checking for both (start == 0; end == text.length) gets the job done.
Under ideal circumstances, we'd check after a user clicks in the textarea on the first line, but no good way to trigger that. :)
Aaron Schulz [Mon, 24 Oct 2011 22:19:02 +0000 (22:19 +0000)]
FU r100645: don't pass unused param
Alexandre Emsenhuber [Mon, 24 Oct 2011 20:37:54 +0000 (20:37 +0000)]
* Remove $abort parameter from MediaWiki::checkMaxLag(); unused and it's a private function.
* Restore wfGetLB()->getMaxLag() call since we are no more in index.php
Raimond Spekking [Mon, 24 Oct 2011 20:02:53 +0000 (20:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net
OverlordQ [Mon, 24 Oct 2011 19:55:01 +0000 (19:55 +0000)]
Add user_former_groups table to PG updater
OverlordQ [Mon, 24 Oct 2011 19:43:16 +0000 (19:43 +0000)]
Update Postgres with missing uploadstash tables
OverlordQ [Mon, 24 Oct 2011 19:28:31 +0000 (19:28 +0000)]
Basic support for Postgres phpunit testing, currently throws 5 errors, 1 inc, 5 skipped
Antoine Musso [Mon, 24 Oct 2011 17:45:45 +0000 (17:45 +0000)]
Tests for r96188 features
That revision let us pass an array of values to 'class', 'rel'
and 'accesskey'. The revision requested some tests :)
Alexandre Emsenhuber [Mon, 24 Oct 2011 17:24:38 +0000 (17:24 +0000)]
Added OutputPage::setPageTitleMsg() and OutputPage::setHTMLTitleMsg() as modified versions of OutputPage::setPageTitle() and OutputPage::setHTMLTitle() that take an message name and its parameters; updated all calls in core that can use the two new functions
Alexandre Emsenhuber [Mon, 24 Oct 2011 16:17:46 +0000 (16:17 +0000)]
Removed unused and deprecated global declaration of $wgDeferredUpdateList
Alexandre Emsenhuber [Mon, 24 Oct 2011 16:14:49 +0000 (16:14 +0000)]
* (bug 31921) Fix for r78201: magic words REVISIONDAY, REVISIONMONTH and REVISIONYEAR now give current values on preview
Siebrand Mazeland [Mon, 24 Oct 2011 16:10:04 +0000 (16:10 +0000)]
Update formatting. Update "<space><tab>" and "<tab><space>" where needed.
Antoine Musso [Mon, 24 Oct 2011 13:58:03 +0000 (13:58 +0000)]
makes HTML5 five only attributes a global property
This patch move an array hidden in Html::expandAttributes() to the top of
the class definition as self::$HTMLFiveOnlyAttribs.
That also make the Html::expandAttributes() method a bit more concise.
Antoine Musso [Mon, 24 Oct 2011 10:51:46 +0000 (10:51 +0000)]
test that preloaded text is unstripped
bug 27467 reported our preloaded system did not unstrip <nowiki>
or <pre> enclosed text. The fix was applied by r82473.
Antoine Musso [Mon, 24 Oct 2011 09:32:33 +0000 (09:32 +0000)]
test {{SERVERNAME}} with relative URLS
bug 31176 mentionned an issue with {{SERVERNAME}} returning the full
URL instead of servername when using relative URLs (//localhost).
The fix was made by r98193.
This patch test three different URL protocols (http, https & relative)
and check we return the expected 'localhost'.
Antoine Musso [Mon, 24 Oct 2011 09:08:13 +0000 (09:08 +0000)]
using real identity for hashar
Converting my pseudonym to use my real identity instead:
Ashar Voultoiz -> Antoine Musso
Antoine Musso [Mon, 24 Oct 2011 08:39:58 +0000 (08:39 +0000)]
Test handling of escaped CSS comments
r85856 fixed a CSS injection issue but lacked testing. This
test verify we properly strip out CSS comments even when the
token delimiter '/*' is backslash-escaped : \2f\2a
Tim Starling [Mon, 24 Oct 2011 04:45:26 +0000 (04:45 +0000)]
Updated documentation of $wgMaxImageArea for r99911 etc.
Aaron Schulz [Mon, 24 Oct 2011 03:08:45 +0000 (03:08 +0000)]
FU r100535:
* Changed custom functions to work via a $thgThumbCallbacks variable
* Added 'checkCache' and 'fillCache' hooks to $thgThumbCallbacks
* Minor regex cleanup to wfExtractThumbParams()
* Re-organized a bit of the wfStreamThumbViaCurl() code
Brian Wolff [Mon, 24 Oct 2011 02:47:22 +0000 (02:47 +0000)]
(follow-up r100575 / r99477) unit-tests for jpegMetadataExtractor dealing with padding bytes.
Brian Wolff [Mon, 24 Oct 2011 02:41:34 +0000 (02:41 +0000)]
(follow up r99477) not sure what I was doing on r99477, but its not right (doesn't work for odd number padding bytes)
Will commit unittests in follow up.
Brian Wolff [Mon, 24 Oct 2011 02:19:11 +0000 (02:19 +0000)]
(bug 31740) JpegMetadataExtractor and friends weren't checking for unexpected end of input properly
I created a new wrapper around unpack - wfUnpack which throws an exception if it runs out of input
(but i didn't use that on GIFMetadataExtractor/PNGMetadataExtractor because those files have a header saying that they weren't external dependencies minimized for potential re-users. I don't think anyone actually re-uses those files, but I didn't want to add a dependency on wfUnpack just in case).
I also changed fopen( blah, "r" ) -> fopen( blah, "rb" ) since these are binary formats, so we don't want newlines converted on windows.
Brandon Harris [Sun, 23 Oct 2011 22:49:03 +0000 (22:49 +0000)]
Update green buttons to a color that doesn't clash with Vector.
Raimond Spekking [Sun, 23 Oct 2011 19:48:36 +0000 (19:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net
John Du Hart [Sun, 23 Oct 2011 18:38:22 +0000 (18:38 +0000)]
Adding functions to HTMLForm for explicitly setting the content of the header and footer.
Also adds a function for setting the intro, as a counterpart to addPreText
John Du Hart [Sun, 23 Oct 2011 18:09:44 +0000 (18:09 +0000)]
HTMLForm is now a context source.
Replace wfMessage() calls with $this->msg()
John Du Hart [Sun, 23 Oct 2011 16:57:53 +0000 (16:57 +0000)]
Adding flatlists to HTMLRadioField, sort of like HTMLMultiSelect
John Du Hart [Sun, 23 Oct 2011 16:45:08 +0000 (16:45 +0000)]
Add check to see if the user has permission to view the log. Right now the page title and description are still set.
Aaron Schulz [Sun, 23 Oct 2011 10:15:51 +0000 (10:15 +0000)]
Removed wrong comment in doBatchLookups()
Aaron Schulz [Sun, 23 Oct 2011 09:51:13 +0000 (09:51 +0000)]
Reverted r99195 quick-fix per r99897
Aaron Schulz [Sun, 23 Oct 2011 09:38:52 +0000 (09:38 +0000)]
Use getId() accessors for Revision object (fixes fatal)
Aaron Schulz [Sun, 23 Oct 2011 09:36:35 +0000 (09:36 +0000)]
Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based on the wmf thumb handler, but simplified. It is disabled by default.
* The thumb.php parameter extraction can also be overridden by the config to handle more complex setups and things like OggHandler and PagedTiffHandler.
* A simple 404 error page is also included. It can be overridden by the config.
* Additional HTTP headers can be passed through cURL via the config.
Alexandre Emsenhuber [Sun, 23 Oct 2011 09:21:02 +0000 (09:21 +0000)]
* Changed action=history to use an Action subclass
* Use local context instead of global variables
* Removed obsolete aliases PageHistory and PageHistoryPager; no longer used
* Made Action::getContext() and related methods public for the call in HistoryPager's constructor and also for consistency with other classes
Alexandre Emsenhuber [Sun, 23 Oct 2011 08:54:48 +0000 (08:54 +0000)]
Group shell-related functions
Derk-Jan Hartman [Sun, 23 Oct 2011 08:17:19 +0000 (08:17 +0000)]
Use attr() instead of this.href, to make sure that we don't absolutify the URI.
Fixes bug 31899
Alexandre Emsenhuber [Sun, 23 Oct 2011 08:13:52 +0000 (08:13 +0000)]
* Use local context to get messages
* Simply use getLang() instead of getContext()->getLang() now that this method exists
* Also changed addWikiMsgArray() to use a Message object with addWikiText() for the parse operation; removed its $options parameter, no caller was using it
Alexandre Emsenhuber [Sun, 23 Oct 2011 07:55:45 +0000 (07:55 +0000)]
Check first that $wgDisableLangConversion is false and we are not in a special page before doing the language variant check
John Du Hart [Sun, 23 Oct 2011 01:10:23 +0000 (01:10 +0000)]
Follow up r100512, adding @since tags and using wfMessage
Robin Pepermans [Sat, 22 Oct 2011 20:48:59 +0000 (20:48 +0000)]
Allowing moving -> allow moving; use past tense
Raimond Spekking [Sat, 22 Oct 2011 20:29:38 +0000 (20:29 +0000)]
Localisation updates for core and extension messages from translatewiki.net
John Du Hart [Sat, 22 Oct 2011 20:10:41 +0000 (20:10 +0000)]
Removing extra stuff that was committed in r100512
John Du Hart [Sat, 22 Oct 2011 20:03:40 +0000 (20:03 +0000)]
Adding functions to HTMLForm for setting the submitText and WrapperLegend to messages instead of having to use wfMsg every single time
Derk-Jan Hartman [Sat, 22 Oct 2011 19:50:43 +0000 (19:50 +0000)]
Follow up to r79085. Fixes bug 31408.
There was a typo, causing the minoredit tag not to show up in the enhanced recentchanges.
Rotem Liss [Sat, 22 Oct 2011 17:35:20 +0000 (17:35 +0000)]
Typo.
Alexandre Emsenhuber [Sat, 22 Oct 2011 05:06:54 +0000 (05:06 +0000)]
* Call Linker methods statically
* Use local context to get messages
Aaron Schulz [Fri, 21 Oct 2011 23:20:52 +0000 (23:20 +0000)]
Revision objects now always use the current name of users, loading it on demand if necessary (e.g. when given a $row with no user_name but rev_user is not 0)
Platonides [Fri, 21 Oct 2011 22:18:02 +0000 (22:18 +0000)]
Fix fatal: Fatal error: func_get_args(): Can't be used as a function parameter in includes/context/ContextSource.php on line 121
Raimond Spekking [Fri, 21 Oct 2011 20:30:08 +0000 (20:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net
John Du Hart [Fri, 21 Oct 2011 20:24:03 +0000 (20:24 +0000)]
Followup r100396, use is_string instead of !is_array
Alexandre Emsenhuber [Fri, 21 Oct 2011 20:09:27 +0000 (20:09 +0000)]
Use local context to get messages
Alexandre Emsenhuber [Fri, 21 Oct 2011 16:54:25 +0000 (16:54 +0000)]
* Call Linker methods statically
* Removed now-useless parameter RevisionDeleter::getLogLinks(), updated the only caller
Brion Vibber [Fri, 21 Oct 2011 00:15:45 +0000 (00:15 +0000)]
* (bug 31847) Fix positioning of WikiEditor 'header' insertions when selection is empty in IE 7/8
Follows up to the test cases added in r100391. jquery.textSelection's getCaretPosition() for IE needs to focus the textarea first in order to get consistent results when there's an empty selection -- getSelection() which returns the text already does this.
Because focus had previously been stolen by the drop-down menus in WikiEditor's toolbar, the saveCursorAndScrollTop() was getting a bogus result from getCaretPosition, saving that, then restoring the bad selection (wiping out the original caret position) right before going ahead with the encapsulateText call.
Now seems to get the correct caret position, and also doesn't appear to interfere with selections.
John Du Hart [Fri, 21 Oct 2011 00:09:56 +0000 (00:09 +0000)]
Bugfix to r96441, class_exists throws warnings when arrays are passed to it
Brion Vibber [Thu, 20 Oct 2011 22:50:04 +0000 (22:50 +0000)]
QUnit test cases for bug 31847: will trigger a fail on IE 6/7/8
jquery.textSelection's getCaretPosition() gives bogus results on IE 6/7/8 when there's not a selection set in the textarea; it seems to give us some value somewhere in the middle of the textarea, rather than what we expected.
If we actually set an empty selection, then it gets it back just fine!
But if the cursor is in initial state, or has been moved by the user, we get back garbage. This is causing WikiEditor to sometimes insert things in the wrong place, as it tries to pull the caret position and manipulate the selection to do insertions; we then end up using the bogus selection when it gets saved in via selection restoration.
Krinkle [Thu, 20 Oct 2011 22:35:27 +0000 (22:35 +0000)]
Updating jquery.qunit from upstream
* Source: https://github.com/jquery/qunit/tree/
ee156923cdb01820e35e6bb579d5cf6bf55736d4
-- Several bug fixes
-- New hooks system
-- Version numbers, finally (this is 1.2.0pre)
-- (BREAKING CHANGE) start/stop now takes count instead of timeout as first argument (read more at https://github.com/jquery/qunit/pull/125 and http://docs.jquery.com/QUnit/stop)
Krinkle [Thu, 20 Oct 2011 22:34:05 +0000 (22:34 +0000)]
[JSTesting] Fix dependencies. Of course jquery.qunit.completenessTest needs jquery.qunit
Krinkle [Thu, 20 Oct 2011 22:33:05 +0000 (22:33 +0000)]
[JSTesting] Don't rely on the timeout argument of start/stop. This behavior is removed in the latest QUnit version.
-- Actually, in the latest QUnit version start/stop take 'count' as first argument. It would internally set the number of wait levels to 5000 xD
Sam Reed [Thu, 20 Oct 2011 21:22:59 +0000 (21:22 +0000)]
After r100379, move release notes for bug 29392
Raimond Spekking [Thu, 20 Oct 2011 19:16:53 +0000 (19:16 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Thu, 20 Oct 2011 19:05:48 +0000 (19:05 +0000)]
More whitespace tweaks...and fixed doc typo
Aaron Schulz [Thu, 20 Oct 2011 17:13:53 +0000 (17:13 +0000)]
Removed deprecated getFullPath(); no callers
Mark A. Hershberger [Thu, 20 Oct 2011 15:12:13 +0000 (15:12 +0000)]
eol w/s
Mark A. Hershberger [Thu, 20 Oct 2011 14:46:29 +0000 (14:46 +0000)]
Revert r79363, r79364, and r79369 to disable datalists support entirely based
on Bug 31602, Bug 31697, Bug 31654, Bug 31658, and even Aryeh Gregor's
comments in
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-December/029593.html
Antoine Musso [Thu, 20 Oct 2011 14:28:41 +0000 (14:28 +0000)]
(bug 31345) document API Revisions parameters as enum
Patch by Brad Jorsch.
Alexandre Emsenhuber [Thu, 20 Oct 2011 10:29:51 +0000 (10:29 +0000)]
Fix for r100333: forgot to override requiresWrite() and requiresUnblock()