Bryan Tong Minh [Sat, 30 Oct 2010 19:11:30 +0000 (19:11 +0000)]
Follow-up r75702: stylize
Bryan Tong Minh [Sat, 30 Oct 2010 19:04:26 +0000 (19:04 +0000)]
Split BitmapHandler::doTransform in functions: transformImageMagick(), transformCustom() and transformGd(). Pass their parameters as an options array. Put common code lines into separate functions such as getClientScalingThumbnailImage(), getMediaTransformError() and logErrorForExternalProcess(). Tested all three scalers, everything appears to be still working.
Shinjiman [Sat, 30 Oct 2010 18:05:42 +0000 (18:05 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese
Chad Horohoe [Sat, 30 Oct 2010 17:47:00 +0000 (17:47 +0000)]
Per r75386 CR, use newMainPage()
Chad Horohoe [Sat, 30 Oct 2010 17:28:26 +0000 (17:28 +0000)]
Revert r75654 per CR, doEdit() already takes care of search updates
Chad Horohoe [Sat, 30 Oct 2010 17:20:41 +0000 (17:20 +0000)]
Oracle maintainer should enable E_STRICT ;-)
Chad Horohoe [Sat, 30 Oct 2010 17:17:26 +0000 (17:17 +0000)]
E_STRICT: Function signature should match parent. This newFromParams stuff should be going away soon anyway
Bryan Tong Minh [Sat, 30 Oct 2010 13:03:41 +0000 (13:03 +0000)]
(bug 23732) Clarified "n links" message on Special:MostLinkedFiles
Antoine Musso [Sat, 30 Oct 2010 11:43:03 +0000 (11:43 +0000)]
Follow up r74684 : use default path if MW_INSTALL_PATH is not present.
Philip Tzou [Sat, 30 Oct 2010 05:42:16 +0000 (05:42 +0000)]
Forgot to commit this one. parserTests fix for
r75617 (in trunk/phase3/includes/Title.php).
Antoine Musso [Fri, 29 Oct 2010 22:42:37 +0000 (22:42 +0000)]
Follow up r75682 : fix private function naming.
Fix cruise control build 2010-10-29T22:18:27
Rotem Liss [Fri, 29 Oct 2010 22:38:26 +0000 (22:38 +0000)]
Localization update for he.
Rotem Liss [Fri, 29 Oct 2010 22:35:20 +0000 (22:35 +0000)]
Localization update for he.
Antoine Musso [Fri, 29 Oct 2010 22:03:17 +0000 (22:03 +0000)]
Follow up r75627. Implements r75670 in PHP to validate emails.
* Server side validation of email according to an HTML5 specifications provided by Simetrical :
http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#e-mail-state
* This is NOT a fix of bug 959 (which wants RFC 2822 validation)
* Basic unit tests
Antoine Musso [Fri, 29 Oct 2010 20:44:26 +0000 (20:44 +0000)]
Follow up r75627 (code review comments):
* Replace background coloring with a label insertion on the right or left of input depending on language direction.
* User side validation of email according to an HTML5 specifications provided by Simetrical :
http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#e-mail-state
Code comments should be self explaining.
Possible follows up:
- use JQuery Validation plugin
- make the validation part a mediawiki validation module
- server side validation
Bryan Tong Minh [Fri, 29 Oct 2010 20:33:27 +0000 (20:33 +0000)]
r75621 copy-paste fail
Raimond Spekking [Fri, 29 Oct 2010 19:21:12 +0000 (19:21 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-30 19:05:00 UTC)
Derk-Jan Hartman [Fri, 29 Oct 2010 18:52:59 +0000 (18:52 +0000)]
Switch the hyphen in diff output to actually minus signs.
Derk-Jan Hartman [Fri, 29 Oct 2010 18:42:55 +0000 (18:42 +0000)]
Add updated release notes for r75658
Derk-Jan Hartman [Fri, 29 Oct 2010 18:28:44 +0000 (18:28 +0000)]
Add a nbsp to each empty "diff-marker".
Fixes Bug 25697
Prevent collapsed table row if both pre and post lines in the diff are totally empty.
Chad Horohoe [Fri, 29 Oct 2010 17:26:22 +0000 (17:26 +0000)]
(bug 22308) Search should find text in default main page immediately after setup. Based on patch by Josh Lerner
Krinkle [Fri, 29 Oct 2010 17:11:22 +0000 (17:11 +0000)]
$.client has been enhanced and made easier since the initial version, may aswell be used directly (r75593)
Chad Horohoe [Fri, 29 Oct 2010 16:28:50 +0000 (16:28 +0000)]
(bug 19593) $wgServer can't be set properly with --server attribute in command line tools. Also fixes regression in generateSitemap.php from maintenance rewrite. Also possible workaround for bug 18274.
Shinjiman [Fri, 29 Oct 2010 16:22:43 +0000 (16:22 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese
Bryan Tong Minh [Fri, 29 Oct 2010 16:19:35 +0000 (16:19 +0000)]
Follow-up r75621: Check for $wgEnableAPI before adding the RSD link to the head
Krinkle [Fri, 29 Oct 2010 15:30:54 +0000 (15:30 +0000)]
white-space cleanup throughout $.client and mw.util and mw.util.test (r75593)
Krinkle [Fri, 29 Oct 2010 15:27:53 +0000 (15:27 +0000)]
adding layoutversion to $.client and isLayoutVersion to mw.util. Follow-up of r75593
Krinkle [Fri, 29 Oct 2010 14:44:18 +0000 (14:44 +0000)]
Follow-up r75577
Sam Reed [Fri, 29 Oct 2010 12:20:11 +0000 (12:20 +0000)]
Followup r75554, functionise Export code, allows for return to be used "non scarily"
Remove some extra blank comment lines
Philip Tzou [Fri, 29 Oct 2010 02:55:37 +0000 (02:55 +0000)]
Fix the LanguageConverterTest to prevent test failures after the changes made on getPreferredVariant() at r75617.
Sam Reed [Thu, 28 Oct 2010 22:56:43 +0000 (22:56 +0000)]
Minor followup to r75621, add whitespace
Add getVersion to ApiFormatXmlRsd
Antoine Musso [Thu, 28 Oct 2010 21:01:56 +0000 (21:01 +0000)]
Lame user side email validator using JQuery.
See bug 22449 : MediaWiki should do validation of e-mail addresses
Raimond Spekking [Thu, 28 Oct 2010 20:10:28 +0000 (20:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-28 19:50:00 UTC)
Raimond Spekking [Thu, 28 Oct 2010 19:49:44 +0000 (19:49 +0000)]
Follow-up r75582: Fix wrong message key in maintenance script
Bryan Tong Minh [Thu, 28 Oct 2010 19:20:21 +0000 (19:20 +0000)]
(bug 25648) API discovery information has been added as RSD link in page <head> and by providing an API module action=rsd. Added hook ApiRsdServiceApis for extensions to add their own service to the services list.
Patch by Brion Vibber and Bryan Tong Minh.
Philip Tzou [Thu, 28 Oct 2010 17:11:21 +0000 (17:11 +0000)]
Follow up r75617. remove extra brackets.
Philip Tzou [Thu, 28 Oct 2010 16:58:39 +0000 (16:58 +0000)]
1. Revert the complicated redirection I made in r59754;
2. Add more Accept-Language XVO cache name for IE;
3. Use hreflang to specify canonical and alternate links, it's search engine friendly
when a wiki has multiple variant languages.
Max Semenik [Thu, 28 Oct 2010 13:54:43 +0000 (13:54 +0000)]
Follow-up r75611: revert release-notes too
Max Semenik [Thu, 28 Oct 2010 13:40:33 +0000 (13:40 +0000)]
Revert r66140 per CR
Antoine Musso [Thu, 28 Oct 2010 06:35:31 +0000 (06:35 +0000)]
Follow up r75585 : messages.inc entry missing
Aaron Schulz [Thu, 28 Oct 2010 02:47:48 +0000 (02:47 +0000)]
truncateHtml() comment tweaks
Sam Reed [Thu, 28 Oct 2010 00:04:48 +0000 (00:04 +0000)]
Function return type hints
Explicit class variable definition
Sam Reed [Wed, 27 Oct 2010 23:56:01 +0000 (23:56 +0000)]
More function parameter commenting
Sam Reed [Wed, 27 Oct 2010 23:50:09 +0000 (23:50 +0000)]
Parameter documentation
Krinkle [Wed, 27 Oct 2010 23:19:26 +0000 (23:19 +0000)]
porting is_opera, is_safari_win etc. to mw.util as isBrowser('..'), isPlatform('...') etc.
Platonides [Wed, 27 Oct 2010 22:27:23 +0000 (22:27 +0000)]
Do NOT use hardcoded passwords! Not even if the user agreed to run destructive tests.
The affected passwords have been disabled in r75588
Follow up r72475,r74213.
Additionally give descriptive names to the users.
Also see the mail to wikitech.
Platonides [Wed, 27 Oct 2010 22:26:39 +0000 (22:26 +0000)]
Add feature to block common (weak) passwords.
This closes the hole of passwords hardcoded in r72475,r74213. Also see r75589.
Roan Kattouw [Wed, 27 Oct 2010 22:22:10 +0000 (22:22 +0000)]
(bug 25339) Allow specifying separate base paths for local and remote paths in ResourceLoaderFileModule::__construct(). Extensions can use this to properly point the resource loader to their resources in a way that doesn't depend on the extensions/ directory being a subdirectory of phase3/ on the filesystem and that respects $wgExtensionAssetsPath. Also converted all extensions using ResourceLoader to use this approach, except MWEmbed which uses way more indirection building its module registrations than I can deal with after midnight.
What actually happens here
* Add $localBasePath, $remoteBasePath params to the FileModule constructor, defaulting to $IP and $wgScriptPath respectively
* Add getLocalPath() and getRemotePath(), which use this information to build a proper FS or URL path for a file
* Make readScriptFiles() non-static so it can use these functions
* Run every single file path we use through either getLocalPath() or getRemotePath() as appropriate
** Except file dependencies, these are already prefixed. Our inability to give them special treatment caused bugs earlier
* Kill prefixFilePathList() and resolveFilePath(), no longer needed
Platonides [Wed, 27 Oct 2010 22:10:33 +0000 (22:10 +0000)]
Use the author that really edited it, from the previously received data. This fixes the last unit test.
Also, fail with the error code if there are problems, instead of an odd message failing in the assert.
Antoine Musso [Wed, 27 Oct 2010 21:17:03 +0000 (21:17 +0000)]
Optional feature to login through HTTPS and come back to HTTP.
Based on an idea by George Herbert <george dot herbert at gmail dot com>
http://lists.wikimedia.org/pipermail/wikitech-l/2010-October/050065.html
Antoine Musso [Wed, 27 Oct 2010 21:11:36 +0000 (21:11 +0000)]
Lame documentation, code style
Bryan Tong Minh [Wed, 27 Oct 2010 21:02:58 +0000 (21:02 +0000)]
(bug 23194) Special:ListFiles now has thumbnails
Added new message listfiles_thumb
Platonides [Wed, 27 Oct 2010 20:48:07 +0000 (20:48 +0000)]
No wonder that the check -added in r75265- Blah == User:Text never succeeded.
Changing to something useful.
Krinkle [Wed, 27 Oct 2010 20:42:33 +0000 (20:42 +0000)]
whitespace cleanup in mediawiki.util.js
Krinkle [Wed, 27 Oct 2010 20:27:04 +0000 (20:27 +0000)]
changing mw.uti functionnames to follow convention + loading $.client as dependency of mw.util
Roan Kattouw [Wed, 27 Oct 2010 20:08:04 +0000 (20:08 +0000)]
Re-add maintenance script from r75555, not totally broken this time
Raimond Spekking [Wed, 27 Oct 2010 20:01:36 +0000 (20:01 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-27 19:25:00 UTC)
Roan Kattouw [Wed, 27 Oct 2010 19:59:10 +0000 (19:59 +0000)]
Fix regression introduced by doing data URL embedding early causing file dependencies for CSS not to be registered: the data URL embedding had modified the URL to the point where getLocalFileReferences() doesn't recognize it anymore. This is a quick&dirty fix registering dependencies in $this->fileDeps just before each remap() call
Antoine Musso [Wed, 27 Oct 2010 19:19:11 +0000 (19:19 +0000)]
Compare latency between http and https by querying localhost.
Roan Kattouw [Wed, 27 Oct 2010 18:49:18 +0000 (18:49 +0000)]
Revert unintended changes in r75555
Max Semenik [Wed, 27 Oct 2010 15:52:02 +0000 (15:52 +0000)]
Introduced $wgAdditionalMailParams to allow adjusting extra email options. Based on patch by Alejandro Mery.
Platonides [Wed, 27 Oct 2010 15:51:37 +0000 (15:51 +0000)]
r74753, r74755, r75254 added new settings, but didn't update SeleniumConfigurationTest.php breaking the tests
Roan Kattouw [Wed, 27 Oct 2010 15:51:31 +0000 (15:51 +0000)]
Whitespace fixes for r75486
Sam Reed [Wed, 27 Oct 2010 15:42:32 +0000 (15:42 +0000)]
* (bug 25463) Export header should not be shown if no pages were requested, to reduce confusion
Patch by Umherirrender, with a tweak to inverse logic to reduce nesting
Krinkle [Wed, 27 Oct 2010 15:37:47 +0000 (15:37 +0000)]
Escaping parameter for regex (Follow-up r75275)
Krinkle [Wed, 27 Oct 2010 15:35:55 +0000 (15:35 +0000)]
Fixed unfinished line from r75275, commented addPortletLink() more, moved prototypes from mediawiki.util.js to mediawiki.js, added String.prototype.escapeRE()
Roan Kattouw [Wed, 27 Oct 2010 15:30:20 +0000 (15:30 +0000)]
Followup r75548: forgot to put global $wgHandheldStyle; back in
Roan Kattouw [Wed, 27 Oct 2010 15:21:18 +0000 (15:21 +0000)]
Followup r74966, r75006: load $wgHandheldStyle again in SkinMonoBook. Can't do this the nice way (with ResourceLoader) because $wgHandheldStyle might be a URL :(
Krinkle [Wed, 27 Oct 2010 15:02:18 +0000 (15:02 +0000)]
moved jQuery.fn.enableCheckboxShiftClick to it's own file and renamed to jQuery.fn.checkboxShiftClick
Jure Kajzer [Wed, 27 Oct 2010 14:52:18 +0000 (14:52 +0000)]
* installers skips recreation of existing user
* updater for 16->17 schema changes
* i dedicate this revision to my greatest supporter ... Reedy :)
Platonides [Wed, 27 Oct 2010 14:46:58 +0000 (14:46 +0000)]
r75540 CR
Platonides [Wed, 27 Oct 2010 14:38:31 +0000 (14:38 +0000)]
Make update.php obey --quiet
Platonides [Wed, 27 Oct 2010 13:56:58 +0000 (13:56 +0000)]
Follow up r75474
Chad Horohoe [Wed, 27 Oct 2010 13:18:14 +0000 (13:18 +0000)]
Don't show new and ok message at the same time
Chad Horohoe [Wed, 27 Oct 2010 12:19:56 +0000 (12:19 +0000)]
Remove unnecessary writable config dir check
Roan Kattouw [Wed, 27 Oct 2010 11:50:20 +0000 (11:50 +0000)]
Followup to r75266: remove warning "rvlimit may not be less than 1 (set to )" when rvparse is set but rvlimit is not set
Siebrand Mazeland [Wed, 27 Oct 2010 11:18:13 +0000 (11:18 +0000)]
Follow-up r75499: initialise $anchorclose to prevent PHP Notice: Undefined variable: anchorclose on line 390.
Derk-Jan Hartman [Wed, 27 Oct 2010 01:56:23 +0000 (01:56 +0000)]
Line endings in wikitext can introduce <p>'s, which was not really the intent here for the fullMedia div.
Derk-Jan Hartman [Wed, 27 Oct 2010 01:50:07 +0000 (01:50 +0000)]
Make the image page more consistent. Now all pages will have the fullMedia div. (with link, and file description)
Perhaps we should move the "Size of this preview:" and "No higher resolution available" markers into that div as well ? Feedback welcome.
Trevor Parscal [Wed, 27 Oct 2010 00:16:32 +0000 (00:16 +0000)]
Mostly reverted r75487, making use of a new version of mediaWiki.msg.
Trevor Parscal [Wed, 27 Oct 2010 00:04:33 +0000 (00:04 +0000)]
* Cleaned up comments
* Added mediaWiki.msg back, this time as the return a string version of mediaWiki.message
* Removed use of that variable in mediaWiki.loader, getting ready to make loader a prototyped object.
Trevor Parscal [Tue, 26 Oct 2010 23:47:09 +0000 (23:47 +0000)]
Improved comments, whitespace and simplicity.
Trevor Parscal [Tue, 26 Oct 2010 23:44:31 +0000 (23:44 +0000)]
Simplified extending of mediaWiki object
Trevor Parscal [Tue, 26 Oct 2010 23:40:26 +0000 (23:40 +0000)]
Introducing mediaWiki.language, and mediaWiki.message which are modeled after their PHP counterparts Language and wfMessage respectively.
Platonides [Tue, 26 Oct 2010 22:34:18 +0000 (22:34 +0000)]
Address my own CR in r75332.
Platonides [Tue, 26 Oct 2010 22:17:42 +0000 (22:17 +0000)]
Provide a proper implementation for passing environment variables to wfShellExec()
The quick fix of r74821 is no longer needed.
Platonides [Tue, 26 Oct 2010 21:42:49 +0000 (21:42 +0000)]
Keep maintenance/update.php php4 compatible up to the point where we can give a maeningful error. Check based in install_version_checks()
Follow up conversion to new maintenance format in r72539
Platonides [Tue, 26 Oct 2010 20:54:29 +0000 (20:54 +0000)]
Reorder to shortcut some more php_uname() calls.
Note that PHP 5.2.1 can't run on Windows 9x since it wouldn't be able to
link with the GetBinaryType() function (added in PHP r225464)
Trevor Parscal [Tue, 26 Oct 2010 20:17:32 +0000 (20:17 +0000)]
Fixes comment mistakes in r75107
Antoine Musso [Tue, 26 Oct 2010 20:16:19 +0000 (20:16 +0000)]
Follow up r75446 : use a default for --count
This also fix a division per zero error since $count was 0 and used to calculate average time.
Antoine Musso [Tue, 26 Oct 2010 20:09:58 +0000 (20:09 +0000)]
Follow up r75446 : simpler bench function, correct parenthesis.
Bryan Tong Minh [Tue, 26 Oct 2010 19:31:47 +0000 (19:31 +0000)]
Follow-up r75282
* Use addWhere instead of addWhereFld
* Don't add properties twice if there is a continue
* Add comments
Antoine Musso [Tue, 26 Oct 2010 17:21:35 +0000 (17:21 +0000)]
Follow up r75429 : benchmark for wfIsWindows();
Also implements a basic class to build new benchmarks.
Chad Horohoe [Tue, 26 Oct 2010 17:18:21 +0000 (17:18 +0000)]
Tweak UPGRADE, no longer need to move LocalSettings. Postgres caveat doesn't apply anymore
Sam Reed [Tue, 26 Oct 2010 17:12:58 +0000 (17:12 +0000)]
Followup r75431, bug 24853. Add to RELEASE-NOTES
Sam Reed [Tue, 26 Oct 2010 16:37:15 +0000 (16:37 +0000)]
Followup r75282, remove now unused class variables
Chad Horohoe [Tue, 26 Oct 2010 16:24:44 +0000 (16:24 +0000)]
Moving new-index.php to index.php. This is pretty much done and I can't see us backing this out of 1.17 at this point. The UI is still a little rough (hopefullly some work coming on that soon). mySQL, SQLite support is complete. Postgres is nearly complete, Oracle as well.
Wanted to get more feedback before we branch. Please see http://mediawiki.org/wiki/New-installer_issues for known problems and to report other things.
Chad Horohoe [Tue, 26 Oct 2010 16:24:17 +0000 (16:24 +0000)]
Make way for move
Platonides [Tue, 26 Oct 2010 15:14:56 +0000 (15:14 +0000)]
Cache the results of wfIsWindows()
Each php_uname() call produces a uname syscall.
The cached one is three times faster (3.
197545885) which is liklely to be the difference between a php var lookup and a syscall on my system.
== Test script ==
<?php
function wfIsWindows() {
if ( substr( php_uname(), 0, 7 ) == 'Windows' ) {
return true;
} else {
return false;
}
}
function wfIsWindowsCached() {
static $isWindows = null;
if ( $isWindows === null ) {
$isWindows = substr( php_uname(), 0, 7 ) == 'Windows';
}
return $isWindows;
}
$win = $nonwin = 0;
$time = microtime( true );
for ( $i = 1; $i < 5e8; $i++ ) {
if ( wfIsWindowsCached() ) {
$win++;
} else {
$nonwin++;
}
}
$time = microtime( true ) - $time;
echo "Time elapsed: $time\n";
Platonides [Tue, 26 Oct 2010 14:31:13 +0000 (14:31 +0000)]
Place into an else branch in the odd case where we are in safe_mode and passthru is additionally blocked.