Roan Kattouw [Wed, 7 Sep 2011 12:54:57 +0000 (12:54 +0000)]
Some comment and whitespace fixes
Roan Kattouw [Wed, 7 Sep 2011 12:48:51 +0000 (12:48 +0000)]
Break some tests intentionally to see how Jenkins displays that
Siebrand Mazeland [Wed, 7 Sep 2011 12:12:24 +0000 (12:12 +0000)]
Add constant Linker::TOOL_LINKS_EMAIL to allow adding a "send e-mail" link from Linker::
Add "send e-mail" link in user tools for developer details (Special:Code/Project/author/authorname) in CodeReview.
Sam Reed [Wed, 7 Sep 2011 12:00:58 +0000 (12:00 +0000)]
Documentation
Add explicit member variables
Trim trailing whitespace
Niklas Laxström [Wed, 7 Sep 2011 09:21:16 +0000 (09:21 +0000)]
Removed old constants: 1) not used 2) because of autoloader, they have not necessarily even been available for long time.
Alexandre Emsenhuber [Wed, 7 Sep 2011 08:29:18 +0000 (08:29 +0000)]
Pass the context to the HTMLForm object
Alexandre Emsenhuber [Wed, 7 Sep 2011 08:18:51 +0000 (08:18 +0000)]
Use local context instead of global variables
Robin Pepermans [Wed, 7 Sep 2011 05:23:16 +0000 (05:23 +0000)]
Per Krinke on r91772, do not use general float/align classes. I removed them in shared.css because they are recent and not widely used yet.
(I removed the vertical-align:bottom; because it is added by css for .collection-creatorbox-row img)
Robin Pepermans [Wed, 7 Sep 2011 04:05:37 +0000 (04:05 +0000)]
Per r90858 CR, throw MW exception on missing title context
Daniel Friesen [Wed, 7 Sep 2011 03:46:05 +0000 (03:46 +0000)]
Move h1-5 bottom margins to commonElements, common generic siteNotice styles and firstHeading to commonInterface.
Daniel Friesen [Wed, 7 Sep 2011 03:25:11 +0000 (03:25 +0000)]
Move the vector styles for the user login form into commonContent.css
The vector styles are very generic and fit well as the common style. With a minor tweak to MonoBook (which actually partially fixes a bug in the signup form on Wikipedia) this style fits in perfectly without conflicting with MonoBook's styles.
Russ Nelson [Wed, 7 Sep 2011 02:31:55 +0000 (02:31 +0000)]
restore proper operation of getArchive{Path|Url}
Daniel Friesen [Wed, 7 Sep 2011 01:12:00 +0000 (01:12 +0000)]
Followup r96217, slight regression use rawElement not element, accidentally caused the <a> to be htmlescaped.
Russ Nelson [Wed, 7 Sep 2011 01:09:23 +0000 (01:09 +0000)]
purgeThumbList() needn't always delete all the files in the thumb dir
Daniel Friesen [Wed, 7 Sep 2011 00:37:44 +0000 (00:37 +0000)]
Followup r92054, these should use css classes not ids.
Ben Hartshorne [Tue, 6 Sep 2011 23:21:39 +0000 (23:21 +0000)]
changed help text to indicate an optional port if nonstandard
Aaron Schulz [Tue, 6 Sep 2011 23:15:42 +0000 (23:15 +0000)]
Fixed typo in ipv6 private IP range list and added test (bug 30739)
Krinkle [Tue, 6 Sep 2011 23:09:04 +0000 (23:09 +0000)]
jquery.tablesorter.test: Add tests for data-sort-value
* Follows-up r86108
Roan Kattouw [Tue, 6 Sep 2011 22:17:01 +0000 (22:17 +0000)]
Fix parse error in r96275
Russ Nelson [Tue, 6 Sep 2011 21:51:25 +0000 (21:51 +0000)]
delete now-empty archived thumb directories
Chad Horohoe [Tue, 6 Sep 2011 21:01:42 +0000 (21:01 +0000)]
(bug 30192) Thumbnails of archived images don't get deleted. Patch by Russ and Sam, with minor tweaks by me.
Chad Horohoe [Tue, 6 Sep 2011 20:51:10 +0000 (20:51 +0000)]
Followup r96369: update child classes and a few callers
Chad Horohoe [Tue, 6 Sep 2011 20:44:03 +0000 (20:44 +0000)]
Fixme on r85888: boolean params are evil, use a nice simple string instead :)
Jeroen De Dauw [Tue, 6 Sep 2011 20:31:51 +0000 (20:31 +0000)]
doc fix
Raimond Spekking [Tue, 6 Sep 2011 20:24:15 +0000 (20:24 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Tue, 6 Sep 2011 19:28:27 +0000 (19:28 +0000)]
Fix trailing whitespaces
Sam Reed [Tue, 6 Sep 2011 19:20:20 +0000 (19:20 +0000)]
-rakkaus/#mediawiki-i18n- [06-Sep-2011 19:12:04] PHP Fatal error: Call to a member function titleAttrib() on a non-object in /www/w/includes/SkinTemplate.php on line 1538
Ryan Lane [Tue, 6 Sep 2011 18:45:36 +0000 (18:45 +0000)]
Set wsDomain based on the user's session, if domain is set in the session. When users use the password change function in their preferences a domain isn't passed, it's assumed to be in their session.
Aaron Schulz [Tue, 6 Sep 2011 18:11:53 +0000 (18:11 +0000)]
Cleanup to r84610 per CR: changed BeforeParserMakeImageLinkObj hook to use a RepoGroup style param array that also excepts a 'broken' parameter. This new parameter replaces the odd "use timestamp '0' to make a broken thumbnail' convention. No other callers are using this hook other than FR, so the old time/sha1 params where removed.
Aaron Schulz [Tue, 6 Sep 2011 18:02:44 +0000 (18:02 +0000)]
Sanity check report size to avoid division by zero
Max Semenik [Tue, 6 Sep 2011 16:47:05 +0000 (16:47 +0000)]
Fix for r96344: explicitly set $wgExtensionAssetsPath during tests
Sam Reed [Tue, 6 Sep 2011 15:45:43 +0000 (15:45 +0000)]
Followup r95458
Add a couple of bits of documentation
Removed an unused global
No need to 1.18 this
Daniel Friesen [Tue, 6 Sep 2011 15:27:42 +0000 (15:27 +0000)]
Small MonoBook cleanup:
* Eliminate the unnecessary ->skin and $skin, $this->skin is only used in one spot and we have getSkin()
* Linker::tooltipAndAccesskeyAttribs isn't &, don't + it to an empty array(), just use a short inline array instead of this var
* Elimiate all this unnecessary code in cactions and just use makeListItem. It's shorter, outputs everything this code does, AND it outputs rel="archive" on history which was missing from MonoBook.
Sam Reed [Tue, 6 Sep 2011 15:23:26 +0000 (15:23 +0000)]
Fix Undefined index: showSizeDiff in /www/w/includes/specials/SpecialContributions.php on line 129
Followup r96306
Max Semenik [Tue, 6 Sep 2011 15:20:07 +0000 (15:20 +0000)]
Even on Windows, some people have diff ;)
Chad Horohoe [Tue, 6 Sep 2011 14:46:58 +0000 (14:46 +0000)]
Merge ParserTestStaticParserHook into ParserTestParserHook since they practically do the same thing.
Robin Pepermans [Tue, 6 Sep 2011 14:08:13 +0000 (14:08 +0000)]
Add new messages of r96311 to messages.inc
Robin Pepermans [Tue, 6 Sep 2011 14:04:30 +0000 (14:04 +0000)]
Fix wording of r96312 and a few other release notes
Alexandre Emsenhuber [Tue, 6 Sep 2011 13:17:22 +0000 (13:17 +0000)]
Use $this->mAttribs['rc_old_len'] and $this->mAttribs['rc_new_len'] instead of $this->mExtra['oldSize'] and $this->mExtra['newSize']
Chad Horohoe [Tue, 6 Sep 2011 12:39:47 +0000 (12:39 +0000)]
Cleanup to r95402, r95474: "Not using CamelCase is so 2001."
Alexandre Emsenhuber [Tue, 6 Sep 2011 12:23:47 +0000 (12:23 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
Niklas Laxström [Tue, 6 Sep 2011 11:14:34 +0000 (11:14 +0000)]
Generic class cannot really wrap around mysql method..
Robin Pepermans [Tue, 6 Sep 2011 00:04:02 +0000 (00:04 +0000)]
release notes for r96311
Robin Pepermans [Tue, 6 Sep 2011 00:01:06 +0000 (00:01 +0000)]
(bug 23057) Importers can 'edit' or 'create' a fully-protected page by importing a new revision into it
Krinkle [Mon, 5 Sep 2011 23:10:33 +0000 (23:10 +0000)]
mediawiki.html: Attribute values may also be numbers (rather than boolean or string). Just make sure that whatever is passed becomes a string (not using .toString as not everything has a toString method)
* Follows-up r96307
Krinkle [Mon, 5 Sep 2011 21:53:20 +0000 (21:53 +0000)]
release-notes for r96307
Krinkle [Mon, 5 Sep 2011 21:51:04 +0000 (21:51 +0000)]
mediawiki.html: mediawiki.html: Add support for numbers and booleans
* Tests introduced in r96305 work now
* (bug 30774) - mediawiki.html: Add support for numbers and booleans
--
* Removed unneeded value-attribute in one the tests
* Changed if-else intro a switch. (to avoid calling the typeof operator multiple times and making the code a bit more readable)
Roan Kattouw [Mon, 5 Sep 2011 21:47:28 +0000 (21:47 +0000)]
Revert r88008 (add size difference to Special:Contributions) and its large group of friends, they break Special:Contributions by joining against recentchanges and dropping any contribs that have fallen off RC. See also CR discussion at r95496, which was Sam's incomplete attempt at reverting this.
Follow-ups reverted: r88019, r88024, r88111, r88117, r88252, r96081. Left the parts of r88025 and r88026 (everything except the MessagesEn.php change) that disable the namespace filter in miser mode intact; that was a good change and not really related to the r88008 other than that it touched nearby code.
Krinkle [Mon, 5 Sep 2011 21:25:48 +0000 (21:25 +0000)]
mediawiki.html: Add broken tests for numbers and booleans
* The following are broken right now:
mw.html.element( 'p', {}, 500 );
> Error: mw.html.element: Invalid type of contents
(custom error by mw.html.element)
mw.html.element( 'option', { selected: foo === bar }, 'label' );
> TypeError: Undefined method .replace
(bug 30774) - mediawiki.html: Add support for numbers and booleans
Alexandre Emsenhuber [Mon, 5 Sep 2011 21:01:39 +0000 (21:01 +0000)]
Deleted incorrect svn:executable properties
Raimond Spekking [Mon, 5 Sep 2011 20:53:36 +0000 (20:53 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Mon, 5 Sep 2011 20:48:14 +0000 (20:48 +0000)]
Call Linker method statically; also changed it to linkKnown()
Daniel Friesen [Mon, 5 Sep 2011 19:30:11 +0000 (19:30 +0000)]
Another thing that's been bothering me, skins shouldn't have to access $wgSitenotice directly when we have a logopath.
Roan Kattouw [Mon, 5 Sep 2011 19:29:20 +0000 (19:29 +0000)]
Don't use $wgServer (potentially protocol-relative!) in the password reset e-mail. The documentation calls for $4 to be "the base URL of the wiki" and the code was using $wgServer . $wgScript which produces the URL to index.php , so I decided to use the URL to the Main Page instead. This avoids using globals and doesn't suffer from mixed URL structure issues on secure.wm.o
Robin Pepermans [Mon, 5 Sep 2011 18:37:50 +0000 (18:37 +0000)]
Partially revert/fix r96295: only use Gothic script per Siebrand
Robin Pepermans [Mon, 5 Sep 2011 18:14:27 +0000 (18:14 +0000)]
* Split MessagesGot file into Latin and Gothic script files; add usable messages from gotwiki
* Add usable messages from bmwiki to MessagesBm
* Rebuilt these files
Robin Pepermans [Mon, 5 Sep 2011 16:03:31 +0000 (16:03 +0000)]
Add missing authors to message files that were in the past imported/copied from the respective Wikipedias
Add one message to ks-arab/ks-deva from kswiki
Daniel Friesen [Mon, 5 Sep 2011 15:30:01 +0000 (15:30 +0000)]
Pass the key for the skin being created to the constructor of a skin. This is just something that's been bothering me for awhile, without this it's hard to create extensions that dynamically load skins and implement the skin conversion functionality in a central class.
Daniel Friesen [Mon, 5 Sep 2011 15:25:20 +0000 (15:25 +0000)]
Add a new RequestContext::newExtraneousContext() to create a context filled with data not derived from the current session. Also modify setLang to accept a language code.
Roan Kattouw [Mon, 5 Sep 2011 11:23:49 +0000 (11:23 +0000)]
Stylize Export.php
Roan Kattouw [Mon, 5 Sep 2011 11:22:57 +0000 (11:22 +0000)]
Whitespace fixes for r95272, r95604
Roan Kattouw [Mon, 5 Sep 2011 11:16:09 +0000 (11:16 +0000)]
Fixes for r95260:
* Use protected instead of var
* Move documentation of closeRenameAndReopen() to parent class. Add a TODO for the other undocumented methods introduced in r95260
* Use the correct method name in the exceptions by using __METHOD__; messages were copypasted from one method to the other without changing anything. Also fix a typo ("argumnts")
* Minor coding style bit, will commit more style fixes in a minute
Roan Kattouw [Mon, 5 Sep 2011 10:55:54 +0000 (10:55 +0000)]
Followup r96180: remove unused global $wgCanonicalServer
Daniel Friesen [Mon, 5 Sep 2011 08:31:51 +0000 (08:31 +0000)]
Followup r96180, I can't believe I did't notice I accidentally killed the hook name.
While I'm at it, add missing $variant parameters to every 'Get*URL' hook in Title.
Tim Starling [Mon, 5 Sep 2011 06:56:08 +0000 (06:56 +0000)]
Reverted r84357 and r90461 and fixed the bug in a better way: in an empty document, consider section zero to exist, and to be empty, effectively representing the whole document. This allows section zero of a blank page to be viewed and edited with no updates to EditPage.
Antoine Musso [Mon, 5 Sep 2011 06:28:36 +0000 (06:28 +0000)]
(bug 26470) add checkered background on files pages
Robin Pepermans [Mon, 5 Sep 2011 02:02:59 +0000 (02:02 +0000)]
(bug 27295) Some corrections to the default main page text
Robin Pepermans [Mon, 5 Sep 2011 00:56:54 +0000 (00:56 +0000)]
(bug 30679) Some installer fields should always be LTR
Patch by Amir E. Aharoni (some whitespace fixes)
Robin Pepermans [Sun, 4 Sep 2011 22:05:56 +0000 (22:05 +0000)]
Fix r96261: don't add important if 'none', so it doesn't break underlining on hover
Robin Pepermans [Sun, 4 Sep 2011 21:50:02 +0000 (21:50 +0000)]
* Mark underline css as !important. It should override other css (such as the css added in r91432) if the user specifically selected that option.
* Fix css flipping: for Simple, it still depended on the content language (however, no css actually needs flipping there). For Standard/CologneBlue, I re-added flipping even though it's not needed there either. Just in case css is added that does need flipping, so it is future-proof :). Consequently, I added noflip to the existing css.
* For this flipping I added a parameter to addInlineStyle(), which I assume to be useful in other cases as well
Sam Reed [Sun, 4 Sep 2011 21:40:17 +0000 (21:40 +0000)]
Trim trailing whitespace
Add/tweak/update documentation
Simplify some boolean returns
Robin Pepermans [Sun, 4 Sep 2011 21:22:51 +0000 (21:22 +0000)]
whoops, fix r96257
Robin Pepermans [Sun, 4 Sep 2011 21:19:18 +0000 (21:19 +0000)]
Correctly parse interface messages as such, so it doesn't get converted according to the content language (like r94395/r94279)
Krinkle [Sun, 4 Sep 2011 21:18:27 +0000 (21:18 +0000)]
Add documentation for r96170 and r96188.
Siebrand Mazeland [Sun, 4 Sep 2011 20:38:24 +0000 (20:38 +0000)]
Follow-up r96250: Remove messages from all core language files and populate InlineCategorizer.i18n.php.
Krinkle [Sun, 4 Sep 2011 19:35:22 +0000 (19:35 +0000)]
Split ajaxCategories away from core for now, into an extension:
* Move js/css/images from core into extension dir (kept svn history in tact)
* Removed from core:
** Messages
** Resource definition
** Default settings
* Recreated in extension:
** Messages with 'inlinecategorizer' prefix (instead of generic 'ajax' prefix).
** wgResourceModule definition
** Hooks for adding module to the page
** Setting wgAJAXCategoriesNamespaces kept (renamed to $wgInlineCategorizerNamespaces)
* Made minor adjustments to the messages:
** Fixed references to other messages (in /qqq) with the new message key
* Made minor adjustments to the javascript:
** Usage of mw.msg fixed to the new message keys
** Removed "@since 1.19"
** Removed "Relies on mw.user.getId" (because it didn't', and still doesn't)
** Object 'mw.ajaxCategories' -> 'mw.InlineCategorizer' (capitalized, since it's a constructor, per our conventions)
** Removed 'disableAJAXCategories' config, not needed.
Summary of justification for move out of core (again):
* Too many issues with the parsing logic (many cases still don't work yet)
* Almost untested and untestable because of mixing UI with logic code. Needs separation.
* See http://www.mediawiki.org/wiki/User:Krinkle/Extension_review/InlineCategorizer#Prequel
One day we might move it in, or if the "new parser" is ready and the "visual editor" we might not need it all together and it'd simply be a 10-20 line module in the visual editor (that, or it'd be part of the visual editor by default).
Anyway, I'm not against this module. if we can get this to an acceptable state soonish before any of the new parser / visual editor is ready, then I see no problem in bundling it with core and/or merging it into core.
Alexandre Emsenhuber [Sun, 4 Sep 2011 19:28:53 +0000 (19:28 +0000)]
Use local context instead of global variables
Raimond Spekking [Sun, 4 Sep 2011 19:01:32 +0000 (19:01 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Sun, 4 Sep 2011 17:04:09 +0000 (17:04 +0000)]
Add local generator function to account for revert of r93063 in r96236.
Krinkle [Sun, 4 Sep 2011 16:50:42 +0000 (16:50 +0000)]
Revert r93063 per r93063 CR
Robin Pepermans [Sun, 4 Sep 2011 16:09:58 +0000 (16:09 +0000)]
Mark $mDiffLang protected, and rename function to setTextLanguage per Nikerabbit on r92956
Robin Pepermans [Sun, 4 Sep 2011 15:30:27 +0000 (15:30 +0000)]
Add zh-min-nan, zh-yue, zh-classical to dummy language codes, and mention the "redirect destination" or purpose of each code.
Robin Pepermans [Sun, 4 Sep 2011 14:07:51 +0000 (14:07 +0000)]
Followup r87677 / r87676: add 'bh' to dummy language codes (and also, Bihari is not a macrolanguage but a group of languages, per ISO 639-3 terminology)
Robin Pepermans [Sun, 4 Sep 2011 13:56:11 +0000 (13:56 +0000)]
Explain what $wgDummyLanguageCodes does, and remove 'iu' from it as it should be selectable on the installer (it has a LanguageConverter so it should be possible to use that).
Robin Pepermans [Sun, 4 Sep 2011 13:22:16 +0000 (13:22 +0000)]
Add $rtl = true. It inherits this from the fallback 'ur' but it's better to mark it here as well.
Robin Pepermans [Sun, 4 Sep 2011 13:20:03 +0000 (13:20 +0000)]
Fix r94841: remove from 1.19 release notes, and update name in 1.18 release notes per r94831
Daniel Friesen [Sun, 4 Sep 2011 12:38:04 +0000 (12:38 +0000)]
Followup r87340: Post-hook swap bodytext into a new bodycontent key and append printfooter and debughtml to bodytext so that we get the same behaviour as before for skins, the advantage of letting extensions modify them separately, and let skins opt-in to the ability to display these separately.
Rotem Liss [Sun, 4 Sep 2011 07:08:13 +0000 (07:08 +0000)]
Localization update for he.
Sam Reed [Sat, 3 Sep 2011 22:50:44 +0000 (22:50 +0000)]
Set a HTTP 301 header in redirect.php
Upstream wikia change
Alexandre Emsenhuber [Sat, 3 Sep 2011 20:51:17 +0000 (20:51 +0000)]
Use local context instead of global variables
Max Semenik [Sat, 3 Sep 2011 20:14:17 +0000 (20:14 +0000)]
rv r89483 per CR
Aaron Schulz [Sat, 3 Sep 2011 19:21:31 +0000 (19:21 +0000)]
Fixed rightslogentry-autopromote qqq entry
Siebrand Mazeland [Sat, 3 Sep 2011 14:53:15 +0000 (14:53 +0000)]
(bug 30455) Use "undisclosed" instead of "unspecified" in the gender options.
Daniel Friesen [Sat, 3 Sep 2011 14:36:58 +0000 (14:36 +0000)]
Expand r96170's support for space separated attributes with support for boolean keys such as array( 'class' => array( 'selected' => true ) ) to match our array( 'checked' => false ) support.
As per discussion with Krinkle make sure that in array( 'foo', 'foo' => false, 'foo' ) the 'foo' key is authoritive.
Raimond Spekking [Sat, 3 Sep 2011 13:52:53 +0000 (13:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net
ParserFunctions skipped today.
Daniel Friesen [Sat, 3 Sep 2011 13:46:56 +0000 (13:46 +0000)]
Crack down on arguments inside the Linker that call themselves $text but in reality are unescaped html.
Philip Tzou [Sat, 3 Sep 2011 13:41:17 +0000 (13:41 +0000)]
Update zh conversion tables, remove unused/incorrect rules.
Daniel Friesen [Sat, 3 Sep 2011 13:17:55 +0000 (13:17 +0000)]
Use wfExpandUrl+PROTO_CANONICAL inside of getCanonicalURL instead of just prepending the url so this does not break on interwiki and action=render
Philip Tzou [Sat, 3 Sep 2011 13:12:42 +0000 (13:12 +0000)]
Update Chinese conversion tables.
Siebrand Mazeland [Sat, 3 Sep 2011 11:34:55 +0000 (11:34 +0000)]
Update whitespace and a comment.