Chad Horohoe [Wed, 1 Nov 2017 18:29:43 +0000 (11:29 -0700)]
Clean up "bad parameter" error messages in Message handler
Change-Id: I64b54b1991d17ae97a8dd9414d6807daab982a3a
jenkins-bot [Wed, 1 Nov 2017 17:48:19 +0000 (17:48 +0000)]
Merge "resourceloader: Remove outdated readyState handler for base modules request"
jenkins-bot [Wed, 1 Nov 2017 17:20:03 +0000 (17:20 +0000)]
Merge "Put page_is_new back into ContribsPager query"
jenkins-bot [Wed, 1 Nov 2017 16:03:14 +0000 (16:03 +0000)]
Merge "RCFilters: Move label prefixes from dm.ItemModel to ui.TagItemWidget"
jenkins-bot [Wed, 1 Nov 2017 15:58:01 +0000 (15:58 +0000)]
Merge "Remove Media namespace from the list of RCFilters"
jenkins-bot [Wed, 1 Nov 2017 15:53:41 +0000 (15:53 +0000)]
Merge "RCFilters: HTML-escape tag names in filter capsules"
Brad Jorsch [Thu, 12 Oct 2017 20:00:52 +0000 (16:00 -0400)]
Add deprecation notices for selectFields() methods deprecated in Idcfd1556
Now that WMF-deployed extensions have been updated to no longer call
them.
Change-Id: I04942ca1b95baa2126f2dcf4d0975536f4dd07c7
Depends-On: I300130c7b952a353ac28989d39d7f01366da2a37
Depends-On: Ia81bf6a655af800ce8ac19940d851e65746e1f77
Depends-On: I0d869aacaaad85cdd34361a611ac8348bdbb757d
Depends-On: I7b05a99e23da296a673eb0bd34f18344618c8be3
Depends-On: I42237e8e29497bbc56606f6ad01de3d525bf8b2a
Depends-On: If75d2e76c2f166bc40a544dd502da43171ce1e7b
Depends-On: I401809d2638b11e6c77a318fc8fbbc41fa639083
Depends-On: I5d62ad76fdb64a9c6efd228f27e9b5f512f17d5e
Depends-On: I488afaa991e3d26b638a4f588f70db455959eadf
Depends-On: Ibe82dadb0f2d1c5dbc38b96731c6e443c5469ff0
Depends-On: Id25b86dd415e2e3c6190a91faee2a3b815e50f61
Brad Jorsch [Wed, 1 Nov 2017 14:02:15 +0000 (10:02 -0400)]
Put page_is_new back into ContribsPager query
Accidentally removed in Idcfd15568.
Bug: T179467
Change-Id: I0a26da37638352d4a4dca08c0ef3eb9f99c7100a
petarpetkovic [Wed, 1 Nov 2017 11:52:54 +0000 (12:52 +0100)]
Remove Media namespace from the list of RCFilters
Bug: T176990
Change-Id: I3c5b65244fd6b2782dea0404fe3671407fbb99e6
jenkins-bot [Wed, 1 Nov 2017 10:49:44 +0000 (10:49 +0000)]
Merge "RCFilters: Change main entry point text"
petarpetkovic [Wed, 1 Nov 2017 10:00:04 +0000 (11:00 +0100)]
RCFilters: Spell out Tags and Namespaces labels
- Provide Tags and Namespaces menus with labels where the icons now are,
in order to increase discoverability.
Bug: T178539
Change-Id: I2101898d10043ef45d7636f6676d8f1f51b9db58
petarpetkovic [Wed, 1 Nov 2017 09:01:08 +0000 (10:01 +0100)]
RCFilters: Change main entry point text
Bug: T178069
Change-Id: I52c41a795ca76af9c645cb35266ccebe32a8f1fa
jenkins-bot [Wed, 1 Nov 2017 01:30:08 +0000 (01:30 +0000)]
Merge "resources: Remove deprecated 'mediawiki.widgets.CategorySelector' module alias"
jenkins-bot [Wed, 1 Nov 2017 01:19:16 +0000 (01:19 +0000)]
Merge "resources: Remove deprecated 'jquery.appear' module"
jenkins-bot [Wed, 1 Nov 2017 01:19:12 +0000 (01:19 +0000)]
Merge "resources: Remove deprecated 'jquery.placeholder' module"
jenkins-bot [Wed, 1 Nov 2017 01:19:08 +0000 (01:19 +0000)]
Merge "Add statsd metric support to WANObjectCache"
jenkins-bot [Wed, 1 Nov 2017 01:04:48 +0000 (01:04 +0000)]
Merge "resources: Remove deprecated 'jquery.autoEllipsis' module"
Jonathan [Thu, 17 Aug 2017 21:13:23 +0000 (21:13 +0000)]
search: Hyphen to dash for range in results message
Change-Id: I0ace65b08a21b4024f7c9825173dc17b7f408d3d
James D. Forrester [Wed, 25 Oct 2017 19:41:29 +0000 (12:41 -0700)]
resources: Remove deprecated 'mediawiki.widgets.CategorySelector' module alias
Change-Id: I28557186a6cfe45b2a378f06ca59848be3f8e781
James D. Forrester [Wed, 25 Oct 2017 19:39:26 +0000 (12:39 -0700)]
resources: Remove deprecated 'jquery.appear' module
Change-Id: Ifce63eb64c94203acb049d3f588e75f18123f12e
James D. Forrester [Wed, 25 Oct 2017 19:38:18 +0000 (12:38 -0700)]
resources: Remove deprecated 'jquery.placeholder' module
Change-Id: I1f14561e54df477067460411ff155e3f2eeb167a
James D. Forrester [Wed, 25 Oct 2017 19:34:32 +0000 (12:34 -0700)]
resources: Remove deprecated 'jquery.autoEllipsis' module
Change-Id: Ib181b814953bac0153dead95a25040ed2d4ca7ca
jenkins-bot [Wed, 1 Nov 2017 00:13:50 +0000 (00:13 +0000)]
Merge "resources: Remove the deprecated 'jquery.badge' module"
James D. Forrester [Tue, 31 Oct 2017 22:49:11 +0000 (15:49 -0700)]
Update OOjs UI to v0.24.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.1
Depends-On: I9ebdc86488c4eda7c524fb6004ea6a124a63d7ab
Change-Id: Ia6332cc6bd7ae6e99bfe68043b0510a8bd483668
Translation updater bot [Tue, 31 Oct 2017 20:55:46 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I522e124758e4aecddc5dc36024b3df1ca8891067
jenkins-bot [Tue, 31 Oct 2017 20:09:30 +0000 (20:09 +0000)]
Merge "EditPage: Extract some edit conflict code into EditConflictHelper"
jenkins-bot [Tue, 31 Oct 2017 09:22:39 +0000 (09:22 +0000)]
Merge "Prefer using plaintextParams instead of rawParams where possible"
Timo Tijhof [Tue, 31 Oct 2017 02:16:52 +0000 (19:16 -0700)]
resourceloader: Remove outdated readyState handler for base modules request
There is a bug in IE10 where under certain conditions[1], the browser will
fire 'onreadystatechange' on script tags before the script has executed.
To avoid this bug, simply remove this outdated compatibility code. It was
originally placed in startup.js in 2011 for compatibility with IE6-8, and
was inspired by the internal source code behind jQuery's ajax transport for
script tags.
jQuery no longer does this either and uses 'script.onload' in all browsers,
which is supported by IE 9 and above. MediaWiki currently requires IE 10
for its Grade A experience.
Looking further, it actually seems that Microsoft has now retroactively
documented that readyState="loaded" in IE6-10, for script tags, represents
the completion of the download, not the execution. [2] Presumably the reason
we did not find this bug earlier is because of the rare conditions [1], and
because even then, on most page views, readyState="loaded" is never fired.
Instead, usually the event is skipped by IE and the first and only readyState
event is readyState="complete".
[1] The conditions are: A relatively short HTML page, with a script from
<script async href=".."> that in turn appends a dynamic script tag, where
the <script async> is followed by a <link rel=stylesheet> that is relatively
large/complex (possibly due to use of cross-domain @imports, not sure).
[2] https://connect.microsoft.com/IE/feedback/details/729164/ie10-dynamic-script-element-fires-loaded-readystate-prematurely
Bug: T178943
Change-Id: Id3de61515e4701a7ef59e4a4d8643a0e09f8f589
jenkins-bot [Mon, 30 Oct 2017 23:42:35 +0000 (23:42 +0000)]
Merge "build: Upgrade grunt-stylelint"
Brad Jorsch [Fri, 6 Oct 2017 17:03:55 +0000 (13:03 -0400)]
Replace selectFields() methods with getQueryInfo()
Several classes have a "selectFields()" static method to tell callers
which fields to select from the database. With the recent comment table
change and the upcoming actor table change, this pattern has become too
simplistic as a SELECT will need to join several tables to be able to
retrieve all the needed fields.
Thus, we deprecate the selectFields() methods in favor of getQueryInfo()
methods that return tables and join conditions in addition to the
fields.
Change-Id: Idcfd15568489d9f03a7ba4460e96610d33bc4089
Ed Sanders [Mon, 30 Oct 2017 21:49:12 +0000 (21:49 +0000)]
build: Upgrade grunt-stylelint
Change-Id: I4c47f1d290802705d061167fe369c130405512e0
James D. Forrester [Thu, 26 Oct 2017 21:15:51 +0000 (14:15 -0700)]
resources: Mark MediaWiki.UI as deprecated.
Change-Id: Idd5f898c1b596040be8d14dee0a9893b59d6a532
James D. Forrester [Wed, 25 Oct 2017 19:53:56 +0000 (12:53 -0700)]
build: Bump karma devDependencies to latest
karma 1.5.0 → 1.7.1
karma-chrome-launcher 2.0.0 → 2.2.0
karma-mocha-reporter 2.2.3 → 2.2.5
nodemw 0.10.1 → 0.11.0
qunitjs 2.4.0 → 2.4.1
Change-Id: I1e06189a12fbbc1d62781a4636f192c5b7078c1a
jenkins-bot [Mon, 30 Oct 2017 21:43:51 +0000 (21:43 +0000)]
Merge "build: Bump eslint devDependencies to latest"
Translation updater bot [Mon, 30 Oct 2017 20:59:30 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I647e1c0b0bf533b1918b8ab7404676e86e9ace74
jenkins-bot [Mon, 30 Oct 2017 16:08:29 +0000 (16:08 +0000)]
Merge "Article: Show moveddeleted on 404s for all pages if the user has a session"
Brian Wolff [Fri, 27 Oct 2017 14:26:33 +0000 (14:26 +0000)]
Prefer using plaintextParams instead of rawParams where possible
Using Message::rawParams() is something that should immediately
jump out as scary. While it's perfectly safe to do something like
wfMessage( 'foo' )->rawParams( $userControlledVar )->text() and
escape later, mixing the safe type of rawParams with the
dangerous type makes it more likely someone will miss something
when checking for security.
To reduce the likelyhood of confusion, prefer ->plaintextParams
for such cases, as it can be seen to be safe at a glance.
Change-Id: Ib067eb08ec934779ae743751306f1a0397bdf71c
jenkins-bot [Mon, 30 Oct 2017 15:21:59 +0000 (15:21 +0000)]
Merge "No longer special case 'patrol' in $wgFilterLogTypes"
vinithegit [Mon, 30 Oct 2017 12:30:37 +0000 (18:00 +0530)]
Article: Show moveddeleted on 404s for all pages if the user has a session
Add a check for user session and show movedelete message for this case as well.
Bug: T178099
Change-Id: Id42f27a19e85b608a734c7fedb4e016d8cdc163e
Bryan Davis [Wed, 27 Jan 2016 17:26:42 +0000 (10:26 -0700)]
Support language fallbacks for Special:MyLanguage
Add fallback lookup based on the interface language to
Special:MyLanguage. Lookup order:
<user lang> -> <explicit lang> -> <fallback lang(s)> -> <base>
Example when the user's lang is arz:
arz -> <explicit lang> -> ar -> en -> <base>
Bug: T50292
Change-Id: I245cab71fdd4b4585f86dde808493cd69841b09a
Translation updater bot [Sun, 29 Oct 2017 20:54:39 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I2a9bd114c751283b554f79e576168a78cf700cfd
Translation updater bot [Sat, 28 Oct 2017 19:55:02 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I248dd76bd1d4ed220a09573916ba99ec73f225d0
Brian Wolff [Sat, 14 Oct 2017 03:20:10 +0000 (03:20 +0000)]
No longer special case 'patrol' in $wgFilterLogTypes
Previously, if you did not have the right to patrol/view patrolmarks,
you were not allowed to filter Special:Log to remove autopatrol
entries.
Now if wikiadmins want to disable the filtering, they have to
directly change the config value.
This was stupid because:
* Users without patrol rights are just as likely to not care about
autopatrol spam as users with the priv.
* Sometimes wikiadmins want to hide old patrol log entries even
after they disabled the patrol feature.
It should be noted there have been two previously attempts at fixing
this issue that didn't go anywhere:
* I9de17fc197a06402a4999a9fb792b86657641f76
* I88448ca0f09069943fd514a5b8213dfdafa57299
Bug: T44246
Change-Id: I590db72c169f3a9ad96c710f088923419d40e48d
Chad Horohoe [Thu, 26 Oct 2017 19:24:17 +0000 (12:24 -0700)]
Group XMP parse failures by exception message
Change-Id: I2bba40ded5c90f2e19a32bb5540e3c441b605da6
jenkins-bot [Fri, 27 Oct 2017 20:19:42 +0000 (20:19 +0000)]
Merge "rdbms: Group disconnect/reconnect errors by DB server name"
Chad Horohoe [Thu, 26 Oct 2017 20:43:49 +0000 (13:43 -0700)]
rdbms: Group disconnect/reconnect errors by DB server name
Still allow varying on stacktrace, as those are interesting
Change-Id: I62bc3f68fcbe43532dce849d515a5e0620fba6f2
Translation updater bot [Fri, 27 Oct 2017 19:54:08 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I5824c8668527b63f942ca56da1c6d886adce2ae7
jenkins-bot [Fri, 27 Oct 2017 18:06:14 +0000 (18:06 +0000)]
Merge "build: Update stylelint"
jenkins-bot [Fri, 27 Oct 2017 14:43:28 +0000 (14:43 +0000)]
Merge "MediaWiki\Shell: log stderr"
Brian Wolff [Fri, 27 Oct 2017 08:30:48 +0000 (08:30 +0000)]
Html escape the timestamp in Special:Undelete
Change-Id: I377effe4050d961ec6295a9fe684e4ff6a71bc77
Ed Sanders [Fri, 27 Oct 2017 12:31:41 +0000 (13:31 +0100)]
build: Update stylelint
Change-Id: I5a0ccb26a54109e641fd121c6427a71e82e05c74
Roan Kattouw [Fri, 27 Oct 2017 05:07:11 +0000 (10:37 +0530)]
RCFilters: Move label prefixes from dm.ItemModel to ui.TagItemWidget
Change-Id: I0d463b60ffaa7ab099cb46eeac94b709af325933
Roan Kattouw [Wed, 25 Oct 2017 09:09:05 +0000 (14:39 +0530)]
RCFilters: HTML-escape tag names in filter capsules
Bug: T178975
Change-Id: I9544a675fa2801bdb5d7de3ebd162a4214de740f
Gergő Tisza [Mon, 23 Oct 2017 08:29:20 +0000 (01:29 -0700)]
MediaWiki\Shell: log stderr
Change-Id: I1495fe2aba10102d7e36c3a3e5fdabf97f14546b
jenkins-bot [Fri, 27 Oct 2017 00:03:11 +0000 (00:03 +0000)]
Merge "mw.widgets.DateInputWidget: Fix unexpected MMMMM or ddddd date format"
Liangent [Tue, 24 Oct 2017 21:29:57 +0000 (21:29 +0000)]
mw.widgets.DateInputWidget: Fix unexpected MMMMM or ddddd date format
In some locale data in moment.js such as zh, llll date format already
uses MMMM and dddd. The original attempt to expand MMM to MMMM and ddd
to dddd inadvertently expands MMMM to MMMMM and dddd to ddddd, which is
then interpreted as MMMM or dddd followed by an unexpected single M or d.
Change-Id: I2634dfbaaf9615a13dce7b8f4ba3c3bea6863a91
jenkins-bot [Thu, 26 Oct 2017 22:44:23 +0000 (22:44 +0000)]
Merge "CheckBlocksSecondaryAuthenticationProvider: Avoid user language during auto-creation"
James D. Forrester [Wed, 25 Oct 2017 19:52:10 +0000 (12:52 -0700)]
build: Bump eslint devDependencies to latest
eslint 3.12.2 → 4.9.0
grunt-eslint 20.0.0 → 20.1.0
Change-Id: I7eb9964fb5d163c5bbcef850f62383cbceb59287
Translation updater bot [Thu, 26 Oct 2017 19:54:25 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1314aff11d814fe14dd72987ea4c67f273a801fb
jenkins-bot [Thu, 26 Oct 2017 18:50:53 +0000 (18:50 +0000)]
Merge "Refactor some Installer code into ExecutableFinder"
jenkins-bot [Thu, 26 Oct 2017 18:48:41 +0000 (18:48 +0000)]
Merge "Add Unicode to ICU mappings for versions 58 and 59"
Kunal Mehta [Fri, 20 Oct 2017 07:36:03 +0000 (00:36 -0700)]
Refactor some Installer code into ExecutableFinder
Refactor Installer::locateExecutableInDefaultPaths() into a separate
utility class, ExecutableFinder. This class is already used in plenty of
places outside of the installer, so it's ripe for being extracted.
This class is located in utils/ due to the dependency upon
Shell::command(). Once that no longer has a dependence upon MediaWiki,
this class can be moved to libs/ too.
Change-Id: I175465acc0d64f990445ce05fabcee8b88a0b259
Chad Horohoe [Thu, 26 Oct 2017 17:33:42 +0000 (10:33 -0700)]
Group Swift metadata errors by making $path a parameter
Change-Id: I3beb3743e1d13b06a9110c44f84fdc8d1b193137
jenkins-bot [Thu, 26 Oct 2017 17:22:40 +0000 (17:22 +0000)]
Merge "Add test for Revision::insertOn"
jenkins-bot [Thu, 26 Oct 2017 17:20:44 +0000 (17:20 +0000)]
Merge "Refactor BlockTest"
Brad Jorsch [Thu, 26 Oct 2017 16:22:01 +0000 (12:22 -0400)]
Remove Article static methods deprecated in 1.24
The Article::selectFields(), Article::onArticleCreate(),
Article::onArticleDelete(), and Article::onArticleEdit() methods have
been deprecated in favor of the correponding WikiPage methods since
1.24. Remove them.
Change-Id: I30f3d88f8d28ccaebf5a858058e183112d29a1a7
addshore [Thu, 26 Oct 2017 12:03:43 +0000 (13:03 +0100)]
Add test for Revision::insertOn
The success test indicates a change in behaviour
of the insertOn method once
I4f24e7fbb683cb51f3fd8b250732bae9c7541ba2
is applied.
Change-Id: I987d64c5bc3788b7d6b0a858ff39e97fae38de3c
jenkins-bot [Thu, 26 Oct 2017 10:06:51 +0000 (10:06 +0000)]
Merge "RawAction: Add json to the allowed content types"
Kunal Mehta [Fri, 22 Sep 2017 11:48:27 +0000 (04:48 -0700)]
EditPage: Extract some edit conflict code into EditConflictHelper
Extensions with custom content models (e.g. ProofreadPage) will extend
EditPage to provide a customized editing experience. However when
another extension like TwoColConflict wants to change just how edit
conflicts look, this causes problems since only one class can take the
place of EditPage.
So instead, split most of the frontend code for edit conflicts into
TextConflictHelper, and call it from edit page. Extensions can override
with the instance created by calling
EditPage::setEditConflictHelperFactory().
And to make that split possible also move EditPage::addNewLineAtEnd()
and ::buildTextboxAttribs() into a separate TextboxBuilder class that
both EditPage and TextConflictHelper can use.
Bug: T176393
Change-Id: Ie415edd84329c02d5762477f8a171fced85b01a2
Reedy [Wed, 25 Oct 2017 22:42:28 +0000 (23:42 +0100)]
Add Unicode to ICU mappings for versions 58 and 59
Change-Id: I87a5e6ce3a44a2be1e6bf8adf2f98cd0a4745574
jenkins-bot [Wed, 25 Oct 2017 22:03:09 +0000 (22:03 +0000)]
Merge "Remove unused mediawiki.ui 'checked' icons"
James D. Forrester [Mon, 23 Oct 2017 17:52:33 +0000 (10:52 -0700)]
resources: Remove the deprecated 'jquery.badge' module
Bug: T178450
Change-Id: I4540e5959ea15323b1f54be51fbeea6ca3f35169
Depends-On: I78543abe412d04d61a05e76702cb7681d5fad61d
Translation updater bot [Wed, 25 Oct 2017 19:54:46 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic741440ded2718acbe29973af639442eb722d0ff
addshore [Wed, 25 Oct 2017 17:22:32 +0000 (18:22 +0100)]
Refactor BlockTest
Something is holding state and interfering with
RevisionUnitTest from within BlockTest
as seen in I4f24e7fbb683cb51f3fd8b250732bae9c7541ba2
PS30
Change-Id: I5b779941385eb88e560dd2c63a8aea356804c806
jenkins-bot [Wed, 25 Oct 2017 17:09:16 +0000 (17:09 +0000)]
Merge "HistoryPager: Add missing $tagFilter property"
addshore [Wed, 25 Oct 2017 09:04:25 +0000 (10:04 +0100)]
HistoryPager: Add missing $tagFilter property
Change-Id: Iec2d944d5583eb13fa9383c0a6a183b550f60aab
James D. Forrester [Wed, 25 Oct 2017 15:42:38 +0000 (08:42 -0700)]
Article: Drop partial purge code and constants, deprecated in 1.29
Change-Id: I4f20d823e6c9206121212b8a73ecc28f91e68b45
jenkins-bot [Wed, 25 Oct 2017 15:28:10 +0000 (15:28 +0000)]
Merge "Rename some cache keys with odd virtual hierarchies"
jenkins-bot [Wed, 25 Oct 2017 15:28:07 +0000 (15:28 +0000)]
Merge "Make runJobs.php treat --json value as case insensitive"
jenkins-bot [Wed, 25 Oct 2017 15:24:03 +0000 (15:24 +0000)]
Merge "API: Include setupSkinUserCss in prop=modules for useskin mode"
jenkins-bot [Wed, 25 Oct 2017 15:24:00 +0000 (15:24 +0000)]
Merge "API: Add tests for useskin parameter of ApiParse"
Volker E [Wed, 25 Oct 2017 07:59:22 +0000 (00:59 -0700)]
Remove unused mediawiki.ui 'checked' icons
Removing unused mediawiki.ui 'checked' image, which was in use before
the switch to the unified checkbox with blue and white appearance.
Change-Id: I4ba88583a2ed59b44a1f7bbffe823468af8e3874
Aaron Schulz [Tue, 24 Oct 2017 22:42:30 +0000 (15:42 -0700)]
Make runJobs.php treat --json value as case insensitive
The docs mentioned "JSON", which did not actually work.
Change-Id: Ie9802551d05f7d80d1db0fd316e36f4b35bbc521
Aaron Schulz [Wed, 25 Oct 2017 01:42:31 +0000 (18:42 -0700)]
Rename some cache keys with odd virtual hierarchies
This makes automatic statsd metrics more useful.
Change-Id: I07d87dcb8ce9b42cc2f1c84ac4c06d177d463b1d
Aaron Schulz [Thu, 19 Oct 2017 02:50:17 +0000 (19:50 -0700)]
Add statsd metric support to WANObjectCache
Bug: T178531
Change-Id: I3037281d09cd5195347789f544deae89711f128b
Timo Tijhof [Wed, 25 Oct 2017 01:16:01 +0000 (02:16 +0100)]
API: Include setupSkinUserCss in prop=modules for useskin mode
Follows-up
90c95fc7f290f, which included result of Skin::getDefaultModules
in the prop=modules list. All hardcoded modules in OutputPage and Parser
were also subsequently moved into Skin::getDefaultModules.
However, a number of modules cannot be moved there because fundamentally
Skin::getDefaultModules can only load modules via OutputPage::addModules().
For style modules, addModuleStyles() must be used.
Fortunately, there is already a centralised place for that, namely
Skin::setupSkinUserCss(). Include that in the ApiParse return as well.
That should resolve the last bit of inconsistency between ApiParse
and OutputPage when it comes to the module queue.
Bug: T140664
Change-Id: I35e2e3bbdccdd1aa2a259b8e624daa80c609ba8c
Timo Tijhof [Wed, 25 Oct 2017 01:07:59 +0000 (02:07 +0100)]
API: Add tests for useskin parameter of ApiParse
Change-Id: If3dff7be5ccb6791f95d37c06998fcbadf1f469f
jenkins-bot [Wed, 25 Oct 2017 00:57:06 +0000 (00:57 +0000)]
Merge "Setup: Merge PreConfigSetup into Setup.php"
jenkins-bot [Wed, 25 Oct 2017 00:03:23 +0000 (00:03 +0000)]
Merge "Add action/user tracking to link refresh jobs"
Timo Tijhof [Tue, 19 Sep 2017 19:24:19 +0000 (20:24 +0100)]
Setup: Merge PreConfigSetup into Setup.php
Follows-up
41ea7e2fefff65.
The following previously happened between PreConfigSetup and Setup
and must now happen either before it, after it, or moved inside it.
* WebStart: Detect missing composer.
This must be after Autoloader/Vendor but before the first call to
wfDebugLog (or other loggers) so that we can output a more descriptive
error instead of a generic "Unknown class" fatal error.
Moving it to before Setup is too early, and after is too late.
Move it to within Setup.php and make it work in CLI mode.
* WebStart: Install header callback
Moving it to before Setup is too early, and after is too late.
Move it to within Setup.php (no-op in CLI mode).
* WebStart/Maintenance: Load LocalSetings.
Must be between PreConfigSetup and Setup.
Move to Setup.php to maintain execution order.
Utilise MW_CONFIG_File for custom handling in Maintenance.php.
* WebStart: Initialise output buffering
Utilise (new) MW_SETUP_CALLBACK hook.
* WebStart: Display NoLocalSettings.php
Utilise MW_CONFIG_CALLBACK hook.
* Maintenance: Setting $wgLocalisationCacheConf, calling Maintenance::finalSetup.
Utilise (new) MW_SETUP_CALLBACK hook.
Change-Id: I633a6ff235b4275391c48034c0525d2fbfa3fecd
jenkins-bot [Tue, 24 Oct 2017 21:57:13 +0000 (21:57 +0000)]
Merge "Removed Toki Pona localization files"
zoranzoki21 [Sat, 21 Oct 2017 09:48:51 +0000 (11:48 +0200)]
Removed Toki Pona localization files
Bug: T132899
Bug: T178730
Change-Id: I4c61b3ef42cdc24fee74587965240ca08242867e
Translation updater bot [Tue, 24 Oct 2017 20:21:19 +0000 (22:21 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic5c7a0f485ea4efe772c791965d5c43c98780940
jenkins-bot [Tue, 24 Oct 2017 19:06:45 +0000 (19:06 +0000)]
Merge "Add support for SVGs to $wgLogoHD with PNG fallback"
jenkins-bot [Tue, 24 Oct 2017 18:24:21 +0000 (18:24 +0000)]
Merge "Follow-up
2454f51b274: Upgrade qunit from 1.x to 2.x too"
jenkins-bot [Tue, 24 Oct 2017 18:04:33 +0000 (18:04 +0000)]
Merge "Remove unused table pager icons"
jenkins-bot [Tue, 24 Oct 2017 17:52:23 +0000 (17:52 +0000)]
Merge "registration: Only allow one extension to set a specific config setting"
Paladox [Mon, 22 May 2017 18:12:26 +0000 (19:12 +0100)]
Add support for SVGs to $wgLogoHD with PNG fallback
SVGs could already be used through $wgLogo. However, if a PNG fallback
is desired for older browsers, using SVGs was previously not possible.
This commit adds support for using an SVG image in $wgLogoHD and,
using $wgLogo as the fallback image.
Usage example:
> $wgLogo = '/path/to/png';
> $wgLogoHD = [
> 'svg' => 'path/to/svg',
> ];
Note: When the 'svg' key is set in $wgLogoHD, any '1.5x' and '2x' keys will
no longer be used because SVGs can render optimally on any screen sizes.
@Reedy, @Krinkle and @Brion VIBBER helped me alot with this.
Bug: T86229
Change-Id: I6197d96ce9110f4711ef2c4b198445bc5c6ae110
Volker E [Tue, 24 Oct 2017 17:34:39 +0000 (10:34 -0700)]
Remove unused table pager icons
Removing unused table pager icons, which have not been in use since
Ia750131aae52
Change-Id: Ia9a8cf12c2efcc7760f3ca028aff6c7e82253ccb
Fomafix [Tue, 24 Oct 2017 09:23:46 +0000 (11:23 +0200)]
api.js: Add an else to avoid unnecessary checks
If the first if matches then the second if can never match.
Change-Id: I96d59b57cac414c9ee7008e2f284a7a4e3348f3f