jeroendedauw [Thu, 24 Sep 2015 17:06:59 +0000 (19:06 +0200)]
Remove unused $pageSet var
Change-Id: Ic9c8bf9ed840703128a4c0e873ef7d70b6155494
jenkins-bot [Thu, 24 Sep 2015 15:49:25 +0000 (15:49 +0000)]
Merge "Some bugzilla.wikimedia.org -> phabricator.wikimedia.org changes"
jenkins-bot [Thu, 24 Sep 2015 15:32:24 +0000 (15:32 +0000)]
Merge "Don't attempt to render block if none of the lines can be shown"
jenkins-bot [Thu, 24 Sep 2015 15:31:23 +0000 (15:31 +0000)]
Merge "Fix PHP notice when logging the result of a DNS blacklist check."
umherirrender [Sat, 12 Sep 2015 13:54:13 +0000 (15:54 +0200)]
Some bugzilla.wikimedia.org -> phabricator.wikimedia.org changes
Changed some old bugzilla links to new phabricator links in comments,
test data and error message. This reduces the need for redirects from
old bugzilla to new phabricator from our source code.
Change-Id: Id98278e26ce31656295a23f3cadb536859c4caa5
jenkins-bot [Thu, 24 Sep 2015 15:13:21 +0000 (15:13 +0000)]
Merge "Sync up with Parsoid parserTests."
jenkins-bot [Thu, 24 Sep 2015 14:38:58 +0000 (14:38 +0000)]
Merge "tests: add structure and less tests to 'skins' suite"
jenkins-bot [Thu, 24 Sep 2015 12:47:40 +0000 (12:47 +0000)]
Merge "Skip ImportTest if allow_url_fopen disabled"
jenkins-bot [Thu, 24 Sep 2015 12:41:09 +0000 (12:41 +0000)]
Merge "Fix exception in Import, when import of a revision fails"
jenkins-bot [Thu, 24 Sep 2015 12:07:18 +0000 (12:07 +0000)]
Merge "Add language 'olo' Livvi-Karelian"
jenkins-bot [Thu, 24 Sep 2015 12:07:14 +0000 (12:07 +0000)]
Merge "resourceloader: Keep module_deps handling inside module base class"
Raimond Spekking [Mon, 14 Sep 2015 20:25:55 +0000 (20:25 +0000)]
Add language 'olo' Livvi-Karelian
First export with I4893e65a430118dbe35f90144afa492899f90150
Change-Id: I8b77182c0c09058d7361785bc1af0194bcc80ae6
saper [Tue, 11 Nov 2014 22:53:45 +0000 (23:53 +0100)]
Skip ImportTest if allow_url_fopen disabled
Workaround for:
Bug: 73283
Change-Id: I7afbf4dba358c89f9ba78042d82c35df1d2258e8
jenkins-bot [Thu, 24 Sep 2015 11:13:25 +0000 (11:13 +0000)]
Merge "i18n: mw.Upload.BookletLayout: Update message names"
Prateek Saxena [Thu, 24 Sep 2015 10:25:50 +0000 (15:55 +0530)]
i18n: mw.Upload.BookletLayout: Update message names
The messages that are no longer in the upload dialog still have the
'upload-dialog-' prefix. Replacing those with 'upload-process-' and
'upload-form-' where appropriate.
Change-Id: If02482f06f6bb634079a9311150fc15e0c95fd4b
Arlo Breault [Thu, 24 Sep 2015 08:25:52 +0000 (10:25 +0200)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
6619409e60a3208144836970773f191e7a6d147f
Change-Id: Iea6199d2d6a314f118febdc2308be1723a9970d2
haritha28 [Mon, 14 Sep 2015 07:08:32 +0000 (12:38 +0530)]
Add GENDER support
The message Emailuserfooter has been modified
by adding the GENDER support with the parameters
$1 and $2.
Bug: T111944
Change-Id: I7df3027d0cac203f0147de845b49b1a3b6ce1c10
Timo Tijhof [Thu, 17 Sep 2015 22:14:46 +0000 (23:14 +0100)]
resourceloader: Keep module_deps handling inside module base class
Most of it was already there (SELECT in preloadInfo, and in-class holder via
setFileDependencies) but the logic to write to the database was within
the file module class.
Moving it the other way around may make more sense in the future, but for
the moment ResourceLoader.php makes assumptions about all modules being
able to store setFileDependencies as read from the database. Whether or not
a class currently implements a way to write to that table.
Change-Id: I06b5da4144798197478c66e8b9ccd4cc62cf6fb6
jenkins-bot [Thu, 24 Sep 2015 06:52:35 +0000 (06:52 +0000)]
Merge "Use 'Create account' for button in Special:UserLogin/Signup"
Devi Krishnan [Sat, 12 Sep 2015 14:31:41 +0000 (20:01 +0530)]
Use 'Create account' for button in Special:UserLogin/Signup
'Create another account' button in the Special:UserLogin/Signup section
changed to 'Create account'.
Bug: T91614
Change-Id: Ib7cb81c89e2a922ac9029c167c09e28a12207372
jenkins-bot [Thu, 24 Sep 2015 01:14:35 +0000 (01:14 +0000)]
Merge "Set $wgBlockAllowsUTEdit = true; by default"
jenkins-bot [Thu, 24 Sep 2015 01:02:05 +0000 (01:02 +0000)]
Merge "Make $file->getLength() return duration of GIF and APNG files."
jenkins-bot [Thu, 24 Sep 2015 01:00:17 +0000 (01:00 +0000)]
Merge "resourceloader: Use FileContentsHasher in safeFileHash()"
Brian Wolff [Sun, 15 Jun 2014 00:42:13 +0000 (21:42 -0300)]
Set $wgBlockAllowsUTEdit = true; by default
This setting allows blocked users to edit their talk page, unless
talk page editing is specificly revoked in the Special:Block screen.
Almost all Wikimedia wikis do this, to the point where many people
don't even realize it's a config option.
Note: Existing blocks will not be affected by this setting change.
Change-Id: I05194f3fb313098284c474c948d7d26541ab6094
Ori Livneh [Wed, 23 Sep 2015 08:11:58 +0000 (01:11 -0700)]
resourceloader: Use FileContentsHasher in safeFileHash()
Replace the one-off code for APC-assisted file content hashing from I5ceb8537c
with a call to the FileContentsHasher class introduced in I1ff61153.
Change-Id: I8e4c3d5a5e7cdf6455a43769261d742b0255622c
Brian Wolff [Sun, 14 Sep 2014 21:26:05 +0000 (18:26 -0300)]
Make $file->getLength() return duration of GIF and APNG files.
Its not just ogg files that have a duration, animated GIFs
and APNGs do too.
After If172a1cba is merged, this will show up in the api.
Change-Id: Ie7cf00df34950ae404fcf655dd16397a273e5523
jenkins-bot [Thu, 24 Sep 2015 00:44:39 +0000 (00:44 +0000)]
Merge "resourceloader: Improve caching for LESS file compilation"
Ori Livneh [Wed, 23 Sep 2015 07:47:40 +0000 (00:47 -0700)]
resourceloader: Improve caching for LESS file compilation
Caching the output of a LESS compiler is tricky, because a LESS file may
include additional LESS files via @imports, in which case the cache needs
to vary as the contents of those files vary (and not just the contents of
the primary LESS file).
To solve this, we first introduce a utility class, FileContentsHasher. This
class is essentially a smart version of md5_file() -- given one or more file
names, it computes a hash digest of their contents. It tries to avoid
re-reading files by caching the hash digest in APC and re-using it as long as
the files' mtimes have not changed. This is the same approach I used in
I5ceb8537c.
Next, we use this class in ResourceLoaderFileModule in the following way:
whenever we compile a LESS file, we cache the result as an associative array
with the following keys:
* `files` : the list of files whose contents influenced the compiled CSS.
* `hash` : a hash digest of the combined contents of those files.
* `css` : the CSS output of the compiler itself.
Before using a cached value, we verify that it is still current by asking
FileContentHasher for a hash of the combined contents of all referenced files,
and we compare that against the value of the `hash` key of the cached entry.
Bug: T112035
Change-Id: I1ff61153ddb95ed17e543bd4af7dd13fa3352861
jenkins-bot [Thu, 24 Sep 2015 00:27:18 +0000 (00:27 +0000)]
Merge "Improvements to WANObjectCache::getWithSetCallback()"
Erik Bernhardson [Wed, 23 Sep 2015 21:24:21 +0000 (14:24 -0700)]
Fix stray literal \n in output
Bug: T113518
Change-Id: Ia4591849f7675ad062210f21ff6273077a198704
jenkins-bot [Wed, 23 Sep 2015 20:53:50 +0000 (20:53 +0000)]
Merge "Add MWTimestamp::getTimezoneString(), use it in file revert message"
jenkins-bot [Wed, 23 Sep 2015 20:52:14 +0000 (20:52 +0000)]
Merge "Remove closing PHP tag from MediaWiki\Tidy\RaggettWrapper"
jenkins-bot [Wed, 23 Sep 2015 20:52:11 +0000 (20:52 +0000)]
Merge "Use tab instead of spaces in ParsoidVirtualRESTService"
jenkins-bot [Wed, 23 Sep 2015 20:46:58 +0000 (20:46 +0000)]
Merge "OOUIHTMLForm: s/else if/elseif/"
gladoscc [Fri, 26 Dec 2014 01:57:14 +0000 (12:57 +1100)]
Add MWTimestamp::getTimezoneString(), use it in file revert message
MWTimestamp::getTimezoneString() returns the timezone name as a message,
that supports wiki localization. The code is moved from Parser::pstPass2.
The default file revert message is currently always in UTC.
This patch sets the default timestamp to be in the wiki timezone (similar
to ~~~~). The timezone is passed as a new parameter to the message, with
the date / time parameters being merged and handled by
$wgContentLang->timeanddate
Bug: T36948
Change-Id: I48772f5f3b1635d33b6185776cedfc4ee1882494
jenkins-bot [Wed, 23 Sep 2015 20:36:53 +0000 (20:36 +0000)]
Merge "Terminate free external link on (and numeric versions of <>)"
Kunal Mehta [Wed, 23 Sep 2015 20:35:31 +0000 (13:35 -0700)]
Remove closing PHP tag from MediaWiki\Tidy\RaggettWrapper
Change-Id: Id90cb99862eb9997f56506db99aa2ca6e2885516
Kunal Mehta [Wed, 23 Sep 2015 20:31:04 +0000 (13:31 -0700)]
Use tab instead of spaces in ParsoidVirtualRESTService
Spotted by phpcs
Change-Id: Iab3b1e7aa69f84d0655d54c7c64d2681e0662af4
Kunal Mehta [Wed, 23 Sep 2015 20:29:30 +0000 (13:29 -0700)]
OOUIHTMLForm: s/else if/elseif/
Spotted by phpcs.
Change-Id: I1a0b7a08a17849b270a262063744198d81d36de1
jenkins-bot [Wed, 23 Sep 2015 20:26:59 +0000 (20:26 +0000)]
Merge "Added support for enqueueable DataUpdates"
jenkins-bot [Wed, 23 Sep 2015 20:03:17 +0000 (20:03 +0000)]
Merge "Revert "Do not double load gallery styles now cache has expired""
C. Scott Ananian [Wed, 23 Sep 2015 19:16:24 +0000 (15:16 -0400)]
Terminate free external link on (and numeric versions of <>)
Bug: T84937
Change-Id: Ic74d8d069e08c0597c7b26755e0d942bf3a510cc
jenkins-bot [Wed, 23 Sep 2015 19:57:15 +0000 (19:57 +0000)]
Merge "Remove oversight references from i18n"
Ori.livneh [Wed, 23 Sep 2015 19:32:33 +0000 (19:32 +0000)]
Revert "Do not double load gallery styles now cache has expired"
This reverts commit
0fc3b0850c0def14a213dc7f0278444948762f82.
Bug: T113511
Change-Id: I62afd734432c4e7432fe04b146809423090df9fe
Translation updater bot [Wed, 23 Sep 2015 19:14:28 +0000 (21:14 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8ae3ae761cc2dd0e418bc584d8b1c0328a1a9dbb
Aaron Schulz [Tue, 22 Sep 2015 18:43:33 +0000 (11:43 -0700)]
Added support for enqueueable DataUpdates
* Updates can now declare themselves as having enqueueUpdate()
as an alternative to doUpdate(). This lets more expensive
or slave lag producing updates use the job queue if desired.
* Added a $mode flag to DataUpdate::runUpdates() to prefer
pushing jobs over calling doUpdate().
* Made page deletions defer deletion updates when possible.
Bug: T95501
Change-Id: Ic6f50f92768089ba0fbc223b8d178f5a91512959
Alex Monk [Tue, 15 Sep 2015 22:52:10 +0000 (23:52 +0100)]
Remove oversight references from i18n
Change-Id: Ie1c81e0e54cf8cb36c83b8e11932ca8917fdd07b
Fomafix [Fri, 24 Jul 2015 15:24:03 +0000 (15:24 +0000)]
Feed.php: Apply wfBCP47 to language code
Change-Id: Ibaf771f6348bd5c25a39d6e6ae328251191454e2
Ori Livneh [Wed, 23 Sep 2015 18:03:19 +0000 (18:03 +0000)]
Merge "Compat fix for HHVM on non-Linux OSs"
jenkins-bot [Wed, 23 Sep 2015 17:11:08 +0000 (17:11 +0000)]
Merge "SpecialNewpages: Add redirect=no only to links to redirects"
jenkins-bot [Wed, 23 Sep 2015 16:37:19 +0000 (16:37 +0000)]
Merge "mediawiki.Upload.Dialog: Factor out booklet layout"
Fomafix [Wed, 23 Sep 2015 16:34:46 +0000 (16:34 +0000)]
SpecialNewpages: Add redirect=no only to links to redirects
Since
2748c4091 all title links have redirect=no. This is requested in T16353.
To satisfy T16353 it should be enough to add this only to links to redirects.
Appending redirect=no to all links has the disadvantage of a duplicate link.
This change adds redirect=no only to links to redirects.
Change-Id: I33da0f1eadc5dfbc46820015622ee1a55acbfe21
jenkins-bot [Wed, 23 Sep 2015 16:30:47 +0000 (16:30 +0000)]
Merge "CategorySelector: Add different ways of searching"
jenkins-bot [Wed, 23 Sep 2015 16:30:36 +0000 (16:30 +0000)]
Merge "Add hook to allow lazy loading of import sources"
Bartosz Dziewoński [Wed, 23 Sep 2015 15:28:59 +0000 (15:28 +0000)]
Merge "docs: mediawiki.ForeignStructuredUpload: Fix formatting"
Aaron Schulz [Fri, 18 Sep 2015 19:22:18 +0000 (12:22 -0700)]
Improvements to WANObjectCache::getWithSetCallback()
* If lockTSE is set, make sure it applies during during
the entire duration of a key being tombstoned. This lets
regenerations happen during that whole time, which lowers
the chance of seeing stale data if the DBs are lagged.
* If lockTSE is not set, do not apply tempTTL (for tomstoned keys).
If traffic is high, a stale value would usually be "stashed" and
used for 5 seconds. If the lag was only 1 second, then this
is suboptimal.
* Determine tempTTL from lockTSE as they no longer make sense
being separate. This makes things easier to understand and
also makes the lockTSE value account for the last regeneration
time (via stash key TTL). Since LOCK_TSE << HOLDOFF_TTL, this
helps avoid stale reads without adding stampede risk.
Change-Id: I3b01f0ec67935a238b30e02e42004fd3b2dcfb9d
Rohan [Sun, 15 Jun 2014 17:47:49 +0000 (23:17 +0530)]
UploadFromUrl: Display an error to the user on invalid wpUploadFileURL
Removes check for URL validity from UploadFromUrl::isValidRequest()
so that an error can be thrown later and displayed to the user.
Bug: T34361
Change-Id: Idf4cfcd6199ef6e875f760e46db98248ba53a327
Skizzerz [Wed, 4 Jun 2014 02:40:03 +0000 (21:40 -0500)]
Fix PHP notice when logging the result of a DNS blacklist check.
When the array syntax is used for the DNS blacklist, PHP throws a notice about array to string
conversion. This change ensures that the correct string name is used regardless of what type of
blacklist entry is used.
Change-Id: I2511a8320474a02d8f321d04f005bb9d18fb15b3
Ed Sanders [Mon, 21 Sep 2015 21:08:17 +0000 (22:08 +0100)]
mediawiki.Upload.Dialog: Factor out booklet layout
So that it can be used outside of the upload dialog.
Change-Id: Ic6e7e4499611e64a905f2828bdf0ee538168c9ec
Prateek Saxena [Wed, 23 Sep 2015 12:17:01 +0000 (17:47 +0530)]
docs: mediawiki.ForeignStructuredUpload: Fix formatting
Before - https://phabricator.wikimedia.org/
F2627998
After - https://phabricator.wikimedia.org/
F2627999
Change-Id: Ib4844f26ee75c9d85840043d06969e0866c85d99
Prateek Saxena [Fri, 11 Sep 2015 09:22:22 +0000 (14:52 +0530)]
CategorySelector: Add different ways of searching
We'll need this for HotCat. We'll be able to set multiple ways of
searching, build an array of promises and collate the results once all
of them have resolved.
Also adds methods to set searchTypes and validates the list.
searchCategories() is too long right now, but can be easily broken down
into multiple routines, not sure if that is helpful though.
This also allows the user to choose categories that don't exist yet.
Bug: T113462
Change-Id: I5a350a2d91b0afb0567f4290654770c74607ce63
Matthias Mullie [Wed, 23 Sep 2015 11:24:34 +0000 (13:24 +0200)]
Don't attempt to render block if none of the lines can be shown
Not only doesn't it make sense to render this, getLogText has
some assumptions about this array, and an empty array just didn't
work.
Bug: T112738
Change-Id: Ibdc0c4ed15449883a91a3292bfa174ff84116be0
Ori Livneh [Wed, 23 Sep 2015 08:53:47 +0000 (01:53 -0700)]
Compat fix for HHVM on non-Linux OSs
RUSAGE_THREAD is not POSIX; it's Linux-specific. HHVM now compiles on OS X,
and calling getrusage( 2 ) on OS X explodes with:
exception : f_getrusage is not supported: RUSAGE_THREAD is not defined on
this sytem [sic]
HHVM is being ported to Windows, too, where RUSAGE_THREAD is likewise missing.
So check that PHP_OS === 'Linux' before using it.
Change-Id: I6eac7d2bb4edfa1e697ae72f89299d0d5ac135f4
jenkins-bot [Wed, 23 Sep 2015 08:05:33 +0000 (08:05 +0000)]
Merge "Fix hook documentation for PageRenderingHash"
jenkins-bot [Wed, 23 Sep 2015 08:00:52 +0000 (08:00 +0000)]
Merge "jsduck: Load OOjs and OOjs UI in eg-iframe.html"
jenkins-bot [Wed, 23 Sep 2015 07:56:34 +0000 (07:56 +0000)]
Merge "Fix hook documentation for UploadFormSourceDescriptors"
This, that and the other [Wed, 23 Sep 2015 07:54:31 +0000 (17:54 +1000)]
Add hook to allow lazy loading of import sources
Currently import sources have to be set into $wgImportSources as part of
wiki startup. This is not practical for the WMF cluster, where we need some
reasonably complex logic to set up the import source structure.
This change allows the import source list to be populated from a new
"ImportSources" hook. This hook is only called when the list of import
sources is actually needed (namely, when a user with relevant permissions
loads Special:Import).
Bug: T17583
Change-Id: Ice9a19cb6dfe53ae72aa71353d0553ee9338f233
umherirrender [Sun, 20 Sep 2015 08:44:15 +0000 (10:44 +0200)]
Fix hook documentation for PageRenderingHash
The last parameter was not in documentation.
Follows Ieecb27216c39b7e6e354b4a1904fbff06506307d
Change-Id: I1eaf0e98a97f804f6b402517e45fcad54ee65ac0
Roan Kattouw [Wed, 2 Sep 2015 16:18:50 +0000 (09:18 -0700)]
jsduck: Load OOjs and OOjs UI in eg-iframe.html
This makes live preview work for OOUI classes.
Also:
* Remove duplicate definition of window.onerror (the latter which
fails to include the 'error' variable in the logged message).
* Set mwPerformance to match startup.js as it was throwing
a fatal exception on every page.
Bug: T112116
Change-Id: I00e789a2853e82e9a89d07752ce92fa6bb9615f5
jenkins-bot [Wed, 23 Sep 2015 07:40:32 +0000 (07:40 +0000)]
Merge "Translate password reset e-mail subject into proper language"
jenkins-bot [Wed, 23 Sep 2015 07:40:12 +0000 (07:40 +0000)]
Merge "build: Enable jscs jsDoc rule 'checkRedundantReturns' and make pass"
James D. Forrester [Sat, 5 Sep 2015 19:15:01 +0000 (12:15 -0700)]
build: Enable jscs jsDoc rule 'checkRedundantReturns' and make pass
Change-Id: I5006ea3df6798201edfacbf8ad4624266554f064
Florianschmidtwelzow [Tue, 22 Sep 2015 08:20:06 +0000 (10:20 +0200)]
Add my second gerrit e-mail to .mailmap
Change-Id: I6f57e871a54ae73a375023e6ab033c74dd67c8fc
jenkins-bot [Wed, 23 Sep 2015 07:06:28 +0000 (07:06 +0000)]
Merge "Update mailmap from USERINFO"
jenkins-bot [Wed, 23 Sep 2015 05:28:18 +0000 (05:28 +0000)]
Merge "objectcache: Fix some doc bullet points in WANObjectCache"
jenkins-bot [Wed, 23 Sep 2015 05:26:27 +0000 (05:26 +0000)]
Merge "objectcache: Add comments about DB isolation to WANObjectCache"
Aaron Schulz [Tue, 22 Sep 2015 20:37:19 +0000 (13:37 -0700)]
objectcache: Fix some doc bullet points in WANObjectCache
Change-Id: Id3e65b0768d45087aaf83ed3f432923c82acc713
Aaron Schulz [Tue, 22 Sep 2015 19:54:24 +0000 (12:54 -0700)]
objectcache: Add comments about DB isolation to WANObjectCache
Change-Id: Ic3454d0ebfdb05488dd650f77e09264842caea1c
jenkins-bot [Tue, 22 Sep 2015 21:52:52 +0000 (21:52 +0000)]
Merge "Update OOjs UI to v0.12.9"
Timo Tijhof [Tue, 22 Sep 2015 20:44:52 +0000 (21:44 +0100)]
mw.storage: Fix broken test (incompatible with Chrome 45)
The localStorage global is read-only which Chrome 45 enforces.
Simplify things by dropping mediaWiki.storage.isStorageEnabled, and
by wrapping each operation with a try / catch.
Bug: T113413
Change-Id: Iecbdeb050b9a69febd3388898d98293a84588a94
James D. Forrester [Tue, 22 Sep 2015 20:14:56 +0000 (21:14 +0100)]
Update OOjs UI to v0.12.9
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.12.9/History.md
Change-Id: I8780a6d31a3c9d11e42f0858bb66a39f678bf28f
Translation updater bot [Tue, 22 Sep 2015 19:50:09 +0000 (21:50 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I22fc6e0c1af4d2db3c1a7e053a1597764dce8339
Kunal Mehta [Tue, 22 Sep 2015 18:29:34 +0000 (11:29 -0700)]
Mark UserRights hook as deprecated
Bug: T113358
Change-Id: I0b4a319f703c549da42d579063e1eadb2260fa21
jenkins-bot [Tue, 22 Sep 2015 18:24:35 +0000 (18:24 +0000)]
Merge "Moved LinksDeletionUpdate to a separate file"
jenkins-bot [Tue, 22 Sep 2015 18:15:25 +0000 (18:15 +0000)]
Merge "Add the performer to the UserRightsChanged hook"
Aaron Schulz [Tue, 22 Sep 2015 18:07:47 +0000 (11:07 -0700)]
Moved LinksDeletionUpdate to a separate file
* Also removed unused updateCategoryCounts() method
Change-Id: I25f64d3771a23d18e7993433dab449adec375d9b
jenkins-bot [Tue, 22 Sep 2015 18:05:57 +0000 (18:05 +0000)]
Merge "mediawiki.Upload: Return same data for upload & stashed upload"
Kunal Mehta [Tue, 22 Sep 2015 17:58:20 +0000 (10:58 -0700)]
Add the performer to the UserRightsChanged hook
This allows extensions (e.g. Echo) to detect who made the change without
relying upon $wgUser. It also allows for differentiation between
autopromotion entries which will pass in `false` as the performer.
Change-Id: Idebd78b54dcea1bdc84c83f402e87b240ab4ade1
Ed Sanders [Tue, 22 Sep 2015 15:18:55 +0000 (16:18 +0100)]
mediawiki.Upload: Return same data for upload & stashed upload
The stashed upload was omitting the imageinfo and raw result in the promise.
Change-Id: I79462c1121c879d90eed3d245948335cd08bba30
jenkins-bot [Tue, 22 Sep 2015 16:58:58 +0000 (16:58 +0000)]
Merge "Set visibility of monolog tests setUp method to protected"
jenkins-bot [Tue, 22 Sep 2015 16:49:06 +0000 (16:49 +0000)]
Merge "Also check Kafka class exists in KafkaHandlerTest"
aude [Tue, 22 Sep 2015 14:57:55 +0000 (16:57 +0200)]
Set visibility of monolog tests setUp method to protected
In phpunit and MediaWikiTestCase, the setUp method is protected,
and it's nice if the subclasses are consistent.
Change-Id: I4b8ac612951168913bb2dc9cf16d3dc18762a211
aude [Tue, 22 Sep 2015 14:54:58 +0000 (16:54 +0200)]
Also check Kafka class exists in KafkaHandlerTest
I have monolog installed but not Kafka, so still
the test was run and broken for me.
Change-Id: If396815d77b0ae25fbd5c16b628f217478062b43
jenkins-bot [Tue, 22 Sep 2015 14:48:08 +0000 (14:48 +0000)]
Merge "Fixes for RedisBagOStuff when using twemproxy"
jenkins-bot [Tue, 22 Sep 2015 14:45:31 +0000 (14:45 +0000)]
Merge "Fix typo in KafkaHandlerTest"
jenkins-bot [Tue, 22 Sep 2015 14:44:03 +0000 (14:44 +0000)]
Merge "Fix missing dependencies needed for tests."
aude [Tue, 22 Sep 2015 14:35:36 +0000 (16:35 +0200)]
Fix typo in KafkaHandlerTest
Change-Id: Ib73152a269e01bc64a4b1e7a9157de2088d152d2
aude [Tue, 8 Sep 2015 14:18:03 +0000 (16:18 +0200)]
Fix exception in Import, when import of a revision fails
A 'notice' is thrown when an import fails, for some reason,
such as the user does not have permission, and the reason
is reported to the user.
In this case, $title is false and not a Title object,
as needed by the beforeImportPage callback (which calls
WikiPage::factory). As well, $pageInfo['_title'] is undefined,
in pageOutCallback, which also calls WikiPage::factory via
finishImportPage.
Bug: T108544
Change-Id: I55042fdf305cd1198d3a4b28a0ebb5ce31b76a1f
Jan Zerebecki [Tue, 22 Sep 2015 10:27:29 +0000 (12:27 +0200)]
Fix missing dependencies needed for tests.
Added to require-dev: wikimedia/avro, nmred/kafka-php,
monolog/monolog. These were added to vendor, but are
only suggested in core.
Change-Id: Ic760077df11bfac461ad85c5d6d395bed55d6c92
James D. Forrester [Tue, 22 Sep 2015 11:36:49 +0000 (12:36 +0100)]
Follow-up
5cd0a43e5: Add SelectFileWidget's i18n to ResourcesOOUI
Change-Id: Ibd8ff7e66ac48bdfb24a3d2a2673e1586c4bb5dc