Antoine Musso [Tue, 10 Jul 2012 15:16:46 +0000 (17:16 +0200)]
converts '@fixme' to '@todo FIXME'
@fixme is simply not recognized by doxygen whereas @todo is used to
generate a nice ... todo list!!
Change-Id: If956c0a164373126ce48b791d45c56962034eecd
Antoine Musso [Tue, 10 Jul 2012 14:58:52 +0000 (16:58 +0200)]
update @param @return doc in several files
Change-Id: I0e23227330f90dc4121fd2a313d2e9a33c3c97a7
Antoine Musso [Tue, 10 Jul 2012 14:46:22 +0000 (16:46 +0200)]
prettify filerepo documentation
Change-Id: Ia84494c8c0c09a3d509975d63ab698e0a35c4631
Antoine Musso [Tue, 10 Jul 2012 14:45:44 +0000 (16:45 +0200)]
prettify SkinTemplate:makeLink documentation
Change-Id: Ib70e00460c8e01ec810a4123b7eec52c3632b99d
Antoine Musso [Tue, 10 Jul 2012 13:12:30 +0000 (15:12 +0200)]
move parameter doc under @param
The description of an array of parameter really belong under @param,
makes doxygen HTML documentation nicer.
Change-Id: If2c01a11b8dbf02b272b7ccce591a92293346731
Antoine Musso [Tue, 10 Jul 2012 12:48:06 +0000 (14:48 +0200)]
escape tags and entity in doxygen comments
When inserting XML elements inline <such as this one>, doxygen chokes
about it not being known. Simply enclosing the tag in double quotes
prevents doxygen from emitting a warning.
Also enclosed a few invalid functions calls such as \. and double quoted
the HTML entities such as &foobar;
Change-Id: I4019637145e683c2bec3d17b2fd98b0c50a932f1
Reedy [Mon, 9 Jul 2012 20:40:32 +0000 (20:40 +0000)]
Merge "Fixed Language::isValidBuiltInCode exception."
Aaron Schulz [Mon, 9 Jul 2012 20:25:37 +0000 (20:25 +0000)]
Merge "adjust method comment for Ia19f1011"
Aaron [Mon, 9 Jul 2012 20:10:05 +0000 (13:10 -0700)]
Fixed Language::isValidBuiltInCode exception.
Change-Id: Ib7c7c0f3ed9382beea5fb0a9b2aa1809f75a8e1c
Translation updater bot [Mon, 9 Jul 2012 20:01:49 +0000 (20:01 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ibee3987c8a3848e94975a63ecfa832f601b86347
Aaron [Mon, 9 Jul 2012 17:27:53 +0000 (10:27 -0700)]
Prevent duplicate edits due to failure to load the current revision.
* This works via throwing an exception. Ideally, a deeper fix can be
made so the exception stops getting triggered anymore.
Change-Id: Ie6a11016be9f9e5a76e2f6f369bc3aac42d78c2d
MaxSem [Mon, 9 Jul 2012 14:31:00 +0000 (14:31 +0000)]
Merge "(bug 36819) Lowercase ba,bat-smg,bxr,crh,krc,kv,mdf,mhr,mrj,myv,tyv,vep,xal"
MaxSem [Mon, 9 Jul 2012 14:30:11 +0000 (14:30 +0000)]
Merge "(bug 36819) Lowercase Kazakh and Uzbek"
Viačeslav [Sun, 8 Jul 2012 16:30:24 +0000 (18:30 +0200)]
(bug 36819) Lowercase av,ce,lbe and lez
Follow up to gerrit change 7306:
https://gerrit.wikimedia.org/r/#/c/7306/
Lowercase some language names from Caucasus
'av' => 'авар', # Avar
'ce' => 'нохчийн', # Chechen
'lbe' => 'лакку', # Lak
'lez' => 'лезги', # Lezgi
Change-Id: Ia5a8a28c6cc0159898469cc458dd366886916c86
Reedy [Wed, 20 Jun 2012 21:45:21 +0000 (22:45 +0100)]
Flesh out parameter documentation etc
Remove some trailing whitespace
A bit of code simplification
Change-Id: Iea96a2482c53868713a43569be4e5de4c9edb2a2
Hashar [Mon, 9 Jul 2012 12:41:26 +0000 (12:41 +0000)]
Merge "pass Language to wfMessage() calls"
Alexandre Emsenhuber [Sat, 7 Jul 2012 16:37:31 +0000 (18:37 +0200)]
pass Language to wfMessage() calls
Pass the Language object to the wfMessage calls in
LogPage::getTitleLink() and LogPage::formatBlockFlags().
Change-Id: I4f8347d6616ee0e6be31b268679b398e108680c0
Reedy [Sun, 8 Jul 2012 22:55:57 +0000 (22:55 +0000)]
Merge "Improve documentation of maintenance scripts."
Krinkle [Sun, 8 Jul 2012 21:27:16 +0000 (21:27 +0000)]
Merge "Add some trailing full stops"
Alexandre Emsenhuber [Sun, 8 Jul 2012 20:47:27 +0000 (22:47 +0200)]
Improve documentation of maintenance scripts.
Change-Id: I2433d23544e808e16f28805f93183b1af2409c94
Translation updater bot [Sun, 8 Jul 2012 19:48:58 +0000 (19:48 +0000)]
Merge "Localisation updates from translatewiki.net."
Kaldari [Sun, 8 Jul 2012 04:58:30 +0000 (21:58 -0700)]
mediawiki.api.edit: Use the new 'tokens' api action
Use action=tokens instead of the old way with info properties
for a fake title.
Change-Id: I35cd26180e7af7122ff64ce146199cdaa5f7d88b
Translation updater bot [Sun, 8 Jul 2012 19:11:42 +0000 (19:11 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ifbcaa781fc601b7887525fe83a93d8148569b624
Viačeslav [Sun, 8 Jul 2012 16:30:24 +0000 (18:30 +0200)]
(bug 36819) Lowercase Kazakh and Uzbek
Follow up to gerrit change 7306:
https://gerrit.wikimedia.org/r/#/c/7306/
Lowercase some Central Asian language names.
'kk' => 'қазақша', # Kazakh (multiple scripts - defaults to Cyrillic)
'kk-cyrl' => "\xE2\x80\xAAқазақша (кирил)\xE2\x80\xAC", # Kazakh Cyrillic
'kk-latn' => "\xE2\x80\xAAqazaqşa (latın)\xE2\x80\xAC", # Kazakh Latin
'kk-kz' => "\xE2\x80\xAAқазақша (Қазақстан)\xE2\x80\xAC", # Kazakh (Kazakhstan)
'kk-tr' => "\xE2\x80\xAAqazaqşa (Türkïya)\xE2\x80\xAC", # Kazakh (Turkey)
'uz' => 'oʻzbekcha', # Uzbek
Change-Id: Ieb56ff2854464ea57169985b40fb7f6fdcfacc33
Viačeslav [Sun, 8 Jul 2012 16:30:24 +0000 (18:30 +0200)]
(bug 36819) Lowercase ba,bat-smg,bxr,crh,krc,kv,mdf,mhr,mrj,myv,tyv,vep,xal
Follow up to gerrit change 7306:
https://gerrit.wikimedia.org/r/#/c/7306/
Lowercase some Eastern European and Central Asian
language names.
'ba' => 'башҡортса', # Bashkir
'bat-smg' => 'žemaitėška', # Samogitian (deprecated code, 'sgs' in ISO 693-3 since 2010-06-30 )
'bxr' => 'буряад', # Buryat (Russia)
'crh' => 'qırımtatarca', # Crimean Tatar (multiple scripts - defaults to Latin)
'crh-latn' => "\xE2\x80\xAAqırımtatarca (Latin)\xE2\x80\xAC", # Crimean Tatar (Latin)
'crh-cyrl' => "\xE2\x80\xAAкъырымтатарджа (Кирилл)\xE2\x80\xAC", # Crimean Tatar (Cyrillic)
'krc' => 'къарачай-малкъар', # Karachay-Balkar
'kv' => 'коми', # Komi-Zyrian (Cyrillic is common script but also written in Latin script)
'mdf' => 'мокшень', # Moksha
'mhr' => 'олык марий', # Eastern Mari
'mrj' => 'кырык мары', # Hill Mari
'myv' => 'эрзянь', # Erzya
'tyv' => 'тыва дыл', # Tyvan
'udm' => 'удмурт', # Udmurt
'vep' => 'vepsän kel’', # Veps
'xal' => 'хальмг', # Kalmyk-Oirat (Kalmuk, Kalmuck, Kalmack, Qalmaq, Kalmytskii Jazyk, Khal:mag, Oirat, Volga Oirat, European Oirat, Western Mongolian)
Change-Id: I47ad9b05eca9f5c2fe69ef2e8f5325371b0f9e89
Reedy [Sat, 7 Jul 2012 21:31:00 +0000 (21:31 +0000)]
Merge "(bug 38237) Add missing parentheses around diff links on Special:Undelete"
Reedy [Sat, 7 Jul 2012 21:29:18 +0000 (21:29 +0000)]
Merge "CLI install exited with 0 status code"
Aaron Schulz [Sat, 7 Jul 2012 21:28:10 +0000 (21:28 +0000)]
Merge "Send correct HTML when reporting a MWException object and the OuputPage object cannot be used."
Reedy [Sat, 7 Jul 2012 21:27:42 +0000 (21:27 +0000)]
Merge "Use Revision::getParentLengths in history"
Aaron Schulz [Sat, 7 Jul 2012 21:25:33 +0000 (21:25 +0000)]
Merge "Added assertArrayEquals method to MediaWikiTestCase to avoid duplicating asort and array_values all over the place"
Reedy [Sat, 7 Jul 2012 21:23:42 +0000 (21:23 +0000)]
Merge "Added SpecialPageAfterExecute and SpecialPageBeforeExecute hooks"
Reedy [Sat, 7 Jul 2012 21:03:24 +0000 (21:03 +0000)]
Merge "Improve documentation of maintenance scripts."
Reedy [Sat, 7 Jul 2012 20:56:35 +0000 (20:56 +0000)]
Merge "(bug 31313) Clarify watchlist preference messages"
Alex Monk [Sat, 7 Jul 2012 20:41:47 +0000 (21:41 +0100)]
(bug 38237) Add missing parentheses around diff links on Special:Undelete
Change-Id: Id6846abd42f3c3e1210e760a583b3180d1aab18d
Translation updater bot [Sat, 7 Jul 2012 19:24:47 +0000 (19:24 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ia7d6bf5c1515498956cb4b06745a2b1ce5700d15
Antoine Musso [Sat, 7 Jul 2012 18:09:45 +0000 (20:09 +0200)]
CLI install exited with 0 status code
The CliInstaller used the '0' exit code whenever the status was not OK.
That makes third party script assuming the install actually ran fine
since a 0 exit code is mostly considered as a success. By sending an
error code > 0 (here 1), our automatic installers will be able to catch
the failure and stop proceeding.
I had that issue with a Jenkins job which ran the CLI installer and kept
continuing although there was an error about LocalSettings.php already
existing.
Change-Id: I4f4727df85c09c0a04e4630df91c6213dfce6e9a
Reedy [Sat, 7 Jul 2012 15:19:58 +0000 (16:19 +0100)]
Remove BOM from cleanupPreferences
Change-Id: I3c049c0229bb9ed1365f2781baa44b4c8e1e1e18
Reedy [Sat, 7 Jul 2012 15:09:47 +0000 (16:09 +0100)]
Add some trailing full stops
Change-Id: I878b24102a4de0c5a5fc1c1b1f9d52b053595002
umherirrender [Sat, 7 Jul 2012 14:45:24 +0000 (16:45 +0200)]
Use Revision::getParentLengths in history
Using new method from I6e388e75
Change-Id: I902dd1e2699c7291c49cd68fce271941ff4c6e34
Brad Jorsch [Fri, 1 Jun 2012 21:46:40 +0000 (23:46 +0200)]
(bug 35980) drcontinue should pay attention to drdir in "all" mode
In "all" mode (mode #3 in the module's documentation), the drdir
parameter is treated by the result ordering as if it were always
drdir=newer; drcontinue, on the other hand, always tries to honor drdir
correctly, leading to the drcontinue not actually working unless drdir
is specifically given.
This fixes that.
Change-Id: Icf6982d0ba55490b7a7ae3a1ee6c94c40f1c3c64
MaxSem [Fri, 6 Jul 2012 22:41:41 +0000 (22:41 +0000)]
Merge "(bug 30836) API siteinfo specialpagealiases should not return nonexistent special pages"
Brad Jorsch [Sat, 2 Jun 2012 20:20:14 +0000 (22:20 +0200)]
(bug 30836) API siteinfo specialpagealiases should not return nonexistent special pages
Some special pages are conditionally registered (e.g.
Special:Popularpages only exists when $wgDisableCounters is false), or
sometimes an alias exists for a special page that does not. The API
should probably not return entries for these from
meta=siteinfo&siprop=specialpagealiases.
Change-Id: I59eb82eae45fb47c6a769195cc1bd28711b4fcac
Translation updater bot [Fri, 6 Jul 2012 21:12:53 +0000 (21:12 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ic30774dd104bf2b329e3682312c8badc54b99ecc
MaxSem [Fri, 6 Jul 2012 20:30:25 +0000 (20:30 +0000)]
Merge "I18n of display of change tags"
Alexandre Emsenhuber [Thu, 28 Jun 2012 09:52:43 +0000 (11:52 +0200)]
Send correct HTML when reporting a MWException object and the OuputPage object cannot be used.
Currently only the body was sent, without doc type, <html>, <head> or <body> items.
Change-Id: I2d5cc3f69f55d0e1b212148f57f736f100bd2554
Antoine Musso [Fri, 6 Jul 2012 18:22:00 +0000 (20:22 +0200)]
parse.php Windows uses CTRL+Z as a EOF sequence
Follow up:
1fc2bb9 - parse.php note about using ^D to end output
The previous patch assumed ^D to be the standard.
Change-Id: If573c1a03eb9679d74fcb24c1be6931eee361158
Reedy [Fri, 6 Jul 2012 18:18:11 +0000 (18:18 +0000)]
Merge "Pass the full context to the ApiMain instance from api.php."
Alexandre Emsenhuber [Fri, 6 Jul 2012 08:41:17 +0000 (10:41 +0200)]
Pass the full context to the ApiMain instance from api.php.
Passing only the WebRequest instance is not the best
thing when it accepts a complete context.
Change-Id: If02148c850b395a2382f87cbeafbc25887ce8728
Reedy [Fri, 6 Jul 2012 16:57:40 +0000 (17:57 +0100)]
Use estimateRowPage if wiki is using wgMiserMode
Change-Id: I59404e9514a87f65faf3eb865fafe358d9f01079
jeroendedauw [Fri, 6 Jul 2012 11:36:01 +0000 (13:36 +0200)]
Added SpecialPageAfterExecute and SpecialPageBeforeExecute hooks
Danwe apparently needs them :)
Change-Id: Ic74c7ba7f4168d2b0cfbd3c4e551218f6cb2693a
MaxSem [Fri, 6 Jul 2012 13:45:15 +0000 (13:45 +0000)]
Merge "Tweaked mysql_affected_rows() check in WikiPage since it can return -1."
MaxSem [Fri, 6 Jul 2012 13:03:07 +0000 (13:03 +0000)]
Merge "Simplify factory methods of RecentChange."
MaxSem [Fri, 6 Jul 2012 12:51:53 +0000 (12:51 +0000)]
Merge "Fixed cp error in method name"
Antoine Musso [Fri, 6 Jul 2012 12:20:57 +0000 (14:20 +0200)]
rm duplicate "Antoine Musso" in README
Change-Id: I8051199582955b95542f0a258d57a80668f070d5
jeroendedauw [Fri, 6 Jul 2012 11:10:47 +0000 (13:10 +0200)]
Fixed cp error in method name
Change-Id: Idf5a397773418ee85ea17bcd3e3cbbf16d1a57b5
Alexandre Emsenhuber [Fri, 29 Jun 2012 09:51:55 +0000 (11:51 +0200)]
Simplify factory methods of RecentChange.
* Make RecentChange::newFromId() use RecentChange::newFromConds()
* We have DatabaseBase::selectRow() for the purpose of selecting
a single row.
Change-Id: Ie818205437ecea6a4860b74f49b2940c91132a66
Reedy [Wed, 4 Jul 2012 22:27:30 +0000 (23:27 +0100)]
Add some explicit member variable definitions
Bits of parameter documentation
Change-Id: If99a344222900a6715114fa61eadcd4dd3e13db6
Reedy [Thu, 5 Jul 2012 22:53:57 +0000 (23:53 +0100)]
Minor stylize, add some braces
Couple of bits of member variable docs
Change-Id: Iccf861b1b93543f21f43c50864107ec6bb233bd1
Aaron Schulz [Thu, 5 Jul 2012 21:42:39 +0000 (21:42 +0000)]
Merge "Use Linker::getInvalidTitleDescription() to display invalid title entries in Special:Undelete."
Alexandre Emsenhuber [Thu, 5 Jul 2012 21:07:58 +0000 (23:07 +0200)]
Add a context parameter to Liker::generateRollback() and Linker::buildRollbackLink() and updated callers.
This allows both methods to not always rely on global object, but also to use the local context when possible.
Change-Id: Id10f55ed9b18c889afd8d9937d9f35acb376cce4
Aaron [Thu, 5 Jul 2012 20:54:33 +0000 (13:54 -0700)]
Tweaked mysql_affected_rows() check in WikiPage since it can return -1.
In theory, a DBError or something should be thrown already; this is just for sanity.
Change-Id: Ie54dc764ee4d4c6e450b7bcff5663c1707027c6d
jeroendedauw [Thu, 5 Jul 2012 20:47:15 +0000 (22:47 +0200)]
Change entry point of SpecialPage
The old entry point is the execute method, which clearly is not meant to be an entry point,
as it's overloaded in most subclasses, making it impossible for the deriving classes to do anything
before or after (which for instance sucks big time in SpecialCachedPage).
Change-Id: I74c22a1dc3b1a9d062295d5fb709fb87577810ae
Reedy [Thu, 5 Jul 2012 20:31:39 +0000 (20:31 +0000)]
Merge "Reimplement CORS properly, addressing Tim's concerns"
Catrope [Fri, 1 Jun 2012 12:14:47 +0000 (05:14 -0700)]
Reimplement CORS properly, addressing Tim's concerns
Tim's concerns (listed at
https://bugzilla.wikimedia.org/show_bug.cgi?id=20814#c6) were:
* Lack of Vary: Origin breaks Squid caching
* Vary: Origin on everything would be disastrous, so add an origin param
* Origin header is space-separated list, wasn't treated as such
This commit:
* Remove CORS code from api.php and reimplement it in ApiMain.php
* Add 'origin' parameter to ApiMain
* If 'origin' parameter doesn't match Origin header, send a 403
* If origin is whitelisted, set CORS headers and set Vary: Origin
* Add https?:// to wildcard matching logic, wasn't there but is needed
CORS now works :) you can test it locally as follows:
Set $wgCrossSiteAJAXdomains[] = '*.wikipedia.org';
Log into MediaWiki on localhost
Go to Wikipedia, open a JS console, and run:
$.ajax( {
'url': 'http://localhost/w/api.php',
'data': {
'action': 'query',
'meta': 'userinfo',
'format': 'json',
'origin': 'https://en.wikipedia.org'
// or whichever domain you're on; must be correct!
},
'xhrFields': {
'withCredentials': true
},
'success': function( data ) {
alert( 'Foreign user ' + data.query.userinfo.name +
' (ID ' + data.query.userinfo.id + ')' );
}
} );
Change-Id: I725ce176866d7c81dd9ad6d7bc4a86b7160f2458
Catrope [Fri, 1 Jun 2012 11:11:32 +0000 (04:11 -0700)]
In ApiMain, gather Vary headers in OutputPage
Using OutputPage for this rather than something like WebResponse
probably isn't optimal, but it's a lot nicer than the mess we had
before.
Change-Id: I9dce06d3eb69dd7952eafc6c94ead2ad5ad88792
Translation updater bot [Thu, 5 Jul 2012 19:42:03 +0000 (19:42 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ie9fc1396e26a2ef8f71b74fd92c4a80bb0d8b493
Alexandre Emsenhuber [Wed, 4 Jul 2012 09:33:00 +0000 (11:33 +0200)]
Pass objects to methods accepting them instead of relying on global objects.
* Pass the User object to Title::quickUserCan()
* Pass the Context object to ChangesList::showCharacterDifference()
Change-Id: I53e5338c66c9d43b7b2257cd0515fe37dd05f5e3
Alexandre Emsenhuber [Wed, 4 Jul 2012 09:38:56 +0000 (11:38 +0200)]
Fix parameter name: $displayText does not exist, but $altUserName does.
Change-Id: Ic901d6a74701eb8c1802ac7a28c479b253353a14
Aaron Schulz [Thu, 5 Jul 2012 17:29:38 +0000 (17:29 +0000)]
Merge "Remove some old debugging code"
jeroendedauw [Thu, 5 Jul 2012 15:08:10 +0000 (17:08 +0200)]
Fix method siganture mismatch causing notice
Change-Id: If2eb0441c19f2f9635d3ce0633e2da7005a9d9b0
Krinkle [Thu, 5 Jul 2012 03:59:01 +0000 (03:59 +0000)]
Merge "(bug 37604) Update jquery.cookie.js from 2009 to 2011"
Mark Holmquist [Thu, 14 Jun 2012 19:14:30 +0000 (12:14 -0700)]
(bug 37604) Update jquery.cookie.js from 2009 to 2011
* Upstream
- version: 2009 -> 2011
- commit: https://github.com/carhartl/jquery-cookie/commit/
faa09dc38bd3c791212e8fca67ee661af55fa530
* Copyright noted 2006, but that wasn't updated until 2009..
Change-Id: Id9277c7bb99c2e0a170b4dfa3e83b7b41926ea2e
Reedy [Thu, 5 Jul 2012 01:04:16 +0000 (01:04 +0000)]
Merge "Allow API meta=siteinfo to return list of know variable IDs"
Brad Jorsch [Sat, 2 Jun 2012 20:34:18 +0000 (22:34 +0200)]
Allow API meta=siteinfo to return list of know variable IDs
To know whether something like {{foo}} is a template, variable, or
function, you have to first check if it's a magic word, and then look up
the magic word ID in the list of variables and the list of function
hooks. The API already can return the list of known magic word mappings
(siprop=magicwords) and function hooks (siprop=functionhooks), this
completes the set by allowing siprop=variables.
Change-Id: If13df9c3796ea6815393d847a3c6f70380bba58a
Reedy [Thu, 5 Jul 2012 00:58:20 +0000 (00:58 +0000)]
Merge "Sync DeviceDetection with MF"
Kaldari [Thu, 5 Jul 2012 00:54:19 +0000 (00:54 +0000)]
Merge "(bug 38152) jquery.tablesorter: Use .data() instead of .attr()"
Reedy [Wed, 4 Jul 2012 22:35:00 +0000 (22:35 +0000)]
Merge "Revert "Watchlist grouping (not ready for review)""
Daniel Werner [Sun, 24 Jun 2012 20:43:17 +0000 (22:43 +0200)]
hook InternalParseBeforeSanitize
This patch add the hook 'InternalParseBeforeSanitize' which gets called
during Parser's internalParse method just before the parser removes
unwanted/dangerous HTML tags.
Change-Id: If32053f9304088d7943aa0c9e78716a644c34fe1
Reedy [Wed, 4 Jul 2012 22:11:18 +0000 (22:11 +0000)]
Merge "*(bug 30976) Add maintenance script to remove preferences from $wgHiddenPrefs"
TyA [Wed, 30 May 2012 03:49:17 +0000 (04:49 +0100)]
*(bug 30976) Add maintenance script to remove preferences from $wgHiddenPrefs
Change-Id: Ie74fab1edeac2c6b275c51e6af3a7924b3aac46b
Reedy [Wed, 4 Jul 2012 22:01:25 +0000 (22:01 +0000)]
Merge "Fix small typo in comment"
umherirrender [Sun, 17 Jun 2012 07:59:19 +0000 (09:59 +0200)]
(bug 32383) Allow descending order for list=langbacklinks
Change-Id: I5ebcb8c3d49f85eba14c1caafb5b5b78ccee4605
umherirrender [Mon, 30 Apr 2012 12:24:48 +0000 (14:24 +0200)]
(bug 32381) Allow descending order for list=backlinks, list=embeddedin
and list=imageusage
Also avoid some filesorts when using redirect param of that modules
due to fields in order by, which are constant in where
Change-Id: I4b1c4282ab3be9cb93601c57d660520456cf8617
umherirrender [Sun, 17 Jun 2012 07:46:30 +0000 (09:46 +0200)]
(bug 32382) Allow descending order for list=iwbacklinks
Change-Id: If9425f3d6dbee3da34e875c1b02088478c3d6d53
Brad Jorsch [Sun, 17 Jun 2012 00:34:36 +0000 (20:34 -0400)]
(bug 17865) Add a "ParserAfterParse" hook
In order to correctly output an error message that might contain
wikilinks, Cite.php needs a hook that is called after the page is parsed
but before the call to replaceLinkHolders().
Change-Id: Iaa2755f994edb081eb1d176f632f7add41640dbf
Timo Tijhof [Tue, 3 Jul 2012 20:55:43 +0000 (22:55 +0200)]
(bug 38152) jquery.tablesorter: Use .data() instead of .attr()
* .data() is faster when looking up repeatedly
* .data() will return the latest value, even if it has changed over
time, whereas .attr() only gives the value as it was when the page
was generated. Much like the difference between attr() and prop()
when it comes to value, checked, disabled etc.
* Moved buildCache() call outside `if ( firstTime )`.
Tests show that this is fast enough to do on the fly. Left inline
comment with proposal on how to make this more elaborate in the
future would it become necessary.
* jquery.tablesorter.test.js:
- Add tests for bug 38152
- Clean up double quotes
- Use more descriptive id (prefix with mw-bug-)
Change-Id: Ie4f801c5b1f93617fd3fd173d2eaaf173a7604e9
Translation updater bot [Wed, 4 Jul 2012 20:03:46 +0000 (20:03 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ie04d0ed3e4238ff292aa4656e8ed897085cf04aa
Reedy [Wed, 4 Jul 2012 15:31:01 +0000 (16:31 +0100)]
Remove some old debugging code
Add a couple more bits of function parameter documentation
Change-Id: If355978801b2bfc8a51f642f53f2cea6f87fc351
Nikerabbit [Wed, 4 Jul 2012 13:03:09 +0000 (13:03 +0000)]
Merge "No need to wrap the result of DatabaseBase::select() in a ResultWrapper object."
Subramanya Sastry [Tue, 3 Jul 2012 16:16:53 +0000 (11:16 -0500)]
Added wikitext parsertests for dashes
Change-Id: I0f595f05057068e6459062fc8e8f9fad23021dec
Hashar [Wed, 4 Jul 2012 09:01:33 +0000 (09:01 +0000)]
Merge "Revert "jquery.byteLimit: Partial rewrite to fix logic errors""
Alexandre Emsenhuber [Wed, 4 Jul 2012 08:55:09 +0000 (10:55 +0200)]
No need to wrap the result of DatabaseBase::select() in a ResultWrapper object.
Change-Id: I2cceb363b4573a850a7a63c93d2ca9899e477a7f
DatabaseBase::select() already returns a ResultWrapper object, so its useless to wrap it again.
Siebrand [Wed, 4 Jul 2012 08:50:02 +0000 (08:50 +0000)]
Revert "jquery.byteLimit: Partial rewrite to fix logic errors"
This causes bug 38158.
This reverts commit
1ceab34587b98abae29bba9027838ed354330025
Siebrand [Wed, 4 Jul 2012 08:12:43 +0000 (08:12 +0000)]
Merge "f-prot isn't so open now, so might aswell not advertise it in DefaultSetttings under antivirus"
Catrope [Wed, 4 Jul 2012 06:28:37 +0000 (06:28 +0000)]
Merge "jshint: add .jshintrc / .jshintignore files"
Catrope [Wed, 4 Jul 2012 06:23:00 +0000 (06:23 +0000)]
Merge "(bug 31895) Fix bug in mediawiki.js with early domready handlers."
Catrope [Wed, 4 Jul 2012 06:17:35 +0000 (06:17 +0000)]
Merge "jquery.byteLimit: Partial rewrite to fix logic errors"
Timo Tijhof [Sat, 23 Jun 2012 14:48:09 +0000 (16:48 +0200)]
(bug 31895) Fix bug in mediawiki.js with early domready handlers.
Previously it used a local `ready` variable set to false, that is
set to true from a $.fn.ready callback. Sounds good, except that
we're not the only one in that callback list. And, more
importantly, not always the first one.
Thus if an earlier domready callback calls mw.loader, the value is
still false, and the wrong load method could be used (bug 31895).
Fixing by using $.isReady directly, which is set to true right
before the domready callback list is fired.
This is bug is impossible to hit within a MediaWiki environment
since mediawiki.js is the first script loaded from the startup
module and is blocking as well.
But browser-userscripts, greasemonkey and/or browse extensions can
sometimes get in an odd position in between or before.
Change-Id: I146c1d2245aae71c538ce84daee30b4ec490b874
Timo Tijhof [Sat, 23 Jun 2012 02:16:06 +0000 (04:16 +0200)]
jquery.byteLimit: Partial rewrite to fix logic errors
* Previously it was hooking into the keypress event, this meant
that it had to do all sorts of calculation to figure out what
the string length would be *after* the to-be-pressed key
is allowed to be pressed. This sounds trivial, but is quite the
contrary. First of all are control, alt, shift etc. those were
covered.
What wasn't covered and imho can't be realistically covered
without bugs is: copy/paste, drag/drop, text selection and
replacing or removing more at once. Or even a combination of the
above. And then there is custom insert methods such as Narayam,
where the character will not be literally inserted at all.
Therefore I've changed it to instead listen to *after* the insert.
and if necessary undo the last (one or more) characters until the
byteLimit is satisfied. This works much more stable. Still very
fast and not noticeable to the user.
This also fixes the bug where when the limit is reached, you
select all and type something else, you couldn't because it would
prevent the keypress since the limit is reached.
* Updated documentation comments.
* Updated unit tests to simulate onkeyup instead of onkeypress.
- hasLimit option in byteLimitTest() was redundant, using limit
directly, instead of duplicating it twice.
- Added more comments and better test names. Tests themselves
have not changed.
- Removed redundant tests at the bottom that no longer make sense
in the new version (and were broken) since the property is
now always unset instead of just if there is a callback.
The native limit must not interfere.
Change-Id: I9ace3ab79f488d24ad13baace32118c151c06347
Catrope [Wed, 4 Jul 2012 06:00:51 +0000 (06:00 +0000)]
Merge "(bug 36310) jquery.byteLimit should skip < 0 due to Firefox bug."