Rob Church [Fri, 18 May 2007 20:46:42 +0000 (20:46 +0000)]
* Support passing message arguments to OutputPage::showErrorPage()
* (bug 8818) Expose "wpDestFile" as parameter $1 to "uploaddisabledtext"
Rob Church [Fri, 18 May 2007 20:17:53 +0000 (20:17 +0000)]
* (bug 9628) Show warnings about slave lag on Special:Contributions, Special:Watchlist - adding this to other pages is quite simple
* A little release notes tweaking
Yuri Astrakhan [Fri, 18 May 2007 19:46:45 +0000 (19:46 +0000)]
API: disabled login module until it is more secure. added performance comment in HTML output.
Antoine Musso [Fri, 18 May 2007 19:17:21 +0000 (19:17 +0000)]
Test files for the Byte Order Mask (BOM) (see #9954)
Brion Vibber [Thu, 17 May 2007 21:04:50 +0000 (21:04 +0000)]
Forgot to bump the cache version when making RTL fixes
Brion Vibber [Thu, 17 May 2007 20:02:59 +0000 (20:02 +0000)]
Fix for regression in variant short-URLs...
Cleaned up the new URL parsing code a bit, now able to recognize both $wgActionPaths and $wgVariantArticlePath and interpolate those variables.
Moved that bit into WebRequest::interpolateTitle() function which is called after $wgContLang stub object is created, so it can be used to get the variant list.
I'm not totally happy with all this code, but it works. The variant bits generally creep me out.
Brion Vibber [Thu, 17 May 2007 18:33:00 +0000 (18:33 +0000)]
* Right-align diff line numbers in RTL language display
Use .diff-lineno class instead of hardcoding a <strong> and an alignment. Leaving default alignment does the right thing in both LTR and RTL; forcing left was unnecessary.
Also swapping alignment for the +/- marker column to improve look on RTL.
Brion Vibber [Thu, 17 May 2007 15:02:26 +0000 (15:02 +0000)]
Another tweak for wide diffs: there *is* a CSS 3 draft property (word-wrap: break-word) which can force long words to break instead of just the scrolling hackaround. Yay!
Still no love in Firefox or Opera, but fixes Internet Explorer and Safari.
works in:
Safari 2.0.4
MSIE 7.0/Win
MSIE 6.0/Win
MSIE 5.2/Mac
doesn't work in:
Opera 9.20
Firefox 2.0.3
Konqueror 3.5.6
iCab (wraps at punctuation but not in mid-word)
Niklas Laxström [Thu, 17 May 2007 14:14:33 +0000 (14:14 +0000)]
* cleanup
Antoine Musso [Thu, 17 May 2007 12:48:39 +0000 (12:48 +0000)]
Fix #9869 : '#redirect' synonym for ka:
Antoine Musso [Thu, 17 May 2007 11:28:44 +0000 (11:28 +0000)]
make wikinews local like the others
Nick Jenkins [Thu, 17 May 2007 08:05:00 +0000 (08:05 +0000)]
Trying out online PHPlint tool ( icosaedro.it/phplint/phplint-on-line.html ) using the includes/Image.php file as sample input, to see what it does.
PHPlint seems to fit somewhere in the continuum between Documentation Systems and Static Code Analysis, although most of the things it found related to documentation tags (for example, it guesses a function's parameter types where they are not specified in the @param tags, based on the way the code is used). In terms of type-of-thing-found per quantity-of-output, it's much closer to a Documentation System. However, it'll also find unused variables, and a few other things in code.
However, it's quite chatty / noisy, unless you add a number of special-purpose tags & notations to define globals and specify which PHP functions are used in the code - so it's ''probably'' not currently useful for production purposes.
Some example output, plus my notes (marked as indented, with an asterisk) -
-------------------------------------------------------
We guess the method `Image::newFromName()' returns a value of type Image
77: Warning: missing `@param Title $title' in DocBlock above:
function newFromTitle( $title ) {
81: notice: the constructor `Image' has the same name of the class. PHP 5 states it should be called `__construct()' :
function Image( $title ) {
* Have not changed this.
Line 101:
* @param $ext string (without the .)
change to:
* @param string $ext (without the .)
132: notice: from this `return' we guess the method `Image::getCacheKeys()' returns a value of type array[int]mixed
480: notice: invalid type `$', presuming mixed and trying to continue anyway - was:
* @param $mime "text/html" etc
change to:
* @param string $mime "text/html" etc
551: Warning: missing `@param TYPE $page' in DocBlock above
Add:
* @param int $page Page number to find the width of.
571: Warning: missing `@param TYPE $page' in DocBlock above
Add:
* @param int $page Page number to find the height of.
672: notice: guessed signature of the method `Image::isSafeFile()' as public boolean()
* @public
* @return boolean
711: Warning: missing `@param TYPE $query' in DocBlock above
* @param string $query URL query string
759: Warning: missing `@param TYPE $thumbName' in DocBlock above
* @param string $thumbName
798: notice: from this `return' we guess the method `Image::getTransformScript()' returns a value of type string
* @return mixed
823: declare the return type of thumbName
* @return string file name of a thumbnail with the specified parameters
919: notice: variable `$thumbMime' assigned but never used
919: notice: variable `$thumbExt' assigned but never used
* deleted these local variables.
961: Warning: missing `@param TYPE $thumbName' in DocBlock above
* @param string $thumbName File name of thumbnail.
1001: ERROR: the name `$try' is a keyword. This is deprecated by PHP and forbidden by PHPLint.
* renamed $try to $icons.
if ( $file{0} != '.' ) {
\_ HERE
1034: Warning: using deprecated character selector operator `{'. The support for this operator dropped from PHP 5.1. Use `[' instead.
* done
1060: Warning: missing `@param TYPE $archiveFiles' in DocBlock above
1060: Warning: missing `@param TYPE $shared' in DocBlock above
* @param array $archiveFiles
* @param boolean $shared
1106: notice: invalid type `$', presuming mixed and trying to continue anyway
1106: notice: unknown/unexpected symbol `urlArray' in type
change from
* @param $urlArray array
to:
* @param array $urlArray
1204: notice: from this `return' we guess the method `Image::getFullPath()' returns a value of type string
line 1189, add:
* @return string Full filesystem path to the file.
public static function isHashed( $shared ) {
\_ HERE
1210: Warning: missing `@param TYPE $shared' in DocBlock above
* @param boolean $shared
function recordUpload( $oldver, $desc, $license = '', $copyStatus = '', $source = '', $watch = false ) {
\_ HERE
1218: Warning: missing `@param TYPE $oldver' in DocBlock above
* (whinges about other params too)
1218: notice: guessed signature of the method `Image::recordUpload()' as public boolean(mixed, mixed [, string, string, string, boolean])
* @param string $oldver
* @param string $desc
* @param string $license
* @param string $copyStatus
* @param string $source
* @param boolean $watch
1400: notice: from this `return' we guess the method `Image::getLinksTo()' returns a value of type array[]
1374: notice: guessed signature of the method `Image::getLinksTo()' as public array[]([string])
1374: add:
* @return array[int]Title
1406: notice: from this `return' we guess the method `Image::getExifData()' returns a value of type array[]
1402, add:
* @return array
1451: notice: invalid type `$', presuming mixed and trying to continue anyway
1451: notice: unknown/unexpected symbol `reason' in type
1451: notice: missing parameter $name for @param no. 1
1451: notice: unknown type/class `true'
* @param string $reason
* @param boolean $suppress
* @return boolean true on success, false on some kind of failure
-------------------------------------------------------
Antoine Musso [Wed, 16 May 2007 22:04:09 +0000 (22:04 +0000)]
add 'fast' target, skip the slow 'maint' tests.
Brion Vibber [Wed, 16 May 2007 21:57:55 +0000 (21:57 +0000)]
Fix a couple regressions due to diff style changes, where diffs were shown unstyled:
* move the addition of common/diffs.css from showDiffPage() to showDiff() which catches most 'legit' cases
* hack it in to a couple of uses where getDiff() is used and manually spit out
* hack around the hacked-up custom diff table in Oversight... that should be refactored in the base class
Greg Sabino Mullane [Wed, 16 May 2007 20:31:58 +0000 (20:31 +0000)]
More defined() that should be isset(), thanks to David Ford, david@blue-labs.org
Greg Sabino Mullane [Wed, 16 May 2007 20:29:05 +0000 (20:29 +0000)]
Replace defined with isset, thanks to David Ford, david@blue-labs.org
Greg Sabino Mullane [Wed, 16 May 2007 20:21:27 +0000 (20:21 +0000)]
Check that the user is configured correctly if using Postgres
Brion Vibber [Wed, 16 May 2007 19:54:58 +0000 (19:54 +0000)]
use $wgStyleVersion in handy-dandy $wgOut->addStyle() func
Magnus Manske [Wed, 16 May 2007 19:52:22 +0000 (19:52 +0000)]
New hook 'ImageOpenShowImageInlineBefore' for upcoming extension
Brion Vibber [Wed, 16 May 2007 19:10:41 +0000 (19:10 +0000)]
Add a version constant for diff cache so it can be cleared on major updates.
Added a release note for a related diff bug
Brion Vibber [Wed, 16 May 2007 17:57:00 +0000 (17:57 +0000)]
* (bug 1438) Fix for diff table layout on very wide lines.
Diff style rules have been broken out to common/diff.css,
and the dupes removed from the default skin files.
Skins can still override the default rules.
Improvements over r22192, now known to work in:
* Firefox 2.0.0.3
* Opera 9.10 and 9.20
* Safari 2.0.4
* Konqueror 3.5.6
* MSIE/Win 7.0 (wide cells may produce vertical scrollbars as well)
* MSIE/Win 6.0 (wide cells are cropped instead of scrolling)
* MSIE/Mac 5.2.3 (wide words break instead of scrolling)
* iCab 3.0.3 (some cells provoke unnecessary horizontal scrollbar)
I've cleaned up the diff table formatting a bit, moving some attributes
from the HTML to the style sheet and consolidating the duplicated styles
into a common/diff.css file which is conditionally loaded for diff views.
Individual skins or site/user CSS can still override that style if they wish.
Greg Sabino Mullane [Wed, 16 May 2007 14:36:10 +0000 (14:36 +0000)]
Give feedback on wrong/missing args, and for invalid user.
Brion Vibber [Wed, 16 May 2007 13:59:23 +0000 (13:59 +0000)]
Fix regression in even sizing of diff columns; forgot to restore a couple bits I removed when experimenting.
Raimond Spekking [Wed, 16 May 2007 10:53:52 +0000 (10:53 +0000)]
* (bug 7859) Update Kazakh translations
Patch by AlefZet
Brion Vibber [Tue, 15 May 2007 21:24:56 +0000 (21:24 +0000)]
* (bug 1438) Fix for diff table layout on very wide lines for Gecko and
Opera-based browsers (incomplete, does not fix KHTML or MSIE)
This adds a <div> inside the <td> for diff content cells, and declares
the style for these <div>s to have overflow: auto.
In Gecko (tested Firefox 2.0) and Opera (tested 9.10 and over) this does
two things:
* The table layout treats the cells as the requested width instead of bloating
out to the widest line of content, so the table stays visible on screen
* The individual cells that are too long get horizontal scroll bars
Unfortunately this doesn't have the hoped-for effects in other tested browsers:
* MSIE 7
* Safari 2
* Konqueror 3.5
* iCab 3
But neither has it any ill effects, so... it's a start.
There's probably some other way to force the layout algorithm to behave
that I haven't quite stumbled on yet... Might have better luck with the
fixed table layout option, though that seems less friendly to the little
+ and - columns.
The C++ diff plugins will have to be updated to support this scheme, but
no harm will be done if they're not (just they won't do anything new).
Greg Sabino Mullane [Tue, 15 May 2007 18:46:04 +0000 (18:46 +0000)]
byte -> bytea
Yuri Astrakhan [Tue, 15 May 2007 18:45:20 +0000 (18:45 +0000)]
* API: JSON format now allows callback parameter
Greg Sabino Mullane [Tue, 15 May 2007 12:39:41 +0000 (12:39 +0000)]
Bug 9908: check server version and adjust rank() argument accordingly
Greg Sabino Mullane [Tue, 15 May 2007 12:14:20 +0000 (12:14 +0000)]
Re-add tableName call to insert, whitespace/docs cleanup.
Tim Starling [Tue, 15 May 2007 06:41:49 +0000 (06:41 +0000)]
Revert r22159 as per wikitech-l.
Raimond Spekking [Tue, 15 May 2007 05:58:25 +0000 (05:58 +0000)]
* (bug 9915) Update Portuguese translations
Patch by 555
* 1 German message
Yuri Astrakhan [Tue, 15 May 2007 03:35:32 +0000 (03:35 +0000)]
* API: Allow for query extensions
* API: User contrib query now uses 'contributions' db group
Greg Sabino Mullane [Tue, 15 May 2007 03:02:29 +0000 (03:02 +0000)]
Doc bug fix for 9417.
Greg Sabino Mullane [Tue, 15 May 2007 02:59:20 +0000 (02:59 +0000)]
Redo insert() function: support IGNORE option, support multi-values.
Fixes bug #9417
Yuri Astrakhan [Tue, 15 May 2007 02:16:48 +0000 (02:16 +0000)]
* API: fixed watchlist db selection ('watchlist' db group)
Greg Sabino Mullane [Mon, 14 May 2007 22:38:59 +0000 (22:38 +0000)]
Remove todo re creating users: already done elsewhere for other databases (all one of them)
Greg Sabino Mullane [Mon, 14 May 2007 22:26:25 +0000 (22:26 +0000)]
Wrap MySQL specific character set detection section in MySQL-only if loop.
Antoine Musso [Mon, 14 May 2007 20:42:19 +0000 (20:42 +0000)]
Convert comments in a --help option
Antoine Musso [Mon, 14 May 2007 20:24:10 +0000 (20:24 +0000)]
This is only for MySQL.
Yuri Astrakhan [Mon, 14 May 2007 19:09:42 +0000 (19:09 +0000)]
* API: updated documentation link
Brion Vibber [Mon, 14 May 2007 13:56:26 +0000 (13:56 +0000)]
Fix regression where $wgActionPaths were not respected when parsing info out of REQUEST_URI.
There may still be bugs with alternate/compatibility URLs, investigate further...
Niklas Laxström [Mon, 14 May 2007 10:41:37 +0000 (10:41 +0000)]
* Updates from Jhs
Raimond Spekking [Mon, 14 May 2007 09:02:21 +0000 (09:02 +0000)]
* (bug 9904) Updates of zh-cn, zh-tw
remove dupe message
Raimond Spekking [Mon, 14 May 2007 08:45:11 +0000 (08:45 +0000)]
* (bug 9904) Updates of zh-cn, zh-tw
patches by Alex S.H. Lin
Raimond Spekking [Mon, 14 May 2007 08:20:24 +0000 (08:20 +0000)]
* (bug 9873) Updates of zh-cn, zh-tw, zh-yue
patches by Shinjiman
Ilmari Karonen [Mon, 14 May 2007 07:40:10 +0000 (07:40 +0000)]
It's dead code, Jim!
Yuri Astrakhan [Mon, 14 May 2007 07:04:13 +0000 (07:04 +0000)]
* API: added property for external links (urls) retrieval
Yuri Astrakhan [Mon, 14 May 2007 06:21:49 +0000 (06:21 +0000)]
* API: added categories property
Ilmari Karonen [Mon, 14 May 2007 06:07:06 +0000 (06:07 +0000)]
All the MediaWiki: pages linked to from Special:Allmessages have at least a default value, there's no point in showing any of them as redlinks.
Yuri Astrakhan [Mon, 14 May 2007 05:28:06 +0000 (05:28 +0000)]
* New properties: links, templates, images, langlinks
* Breaking Change: imagelinks renamed into imageusage (il->iu)
* Bug fix: incorrect generator behavior in some cases
Ilmari Karonen [Mon, 14 May 2007 03:38:42 +0000 (03:38 +0000)]
rm useless "!!" left over from testing
Ilmari Karonen [Mon, 14 May 2007 03:23:02 +0000 (03:23 +0000)]
wrap links to redirects in <span class="redirect-in-category"></span> in categories, similar to what Special:Allpages does
Antoine Musso [Sun, 13 May 2007 19:20:36 +0000 (19:20 +0000)]
exif::version is static
Antoine Musso [Sun, 13 May 2007 12:44:38 +0000 (12:44 +0000)]
#9896 Documentation for wgSquidServers. Patch by Loic Dachary.
Antoine Musso [Sun, 13 May 2007 11:53:07 +0000 (11:53 +0000)]
* Bug 9123 : safer way when applying $wgLocalTZoffset.
* Add a test for Language::userAdjust()
Antoine Musso [Sun, 13 May 2007 10:46:30 +0000 (10:46 +0000)]
vim modeline
Tim Starling [Sat, 12 May 2007 19:25:25 +0000 (19:25 +0000)]
a couple of fixes
Antoine Musso [Sat, 12 May 2007 17:56:09 +0000 (17:56 +0000)]
svn:eol-style native
Aaron Schulz [Sat, 12 May 2007 17:46:50 +0000 (17:46 +0000)]
*Revert r22121, causes a lot of stuff to redirect to main page for no reason, clicking history/edit tabs results in "Editing Main Page" no matter what (Apache/2.2.3_)
Niklas Laxström [Sat, 12 May 2007 16:07:27 +0000 (16:07 +0000)]
* Random cleanup
Tim Starling [Sat, 12 May 2007 15:44:54 +0000 (15:44 +0000)]
Use $_SERVER['REQUEST_URI'] instead of $_SERVER['PATH_INFO'], because Apache 2.x corrupts the latter. Idea came from trac.agavi.org/ticket/502 .
Ivan Lanin [Sat, 12 May 2007 05:32:29 +0000 (05:32 +0000)]
Indonesian (id) localisation updates.
Tim Starling [Fri, 11 May 2007 20:03:05 +0000 (20:03 +0000)]
Removed identical language class, used a fallback instead.
Brion Vibber [Fri, 11 May 2007 19:25:53 +0000 (19:25 +0000)]
keep compat link for be-x-old for now
Greg Sabino Mullane [Fri, 11 May 2007 18:44:51 +0000 (18:44 +0000)]
Clarify that wgDBport is not for mysql, make explicit sections.
Tim Starling [Fri, 11 May 2007 17:05:10 +0000 (17:05 +0000)]
typo
River Tarnell [Fri, 11 May 2007 16:42:18 +0000 (16:42 +0000)]
instead of storing every mail as a job, have a job to send enotif updates for the whole mail at once.
Rotem Liss [Fri, 11 May 2007 15:35:38 +0000 (15:35 +0000)]
Update.
River Tarnell [Fri, 11 May 2007 15:21:06 +0000 (15:21 +0000)]
english stripping
Tim Starling [Fri, 11 May 2007 15:00:19 +0000 (15:00 +0000)]
Renaming be-x-old to be-tarask, changing name to "Беларуская (тарашкевіца)" as suggested on wikipedia-l.
Rotem Liss [Fri, 11 May 2007 14:16:05 +0000 (14:16 +0000)]
Update.
River Tarnell [Fri, 11 May 2007 12:03:01 +0000 (12:03 +0000)]
(bug 9877) Fix Catalan translation of rev-deleted-text-view
River Tarnell [Fri, 11 May 2007 10:52:39 +0000 (10:52 +0000)]
NS_MAIN should have no translation, breaks article name generation (cf. #9876)
Raimond Spekking [Fri, 11 May 2007 09:46:43 +0000 (09:46 +0000)]
* (bug 9873) Updates of zh-cn, zh-tw, zh-yue
patches by Shinjiman
River Tarnell [Fri, 11 May 2007 07:49:32 +0000 (07:49 +0000)]
fixes
River Tarnell [Fri, 11 May 2007 07:44:40 +0000 (07:44 +0000)]
nextJobDB should have a way to pick a db having specific type of job in the queue
River Tarnell [Fri, 11 May 2007 07:36:05 +0000 (07:36 +0000)]
runJobs should have a way to only run certain types of job
Raimond Spekking [Fri, 11 May 2007 05:36:33 +0000 (05:36 +0000)]
* (bug 9871) Update Swedish translations
Patch by Lejonel
Ivan Lanin [Fri, 11 May 2007 03:47:13 +0000 (03:47 +0000)]
Sundanese (su) localisation updates from BetaWiki.
Ivan Lanin [Fri, 11 May 2007 02:07:47 +0000 (02:07 +0000)]
Indonesian (id) localisation updates.
Aaron Schulz [Fri, 11 May 2007 00:36:21 +0000 (00:36 +0000)]
*nest deletion per row, to avoid racing
Aaron Schulz [Thu, 10 May 2007 22:10:25 +0000 (22:10 +0000)]
*Add a script to delete archived images
Aaron Schulz [Thu, 10 May 2007 21:50:57 +0000 (21:50 +0000)]
*Comment: based on deleteOldRevisions.php
Antoine Musso [Thu, 10 May 2007 21:40:23 +0000 (21:40 +0000)]
Fix #7070: monobook/user.gif has antialias artifacts
Patch by Ryan Finnie
Aaron Schulz [Thu, 10 May 2007 21:17:09 +0000 (21:17 +0000)]
*opps, fix doc comment
Antoine Musso [Thu, 10 May 2007 21:05:36 +0000 (21:05 +0000)]
Fix #5375: profiling does not respect read-only mode
Aaron Schulz [Thu, 10 May 2007 21:05:10 +0000 (21:05 +0000)]
*Add a script to delete archived revisions
Antoine Musso [Thu, 10 May 2007 20:51:15 +0000 (20:51 +0000)]
Some fixes to avoid Xml::element call with null content when we actually want
to open a XML element. It should help fix bug #5312 later on.
* XML attributes rendering now made by private Xml::expandAttributes() method
* Xml::openElement() and Xml::tags() no more rely on Xml::element() with
a null content.
* Fix wfElement() call with null content when we actually open an element.
Raimond Spekking [Thu, 10 May 2007 20:01:27 +0000 (20:01 +0000)]
* (bug 7859) Update Kazakh translations
Patch by AlefZet
Raimond Spekking [Thu, 10 May 2007 19:53:55 +0000 (19:53 +0000)]
* (bug 7859) Update Kazakh translations
* (bug 7971) Update Kazakh extension translations
Patches by AlefZet
River Tarnell [Thu, 10 May 2007 19:29:21 +0000 (19:29 +0000)]
PHP Fatal error: Call to undefined function request() in /usr/local/apache/common-local/php-1.5/includes/HttpFunctions.php on line 8
need to qualify function with class name
Raimond Spekking [Thu, 10 May 2007 19:19:03 +0000 (19:19 +0000)]
Update German
River Tarnell [Thu, 10 May 2007 19:13:02 +0000 (19:13 +0000)]
- Http::request(), Http::post()
- don't redirect page views on POST
- Special:Export shouldn't do POST special case when page name provided
- Special:Import should use POST for interwiki fetches
Niklas Laxström [Thu, 10 May 2007 18:04:02 +0000 (18:04 +0000)]
* Bah, these two aren't even used
Niklas Laxström [Thu, 10 May 2007 17:58:33 +0000 (17:58 +0000)]
* Better use of Xml functions
Niklas Laxström [Thu, 10 May 2007 17:43:46 +0000 (17:43 +0000)]
* Updates
Niklas Laxström [Thu, 10 May 2007 17:31:10 +0000 (17:31 +0000)]
* Don't show search box when the list is empty
Niklas Laxström [Thu, 10 May 2007 17:23:07 +0000 (17:23 +0000)]
* Consistent case for plurar
Raimond Spekking [Thu, 10 May 2007 16:12:43 +0000 (16:12 +0000)]
* move hardcoded colons into message files
* make input forms nicer for RTL wikis. Should not make any difference to LTR wikis.
Tim Starling [Thu, 10 May 2007 15:55:15 +0000 (15:55 +0000)]
Fixed another stat call