From: Siebrand Mazeland <s.mazeland@xs4all.nl>
Date: Wed, 13 Feb 2013 18:49:44 +0000 (+0100)
Subject: Start yelling if a job's run() does not return bool
X-Git-Tag: 1.31.0-rc.0~20704
X-Git-Url: http://git.cyclocoop.org/data/Luca_Pacioli_%28Gemaelde%29.jpeg?a=commitdiff_plain;h=ea1f4d1bb47fb81d25981121fce3928e8a8fc82a;p=lhc%2Fweb%2Fwiklou.git

Start yelling if a job's run() does not return bool

Change-Id: Ia31be9cc5bac1427225c993911a1f77e8654f778
---

diff --git a/maintenance/runJobs.php b/maintenance/runJobs.php
index a78acd5216..3fc928843b 100644
--- a/maintenance/runJobs.php
+++ b/maintenance/runJobs.php
@@ -91,6 +91,11 @@ class RunJobs extends Maintenance {
 				$t = microtime( true );
 				$this->runJobsLog( $job->toString() . " STARTING" );
 				$status = $job->run();
+
+				if( !is_bool( $status ) ) {
+					wfWarn( $job->toString() . ' must return boolean and didn\'t!'  );
+				}
+
 				if ( $status ) {
 					$group->ack( $job ); // done
 				}