From: Kunal Mehta <legoktm@member.fsf.org>
Date: Wed, 1 Jun 2016 04:25:18 +0000 (-0700)
Subject: Make $url parameter to Parser::getExternalLinkAttribs() required
X-Git-Tag: 1.31.0-rc.0~6740^2~2
X-Git-Url: http://git.cyclocoop.org/data/Luca_Pacioli_%28Gemaelde%29.jpeg?a=commitdiff_plain;h=b07eb85267fc61adfe75d8af48e9272c46e67a4b;p=lhc%2Fweb%2Fwiklou.git

Make $url parameter to Parser::getExternalLinkAttribs() required

All callers in Gerrit pass $url in.

Change-Id: I36246f6510db414dcc7023f8779796c060c3eba5
---

diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 17098f7cd3..66298b00f3 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -1882,11 +1882,11 @@ class Parser {
 	 * (depending on configuration, namespace, and the URL's domain) and/or a
 	 * target attribute (depending on configuration).
 	 *
-	 * @param string|bool $url Optional URL, to extract the domain from for rel =>
+	 * @param string $url URL to extract the domain from for rel =>
 	 *   nofollow if appropriate
 	 * @return array Associative array of HTML attributes
 	 */
-	public function getExternalLinkAttribs( $url = false ) {
+	public function getExternalLinkAttribs( $url ) {
 		$attribs = [];
 		$rel = self::getExternalLinkRel( $url, $this->mTitle );