Merge "Avoid calling rollback() in setVisibility() when nothing changed"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 22 Jul 2016 17:40:59 +0000 (17:40 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 22 Jul 2016 17:40:59 +0000 (17:40 +0000)
1  2 
includes/revisiondelete/RevDelList.php

@@@ -234,7 -234,7 +234,7 @@@ abstract class RevDelList extends Revis
                }
  
                if ( $status->successCount == 0 ) {
-                       $dbw->rollback( __METHOD__ );
+                       $dbw->endAtomic( __METHOD__ );
                        return $status;
                }
  
                // Move files, if there are any
                $status->merge( $this->doPreCommitUpdates() );
                if ( !$status->isOK() ) {
 -                      // Fatal error, such as no configured archive directory
 -                      $dbw->rollback( __METHOD__ );
 +                      // Fatal error, such as no configured archive directory or I/O failures
 +                      wfGetLBFactory()->rollbackMasterChanges( __METHOD__ );
                        return $status;
                }