registration: Only allow one extension to set a specific config setting
authorFlorianschmidtwelzow <florian.schmidt.stargatewissen@gmail.com>
Mon, 28 Aug 2017 15:03:47 +0000 (15:03 +0000)
committerFlorianschmidtwelzow <florian.schmidt.stargatewissen@gmail.com>
Mon, 28 Aug 2017 15:03:47 +0000 (15:03 +0000)
commit29a5fc72e3ab7d3da28bc4cc91d4bb051b9a690a
tree61aac58204487a9c0aeee2ad189ceae38ed586c5
parent236456777b920047b8b8502628143b218c486d8b
registration: Only allow one extension to set a specific config setting

ExtensionProcessor would previously just blindly overwrite duplicate
config settings, which ends up depending upon load order.

It's relatively hard to debug since it is silently overwritten. This now
throws exceptions in case of duplicate config settings.

This will also have some side-effects of catching people putting things
like "ResourceModules" in their "config" section when it should be a
top-level item.

Bug: T152929
Depends-On: I4c5eaf87657f5dc07787480a2f1a56a1db8c714f
Change-Id: Ieeb26011e42c741041d2c3252238ca0823b99eb4
includes/registration/ExtensionProcessor.php
tests/phpunit/includes/registration/ExtensionProcessorTest.php