jenkins-bot [Tue, 31 Jul 2018 05:34:30 +0000 (05:34 +0000)]
Merge "MagicWordFactory to replace MagicWord static members/methods"
jenkins-bot [Tue, 31 Jul 2018 04:16:10 +0000 (04:16 +0000)]
Merge "Use multibyte-aware truncation to avoid invalid UTF-8 in cl_sortkey_prefix"
Bartosz Dziewoński [Mon, 30 Jul 2018 15:25:25 +0000 (17:25 +0200)]
Pass $title to 'GetLinkColours' hook
I think it's reasonable for link "colours" to depend on the page on
which they are shown. It seems similar to how self-links are handled.
The $colours variable is not cached, so title-specific link colours
will not "leak" to other titles.
Used in ProofreadPage in Ic910c2c33a6f1f8a70d9a122fbd2128428f29bd5.
Bug: T199288
Change-Id: I7378102a3e06544e9e695b255982c9bb0cfbf3a2
jenkins-bot [Mon, 30 Jul 2018 22:40:40 +0000 (22:40 +0000)]
Merge "API: Update query modules for MCR"
Translation updater bot [Mon, 30 Jul 2018 19:54:33 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I2a9594ddac8152a66caadade3c0293a16942d42a
Bartosz Dziewoński [Mon, 30 Jul 2018 19:37:45 +0000 (21:37 +0200)]
Use multibyte-aware truncation to avoid invalid UTF-8 in cl_sortkey_prefix
The invalid UTF-8 could cause incorrect sorting of affected pages in
category lists on wikis using UCA collations. On my local testing
wiki, the generated cl_sortkey was just 0x30 regardless of the value
of cl_sortkey_prefix.
This doesn't fix existing bad data in the database. It will only be
updated when the affected page is edited (or null-edited).
The cl_timestamp field will also be updated when that happens, which
apparently may affect Wikinews' DynamicPageList extension, according
to comments on T27254. This is not easily avoidable.
Bug: T200623
Change-Id: I4baa9ea3c7f831ff3c9c51e6b8e5d66e7da42a91
Aryeh Gregor [Tue, 24 Jul 2018 16:44:09 +0000 (19:44 +0300)]
MagicWordFactory to replace MagicWord static members/methods
Static members of MagicWord have been removed.
Static methods are soft-deprecated and forward to the factory. They
will be hard-deprecated when all callers are removed from core.
MagicWord::clearCache() has been removed. Instead, call
resetServiceForTesting( 'MagicWordFactory' ) on your MediaWikiServices
object.
Change-Id: Ie061fe90f9b9eca0cbf7e8199d9ca325c464867a
Bug: T200247
jenkins-bot [Mon, 30 Jul 2018 14:07:39 +0000 (14:07 +0000)]
Merge "Special:NewPages: Change to use OOUI"
jenkins-bot [Mon, 30 Jul 2018 12:48:49 +0000 (12:48 +0000)]
Merge "Improve test coverage for OutputPage"
jenkins-bot [Mon, 30 Jul 2018 12:27:38 +0000 (12:27 +0000)]
Merge "Treat all time values on Special:Watchlist as floats"
Aryeh Gregor [Mon, 23 Jul 2018 18:26:32 +0000 (21:26 +0300)]
Improve test coverage for OutputPage
Raises coverage locally from 16.10% to 26.81%.
Change-Id: Ib564624c644ee6620ac06872f5684831acaaaadb
Depends-On: I79c4e37092958c63a693194b27a9eafae70cb2f8
Matěj Suchánek [Sun, 29 Jul 2018 09:54:45 +0000 (11:54 +0200)]
Treat all time values on Special:Watchlist as floats
PHP division may return float or int, depending on the operands. [1]
Make sure all numbers are of the same type (floats), because
XmlSelect compares values with ===.
[1] http://php.net/manual/en/language.operators.arithmetic.php
Bug: T199566
Change-Id: I37df6fd425f47d9a4562d83e04fcb50c3b97e0da
addshore [Mon, 30 Jul 2018 10:01:37 +0000 (11:01 +0100)]
Add @since tag for MediaWikiServices::getConfigRepository
Change-Id: I9c92b9640526c5a8dee2e994a5d0b1bc27d43381
jenkins-bot [Mon, 30 Jul 2018 09:06:42 +0000 (09:06 +0000)]
Merge "Move utility methods from ApiTestCase to MediaWikiTestCase"
jenkins-bot [Mon, 30 Jul 2018 03:14:34 +0000 (03:14 +0000)]
Merge "Use array_merge() for OutputPage::$mLanguageLinks, not +"
Pankajeshkr [Sat, 12 Mar 2016 09:53:20 +0000 (15:23 +0530)]
Special:NewPages: Change to use OOUI
Bug: T117739
Change-Id: I802d215374c0b5247247dd4ae2facce251e8d369
Translation updater bot [Sun, 29 Jul 2018 19:55:00 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3d04523e2e1357fb5f5b69bb91b5d51d65dcdf1b
Aryeh Gregor [Wed, 25 Jul 2018 18:36:56 +0000 (21:36 +0300)]
Use array_merge() for OutputPage::$mLanguageLinks, not +
Based on documentation together with inspection of some callers, the
intent seems to be that this is an indexed array, not associative. +
will therefore do totally the wrong thing, ignoring any new values that
have the same key as an existing item (e.g., '0' or '1'). Even if it
was an associative array, + keeps the values on the left-hand side,
which means you normally want to do $foo = $bar + $foo instead of $foo
+= $bar if you want to overwrite old values with the new ones.
Before this change, calling addLanguageLinks() or
addParserOutputMetadata() would generally not add all of the links it
was supposed to if there were already links defined. (It could still
work if the arrays' keys didn't conflict for some reason, e.g.,
something passed an associative array or an indexed array with a hole.)
I don't know if anything actually hits this bug, because it's likely
that callers usually add all their links at once. I find no uses of
addLanguageLinks() at all.
I found this bug while working on adding more tests for OutputPage, and
the tests for this change will be submitted later in
Icdc0288c04b8c4ba841f9fbb3e05a0cdc8a20fa5.
Change-Id: I53f6e7ea94417b0034371e56e733e8c86af21658
Aryeh Gregor [Tue, 24 Jul 2018 14:50:03 +0000 (17:50 +0300)]
Move utility methods from ApiTestCase to MediaWikiTestCase
Change-Id: I79c4e37092958c63a693194b27a9eafae70cb2f8
jenkins-bot [Sun, 29 Jul 2018 00:32:46 +0000 (00:32 +0000)]
Merge "GlobalFunctions: Hard-deprecate wfUseMW, unused"
James D. Forrester [Sat, 28 Jul 2018 23:59:08 +0000 (16:59 -0700)]
GlobalFunctions: Hard-deprecate wfUseMW, unused
Change-Id: Ifa532f2fb7d482238e4b922f622a79b9ab6540e8
Max Semenik [Sat, 28 Jul 2018 20:59:22 +0000 (13:59 -0700)]
Make sure to not unpack an associative array into parameter list
Bug: T200394
Change-Id: I9c28e1cadeb76275d24eb7725f1578bf5ba43ad0
jenkins-bot [Sat, 28 Jul 2018 21:43:04 +0000 (21:43 +0000)]
Merge "Guard against uncountable tag values"
Sam Wilson [Sat, 30 Jun 2018 07:55:47 +0000 (15:55 +0800)]
Guard against uncountable tag values
As of PHP 7.2 counting false or null raises a "Warning: count(): Parameter must be an array or an object that implements Countable".
Bug: T182377
Bug: T196793
Change-Id: I7ca38bc55ae04f68106fe0d27c7d496da1538459
Translation updater bot [Sat, 28 Jul 2018 19:57:49 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8b1b0ee78ffc63ec22a29175249ec4eae1c8afdc
Kunal Mehta [Wed, 25 Jul 2018 23:40:47 +0000 (16:40 -0700)]
Use LogPage::validTypes() instead of $wgLogTypes in a few places
This is preparation for T200385, which will add a hook to modify the
list of known log types, which will bypass the global variable.
Change-Id: I763cf8b71a98d1dba5f9964fc8d919a268c5d8a5
Max Semenik [Sat, 28 Jul 2018 03:13:57 +0000 (20:13 -0700)]
Enclose compact() call in error suppression
In PHP 7.3, compact() now emits warnings when a variable doesn't exist.
Because our language files aren't required to contain all the possible
variables, this results in massive spam trying to run tests.
Change-Id: Idab0340ec1cdebfca67cb448e350a408438bcbbc
Brad Jorsch [Fri, 16 Feb 2018 18:23:45 +0000 (13:23 -0500)]
API: Update query modules for MCR
MCR deprecated the Revision class in favor of the broadly similar
RevisionRecord, and more interestingly added the concept of multiple
content "slots" to revisions.
Thus, prop=revisions, prop=deletedrevisions, and so on gain a parameter
to specify which slots are wanted. When this new parameter is not
specified (and any content-related props are specified), a warning about
the legacy format will be issued.
The rest of the modules just needed to call methods or use constants on
RevisionRecord instead of Revision. ApiQueryDeletedrevs wasn't touched,
since it has been deprecated since 1.25 anyway.
This also updates a few non-query modules that don't depend on details
of editing, diffing, or viewing MCR revisions that haven't been figured
out yet.
Bug: T200568
Change-Id: I1327d1784f5cedb006cd74df834cf9a560a77a5d
Translation updater bot [Fri, 27 Jul 2018 19:54:02 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibec891ce84ce50657b8b3486f5be27629e6404f5
jenkins-bot [Fri, 27 Jul 2018 18:33:44 +0000 (18:33 +0000)]
Merge "Remove two unused OutputPage methods"
jenkins-bot [Fri, 27 Jul 2018 10:04:02 +0000 (10:04 +0000)]
Merge "Disallow empty paths in LockManager"
jenkins-bot [Fri, 27 Jul 2018 08:30:49 +0000 (08:30 +0000)]
Merge "Correct recent schema changes for MSSQL, Oracle"
jenkins-bot [Fri, 27 Jul 2018 06:53:16 +0000 (06:53 +0000)]
Merge "Fix test database prefix in ParserTestTopLevelSuite"
jenkins-bot [Thu, 26 Jul 2018 23:20:35 +0000 (23:20 +0000)]
Merge "HistoryAction: Implement HistoryPageToolLinks hook for adding more links"
jenkins-bot [Thu, 26 Jul 2018 22:34:00 +0000 (22:34 +0000)]
Merge "Check for right-* messages as a structure test"
jenkins-bot [Thu, 26 Jul 2018 22:26:11 +0000 (22:26 +0000)]
Merge "Segregate right to edit sitewide CSS/JS"
jenkins-bot [Thu, 26 Jul 2018 21:37:00 +0000 (21:37 +0000)]
Merge "Deprecate $wgExternalDiffEngine = 'wikidiff2'"
Kunal Mehta [Thu, 26 Jul 2018 21:14:54 +0000 (14:14 -0700)]
Check for right-* messages as a structure test
Structure tests run for extensions as well, which this test should. All
user rights should have right-* messages for display in the interface.
Bug: T143156
Change-Id: I23b8eb66bc68121b2ae17e73e705acd3e6f2d053
jenkins-bot [Thu, 26 Jul 2018 20:06:13 +0000 (20:06 +0000)]
Merge "Prefill username in form when calling Special:Log/<username>"
jenkins-bot [Thu, 26 Jul 2018 19:33:03 +0000 (19:33 +0000)]
Merge "Handle $title === null in Title::newFromText"
jenkins-bot [Thu, 26 Jul 2018 19:17:35 +0000 (19:17 +0000)]
Merge "SelectWithInput: Add 'disabled' property on main widget"
jenkins-bot [Thu, 26 Jul 2018 18:59:10 +0000 (18:59 +0000)]
Merge "GlobalFunctions: Enable patch-coverage for wfExpandUrl test"
jenkins-bot [Thu, 26 Jul 2018 18:48:28 +0000 (18:48 +0000)]
Merge "INSTALL: Don't warn against using PHP "as a CGI plugin""
jenkins-bot [Thu, 26 Jul 2018 18:46:06 +0000 (18:46 +0000)]
Merge "Update jetbrains/phpstorm-stubs"
Gergő Tisza [Thu, 26 Jul 2018 18:39:21 +0000 (20:39 +0200)]
Handle $title === null in Title::newFromText
This relied on TitleCodec throwing MalformedTitleException in the
past, but that is fragile as other parts of the logic do not
expect null.
Bug: T200456
Change-Id: I1aca3971e2a9c0b1fe3adbcf34f3ee65b2271234
Aaron Schulz [Thu, 26 Jul 2018 17:42:34 +0000 (10:42 -0700)]
Disallow empty paths in LockManager
Fix broken FileBackend test that had paths normalizing to null.
Change-Id: I8a7e88ae44118cc9578e1b306a5a008ccefc23af
Reedy [Thu, 26 Jul 2018 16:31:49 +0000 (17:31 +0100)]
Update composer/spdx-licenses to 1.4.0 and mediawiki/mediawiki-codesniffer to 21.0.0
https://github.com/composer/spdx-licenses/compare/1.3.0...1.4.0
Change-Id: I39f7a1310455159866bfed5224536e800befec0d
Reedy [Thu, 26 Jul 2018 17:14:22 +0000 (18:14 +0100)]
Update jetbrains/phpstorm-stubs
Change-Id: I553afcc8f0126b9611dd9fce26029bd9c9e17071
Jayprakash12345 [Thu, 26 Jul 2018 16:50:56 +0000 (22:20 +0530)]
Prefill username in form when calling Special:Log/<username>
Bug: T200446
Change-Id: I3f2fcedee8440d5943e556f7c1c06dfb1085e549
jenkins-bot [Thu, 26 Jul 2018 15:06:41 +0000 (15:06 +0000)]
Merge "Upstream EasyDeflate library from VisualEditor"
jenkins-bot [Thu, 26 Jul 2018 12:06:05 +0000 (12:06 +0000)]
Merge "Deprecate public access to some DifferenceEngine properties"
Gergő Tisza [Wed, 11 Jul 2018 11:11:25 +0000 (13:11 +0200)]
Deprecate $wgExternalDiffEngine = 'wikidiff2'
The value 'wikidiff2' for $wgExternalDiffEngine was obsoleted in
I32b670ebf6 but not formally deprecated. Let's do that now.
Change-Id: Ie5ccd3895544cf393885b84d38eca6003c79e8ad
Depends-On: I33c6207cfc5fb66987d31818bc27055f597d28c7
Gergő Tisza [Wed, 11 Jul 2018 08:54:58 +0000 (10:54 +0200)]
Deprecate public access to some DifferenceEngine properties
These had no business being public in the first place and there is
no usage in Gerrit. In case something does use them, it will probably
be broken by the refactoring that's soon to come, so the deprecation
warning makes it easier to figure out where the problem lies.
Change-Id: I72ba5cfbf91f4af16028ba4f8619df6a7168a786
Aryeh Gregor [Wed, 25 Jul 2018 14:57:23 +0000 (17:57 +0300)]
Use setContentLang() instead of setMwGlobals()
This changes behavior in some tests by making them set $wgLanguageCode
as well as $wgContLang, but that seems like a good thing.
Bug: T200246
Change-Id: I936888f46ff9fefe2707efba837e2ce3a7ca5e3f
Aryeh Gregor [Tue, 24 Jul 2018 13:45:02 +0000 (16:45 +0300)]
Remove two unused OutputPage methods
addMetadataLink and getMetadataAttribute were added in 2004 (
22f8c4ce)
for functionality that was moved to extensions in 2011 (
27c3b22b).
Those extensions, CreateCommonsRdf and DublinCoreRdf, now use
addHeadItem() directly. There are no other callers in core or
extensions.
Change-Id: I4bc21fdaefc8f56969a2950eb53b340bf4aac399
jenkins-bot [Thu, 26 Jul 2018 09:05:18 +0000 (09:05 +0000)]
Merge "Use 'default' instead of 'value' in HTMLTextField"
Kevin Israel [Thu, 26 Jul 2018 05:36:19 +0000 (01:36 -0400)]
INSTALL: Don't warn against using PHP "as a CGI plugin"
This note is very old; it was added in r2832 (
635388356be70130) and
r3285 (
7ab7a50cf928861f). Modern versions of MediaWiki support CGI and
FastCGI installations nearly as well as mod_php installations. In fact,
Wikimedia currently uses HHVM's "fastcgi" server type, and intends to
use php-fpm with PHP 7 (see migration plan in T176370).
For a basic MediaWiki installation using the web installer, the only
difference I know of is the default URLs: /w/index.php?title=$1 for CGI,
as opposed to /w/index.php/$1 for mod_php. This issue is easy to fix by
changing $wgArticlePath, if the web server sets REQUEST_URI. Admins who
want to use short URLs (e.g. /wiki/$1) have to do this anyway.
Also, in img_auth.php and the "img-auth-nopathinfo" message, don't imply
that CGI and FastCGI server configurations generally can't provide path
information or support MediaWiki features that need it.
Change-Id: I89212e9d51f950a58f911083b9e109b69cd4e060
jenkins-bot [Wed, 25 Jul 2018 22:49:39 +0000 (22:49 +0000)]
Merge "Add helper trait for deprecating properties"
Aaron Schulz [Mon, 25 Jun 2018 12:16:15 +0000 (13:16 +0100)]
Make MessageCache use APC for big messages
Bug: T118893
Change-Id: I418d0ca490911d7ee4213fe1728cfbc637ef8b10
Translation updater bot [Wed, 25 Jul 2018 19:57:29 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I69852319aa363902ca532563bee3938103e1be41
Jayprakash12345 [Wed, 25 Jul 2018 19:38:16 +0000 (01:08 +0530)]
Use 'default' instead of 'value' in HTMLTextField
Bug: T193087
Change-Id: I631970797a778caa77d3605e0a5b8ca00e2cb56e
Timo Tijhof [Wed, 25 Jul 2018 17:24:48 +0000 (18:24 +0100)]
GlobalFunctions: Enable patch-coverage for wfExpandUrl test
Change-Id: I3b4594dab0aba659cc47233f7be3da751066b7de
jenkins-bot [Wed, 25 Jul 2018 17:06:06 +0000 (17:06 +0000)]
Merge "Make the 'other' option superessable in getSuggestedDurations"
jenkins-bot [Wed, 25 Jul 2018 16:23:13 +0000 (16:23 +0000)]
Merge "Follow-up
9742d569b: Replace accidental \t in i18n with a space"
jenkins-bot [Wed, 25 Jul 2018 16:22:22 +0000 (16:22 +0000)]
Merge "Deprecate $wgShowSQLErrors and $wgShowDBErrorBacktrace and make nonfunctional"
Bill Pirkle [Tue, 17 Jul 2018 16:51:36 +0000 (11:51 -0500)]
Deprecate $wgShowSQLErrors and $wgShowDBErrorBacktrace and make nonfunctional
Clarify and simplify exception output by deprecating
$wgShowSQLErrors and wgShowDBErrorBacktrace.
$wgShowExceptionDetails will now control most related output.
$wgShowHostnames will now solely control output of
MWExceptionRenderer::reportOutageHTML.
Bug: T165768
Change-Id: Idead2c11c499463dfa6293c3d4b33be3bde92e1a
James D. Forrester [Wed, 25 Jul 2018 15:34:51 +0000 (08:34 -0700)]
Follow-up
9742d569b: Replace accidental \t in i18n with a space
Change-Id: Id8ad5916b7dd59a078fb600c7998e41f1b8abd3c
jenkins-bot [Wed, 25 Jul 2018 15:33:48 +0000 (15:33 +0000)]
Merge "Make load* methods of DifferenceEngine idempotent"
jenkins-bot [Wed, 25 Jul 2018 14:52:44 +0000 (14:52 +0000)]
Merge "cache: Minor docs for MessageCache interaction with WANObjectCache"
Timo Tijhof [Sun, 22 Jul 2018 23:52:41 +0000 (00:52 +0100)]
cache: Minor docs for MessageCache interaction with WANObjectCache
Follows-up
04bc03a29a.
Change-Id: I8fb810fc2e08277bb64fa18595483a2161cfb1cc
jenkins-bot [Wed, 25 Jul 2018 11:59:58 +0000 (11:59 +0000)]
Merge "Fallback language for Santali should be English"
Prateek Saxena [Wed, 25 Jul 2018 05:29:03 +0000 (10:59 +0530)]
SelectWithInput: Add 'disabled' property on main widget
…also HTMLSelectAndOtherField and HTMLSelectOrOtherField now
pass the 'disabled' field when creating the input widget.
The OOUI versions of these HTMLFormFields would get enabled
right after infusion even they were disabled in PHP. This
makes sure that they remain disabled.
Change-Id: Iddd8ad81731dba7bdcb599d6fe104cb259b11733
jenkins-bot [Wed, 25 Jul 2018 05:29:12 +0000 (05:29 +0000)]
Merge "ApiBase: Use prefixed parameter name for 'missingparam' error"
jenkins-bot [Wed, 25 Jul 2018 04:40:53 +0000 (04:40 +0000)]
Merge "Make OutputPage::mPagetitle private"
jenkins-bot [Wed, 25 Jul 2018 04:16:18 +0000 (04:16 +0000)]
Merge "objectcache: improve logging and error handling in BagOStuff"
Martin Urbanec [Tue, 24 Jul 2018 19:47:50 +0000 (21:47 +0200)]
Fallback language for Santali should be English
Bug: T200290
Change-Id: I65005b8b31bd022c7978628f69c5d56d735063e3
Translation updater bot [Tue, 24 Jul 2018 19:53:03 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Idbc346a6c0d5bf2bdc2278bc2ef3440579500dc7
Aaron Schulz [Thu, 12 Jul 2018 15:26:13 +0000 (16:26 +0100)]
objectcache: improve logging and error handling in BagOStuff
Bug: T198239
Bug: T199383
Change-Id: I0b4110396d03b98e83a7b614caf57d7e7c284361
jenkins-bot [Tue, 24 Jul 2018 16:18:25 +0000 (16:18 +0000)]
Merge "PageArchive: Pass correct overrides to newRevisionFromArchiveRow()"
jenkins-bot [Tue, 24 Jul 2018 16:13:39 +0000 (16:13 +0000)]
Merge "Avoid a redirect loop when the request URL is not normalized"
Huji Lee [Mon, 30 Apr 2018 01:38:42 +0000 (21:38 -0400)]
Make the 'other' option superessable in getSuggestedDurations
Bug: T193364
Change-Id: Ic2dbc961f7eebad11da53724b9cce2f804ffad39
Aryeh Gregor [Tue, 24 Jul 2018 13:38:44 +0000 (16:38 +0300)]
Make OutputPage::mPagetitle private
Code search revealed only one outside access, which I've submitted a patch for.
Depends-On: I001deecad241b091070483d882088d2d6361ed5a
Change-Id: I0f7e565f4eacc1074c619772b2d11a47a05e3584
Thiemo Kreuz (WMDE) [Tue, 24 Jul 2018 06:02:55 +0000 (06:02 +0000)]
thiemowmde's legal name changed
I was a co-author only, and my contribution was not really
noteworthy, so I choose to remove the outdated name (in this
case only).
Change-Id: I9d9592d5b114adae633f6a4bdac2dd60f329bd7a
jenkins-bot [Tue, 24 Jul 2018 01:54:31 +0000 (01:54 +0000)]
Merge "LogEventsList: Correct typo"
jenkins-bot [Tue, 24 Jul 2018 01:13:32 +0000 (01:13 +0000)]
Merge "$wgHttpsPort should only be used in very special cases"
jenkins-bot [Mon, 23 Jul 2018 20:55:21 +0000 (20:55 +0000)]
Merge "LogPager: Add backwards-compatibility for hide_[type]_log URL params"
Translation updater bot [Mon, 23 Jul 2018 20:08:57 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8b632d4052c2634867c7d498305cf287d2fc58c9
Greg Grossmeier [Mon, 23 Jul 2018 16:45:31 +0000 (16:45 +0000)]
Revert "Ensure LanguageCode::bcp47() returns a valid BCP 47 language code"
This reverts commit
8380f0173e79b66f0e2afd6c49cd88afb9f4f6f3.
Reason for revert: Caused T199941
Bug: T199941
Change-Id: I93af756a2d70d6bc91f828fe6ac19bf10ca8788f
jenkins-bot [Mon, 23 Jul 2018 17:22:32 +0000 (17:22 +0000)]
Merge "Revert "Accept BCP 47 codes as aliases for nonstandard variants""
Greg Grossmeier [Mon, 23 Jul 2018 16:44:55 +0000 (16:44 +0000)]
Revert "Accept BCP 47 codes as aliases for nonstandard variants"
This reverts commit
0818070c59eb4e8330496796b943951c01c7a573.
Reason for revert: Caused T199941
Bug: T199941
Change-Id: I24c178eb33890477de79cbb3122861c140578011
jenkins-bot [Mon, 23 Jul 2018 16:28:45 +0000 (16:28 +0000)]
Merge "LogEventsList: Use DerivativeContext"
Bartosz Dziewoński [Mon, 23 Jul 2018 16:18:04 +0000 (18:18 +0200)]
LogEventsList: Correct typo
The parameter to getTitleInputDesc() is actually unused, so this was
not breaking anything.
Change-Id: Ia301faf511e30b4fc4542ccb80b24cf807cf731c
Brad Jorsch [Mon, 23 Jul 2018 13:22:23 +0000 (09:22 -0400)]
ApiBase: Use prefixed parameter name for 'missingparam' error
Similar errors use the prefixed parameter name, this one should too.
Bug: T200155
Change-Id: Ia14d6a9c457af06e72428c1eae14bd3849b4595a
Brad Jorsch [Mon, 23 Jul 2018 12:44:02 +0000 (08:44 -0400)]
PageArchive: Pass correct overrides to newRevisionFromArchiveRow()
Revision::newFromArchiveRow took 'page' as an override for ar_page_id,
while RevisionStore::newRevisionFromArchiveRow() needs 'page_id'.
Thanks to sanity checks elsewhere in RevisionStore, this mistaken
override causes an exception to be thrown rather than undeleted
revisions potentially pointing to the wrong page.
Bug: T200072
Change-Id: I9d7543866c674f4d8aea9ec00fcc15cbf616ca66
Prateek Saxena [Mon, 23 Jul 2018 04:22:36 +0000 (09:52 +0530)]
LogEventsList: Use DerivativeContext
Bug: T200136
Change-Id: Ie2b7753684dc0257b0b53d9c9314feeb14d99182
jenkins-bot [Mon, 23 Jul 2018 02:55:53 +0000 (02:55 +0000)]
Merge "HTMLMultiSelectField: Improve compat with GET forms with no wpFormIdentifier"
Bill Pirkle [Thu, 12 Jul 2018 22:07:54 +0000 (17:07 -0500)]
Added non-parallel fallback to MultiHttpClient when curl is unavailable
If the curl extension is not available, fall back to the existing
HttpRequestFactory and associated classes. Also added related phpunit tests.
Bug: T139169
Change-Id: I2f9d4acbb491bce28d7105e124c5cee7e16e86d7
jenkins-bot [Sun, 22 Jul 2018 23:59:18 +0000 (23:59 +0000)]
Merge "Make MessageCache use getWithSetCallback() for big messages"
Translation updater bot [Sun, 22 Jul 2018 19:52:41 +0000 (21:52 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I93c905909b83a89898922e241610275186e5346b
Gergő Tisza [Tue, 20 Mar 2018 22:44:27 +0000 (15:44 -0700)]
Segregate right to edit sitewide CSS/JS
To limit the likelihood of incidents like T189665, the ability to
edit sitewide CSS/JSON/JS is split out from editinterface, into
separate 'editsitecss', 'editsitejson' and 'editsitejs' rights.
editsitecss, editsitejs, and the right to edit another (potentially
more privileged) user's personal CSS/JS is removed from sysops, and
a new user group, interface-admin, is created specifically for that
task (along with a new grant group 'editsiteconfig').
interface-admin is granted to the first user of a new wiki, along with
sysop and bureaucrat.
Bug: T120886
Bug: T190015
Depends-On: Ia9b2ea1450aff6121dc0f3777bf029292c8aaad9
Change-Id: Ifefd872640642441e26f8b2f144ffe4b88d2eb12