Aaron Schulz [Wed, 21 Sep 2011 20:51:26 +0000 (20:51 +0000)]
Made trimCache() protected
Aaron Schulz [Wed, 21 Sep 2011 20:25:58 +0000 (20:25 +0000)]
Added lock/unlock function stubs. Fixes:
PHP fatal error in /usr/local/apache/common-local/php-1.18/includes/objectcache/MemcachedPhpBagOStuff.php line 91:
Call to undefined method MemCachedClientforWiki::lock()
Robin Pepermans [Wed, 21 Sep 2011 19:30:08 +0000 (19:30 +0000)]
* follow-up r97636: decrease indentation & mention revision per Nikerabbit
* add @since for r97071
Robin Pepermans [Wed, 21 Sep 2011 16:52:44 +0000 (16:52 +0000)]
Revert r93388 because it was a fix for r93386 which was reverted.
Sam Reed [Wed, 21 Sep 2011 16:36:43 +0000 (16:36 +0000)]
Return documentation
Sam Reed [Wed, 21 Sep 2011 16:34:23 +0000 (16:34 +0000)]
Comment out unreachable code
Remove unreachable return false;
Niklas Laxström [Wed, 21 Sep 2011 09:41:40 +0000 (09:41 +0000)]
* (bug 30245) Use the correct way to construct a log page title
Alexandre Emsenhuber [Wed, 21 Sep 2011 09:11:26 +0000 (09:11 +0000)]
Don't use isset() to check for null
Alexandre Emsenhuber [Wed, 21 Sep 2011 09:03:53 +0000 (09:03 +0000)]
Wrap the copyright when its language is not the user's language; avoids problem when direction of the two languages is different
Alexandre Emsenhuber [Wed, 21 Sep 2011 08:54:14 +0000 (08:54 +0000)]
Added missing calls to SpecialPage::setHeaders() and SpecialPage::outputHeader()
Aaron Schulz [Wed, 21 Sep 2011 08:52:57 +0000 (08:52 +0000)]
FU 97704: I was thinking the space was already added in this case
Alexandre Emsenhuber [Wed, 21 Sep 2011 08:40:40 +0000 (08:40 +0000)]
Call Linker methods statically
Aaron Schulz [Wed, 21 Sep 2011 08:39:36 +0000 (08:39 +0000)]
Tweaked diff size number location to make sp:contribs look prettier and more consistent with how it was without them
Alexandre Emsenhuber [Wed, 21 Sep 2011 07:41:45 +0000 (07:41 +0000)]
Per Nikerabbit, follow-up r97658: change getAuthor() into getPerformer() for consistency
Niklas Laxström [Wed, 21 Sep 2011 05:52:55 +0000 (05:52 +0000)]
Fix a conflict(?) in Special:Contributions in r97658.
Brian Wolff [Wed, 21 Sep 2011 00:19:09 +0000 (00:19 +0000)]
Make per page edit notices work in namespaces without subpages enabled.
Brion Vibber [Tue, 20 Sep 2011 22:25:54 +0000 (22:25 +0000)]
* (bug 31048) Fix for width/height reported on Special:Upload thumbnail for EXIF-rotated images
Followup to r79867: switch the reported width/height as well as rotating the thumbnail image. This matches the logical width/height later seen when we complete the upload.
Brion Vibber [Tue, 20 Sep 2011 22:13:34 +0000 (22:13 +0000)]
* (bug 6672, 31024) Fixes for handling of images with an EXIF orientation
- sets an image's reported width/height to the logical form (portait image reports itself as portait)
- everything works in logical coordinates when sizing -- we don't touch the physical pre-rotation dimensions again until it's actual low-level resize time. This fixes several problems with incorrect thumb sizing (eg getting a 600x800 image when we asked for something that fits in 800x600 box)
- fixes unit test cases in ExifRotationTest that were reporting that the width/height were coming back with the physical form which we don't want
- removes some test cases on ExifRotationTest that tested dimension swapping in a place where we don't want it
- ensures that only logical width/height need be exposed to API etc, making exif-rotated images work via ForeignAPIRepo
Note that this may actually cause file metadata to get loaded twice during File::getPropsFromPath, as the $image parameter it passes in to the handler's getImageSize function is bogus and can't be used to fetch an already-loaded metadata blob. This should not generally be too expensive though; it's not a fast path.
Rotated files that were uploaded under previous versions may still have their width/height reversed; an action=purge on the file page will refresh it and cause thumbs to be regenerated.
Follows up on r79845, r90016, r92246, r92279, r96687, r97651, r97656, r97659.
Needs merge to 1.18.
Trevor Parscal [Tue, 20 Sep 2011 21:41:40 +0000 (21:41 +0000)]
Cleaned up leftovers from applying a patch
Sean Colombo [Tue, 20 Sep 2011 21:39:25 +0000 (21:39 +0000)]
Haz moar spaces :) ... follow-up to r97554 as per Jack Phoenix.
Raimond Spekking [Tue, 20 Sep 2011 20:49:59 +0000 (20:49 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Trevor Parscal [Tue, 20 Sep 2011 20:40:54 +0000 (20:40 +0000)]
Fixed IE6 issues in RTL mode
Brion Vibber [Tue, 20 Sep 2011 20:04:26 +0000 (20:04 +0000)]
Further tweaks to r96687, r90016, r97398, r97656 etc tests: try several thumbnail resolutions so we test both width-only and width & height requests
Alexandre Emsenhuber [Tue, 20 Sep 2011 20:00:05 +0000 (20:00 +0000)]
* Made IndexPager extend ContextSource
* Updated special pages using IndexPager or one if its subclasses to pass the context object and use it instead of global variables
* Call Linker methods statically
* Changed LogPager::getUser() to LogPager::getAuthor() to avoid conflict with ContextSource::getUser()
Robin Pepermans [Tue, 20 Sep 2011 19:47:57 +0000 (19:47 +0000)]
Fix support of legacy skins Standard & CologneBlue for user language direction: the topbar and footer used a "quickbar compensator" which relied on the topbar and footer following the content language direction.
Therefore it's easier to do it via CSS (which simplifies PHP code).
See also bug 31031.
Brion Vibber [Tue, 20 Sep 2011 19:39:17 +0000 (19:39 +0000)]
Further tweaks to r96687, r90016, r97398 etc tests: actually produce a thumbnail and check its size as well. Confirms that we're handling bounding boxes incorrectly.
Roan Kattouw [Tue, 20 Sep 2011 19:20:16 +0000 (19:20 +0000)]
Followup r97652, *actually* break the line
Roan Kattouw [Tue, 20 Sep 2011 19:18:57 +0000 (19:18 +0000)]
Break line in r97634
Brion Vibber [Tue, 20 Sep 2011 19:13:52 +0000 (19:13 +0000)]
Partial revert of broken test changes from r92246 -- for some reason it was trying to test some random handler parameter normalization instead of the actual reported width/height! Confirms that returned width/height are incorrect for exif-rotated images.
Niklas Laxström [Tue, 20 Sep 2011 16:26:39 +0000 (16:26 +0000)]
I broke few parser tests in r97633 by overlooking the return value. This fixes them.
Robin Pepermans [Tue, 20 Sep 2011 15:58:01 +0000 (15:58 +0000)]
r97636: ParserCache meant to be committed already too
Robin Pepermans [Tue, 20 Sep 2011 15:55:08 +0000 (15:55 +0000)]
Re-do several things of r96798 in preparation of re-doing the rest (there's a bug somewhere that needs fixing).
* Do additional validation and is_array() check in LanguageConverter
* Make redirects be in content language again (remove from Title->getPageLanguage())
* Pass title object from ParserCache to ParserOptions->optionsHash
Roan Kattouw [Tue, 20 Sep 2011 15:33:17 +0000 (15:33 +0000)]
Followup r97623: some fixes for RTL in IE70Fixes.css:
* Remove useless .rtl #bodyContent a.external rule, already handled by CSSJanus
* Flip the div#column-content div#content hack in RTL mode so the content area doesn't end prematurely on the left
* Fix display of the user icon next to the login link or user name
* External link icons are still broken in IE7+RTL, but they were already broken in 1.17 and are also broken in Vector
Niklas Laxström [Tue, 20 Sep 2011 15:19:18 +0000 (15:19 +0000)]
Added LinkCache::addGoodLinkObjFromRow, since addGoodLinkObj is not going to work much longer when new parameters are added
Niklas Laxström [Tue, 20 Sep 2011 14:53:10 +0000 (14:53 +0000)]
Use LinkBatch, instead of trying doing it manually and incompletely as it gets out of sync.
Adds one or two queries, but that shouldn't be a problem.
Alexandre Emsenhuber [Tue, 20 Sep 2011 13:57:56 +0000 (13:57 +0000)]
Fix for r97328: use SOL_SOCKET instead of SOL_UDP; fixes E_WARNING
Niklas Laxström [Tue, 20 Sep 2011 13:52:47 +0000 (13:52 +0000)]
No need to check isset before unset, shortens the code a bit, and added some whitespace
Sam Reed [Tue, 20 Sep 2011 13:36:09 +0000 (13:36 +0000)]
Followup r90749, beat Aaron
PLEASE!!!! please please please don't hide schema changes in the lists for older versions!
Roan Kattouw [Tue, 20 Sep 2011 13:21:00 +0000 (13:21 +0000)]
Reinstate IE*Fixes.css . This fixes most of the breakage from r74966, but there's one thing (icon placement) that's still broken in IE7 in RTL. Seems like it shouldn't be hard to fix though, I'll poke Trevor
Robin Pepermans [Tue, 20 Sep 2011 13:05:49 +0000 (13:05 +0000)]
As reported in bug 31031, WebKit can mess up the TOC title (which is in user language) because it inherits the direction from the page content direction.
Tim Starling [Tue, 20 Sep 2011 11:06:46 +0000 (11:06 +0000)]
* Fixed notices issued from ProfilerSimpleUDP which were due to ProfilerSimple::profileOut() not adding a complete entry to $this->mCollated for a profile error.
* Simplified other points in the code where $this->mCollated entries were added, by using template arrays $this->errorEntry and $this->zeroEntry.
* Fixed double-counting of -total due to a -total entry being added to $this->mWorkStack both by parent::__construct() and ProfilerSimple::__construct().
* Tested against 1.18wmf1 only.
Roan Kattouw [Tue, 20 Sep 2011 09:16:25 +0000 (09:16 +0000)]
For backwards compatibility with cached HTML generated by MediaWiki 1.17, re-introduce mw.loader.go() . This would have normally been a no-op, but because there is another inconsistency between 1.17 and 1.18 (loading of mw.user) I decided it to abuse it to cover that too. Thanks for Derk-Jan Hartman for reporting the JS errors on test2wiki and figuring out that they were caused by incompatibilities in Squid-cached HTML.
Roan Kattouw [Tue, 20 Sep 2011 09:13:41 +0000 (09:13 +0000)]
Accept ResourceLoader URLs containing '!' in '.' for backwards compatibility with a hack that existed in MediaWiki at some point (was in trunk and 1.17wmf1 but never in any release). This is needed because Squid-cached HTML at Wikimedia still contains such URLs.
Niklas Laxström [Tue, 20 Sep 2011 08:39:29 +0000 (08:39 +0000)]
Moved PatrolLog to logging folder, sorted the autoloaded entries alphabetically
Niklas Laxström [Tue, 20 Sep 2011 08:18:20 +0000 (08:18 +0000)]
Fixing a bug in r97495 that Aaron catched. I misinterpreted the documentation for what 'valid' means.
Tim Starling [Tue, 20 Sep 2011 01:28:08 +0000 (01:28 +0000)]
Don't call Profiler::collateData() from ProfilerSimpleUDP, it destroys $this->mCollated which was filled by profileOut(), leading to a profile with only overhead entries. Call Profiler::close() instead, like what ProfilerSimpleText does.
Chad Horohoe [Mon, 19 Sep 2011 23:25:13 +0000 (23:25 +0000)]
Back-compat for $wgProfiler set as a class. Fix for r89206
Brion Vibber [Mon, 19 Sep 2011 23:14:52 +0000 (23:14 +0000)]
Add in a 'TestCanonicalRedirect' hook to be called when about to make a redirect to the canonical page form of a regular page view. Some extensions such as MobileProfile may need to modify this logic to prevent incorrect redirects, such as on alternate en.m.wikipedia.org domain, where we'd want to either skip it or rewrite to the alternate domain.
Support for resolving bug 31012.
Aaron Schulz [Mon, 19 Sep 2011 21:55:17 +0000 (21:55 +0000)]
Removed duplication in insertArticleLink
Brion Vibber [Mon, 19 Sep 2011 21:16:00 +0000 (21:16 +0000)]
* (bug 30977) Remove directions cruft, undo random limitation of input format for Special:Filepath
Reverts r43471 which forced Special:FilePath's input to not accept titles with the File: or Image: namespace on them, or otherwise requiring any normalization beyond space/underscore.
Also removes the extra line saying 'input the name without the file: prefix' which used the native namespace name, which prompted a question about its formatting in mixed-directionality contexts.
Sean Colombo [Mon, 19 Sep 2011 20:50:08 +0000 (20:50 +0000)]
Merged in change from Wikia which prevents an E_NOTICE on Special:FewestRevisions page.
Sam Reed [Mon, 19 Sep 2011 20:27:36 +0000 (20:27 +0000)]
Followup r97551, use isLocal, more dynamic!
Sam Reed [Mon, 19 Sep 2011 20:20:41 +0000 (20:20 +0000)]
Don't try and delete ForeignAPIFile or ForeignDBFile
Add a space before the error message so it's not cramped up next to the page name
Add a success error message (explicit is better than guessing)
Antoine Musso [Mon, 19 Sep 2011 20:08:27 +0000 (20:08 +0000)]
close <span> with </span> not </p>
follow up r97101
Brion Vibber [Mon, 19 Sep 2011 20:07:40 +0000 (20:07 +0000)]
Revert r97531 -- hook call added that uses undefined local variables, will spew E_NOTICE warnings when run.
Brion Vibber [Mon, 19 Sep 2011 20:00:49 +0000 (20:00 +0000)]
* (bug 31007) Fix regression in rebuildrecentchanges maintenance script
Was trying to save literal string 'NULL' into rc_old_len / rc_new_len fields due to a bug switching to database query builder methods in r77778.
Raimond Spekking [Mon, 19 Sep 2011 19:40:55 +0000 (19:40 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Mon, 19 Sep 2011 18:53:26 +0000 (18:53 +0000)]
Enable Server side searching on Doxygen
* (bug 31004) Class reference (Doxygen docs) should have a search
Sam Reed [Mon, 19 Sep 2011 18:46:57 +0000 (18:46 +0000)]
Simplify array( 'page_id IN (' . $dbw->makeList( $batch ) . ')' ), to array( 'page_id' => $batch ),
Alexandre Emsenhuber [Mon, 19 Sep 2011 18:38:38 +0000 (18:38 +0000)]
* Removed useless isset() check
* Added two spaces
Sean Colombo [Mon, 19 Sep 2011 18:36:35 +0000 (18:36 +0000)]
Merged in a fix from Wikia to make sure to call the ArticleDeleteComplete hook from deleteBatch (this is an existing hook that should be called on article deletion). Part of the diffs here: mediawiki.org/wiki/Wikia_code
Greg Sabino Mullane [Mon, 19 Sep 2011 18:28:35 +0000 (18:28 +0000)]
Put notes in host help about PostgreSQL via unix socket, as IP is not always enabled.
Sean Colombo [Mon, 19 Sep 2011 18:25:39 +0000 (18:25 +0000)]
Merged in a change which causes update.php to be gentler (tests slave-lag). Part of the many Wikia diffs: mediawiki.org/wiki/Wikia_code
Sam Reed [Mon, 19 Sep 2011 18:09:44 +0000 (18:09 +0000)]
Push r97515 into 1.18
Niklas Laxström [Mon, 19 Sep 2011 17:00:42 +0000 (17:00 +0000)]
* (bug 30846) New LanguageOs class
Niklas Laxström [Mon, 19 Sep 2011 14:21:05 +0000 (14:21 +0000)]
Converted patrol log to the new system
Sam Reed [Mon, 19 Sep 2011 13:47:15 +0000 (13:47 +0000)]
Fix assingment in conditionals
Remove unused globals/variables
Niklas Laxström [Mon, 19 Sep 2011 12:36:58 +0000 (12:36 +0000)]
My changes in r96548 were too radical, stripping of edit commits (oops!) and rollback links on some places.
Niklas Laxström [Mon, 19 Sep 2011 11:49:22 +0000 (11:49 +0000)]
Fixing bug 30973. Strip off subpages when determining the username who the current page belongs to.
Sam Reed [Mon, 19 Sep 2011 11:33:07 +0000 (11:33 +0000)]
Remove comment from r97469
Sam Reed [Mon, 19 Sep 2011 11:31:12 +0000 (11:31 +0000)]
Fix typo from r97461, was breaking unit tests
Niklas Laxström [Mon, 19 Sep 2011 11:21:59 +0000 (11:21 +0000)]
Committing another live hack for which I'm tired of getting conflicts.
Basically I'm overriding wfWikiID to run multiple instances on same database
but with different settings, and I don't want to them mess each others caches.
Niklas Laxström [Mon, 19 Sep 2011 11:05:10 +0000 (11:05 +0000)]
Committed a polished local hack I've been using.
At times useful to see if something is hogging much memory.
Didn't really want to add a new global for this.
Niklas Laxström [Mon, 19 Sep 2011 10:43:00 +0000 (10:43 +0000)]
* (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespaces
Niklas Laxström [Mon, 19 Sep 2011 09:04:39 +0000 (09:04 +0000)]
Partial solution for bug 30972 to avoid query flood.
There is still some, because the Parser doesn't use LinkBatch but does it own queries in LinkHolderArray - seriously WTF?
Raimond Spekking [Mon, 19 Sep 2011 06:24:06 +0000 (06:24 +0000)]
Fix per Krinkle's CR r97329: "There is and should be only one kind of #filetoc. Specifying a type here makes overriding it harder, no need to specify the tag name here"
Krinkle [Sun, 18 Sep 2011 23:21:46 +0000 (23:21 +0000)]
Minor whitespace fixes in GlobalFunctions.php
* And some adjustments to documentation (sentence ended with "use the wikis", adjusted to "use the wikis' content language")
[svnblameutil:] r97136,r88447,r86368,r81597,r72134,r2969
Platonides [Sun, 18 Sep 2011 20:36:35 +0000 (20:36 +0000)]
Restore ExifBitmapTest::tearDown removed in r97398
Raimond Spekking [Sun, 18 Sep 2011 19:42:47 +0000 (19:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Sun, 18 Sep 2011 18:21:19 +0000 (18:21 +0000)]
Documentation
Fix whitespace
Set svn:eol-style native on Wikimania/README
Added 0.1 version number to Wikimania.php
Krinkle [Sun, 18 Sep 2011 17:48:58 +0000 (17:48 +0000)]
Modify 'image links' message used for the heading on the File-page showing entries in the mw_imagelinks table which contains pages that use/embed this file.
* Following the discussion on bug 30126. "File links" is confusing. Although developers will understand because of the table named 'imagelinks', other interfaces refer to this as 'usage' not a 'link'.
* Also updated message documentation
Krinkle [Sun, 18 Sep 2011 05:05:20 +0000 (05:05 +0000)]
Release-notes for bug 30843 / r97405 / r97406
Krinkle [Sun, 18 Sep 2011 05:03:03 +0000 (05:03 +0000)]
Fix lowercase test added in r97405
* (bug 30843) mediawiki.Title should not convert extensions (anything after the last full stop) to lower case
* Follows-up r97405
Krinkle [Sun, 18 Sep 2011 04:58:29 +0000 (04:58 +0000)]
Add extra unit test in Transformation for mediawiki.Title
* (bug 30843) mediawiki.Title should not convert extensions (anything after the last full stop) to lower case
* Patch my Michael M. slightly modified (moved to section "Transformation")
* Currently broken, will fix in next commit
Krinkle [Sun, 18 Sep 2011 04:50:47 +0000 (04:50 +0000)]
Move the mediawiki.test.bug30825.js helper script out of the /suites/ directory into /data/ and rename to be more re-usable.
(Follows-up r96680)
Brian Wolff [Sun, 18 Sep 2011 04:25:40 +0000 (04:25 +0000)]
(bug 18424) Clean up paging links on Special:allpages and special:prefixindex.
*Make them normal font size (my eyes! my eyes! with the tiny writing)
*Special:prefindex needs a paging link on the bottom like special:allpages (added a class name here, because I couldn't use the existing id on both)
*special:prefindex was doing $wgLang->pipeList( "full html table here", "next link here" ) which was giving bad output for the obvious reason.
Brian Wolff [Sun, 18 Sep 2011 03:32:43 +0000 (03:32 +0000)]
Make the phpunit old-style parserTest converter thingy not fall on its face if an extension registers a parserTests test file that has a period in it.
Brian Wolff [Sun, 18 Sep 2011 01:53:09 +0000 (01:53 +0000)]
Follow-up r92635 Make sure the Exif related tests handle not having the Exif extension available properly
This should fix issues reported in http://lists.wikimedia.org/pipermail/wikitech-l/2011-September/055212.html Lots of these tests loaded the exif extension dynamically, but then didn't reset $wgShowEXIF var properly.
Also change some of the markTestIncomplete to markTestSkipped as that seemed more correct.
Krinkle [Sat, 17 Sep 2011 20:21:40 +0000 (20:21 +0000)]
Revert r97386, way to soon. loader constructor has dependencies and assumptions about mw.log, mw.html and mw.messages
Krinkle [Sat, 17 Sep 2011 20:15:24 +0000 (20:15 +0000)]
[RL] Stand-alone ResourceLoader front-end
* In preparation of this, duplicating the entire file as-is in order to preserve svn history.
(Part of bug 30956)
Alexandre Emsenhuber [Sat, 17 Sep 2011 19:09:13 +0000 (19:09 +0000)]
Don't use isset() to check for null
Alexandre Emsenhuber [Sat, 17 Sep 2011 19:04:05 +0000 (19:04 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
Krinkle [Sat, 17 Sep 2011 18:03:18 +0000 (18:03 +0000)]
Use Skin->getCategories() instead of Skin->getCategoryLinks() and manually wrapping the #catlinks element around it. This to use the centralized output control, no need to duplicate the IDs and class names here.
* Also removing the conditional addition of <br />, which is no longer needed since <div> is a block level element which downs;t need a line break to start on a new line (this <br />) hasn't been needed since it's an unordered list (r92054)
* Follows-up r92054 and it's CR
Krinkle [Sat, 17 Sep 2011 18:01:54 +0000 (18:01 +0000)]
Adding padding:0px to '.catlinks ul' (Follow-up r92054). Browsers sometimes have a default padding-left: 40px; which looks ugly if the <ul> is diplayed inline with a label in front of it. Before: i.imgur.com/JWJvp.png ; After: http://i.imgur.com/Vo1nN.png
Roan Kattouw [Sat, 17 Sep 2011 15:52:45 +0000 (15:52 +0000)]
Followup to r97150 per CR: use .children() instead of .find(), more efficient and prevents potential issues with nested tables.
Roan Kattouw [Sat, 17 Sep 2011 15:50:06 +0000 (15:50 +0000)]
Followup r95562: forgot to convert one case. Thanks to Nikerabbit for providing the line number
Sam Reed [Sat, 17 Sep 2011 11:49:10 +0000 (11:49 +0000)]
Revert r97257
Krinkle [Sat, 17 Sep 2011 02:42:34 +0000 (02:42 +0000)]
(bug 30940) Add a hook in User:getDefaultOptions.
Needs back porting to 1.18 in order to fix Gadgets in REL1_18
Krinkle [Sat, 17 Sep 2011 02:32:36 +0000 (02:32 +0000)]
[RL] pass 'media' property to <link> tags as well (in already did it for the <style> tags). Fixes debug-mode bug where print stylesheet were loaded in e.g. 'skins.modern'.
* (Follows-up r88053 c22683 CR)
* Whitespace fix in Resources.php
Sean Colombo [Fri, 16 Sep 2011 23:14:13 +0000 (23:14 +0000)]
Followup to r97342 to add docs for new hook.