jenkins-bot [Thu, 14 May 2015 03:23:36 +0000 (03:23 +0000)]
Merge "Allow for dynamic TTLs in getWithSetCallback()"
Timo Tijhof [Sat, 25 Apr 2015 03:27:13 +0000 (04:27 +0100)]
Consistently name the $this callback variable "$that"
Most are already, but some had differnet names. In PHP 5.4+ this is
redundant as they inherit automatically, but we need these for PHP 5.3
compatibility. Settle on "$that" to make these easier to find.
Change-Id: I0b68b2c550fde9c2da53d844421e34b8df0c42ed
jenkins-bot [Wed, 13 May 2015 21:07:25 +0000 (21:07 +0000)]
Merge "registration: Fix having multiple callbacks for a single hook"
Translation updater bot [Wed, 13 May 2015 20:06:46 +0000 (22:06 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I33c7518add142280467483b7fce6c78ba4cdcdad
Kunal Mehta [Wed, 13 May 2015 19:30:21 +0000 (12:30 -0700)]
registration: Fix having multiple callbacks for a single hook
Bug: T98975
Change-Id: I40ff36090d18344fabdb018519209671b7883fa1
Timo Tijhof [Wed, 13 May 2015 18:23:52 +0000 (19:23 +0100)]
Add ActivityUpdateJob to autoloader
Follows-up
836ad263c. Ran generateLocalAutoload.php.
Change-Id: I12f597aa0d8100a60f2c631797a76627acbaa2ec
jenkins-bot [Wed, 13 May 2015 17:12:57 +0000 (17:12 +0000)]
Merge "objectcache: Add WANObjectCache::TTL_NONE constant for readability"
Aaron Schulz [Wed, 13 May 2015 16:55:48 +0000 (09:55 -0700)]
Added getDefaultInstance() return type doc
Change-Id: I9662738efb660f85a5c8e63c37f385d28539de75
Kevin Israel [Wed, 13 May 2015 07:36:43 +0000 (03:36 -0400)]
wfBaseConvert(): Avoid PHP warning when converting zero
The warning occurs when gmp_init() tries to convert the empty string
that came from ltrim(). This is causing tests to fail under HHVM 3.6.1.
Follows-up
5957856c46c3.
Bug: T98882
Change-Id: Ica86c91d7897db979e09d7cfc82fb3a20b95d4ce
Aaron Schulz [Wed, 13 May 2015 05:33:57 +0000 (22:33 -0700)]
objectcache: Add WANObjectCache::TTL_NONE constant for readability
Change-Id: I07592ebb2794a7a8efc0fd1d718c1b5ca3d9b83f
jenkins-bot [Wed, 13 May 2015 08:42:22 +0000 (08:42 +0000)]
Merge "Create global variables related to mediawiki.ui icons"
Prateek Saxena [Wed, 13 May 2015 04:44:16 +0000 (10:14 +0530)]
KSS: Make section headings links
Change-Id: I46aec0fcd846aa40b32eee4b24852cc0ae56a35c
Jackmcbarn [Fri, 19 Dec 2014 07:05:44 +0000 (02:05 -0500)]
Allow running code during unstrip
When adding strip markers, allow closures to be passed in place of text.
The closure is then called during unstrip. Also, add a hook that runs
after unstripGeneral. This is needed for Extension:Cite's I0e136f952.
Change-Id: If83b0623671fd67e5ccc9deaaaab456a6679af8f
jenkins-bot [Tue, 12 May 2015 22:03:21 +0000 (22:03 +0000)]
Merge "Clarify Data types doc applies to API requests"
jenkins-bot [Tue, 12 May 2015 20:57:53 +0000 (20:57 +0000)]
Merge "Add ':' to $wgInvalidUsernameCharacters"
Kunal Mehta [Tue, 12 May 2015 00:59:07 +0000 (17:59 -0700)]
Add ':' to $wgInvalidUsernameCharacters
This will prevent the creation of new users with a colon character
in their username. Existing accounts or system users will not be affected.
Colons themselves are not an issue, however they are used as the delimiter
for namespaces and interwikis. In a global account type system where there
are wikis with multiple languages, usernames that begin with a localized
namespace prefix will be invalid on some wikis and not others, which is
problematic. Preventing the usage of colons avoids that issue entirely.
Bug: T98757
Change-Id: I3c823325e209b2c48c1eee1fbc82a130c768cd2c
Brad Jorsch [Tue, 12 May 2015 20:39:38 +0000 (16:39 -0400)]
ApiQuerySiteInfo: Add invalidusernamechars
Since T98757 is talking about changing this (whether by default or not),
we should probably make it accessible via the API.
Change-Id: I8cd08b214171866208a65181f772de9f2e315cd9
Aaron Schulz [Mon, 11 May 2015 17:03:55 +0000 (10:03 -0700)]
Allow for dynamic TTLs in getWithSetCallback()
* This gives it better parity with BagOStuff::set()
* Also updated some doc comments
Change-Id: Ib94b97715fae901bac1750656e3dc7501919d6d2
jenkins-bot [Tue, 12 May 2015 20:03:02 +0000 (20:03 +0000)]
Merge "Removed executeReadyPeriodicTasks() method"
Translation updater bot [Tue, 12 May 2015 19:48:07 +0000 (21:48 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I4516b10051ed6cec36b3628fda764390f49f5bfc
Baha Man [Tue, 12 May 2015 17:19:30 +0000 (13:19 -0400)]
Create global variables related to mediawiki.ui icons
Change-Id: I6f2e64592e8985c9c14f88b0e91df1d0314a27d0
Aaron Schulz [Sat, 9 May 2015 18:42:14 +0000 (11:42 -0700)]
Added explicit profile sections to JobRunner
Change-Id: Iba60204e1ab7c81686f05b36661080c000b10157
James D. Forrester [Tue, 12 May 2015 12:26:13 +0000 (13:26 +0100)]
Update OOjs UI to v0.11.3
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.11.3/History.md
Change-Id: I3b1ffc8fd346bb6cc8f1029f64e4855afa1db168
Florian [Thu, 16 Apr 2015 16:29:02 +0000 (18:29 +0200)]
Extend mediaWiki.confirmCloseWindow to trigger it manually
Some extensions and/or functions doesn't reload the page to destroy a form
that can contain some user input. To use confirmCloseWindow to cover these forms,
too, we need a way to manually trigger this module and show the warning
to the user.
Bug: T94194
Change-Id: I897330bc62b9ef3bfd04f61f5c5d0744c8ec61d3
jenkins-bot [Tue, 12 May 2015 08:26:49 +0000 (08:26 +0000)]
Merge "Send job ACKs to statsd"
jenkins-bot [Tue, 12 May 2015 08:11:07 +0000 (08:11 +0000)]
Merge "More "check key" doc comments"
jenkins-bot [Tue, 12 May 2015 07:39:52 +0000 (07:39 +0000)]
Merge "gitignore: Add /images/cache"
jenkins-bot [Tue, 12 May 2015 05:59:16 +0000 (05:59 +0000)]
Merge "Added common metadata caching to the djvu handler"
jenkins-bot [Tue, 12 May 2015 03:08:25 +0000 (03:08 +0000)]
Merge "jobrunner: Change logging level for STARTING messages"
Aaron Schulz [Tue, 12 May 2015 02:15:35 +0000 (19:15 -0700)]
More "check key" doc comments
Change-Id: Ide66bc396e811776a58fd6aa7c1af2337ea185bd
Timo Tijhof [Tue, 12 May 2015 01:45:17 +0000 (02:45 +0100)]
gitignore: Add /images/cache
This is the default directory for FileCache (as enabled with $wgUseFileCache).
Used by HTMLFileCache (article views) and ResourceFileCache (load.php).
Change-Id: I8c3ccb734268b0902b693c2c19125f7f858898f1
Timo Tijhof [Tue, 12 May 2015 01:18:31 +0000 (02:18 +0100)]
resourceloader: Using file cache, prepend warnings after creating response
Follows-up
a4379d8f9e0 which broke the warning output.
Previously it was appending warnings to a non-existent "$response"
variable and then re-assigning it with the actual response, thus
never outputting this anywhere.
Change-Id: I6c53e7ccb4ae4783d496c06c7174c9d8a1a88b55
Timo Tijhof [Tue, 12 May 2015 00:50:28 +0000 (01:50 +0100)]
resourceloader: Use makeComment() in tryRespondFromFileCache() for safety
Other code paths in this class already make use of this method,
but this was still embedding arbitrary strings directly, at the
risk of producting invalid CSS or invalid JavaScript.
Change-Id: Ied6c420536a3dd1ef8f3816a078705136e8475b1
Aaron Schulz [Mon, 11 May 2015 23:55:42 +0000 (16:55 -0700)]
Send job ACKs to statsd
Change-Id: Idf6dcd6baf39484ac6fcf14465e13ae12405dd3a
jenkins-bot [Mon, 11 May 2015 20:40:18 +0000 (20:40 +0000)]
Merge "Made triggerOpportunisticLinksUpdate() jobs make use of parser cache"
jenkins-bot [Mon, 11 May 2015 20:40:14 +0000 (20:40 +0000)]
Merge "Remove conflicting parser function alias"
S Page [Mon, 11 May 2015 20:36:40 +0000 (13:36 -0700)]
Clarify Data types doc applies to API requests
A minor tweak only to i18n message.
Change-Id: Ia6451f8d5b47879b63823894cb92b7b9e60b2daf
Aaron Schulz [Sat, 9 May 2015 05:20:25 +0000 (22:20 -0700)]
Made triggerOpportunisticLinksUpdate() jobs make use of parser cache
* On Wikipedia, for example, these jobs are good percent of
all refreshLinks jobs; skipping the parse step should avoid
runner CPU overhead
* Also fixed bad TS_MW/TS_UNIX comparison
* Moved the fudge factor to a constant and raised it a bit
Bug: T98621
Change-Id: Id6d64972739df4b26847e4374f30ddcc7f93b54a
umherirrender [Mon, 11 May 2015 19:19:50 +0000 (21:19 +0200)]
Remove conflicting parser function alias
The alias "speciale" for parser function "special" is conflicting with
the parser function "speciale". The canonical form wins over the local
alias, so the existing alias cannot be used. Therefore removed.
Change-Id: I0fac6315384afb61c49c45b26508d4a3e1cd7b13
Translation updater bot [Mon, 11 May 2015 19:18:17 +0000 (21:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I50d2f517ecb5bc99f5f6f6086273b817d937564e
Ori Livneh [Wed, 22 Apr 2015 19:03:36 +0000 (12:03 -0700)]
Follow-up for I68b1ae842: Deprecate $wgScriptExtension as well
Change-Id: I3690f78bc57030d3f1e3992554ba0ae7eb393273
jenkins-bot [Mon, 11 May 2015 18:15:44 +0000 (18:15 +0000)]
Merge "Start using the Assert helper class for checking parameters."
jenkins-bot [Mon, 11 May 2015 18:11:41 +0000 (18:11 +0000)]
Merge "Update OOjs UI to v0.11.2"
daniel [Wed, 22 Apr 2015 16:46:29 +0000 (18:46 +0200)]
Start using the Assert helper class for checking parameters.
This introduces https://github.com/wmde/Assert as a dependency,
as discussed in the RFC T91071.
This change uses assertions to check some parameters in some places,
to showcase the main intended use case for assertions in MediaWiki.
Bug: T91071
Change-Id: I93ac39b7c146f10532e37b51d973b59b9c424b2f
James D. Forrester [Mon, 11 May 2015 17:30:52 +0000 (18:30 +0100)]
Update OOjs UI to v0.11.2
Release notes:
https://git.wikimedia.org/blob/oojs%2Fui.git/v0.11.2/History.md
Change-Id: I0188c5b80958d9a6a3d063292df724f507b7287f
Aaron Schulz [Mon, 11 May 2015 17:20:20 +0000 (10:20 -0700)]
Fixed variable collision in LocalFile::saveToCache()
Bug: T98754
Change-Id: I656b0c415e1b7ec64ee6c15d9a91ebc427663009
jenkins-bot [Mon, 11 May 2015 16:55:50 +0000 (16:55 +0000)]
Merge "Remove PHP4 "support" from using constant in update.php"
jenkins-bot [Mon, 11 May 2015 16:52:48 +0000 (16:52 +0000)]
Merge "Converted User touched key to using the WAN cache"
jenkins-bot [Mon, 11 May 2015 16:42:16 +0000 (16:42 +0000)]
Merge "Include transaction details log entry for trx write time violations"
jenkins-bot [Mon, 11 May 2015 16:41:55 +0000 (16:41 +0000)]
Merge "Avoid cache stampedes in ChangeTag class"
Bryan Davis [Mon, 11 May 2015 16:36:04 +0000 (10:36 -0600)]
jobrunner: Change logging level for STARTING messages
Mark debug log events describing the start of processing a job as debug
level information rather than informative.
Bug: T87521
Change-Id: I1ce3dabf4a344369fe396c5bb056ed5ed6308c87
jenkins-bot [Mon, 11 May 2015 16:21:20 +0000 (16:21 +0000)]
Merge "Converted LocalFile to using the WAN cache"
Aaron Schulz [Sun, 10 May 2015 19:27:38 +0000 (12:27 -0700)]
Added common metadata caching to the djvu handler
* This should reduce expensive metadata fetches
for djvu files with large (~2mb) img_metadata
Bug: T96360
Change-Id: I7273ea083f90948f8c1d8948a64929bfb759ee72
Reedy [Mon, 11 May 2015 14:34:02 +0000 (15:34 +0100)]
Remove PHP4 "support" from using constant in update.php
Change-Id: I4743d10a3084a7dc4806d73662b19aa6751b0c18
jenkins-bot [Mon, 11 May 2015 06:19:22 +0000 (06:19 +0000)]
Merge "Unbreak --profile=text for CLI scrips"
jenkins-bot [Mon, 11 May 2015 02:11:57 +0000 (02:11 +0000)]
Merge "WebRequest::getHeader: add optional flag to get back list"
Derk-Jan Hartman [Sun, 10 May 2015 14:30:14 +0000 (16:30 +0200)]
LivePreview: Process jsconfigvars
Any jsconfigvars added by the new previewed content needs to added to
the context, so that it can be used by the modules.
Bug: T92944
Change-Id: Ib990f00ebe974008cea4dccbaa212ec20c846674
Brad Jorsch [Fri, 23 Jan 2015 23:27:11 +0000 (15:27 -0800)]
API: Add output of JS config vars to action=parse
Modules will sometimes depend on these.
Bug: T67015
Change-Id: Ida3fd5f8808202892001f66c4a534c1725e769a6
Aaron Schulz [Sun, 10 May 2015 19:49:43 +0000 (12:49 -0700)]
Set isExpensiveToThumbnail for the djvu handler
* This makes FileRenderExpensive pool logic apply for large files
to cut down on DB load from getMetaTree()
Bug: T96360
Change-Id: If892d77077607ffcaba0510355175a1e4d780ae9
Aaron Schulz [Sun, 10 May 2015 18:15:25 +0000 (11:15 -0700)]
Avoid cache stampedes in ChangeTag class
Change-Id: Ieec931c4211323ae7b838c783e45e1a83a7bb6a1
Aaron Schulz [Sat, 9 May 2015 18:44:29 +0000 (11:44 -0700)]
Bump ReplicatedBagOStuff @since
Removed from 1.25 with I961d642e056f3c8087e1c2155e884a5ca5fcbe51
Change-Id: I1b84a03e35c9fe7ea58ef1b80514af062e3d635a
Translation updater bot [Sat, 9 May 2015 18:53:00 +0000 (20:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If24737f37cbf0682d7e90f300b16ee30a6316b19
Timo Tijhof [Sat, 9 May 2015 04:28:10 +0000 (05:28 +0100)]
resourceloader: Use absolute file path in SpecialCharactersDataModule
Follows-up
ec2330f.
When called, it fails fails:
> file_get_contents(resources/src/mediawiki.language/specialcharacters.json):
> failed to open stream: No such file or directory
Needs to be expanded relative to $IP, just like ResourceLoaderFileModule
and others do already.
Not previously caught by unit tests because this method was never
called from any tests.
Change-Id: Id87b3de29a61039d87b630202f1f71f112cbd752
Aaron Schulz [Sat, 9 May 2015 01:59:42 +0000 (18:59 -0700)]
Unbreak --profile=text for CLI scrips
* Fixes "Undefined index: threshold" and
"Invalid argument supplied for foreach()" errors
so that output actually can show
Change-Id: Ibf8090f265d988c58d1752319336a5146a28f4d0
Ori Livneh [Sat, 9 May 2015 00:42:15 +0000 (17:42 -0700)]
WebRequest::getHeader: add optional flag to get back list
* Add a stub FauxRequest::initHeaders method. This allows FauxRequest to
use WebRequest's getHeader implemention, leading to less code duplication.
* Add an optional $flags parameter to WebRequest::getHeader. When the flag
WebRequest::GETHEADER_LIST is set, treat the header as a comma-separated
list of values (per RFC 2616 § 4.2) and return an array.
(Initial use-case: Ibb292d241's treatment of If-None-Match header.)
* Add test.
See <http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html>.
Change-Id: I2760f57adfa7b886c84044a6e9348a47ac307229
Aaron Schulz [Fri, 8 May 2015 19:08:15 +0000 (12:08 -0700)]
Include transaction details log entry for trx write time violations
* This makes it possible to see what is being done by matching
the trx IDs of the (normally) adjacent log entries
Change-Id: I515de99acfe159856930d8e259c00eb744f43213
Aaron Schulz [Tue, 28 Apr 2015 00:26:58 +0000 (17:26 -0700)]
Converted LocalFile to using the WAN cache
Bug: T93141
Change-Id: Iecb182428ae0d8e7511bc28340b57f6e7042b723
jenkins-bot [Fri, 8 May 2015 08:29:34 +0000 (08:29 +0000)]
Merge "Converted Interwiki using WAN cache"
jenkins-bot [Fri, 8 May 2015 08:15:57 +0000 (08:15 +0000)]
Merge "Log transaction that spend too much time in write queries"
Aaron Schulz [Fri, 8 May 2015 00:12:09 +0000 (17:12 -0700)]
Log transaction that spend too much time in write queries
Change-Id: I9ba184601cfb1667291f7a29677cc5205344d5ad
Aaron Schulz [Mon, 27 Apr 2015 21:56:52 +0000 (14:56 -0700)]
Converted sidebar cache to the WAN cache
Bug: T93141
Change-Id: Id99f886c48501bbfef85cb0e7c5d2e2810a68581
Amir E. Aharoni [Thu, 7 May 2015 21:35:14 +0000 (00:35 +0300)]
Mark mw-tag-marker as bidi-embed
This prevents LTR tag names from being shown in an incorrect order
in RTL wikis.
Change-Id: Id0e351105119a48e3eda62fe642d8ccc3d6ab598
jenkins-bot [Thu, 7 May 2015 20:05:53 +0000 (20:05 +0000)]
Merge "Only configure the transaction profiler if profiling is enabled"
jenkins-bot [Thu, 7 May 2015 19:55:13 +0000 (19:55 +0000)]
Merge "Tweaked TempFSFile::bind() param type docs"
jenkins-bot [Thu, 7 May 2015 19:43:02 +0000 (19:43 +0000)]
Merge "Reduce chunk size in doBatchPush for redis"
jenkins-bot [Thu, 7 May 2015 19:42:40 +0000 (19:42 +0000)]
Merge "Added more lockTSE comments to getWithSetCallback()"
jenkins-bot [Thu, 7 May 2015 19:39:43 +0000 (19:39 +0000)]
Merge "Converted LocalRepo to using the WAN cache"
jenkins-bot [Thu, 7 May 2015 19:30:24 +0000 (19:30 +0000)]
Merge "Converted ChangeTags to using the WAN cache"
Translation updater bot [Thu, 7 May 2015 18:39:24 +0000 (18:39 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Thu, 7 May 2015 18:29:26 +0000 (20:29 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia3e8886d116683e83261c5ddd373787654239b73
Aaron Schulz [Thu, 7 May 2015 03:29:51 +0000 (20:29 -0700)]
Removed unused variable in doFlushCaches()
Change-Id: I599fc2e8575cf5e8242bcc15be93e54b74ede435
Brad Jorsch [Thu, 7 May 2015 16:21:27 +0000 (12:21 -0400)]
ApiHelp: Fix undefined array index reference
Follows up I0219689.
Change-Id: I833d8eab49a7093872a66c3bb0d314f6c7adb98c
jenkins-bot [Thu, 7 May 2015 16:07:10 +0000 (16:07 +0000)]
Merge "ApiQueryAllUsers: Set 'array' type on result arrays"
jenkins-bot [Thu, 7 May 2015 16:07:06 +0000 (16:07 +0000)]
Merge "ApiHelp: Make 'toc' parameter work"
jenkins-bot [Thu, 7 May 2015 15:34:32 +0000 (15:34 +0000)]
Merge "Resources: Remove pointless 'position' => 'top' for ResourceLoaderImageModule modules"
jdlrobson [Tue, 21 Apr 2015 22:05:03 +0000 (15:05 -0700)]
mediawiki.notification: Allow skins to style notification area
Minerva skin styles notifications at the bottom of the screen. This change
allows Minerva to style notifications consistently. It is a breaking change
for skins that use skinStyles for mediawiki.notification module as these will
now need to be adjusted to add to styles rather than replace.
See: I1645cbb81a3c76a07695d4c3d9a26a1d698f6ff4
Bug: T66565
Change-Id: Iba35692d38a8248096153146bc296b1079352f01
Bartosz Dziewoński [Thu, 7 May 2015 13:51:09 +0000 (15:51 +0200)]
resourceloader: Fix fatal when using $wgResourceModuleSkinStyles with "+"
Fatal error: [] operator not supported for strings in
includes/resourceloader/ResourceLoader.php on line 354
This would occur when a skin customized ResourceModuleSkinStyles using
the '+' syntax, which preserves default skinStyles, and the default
skinStyles was defined as a string rather than array.
Change-Id: I6cd12a638d562c75bc4704e098de84f3882248b6
jenkins-bot [Thu, 7 May 2015 13:07:25 +0000 (13:07 +0000)]
Merge "MalformedTitleException should call parent::__construct"
jenkins-bot [Thu, 7 May 2015 10:26:49 +0000 (10:26 +0000)]
Merge "Blacklist MeeGo's browser"
Aaron Schulz [Thu, 7 May 2015 03:38:53 +0000 (20:38 -0700)]
Added more lockTSE comments to getWithSetCallback()
Change-Id: I6ac56784bc231d7dec7869c6d2b901341bde6e9b
Aaron Schulz [Thu, 7 May 2015 03:06:01 +0000 (20:06 -0700)]
Removed executeReadyPeriodicTasks() method
* Moved all these hacks to JobQueueDB, which is the only queue that
should need this (for stock installs). Newer queues should always
have the queue store manage stuff like this, not MediaWiki.
* This also avoids expensive object construction that does nothing
when non-DB queues are used.
Change-Id: Id718cda25750be73044a049b39958cca55aa3172
jenkins-bot [Thu, 7 May 2015 01:25:01 +0000 (01:25 +0000)]
Merge "Use HTMLForm for Special:LinkSerach"
Aaron Schulz [Thu, 7 May 2015 01:24:34 +0000 (18:24 -0700)]
Reduce chunk size in doBatchPush for redis
Change-Id: I2c66b6b69535ce2089c1fab2df962f4ebca9f62f
Aaron Schulz [Thu, 7 May 2015 00:49:40 +0000 (17:49 -0700)]
Removed useless doGetPeriodicTasks() override
Change-Id: I70b33ad746c5f31bba5b83e249f8c22faf316cf4
Ori Livneh [Thu, 7 May 2015 00:45:48 +0000 (17:45 -0700)]
Only configure the transaction profiler if profiling is enabled
Follows I0fe14bcda.
Change-Id: I4eb77d3b5ead587da6f01dec00fa6c5852225fcc
Baha Man [Wed, 6 May 2015 17:30:18 +0000 (13:30 -0400)]
Blacklist MeeGo's browser
Bug: T97546
Change-Id: I5347a3598840d55daf32f49fb547c4d89c5d94b5
Bartosz Dziewoński [Wed, 6 May 2015 22:15:19 +0000 (00:15 +0200)]
Resources: Remove pointless 'position' => 'top' for ResourceLoaderImageModule modules
ResourceLoaderImageModule ignores this option and always uses
'bottom'. And these modules should indeed all use bottom, the images
they provide are not critical and need not be loaded in the head.
(Alas, we load them with addModuleStyles, which in turn ignores the
position and always loads in the head. This is a separate problem.)
Change-Id: I3da808f894f7a9058ea4a44a7ce814e216b59e5e
jenkins-bot [Wed, 6 May 2015 20:37:41 +0000 (20:37 +0000)]
Merge "Remove --max-slave-lag options and remnants from maintenance scripts"
jenkins-bot [Wed, 6 May 2015 20:37:26 +0000 (20:37 +0000)]
Merge "update.php: Remove max seconds of lag from wfWaitForSlaves() call"
Kevin Israel [Thu, 30 Apr 2015 17:48:52 +0000 (13:48 -0400)]
Move some global statements to top of function
These were flagged by mediawiki/tools/code-utils/check-vars.php
because they were located inside a switch statement, or inside an
if statement and used outside the statement. All other warnings
from that script are bogus, mostly because the script has no
support for PHP 5.3 namespaces.
Change-Id: If93bae4434b5c28845125095f6a22d6788a76efc