Daniel Kinzler [Wed, 26 Sep 2012 10:29:44 +0000 (10:29 +0000)]
Begin transactions explicitely in Job class.
This reverts commit
dfbf524d3561e3fc54a9a072fda173435acc2e14 which
was "Removed unmatched commits in Job class".
The original change was reverted n the light of the recent discussion about the DBO_TRX flag
and the intended use and bahavior of begin and commit.
See http://www.gossamer-threads.com/lists/wiki/wikitech/300087 for Tim's explanation of DBO_TRX.
This change now implements a new, alternative solution to the original problem of unmatched
calls to commit:
The Job class originally relied on implicitely started transactions. Introducing
explicit calls to begin() avoids warnings while running tests, and
causes transaxctiosn to be used also in cli (maintenance) mode.
Change-Id: I6ecb8faad06449331a79b81860fe64624d3694d4
daniel [Mon, 27 Aug 2012 12:41:15 +0000 (14:41 +0200)]
Removed unmatched commits in Job class.
Job had two calls to commit() that did not correspond to any
call to begin(). This may prematurely about any "outer" transaction,
may cause database corruption, and trigger warnings. There did not
seem to be any good reason for these commits to be there.
Sorting out unmatched begin/commit calls is important to allow the
addition of support for nested transactions, and it also helps
with finding "interesting" database problems.
Change-Id: Iff394f97fbad6e9304d75e6ad69155ada80b9c33
Nikerabbit [Mon, 27 Aug 2012 05:57:34 +0000 (05:57 +0000)]
Merge "Fix double braceSubstitution of some preview messages"
Tim Starling [Mon, 27 Aug 2012 00:40:27 +0000 (10:40 +1000)]
Fix exception on parse due wfMsgExt() -> wfMessage()
Replacing wfMsgExt() with wfMessage() in
4e1ccf0 causes an exception on
parse when the defaults are used for $current and $max. I don't know if
there are other similar fatal errors caused by that set of commits.
Change-Id: I84cfdede844bb2dd3c106721b972ed1cd8bfe480
Siebrand [Sun, 26 Aug 2012 23:44:21 +0000 (23:44 +0000)]
Merge "Check fallbacks correctly in getHeaderVariant()."
Translation updater bot [Sun, 26 Aug 2012 20:12:33 +0000 (20:12 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Idac5f9de0b58872797168de1f7faafcdec35dee0
Aaron Schulz [Sun, 26 Aug 2012 18:53:20 +0000 (18:53 +0000)]
Merge "change raw database quoting to use addQuotes"
umherirrender [Sun, 26 Aug 2012 16:56:29 +0000 (18:56 +0200)]
change raw database quoting to use addQuotes
Change-Id: Ia734f958b1458224f998c5b59df2ff49e597f868
umherirrender [Sun, 26 Aug 2012 16:32:34 +0000 (18:32 +0200)]
Truncate rollback summary for whole multibyte characters
This avoids broken characters for long comment in history
Change-Id: I3104d53c1d3d9b950e23dccecf5cea36561b8c65
Siebrand Mazeland [Sun, 26 Aug 2012 12:45:53 +0000 (12:45 +0000)]
Merge "Localisation updates from translatewiki.net."
Siebrand Mazeland [Sun, 26 Aug 2012 12:45:09 +0000 (12:45 +0000)]
Merge "Prevent Call to a member function msg() on a non-object"
Siebrand Mazeland [Sun, 26 Aug 2012 12:38:51 +0000 (14:38 +0200)]
Localisation updates from translatewiki.net.
Updates for namespaces.
Change-Id: Idd38014a8d421b3afd6b0fc8678f9a4bdf896689
Siebrand Mazeland [Sun, 26 Aug 2012 11:55:25 +0000 (13:55 +0200)]
Localisation updates from translatewiki.net.
Updates for magic words.
Change-Id: I7479b0d525385cca4eddafc57e260a90af65a522
Siebrand Mazeland [Sun, 26 Aug 2012 11:28:02 +0000 (13:28 +0200)]
Localisation updates from translatewiki.net.
Updates for special page names.
Change-Id: I19700829922f3111756719db3d606db9495f9f95
Translation updater bot [Sat, 25 Aug 2012 18:56:57 +0000 (18:56 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ic2cec634659baf997488ef0b328185f4c3c0e591
umherirrender [Sat, 25 Aug 2012 17:55:37 +0000 (19:55 +0200)]
Use __METHOD__ in SpecialUndelete.php
Change-Id: Ia223f91a26b35677818d3ed46331813da7dbf209
Krinkle [Fri, 24 Aug 2012 23:41:07 +0000 (23:41 +0000)]
Merge "Fix some css vector/monobook issues:"
Aaron Schulz [Fri, 24 Aug 2012 20:49:00 +0000 (20:49 +0000)]
Merge "Fix type of exception no longer matching after someone changed it without running the tests..."
Translation updater bot [Fri, 24 Aug 2012 19:34:34 +0000 (19:34 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I90ad39edeeb93bfb65bd7ee1b36dded75ac2f0a2
jeroendedauw [Fri, 24 Aug 2012 19:10:45 +0000 (21:10 +0200)]
Fix type of exception no longer matching after someone changed it without running the tests...
Change-Id: I5b1c3556f40d869f0f5d4a617f01f981d607d11f
Derk-Jan Hartman [Thu, 23 Aug 2012 22:12:12 +0000 (00:12 +0200)]
(bug 39284) Improve the tablesorter for currency.
* Make the detector for currency not trigger on cells
starting with "." or "?".
* Make it trigger on values ending with a currency symbol.
* Add the Yen sign.
* Add a basic unit test.
Change-Id: I3c1fdf41db04ea0726ba7613fa5e1365f8fb8493
Demon [Fri, 24 Aug 2012 13:51:51 +0000 (13:51 +0000)]
Merge "Revert "Use the context language for the toc in SpecialEditWatchlist.""
Siebrand Mazeland [Thu, 23 Aug 2012 07:11:21 +0000 (09:11 +0200)]
Prevent Call to a member function msg() on a non-object
- Added HTMLFormField::msg() to check whether $this->mParent->msg()
can be called and otherwise use wfMessage()
- Made Licenses::msg() inline to prevent conflict with HTMLFormField::msg()
Change-Id: I7fa95e1d61ac4128d1d4d5f091c39bcbc8ecc651
Catrope [Thu, 23 Aug 2012 21:16:15 +0000 (21:16 +0000)]
Merge "Split up doOperations() test to be more robust when tests fail."
Catrope [Thu, 23 Aug 2012 21:14:57 +0000 (21:14 +0000)]
Merge "(bug 8618) support for summary preview in live preview"
Aaron [Thu, 23 Aug 2012 21:13:20 +0000 (14:13 -0700)]
Split up doOperations() test to be more robust when tests fail.
Change-Id: If7c0f1476e694feeb791754608ea964899be0c38
MatmaRex [Thu, 9 Aug 2012 16:16:27 +0000 (18:16 +0200)]
(bug 8618) support for summary preview in live preview
We have to check for the existence of .mw-summary-preview and add it if
it's missing.
See change Idda2e6f7 for more details; this change is analogous.
Change-Id: I4f4f91ed3b51a54b645bca9697c2840b717bddf6
Catrope [Thu, 23 Aug 2012 21:04:52 +0000 (21:04 +0000)]
Merge "support for interwikis in experimental JS preview"
Demon [Thu, 23 Aug 2012 20:49:42 +0000 (20:49 +0000)]
Merge "Enable dropping of tables without having to create a file for each if you want correct output in the console"
jeroendedauw [Thu, 23 Aug 2012 20:43:20 +0000 (22:43 +0200)]
Enable dropping of tables without having to create a file for each if you want correct output in the console
Change-Id: I374885517928430d00446b9711ea5005f58dc2a1
Catrope [Thu, 23 Aug 2012 20:39:52 +0000 (20:39 +0000)]
Merge "Make the width/height in the SVG metadata box be in the SVG's units"
Demon [Thu, 23 Aug 2012 20:34:35 +0000 (20:34 +0000)]
Merge "Fix separated login link so that create account and login are always next to each other."
Translation updater bot [Thu, 23 Aug 2012 20:01:43 +0000 (20:01 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I0a9cc229253bd8cca3a2c0d2e87ae33b519b9cd2
Liangent [Thu, 23 Aug 2012 19:21:01 +0000 (03:21 +0800)]
Check fallbacks correctly in getHeaderVariant().
Currently when users with Accept-Language: en accesses a zh site,
getVariantFallbacks() returns zh for it and zh is treated as their
preferred variant as header variant, making the configuration
setting $wgDefaultLanguageVariant ignored.
Per comments above getVariantFallbacks(), it returns the main
language code for an unknown variant (en in this case), so when
it's returning the main code, just ignore this fallback (when the
user is really sending Accept-Language: zh, it can be caught by
validateVariant() above and fallbacks are not consulted).
Change-Id: I187bdcd70b778883cc80ceeab005de3aca2e286a
Brian Wolff [Sun, 19 Aug 2012 18:18:50 +0000 (15:18 -0300)]
Make the width/height in the SVG metadata box be in the SVG's units
This was suggested by a user at commons. The width/height in px is really
a MediaWiki thingy needed for rendering the image, from a metadata prespective
its the original units (aka the image should be 10cm, etc) that is
the information associated with the file.
The dimensions in pixels is still specified in the long description
of the image (the subtitle directly under the image).
Note: After gerrit change Ic58efbf2 is merged, this will cause no width or height
to be displayed for svg images with cached metadata, until they
get purged. I think that's perfectly ok as the width is
available elsewhere on the page.
p.s. I added one semi-unrelated code comment in SVGMetadataExtractor.
patchset 2,3: Fix test (hopefully, how come getting an up to date
version of PHPUnit is so difficult)
patchset 4: rebase
patchset 5: fix my accidental remove of a comment
Change-Id: I312fbd1c935a0095644c3b63c4929632c6f6e387
Brian Wolff [Fri, 17 Aug 2012 00:41:13 +0000 (21:41 -0300)]
(sort of bug 32410) Fix EXIF GPSAltitude calculation when below sea level.
In EXIF, GPSAltitude is stored as a fraction string like "1/2".
For values below sea level we were negating this value, in order
to represent the sign and the magnitude in the same value. However,
I forgot to convert that to an integer before negating it. PHP was nice
enough to do a best effort conversion of the string to an integer.
This resulted in altitudes below sea level being taken as just the
numerator of the altitude, which gives results that can be significantly
off.
Also add unit tests for the GPS related image metadata stuff. Change the
existing GPS test to use a fractional altitude (Since this issue isn't
appearent if the denominator is 1). Add tests for XMP as well, since
XMP had same issue, and has to do same processing as EXIF stuff does.
In some future time, may want to consider just converting all exif rational values
to real numbers during the extraction process for generally better sanity.
Patchset 2: rebase
Change-Id: I49032b52a4c840b28e667a6a2b8ae23c508df247
Brian Wolff [Sun, 19 Aug 2012 16:21:47 +0000 (13:21 -0300)]
(bug 27111) Make cascading foreign repo's fetch description properly
This changes action=render on file pages to include the shared image
description (if it exists). The reasons for this are two fold:
*Logically, most users would consider the shared description part of
the content of the page, and not part of the site chrome, so it
should be on action=render
*Foreign file repos use action=render to get image descriptions.
if you use say en.wikipedia.org as your file repo, commons images
get cascasively included, but all their descriptions end up
being the noarticletext message, which is bad. This makes
the shared image descriptions work.
Some notes on the implementation:
* on action=render the div containing the shared description
doesn't have the id that the one on normal page view has.
This is to prevent duplicate ids in the cascading repo scenario.
I added a class so people can identify them if they want, and this
allows people to easily identify the "outermost" shared description
as it would be the only one with the id.
* This doesn't include the "shareddescriptionfollows" message
(which is disabled by default) that would normally separate the
local from the non-local description. I wasn't sure, but thought
that would be considered part of the site chrome.
Patchset 2/3: trailing space/spelling mistake
Patchset 4: rebase
Change-Id: I18bdf29de62526d699740607b5015da4b01fd43d
Nikerabbit [Thu, 23 Aug 2012 18:40:31 +0000 (18:40 +0000)]
Merge changes I1aa3b081,I65ee788c,I58a9cdfe
* changes:
Adding JavaScript CLDR plural parser.
CLDR plural parser in PHP
CLDR Plural rules based plural form calculation
Demon [Thu, 23 Aug 2012 18:33:44 +0000 (18:33 +0000)]
Merge "(bug 31817) Teach Tidy about the HTML5 inline tag bdi."
Catrope [Thu, 23 Aug 2012 17:10:42 +0000 (17:10 +0000)]
Merge "Added sanity check to StreamFile for mwstore paths."
Liangent [Thu, 23 Aug 2012 17:02:25 +0000 (01:02 +0800)]
Fix double braceSubstitution of some preview messages
They will fail if sysops write "{{((}}" stuff in it
(where [[Template:((]] contains "{{").
Change-Id: Ie1c3b4a128d9eff23da724b17a729fac9561668e
Krinkle [Thu, 23 Aug 2012 16:58:24 +0000 (16:58 +0000)]
Merge "(bug 30390) upload.js: Decode url encoding in file name."
karun [Sat, 18 Aug 2012 23:28:40 +0000 (09:28 +1000)]
(bug 30390) upload.js: Decode url encoding in file name.
Change-Id: I3a48f8a8033ff6a8cb0b1cb322c2af1fceccbf39
Catrope [Thu, 23 Aug 2012 16:29:26 +0000 (16:29 +0000)]
Merge "[FileBackend] MultiWrite options to avoid pushing certain changes to all backends."
Alexandre Emsenhuber [Thu, 23 Aug 2012 10:17:48 +0000 (12:17 +0200)]
Fix double parsing of "previewnote" message
Change-Id: I2144f026d3b301edb521bf83e1b089de5f35ad64
Niklas Laxström [Wed, 22 Aug 2012 13:15:44 +0000 (13:15 +0000)]
Adding JavaScript CLDR plural parser.
The JavaScript code of the parser was written by Santhosh.
The original project is hosted at GitHub:
https://github.com/santhoshtr/CLDRPluralRuleParser
Introduces resourceloader modules: mediawiki.cldr and
mediawiki.libs.pluralruleparser.
hi.js and ar.js removed since it has only convertPlural method. More [lang].js
needs to remove convertPlural, but not done in this commit.
The actual rules will be taken straight from CLDR and they are not
integrated in this commit yet.
Change-Id: I1aa3b081f4dad68515fd6cd46e4ab2dbdb3291eb
Aaron Schulz [Thu, 23 Aug 2012 04:13:40 +0000 (21:13 -0700)]
Fixed streaming for thumbs that are already in storage.
Change-Id: Iafbd5c435a5d63738a43f1ac4e52e6c4148d6784
Aaron Schulz [Thu, 23 Aug 2012 03:46:54 +0000 (20:46 -0700)]
Added sanity check to StreamFile for mwstore paths.
Change-Id: Id402f077037f3e84c9158f7d48be0ed82ba4a1cf
Aaron Schulz [Wed, 22 Aug 2012 23:41:36 +0000 (23:41 +0000)]
Merge "Use Status::getWikiText() instead of getErrorsArray() in Article::doDelete()"
Aaron [Wed, 22 Aug 2012 18:51:38 +0000 (11:51 -0700)]
[FileBackend] MultiWrite options to avoid pushing certain changes to all backends.
* This can be used to no-op dir and file operations on the clone backends
for the 'thumb' and 'temp' zones to reduce load or avoid hitting certain mounts.
Change-Id: I2c57904b8264b7479b17736333b0b9228b469bbc
Alexandre Emsenhuber [Wed, 22 Aug 2012 21:44:41 +0000 (23:44 +0200)]
Make message escaping conistent between skins.
Also changed one call from Linker::link() with
'known' and 'noclasses' options to Linker::linkKnown().
Change-Id: Ifa1fb1e1dfc28b255d8ece13e0a95aa536207df8
IAlex [Wed, 22 Aug 2012 21:34:31 +0000 (21:34 +0000)]
Merge "Replace deprecated wfMsg* calls with Message class calls."
Catrope [Wed, 22 Aug 2012 21:28:38 +0000 (14:28 -0700)]
Revert "jQuery 1.8"
This reverts commit
9023aa2d830029da5745e92212f03ddbc71da4c2.
Regression reported on Wikinews, see bug 39572
Change-Id: I135c9931e5d3c8b85e1e9c4cd58326c682d878f2
Catrope [Wed, 22 Aug 2012 21:27:54 +0000 (14:27 -0700)]
Revert "Update jQuery UI to 1.8.23"
This reverts commit
6c85cc71f83526126505814d54ab80d4a983a9d0.
Regression reported on Wikinews, see bug 39572
Change-Id: Ie6a3dbf59d0b292d7b72ee60af3fe2ec52b243fd
Siebrand [Wed, 22 Aug 2012 20:47:36 +0000 (20:47 +0000)]
Revert "Use the context language for the toc in SpecialEditWatchlist."
This reverts commit
c85016e27d789bc5990dddb48d02bda3d85f11a1
This change is redundant, since the root cause was fixed in
Change I333021ee and I66fb2d11
Demon [Wed, 22 Aug 2012 20:03:12 +0000 (20:03 +0000)]
Merge "Document Linker::tocList()'s $lang parameter correctly"
Translation updater bot [Wed, 22 Aug 2012 19:58:20 +0000 (19:58 +0000)]
Merge "Localisation updates from translatewiki.net."
Catrope [Wed, 22 Aug 2012 19:49:39 +0000 (12:49 -0700)]
Document Linker::tocList()'s $lang parameter correctly
Change-Id: I6982dc30a0ceeedc8e549ee3bdaa5bc139d6364c
Translation updater bot [Wed, 22 Aug 2012 19:49:29 +0000 (19:49 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I18b1a8aa25c18e87b8e17696c830b0e0655c6dea
Siebrand Mazeland [Wed, 22 Aug 2012 19:29:18 +0000 (21:29 +0200)]
Follow up I66fb2d11: use wfGetLangObj() instead
Change-Id: I333021ee4edc7481b664986c27e12fbcac9d0d08
Aaron Schulz [Wed, 22 Aug 2012 19:24:21 +0000 (19:24 +0000)]
Merge "Fix tocList() breakage in
6fe1f050"
Catrope [Wed, 22 Aug 2012 19:23:14 +0000 (19:23 +0000)]
Merge "Fixed READ_LOCKING bitfield check"
Catrope [Wed, 22 Aug 2012 19:21:59 +0000 (12:21 -0700)]
Fix tocList() breakage in
6fe1f050
The $lang parameter defaults to false, but Message::inLanguage() doesn't
like false, so do an explicit check for false.
Change-Id: I66fb2d11269a988ae92b1594314807a4eed54f1b
Catrope [Wed, 22 Aug 2012 19:18:44 +0000 (19:18 +0000)]
Merge "Use the context language for the toc in SpecialEditWatchlist."
Aaron [Wed, 22 Aug 2012 19:18:42 +0000 (12:18 -0700)]
Fixed READ_LOCKING bitfield check
Change-Id: Ia37761bc21a37cad4d8357b9cbfc623b59065a11
Aaron [Wed, 22 Aug 2012 18:58:47 +0000 (11:58 -0700)]
Use the context language for the toc in SpecialEditWatchlist.
Change-Id: I029372346e18eb75f81eab24c7398b53701ac8ed
Siebrand Mazeland [Tue, 21 Aug 2012 17:23:53 +0000 (19:23 +0200)]
Replace deprecated wfMsg* calls with Message class calls.
Doing this in steps of roughly 100 changes per commit, so that it remains
reviewable.
Change-Id: Ie349afa5c809c887c787c7c04c49c9dd3478ccac
Siebrand Mazeland [Wed, 22 Aug 2012 18:54:38 +0000 (20:54 +0200)]
(bug 39563) Fatal error: Inaccessible function via __call(): msg
Change-Id: I706ce99400edb86740afc5ce8b205030be7f3c68
Alexandre Emsenhuber [Wed, 22 Aug 2012 18:42:27 +0000 (20:42 +0200)]
Use Status::getWikiText() instead of getErrorsArray() in Article::doDelete()
So that the usage of the Status class is more consistent with other places.
Change-Id: I8f7944905df7bc241b21f014d8544486ea012f6b
IAlex [Wed, 22 Aug 2012 18:37:29 +0000 (18:37 +0000)]
Merge "Replace deprecated wfMsg* calls with Message class calls."
Catrope [Wed, 22 Aug 2012 17:38:27 +0000 (17:38 +0000)]
Merge "Fix "return to" display on Special:UserLogin."
Siebrand [Wed, 22 Aug 2012 17:08:01 +0000 (17:08 +0000)]
Merge "Bug 39524 - action=info uses untranslated (raw) protection permissions"
Tim Starling [Thu, 16 Aug 2012 10:36:08 +0000 (20:36 +1000)]
CLDR plural parser in PHP
Wrote a CLDR plural rule parser to replace the eval()-based one from
I58a9cdfe. It converts the infix notation of the XML files to a
sanitized RPN notation, referred to in external interfaces as the
"compiled" form. The RPN notation is cached and then executed by a
fast non-validating evaluator.
Timings for the largest rule in the XML file are ~1.2ms for
compilation and ~200us for execution.
Also:
* Lazy-load the plural rules when recache() requests them, instead of
loading them for every request.
* Language::convertPlural() needs integer keys, and CLDR only gives
string keys. The previous code was not mapping them so it didn't work
at all. I just mapped them in the order they appear in the XML file,
i.e. the first rule becomes MediaWiki's $pluralForm=0, the second
becomes $pluralForm=1, etc. Not sure if there is a more rigorous way
to do it.
Change-Id: I65ee788c1a8e5ee2ede2091990d86eb722749dd3
Alexandre Emsenhuber [Sat, 18 Aug 2012 10:08:32 +0000 (12:08 +0200)]
Fix "return to" display on Special:UserLogin.
- Do not use $wgRedirectOnLogin on permissions
error message
- Added LoginForm::executeReturnTo() to remove
code duplication
- Changed usage of OutputPage::returnToMain()
to OutputPage::addReturnTo() since we already
check these parameters ourself
Change-Id: Ie80d03f5fca7aa87017f1ad7804dda721a1132de
IAlex [Wed, 22 Aug 2012 08:00:54 +0000 (08:00 +0000)]
Merge "Make wfScript()/mw.util.wikiScript() respect $wgScript/$wgLoadScript"
Tim Starling [Wed, 22 Aug 2012 07:34:59 +0000 (07:34 +0000)]
Merge "[FileBackend] Allow enforcing POSIX file owner names."
Alex Monk [Mon, 13 Aug 2012 20:15:53 +0000 (21:15 +0100)]
(bug 24491) Don't show reupload link if the user can't upload because of protection
Instead, show some text explaining that they cannot upload here.
Also remove a linebreak which someone complained about recently.
Change-Id: I92ab8ad5eebcdd38c0d5d9f7bab7d11e5c844586
Catrope [Wed, 22 Aug 2012 01:46:36 +0000 (01:46 +0000)]
Merge "prop=duplicatefiles does not show duplicates under same name"
Catrope [Wed, 22 Aug 2012 01:45:42 +0000 (01:45 +0000)]
Merge "Clean up applyPatch() usage in the installer."
Catrope [Wed, 22 Aug 2012 01:41:07 +0000 (01:41 +0000)]
Merge "* (bug 39376) jquery.form upgraded to 3.14"
Catrope [Wed, 22 Aug 2012 01:37:47 +0000 (01:37 +0000)]
Merge "(bug 38249) No PCRE unicode causes installer to spew giberish"
Catrope [Wed, 22 Aug 2012 01:37:33 +0000 (01:37 +0000)]
Merge "Added --quick option to file test script to use doQuickOperations."
Reedy [Wed, 15 Aug 2012 16:46:19 +0000 (17:46 +0100)]
* (bug 39376) jquery.form upgraded to 3.14
Change-Id: I1d30a5def4ba09054604e5af5666c31c631bc395
Brian Wolff [Sun, 19 Aug 2012 17:44:00 +0000 (14:44 -0300)]
(bug 38249) No PCRE unicode causes installer to spew giberish
If PHP's PCRE is not compiled with unicode property support, this causes
the regexes used by the parser to not compile, causing the parser to
output giberish. Its been reported that the default PHP package for
cent os has PCRE in such a config.
As a result the installer will output total giberish. The user has
no idea what went wrong because there is no meaningful output.
To counter that, cause Parser to throw an exception in that case.
It seemed easier than figuring out how to convince the installer
not to parse the environment check. For completeness sake though
I fixed the PCRE environment check to adequetely check for PCRE
not having unicode support.
This should be backported to 1.19 since there are quite a few
complaints about the issue on project:Support_desk. /me has
no idea what the procedure for that is in our new git world
Change-Id: Idb1658be4ee6203a55740450e335f570a616671c
Brian Wolff [Sun, 19 Aug 2012 01:19:53 +0000 (22:19 -0300)]
(bug 39297) Show a warning if thumbnails won't be animated
This shows a warning on the image description page if the image
is animated, but thumbnails won't be. This includes
gif images that are too big, but also svg images that are animated,
and APNG files.
The message used is file-no-thumb-animation, but will also
check for file-no-thumb-animation-<image extension> so that
admins can do per image type explanations. Gif files have a built-in
explanation that is slightly different (Since its do to resolution).
Ideally one would pass the resolution limit to the gif message,
but I couldn't think of a clean way of doing that. (Also might be
complex to explain to user. They aren't used to resolution as a single
number but as a width x height type thing).
Moves isAnimatedImage from ImageHandler to MediaHandler, so I could
safely use it from any handler class.
Change-Id: I42ee11d889e0c41de53d0951f55a4338ca55311d
Catrope [Wed, 22 Aug 2012 01:12:44 +0000 (01:12 +0000)]
Merge "[FileRepo] Improved support for private wiki repos."
madman [Tue, 21 Aug 2012 13:01:16 +0000 (13:01 +0000)]
Bug 39524 - action=info uses untranslated (raw) protection permissions
* Use restriction-$restrictionType message as parameter
* Updated documentation, lcfirst moved to translation
Change-Id: Ib62a0b9e273e136e09cf0c361b7f9b709b34f583
Catrope [Wed, 22 Aug 2012 00:49:24 +0000 (00:49 +0000)]
Merge "(bug 39431) Fix how SVG metadata is displayed (esp. animated status)"
Catrope [Wed, 22 Aug 2012 00:47:48 +0000 (00:47 +0000)]
Merge "Hide deprecated warning for Revision::revText()."
Catrope [Wed, 22 Aug 2012 00:47:09 +0000 (00:47 +0000)]
Merge "use dir=auto for pt-userpage"
Brian Wolff [Fri, 17 Aug 2012 02:18:39 +0000 (23:18 -0300)]
(bug 39431) Fix how SVG metadata is displayed (esp. animated status)
(Quite a few of these issues are my fault from
65c27ddeb19757cb8a)
*All fields were starting as collapsed, which was not the intent of the code
*Animated field used non-existent messages, and displayed a value of "1" instead
of something meaningful to the user. Both (A)PNG and GIF handlers put
the animated status in the long description which feels more natural to me
so move the animated status to the long desc (long desc = subtitle under
the image on the description page).
*Use human readable file sizes in the long description instead of
total number of bytes. This bring it in line with the implementation
in the parent class.
*Correctly mark scripted SVG's as animated. Mostly a moot point
since we do not allow animated svgs past the upload checks
but for completeness and for people who totally
disable all upload verification.
(Note: This would miss event attributes (onclick, etc)
I didn't see much point in adding that since almost
always there will be a script tag)
Patchset 3: trailing whitespace (d'oh)
patchset 4: rebasing so jenkins is happy
Change-Id: Ic58efbf2bf1e4b14e3129e5bce9ea920d9804111
tpt [Mon, 20 Aug 2012 10:12:47 +0000 (12:12 +0200)]
(bug 23226) Add |class= parameter to image links in order to add class(es) to HTML img tag.
Change-Id: If58802ad2c513c1db7bc3488daf4e078b8694b02
Catrope [Tue, 21 Aug 2012 19:38:00 +0000 (12:38 -0700)]
Make wfScript()/mw.util.wikiScript() respect $wgScript/$wgLoadScript
mw.util.wikiScript() and mw.util.wikiScript( 'index' ) now return the
value of $wgScript rather than building the path to index.php manually;
the latter is incorrect if $wgScript is customized. Similarly,
mw.util.wikiScript( 'load' ) now uses $wgLoadScript.
Same for wfScript(), wfScript( 'index' ) and wfScript( 'load' )
The qunit tests already had a test case for wgScript, but wgScript was
set in a way that didn't trigger the bug. Changed it to use customized
wgScript and wgLoadScript values and added test cases for 'index' and
'load'
This fixes bug 39103 (wfScript/mw.util.wikiScript do not respect custom
$wgScript/$wgLoadScript) as well as bug 39102 ("Entry points" on
Special:Version do not respect custom $wgScript/$wgLoadScript)
Change-Id: I5c9e82849e314dc7a87f8ae91150cc412b4011cf
Siebrand [Tue, 21 Aug 2012 20:43:52 +0000 (20:43 +0000)]
Merge "Use local context to get messages"
Alexandre Emsenhuber [Tue, 21 Aug 2012 20:11:18 +0000 (22:11 +0200)]
Use local context to get messages
Change-Id: Ia615d3cf07bafd324b09bc6c8b0614fadbdc06d4
Translation updater bot [Tue, 21 Aug 2012 19:59:49 +0000 (19:59 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I88441f68df745527a2eb3ce379eddaeb6b5ee151
Siebrand Mazeland [Tue, 21 Aug 2012 19:58:47 +0000 (21:58 +0200)]
Replace deprecated wfMsg* calls with Message class calls.
Doing this in steps of roughly 100 changes per commit, so that it remains
reviewable. This should be the one but last change set with the "easy"
ones for core.
Change-Id: If894a92dd65b2f5f4f096b9133685eb3b067a1d8
Catrope [Tue, 21 Aug 2012 19:31:06 +0000 (19:31 +0000)]
Merge "Update jQuery UI to 1.8.23"
Reedy [Tue, 21 Aug 2012 19:23:27 +0000 (20:23 +0100)]
Update jQuery UI to 1.8.23
Change-Id: If623cc6fc6d47c47ce679d145a2e70420e9010fa
Alexandre Emsenhuber [Tue, 21 Aug 2012 19:18:13 +0000 (21:18 +0200)]
Hide deprecated warning for Revision::revText().
Otherwise the test fails when $wgDevelopmentWarnings
is set to true because it emits a E_NOTICE.
Change-Id: I0c407f04cae4285cc61f73ec0ecb7b6ada8cbe0b