Kunal Mehta [Tue, 24 May 2016 02:16:27 +0000 (19:16 -0700)]
SpecialCategories: Use LinkRenderer instead of MediaWikiPageLinkRenderer
And use TitleValue in one place that we can. While it is technically not
equivalent since Title::makeTitleSafe() can return null, since it is
coming directly out of the database, it should be safe to not require
validation.
Change-Id: I97bc0fd8e86f212414487ec88fbb2d7600bdacb6
Kunal Mehta [Wed, 1 Jun 2016 03:46:13 +0000 (20:46 -0700)]
SpecialNewpages: Use LinkRenderer instead of Linker::link()
Change-Id: I78403b7c24253ba44c256f307559400923cc16a6
Kunal Mehta [Wed, 1 Jun 2016 03:41:22 +0000 (20:41 -0700)]
SpecialMovepage: Use LinkRenderer instead of Linker::link()
Change-Id: I3b50354e62f47557a3a8ab1ec19a28f687887810
Kunal Mehta [Wed, 1 Jun 2016 03:38:10 +0000 (20:38 -0700)]
SpecialBotPasswords: Use LinkRenderer instead of Linker::link()
Change-Id: I939c3d639d8efc0a2f838cf12ff18c9e9795f114
Kunal Mehta [Wed, 1 Jun 2016 03:36:10 +0000 (20:36 -0700)]
SpecialListredirects: Use LinkRenderer instead of Linker::link()
And avoid passing null to LinkBatch::addObj() while we're at it.
Change-Id: I57abaa7c640eb97a3b17be99c8ab898fafb82634
Kunal Mehta [Wed, 1 Jun 2016 03:32:43 +0000 (20:32 -0700)]
SpecialUnusedtemplates: Use LinkRenderer instead of Linker::link()
Change-Id: If54de97106a71d330a0193f61d7eac9d7bb7ad12
Kunal Mehta [Wed, 22 Jun 2016 21:30:30 +0000 (23:30 +0200)]
Add SpecialPage::getLinkRenderer()
And SpecialPage::setLinkRenderer(), so the Parser can pass on its
LinkRenderer instance for when special pages are being included in a
page.
Change-Id: If9a9c648ab670b824ce534e7cf0d20d41e1bfd12
Translation updater bot [Tue, 21 Jun 2016 20:42:23 +0000 (22:42 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id5fb2d3cd7946e8557d2368ffa182a04b937f8c3
jenkins-bot [Mon, 20 Jun 2016 22:13:18 +0000 (22:13 +0000)]
Merge "Add 'ApiMakeParserOptions' hook"
jenkins-bot [Mon, 20 Jun 2016 21:14:17 +0000 (21:14 +0000)]
Merge "Add statsd logging of DeferredUpdates"
Kunal Mehta [Fri, 10 Jun 2016 20:10:27 +0000 (13:10 -0700)]
registration: Add support for $wgGrantPermissions & $wgGrantPermissionGroups
Change-Id: If336aa351ee5dc4dc07f63cfac2a5d236e501718
jenkins-bot [Mon, 20 Jun 2016 20:09:45 +0000 (20:09 +0000)]
Merge "Show request id in Exception pages even if $wgShowExceptionDetails is false"
jenkins-bot [Mon, 20 Jun 2016 20:02:41 +0000 (20:02 +0000)]
Merge "Provide CategoryAfterPageRemoved hook handlers with deleted page IDs"
Glaisher [Wed, 8 Jun 2016 17:04:48 +0000 (22:04 +0500)]
Show request id in Exception pages even if $wgShowExceptionDetails is false
Bug: T137277
Change-Id: I5ff7e4ce0336616f8a9bcc39031a0a032bd9a931
Translation updater bot [Mon, 20 Jun 2016 19:54:50 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3445e2be17bfe12e63d79bf8b5c5d74258b67e51
Aaron Schulz [Fri, 17 Jun 2016 02:56:42 +0000 (19:56 -0700)]
Provide CategoryAfterPageRemoved hook handlers with deleted page IDs
Since this updates happens post-send or via the job queue, the
page object will be for a non-existing or newer page/redirect.
Change-Id: I20b583948157dccceca6eb1fbd25121822bf1b2f
jenkins-bot [Mon, 20 Jun 2016 18:38:55 +0000 (18:38 +0000)]
Merge "Fix documentation of the dir parameter of list=watchlistraw API action"
Brad Jorsch [Mon, 20 Jun 2016 15:58:53 +0000 (11:58 -0400)]
Add 'ApiMakeParserOptions' hook
This allows extensions (e.g. TemplateSandbox in I77a9aa5a) to better
interact with the ApiParse and ApiExpandTemplates modules.
Change-Id: I72d5cf8e0b86e4250af1459219dc3b42d7adbbb8
jenkins-bot [Mon, 20 Jun 2016 18:14:25 +0000 (18:14 +0000)]
Merge "Rephrase 'upload-foreign-cant-load-config' for clarity"
jenkins-bot [Mon, 20 Jun 2016 17:31:22 +0000 (17:31 +0000)]
Merge "Fix LegacyHookPreAuthenticationProvider::testUserForCreation"
jenkins-bot [Mon, 20 Jun 2016 17:30:13 +0000 (17:30 +0000)]
Merge "Add $options parameter for testUserForCreation()"
jenkins-bot [Mon, 20 Jun 2016 15:41:12 +0000 (15:41 +0000)]
Merge "Use GenderCache service in ApiQueryWatchlistIntegrationTest"
Brad Jorsch [Thu, 16 Jun 2016 21:44:44 +0000 (17:44 -0400)]
Fix LegacyHookPreAuthenticationProvider::testUserForCreation
Simply testing shouldn't call AbortNewAccount, we only want to do that
when the account is actually being created.
Change-Id: Icb3d1ce63a2691aa232b4564ed88fee6d50d7ab7
Brad Jorsch [Thu, 16 Jun 2016 21:43:12 +0000 (17:43 -0400)]
Add $options parameter for testUserForCreation()
This will allow providers to know whether the call is just for testing
(from ApiQueryUsers) or for actual creation, and skip duplicate work
when testForAccountCreation() is going to be called.
Change-Id: Id3ef713fd377135d78f66e5100dedd4689293b59
Depends-On: I4af8b3b692f60c42f8685b90be5936da7ba4e2e2
Depends-On: Ie9639a15d04b387be0e72754301eb6d91cd8adc2
Depends-On: I063cbdfbd9a223bf2391fce2b714ab82ddd3272f
Depends-On: I7c67512634f6e72251911238f083857da9fd3f84
Leszek Manicki [Thu, 16 Jun 2016 14:47:40 +0000 (16:47 +0200)]
Add tests for ApiQueryWatchlistRaw
This includes tests that originally were part of
I875a92074b52c00ac11db1fa05615abbf5262ab1
Change-Id: I9c07aa237607143985f0efe20ed0065d2bde27e4
jenkins-bot [Mon, 20 Jun 2016 14:27:55 +0000 (14:27 +0000)]
Merge "Handle session reset errors in invalidateSessionsForUser.php"
Leszek Manicki [Mon, 20 Jun 2016 12:11:04 +0000 (14:11 +0200)]
Fix documentation of the dir parameter of list=watchlistraw API action
Bug: T138213
Change-Id: I26709b03dd9b64c6f1231f3bfc3064c63c8f0c21
Translation updater bot [Sun, 19 Jun 2016 19:58:25 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic37b73b22a6bf310319fe91b09d9a729419b61f2
Jackmcbarn [Thu, 8 Jan 2015 17:53:33 +0000 (12:53 -0500)]
Render bad images in wikitext as links
In galleries, bad images are rendered as links. This causes the same behavior
to occur in wikitext, rather than the current behavior of not rendering
anything.
Change-Id: I1a074bff7cb661b5b4e6db9503eb6a5de702ee2f
jenkins-bot [Sat, 18 Jun 2016 20:04:33 +0000 (20:04 +0000)]
Merge "Deprecate Parser::disableCache"
Translation updater bot [Sat, 18 Jun 2016 19:56:05 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I468bbcade78dcf0b9843b3bd6370cc3cabdf2e22
Aaron Schulz [Wed, 15 Jun 2016 01:25:36 +0000 (18:25 -0700)]
Deprecate Parser::disableCache
Few maintained extensions still rely on this and it is
bad practice to use this for handling cache correctness.
Change-Id: I2de481198bbff5c4f3dd81fc6d1b137e4c37b93f
Aaron Schulz [Sat, 18 Jun 2016 18:24:01 +0000 (11:24 -0700)]
Add statsd logging of DeferredUpdates
Bug: T137326
Change-Id: Icce439210c6412c1824d8d5c411880825bb05643
Gergő Tisza [Fri, 17 Jun 2016 00:12:38 +0000 (00:12 +0000)]
Handle session reset errors in invalidateSessionsForUser.php
Also, do not skip session reset if the user does not exist locally.
Change-Id: I5a55e4a6f2d296576ee76e212ed379225251e128
Aaron Schulz [Fri, 17 Jun 2016 23:16:27 +0000 (16:16 -0700)]
Improve edit stashing when vary-revision is used
At least avoid the first parse in doEditContent()/filters which
never has the revision set either. The second parse cannot be
avoided in doEditUpdates() however.
Bug: T136678
Change-Id: I12d2c3bbe1b21ad2ed9a484745d976ad62475e0d
Translation updater bot [Fri, 17 Jun 2016 19:53:33 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I99bcec90e06d89ea9a6e80ee24ef026bdfacf551
Kunal Mehta [Fri, 17 Jun 2016 01:55:25 +0000 (18:55 -0700)]
Remove no-longer needed backported class from phpunit
Since we finally upgraded our phpunit version, we no longer need a copy
of this phpunit matcher.
Change-Id: I9bf3db344a2e8789a264a453e4e6d87fedc4dc49
jenkins-bot [Fri, 17 Jun 2016 02:12:27 +0000 (02:12 +0000)]
Merge "DumpUploads: output local path instead of mwstore path"
Bartosz Dziewoński [Thu, 16 Jun 2016 12:25:02 +0000 (14:25 +0200)]
Split off basic styles from the JavaScript module 'mediawiki.action.history'
Since
d629541076c the .updatedmarker element was styled via a JavaScript
module - which caused a flash of unstyled content on the history page
for most users, and was left unstyled for noscript users.
Bug: T137383
Change-Id: I362abacf51160a8305b2b0013f65e89deb2ffc93
jenkins-bot [Thu, 16 Jun 2016 21:47:55 +0000 (21:47 +0000)]
Merge "mediawiki.action.edit: Merge with mediawiki.action.edit.stash"
Antoine Musso [Thu, 16 Jun 2016 20:25:58 +0000 (22:25 +0200)]
test: basic test for ApiStashEdit
At least execute the main entry point.
Change-Id: I0788c9a7bf93b5365f4e510dff4e11fe6ffa3558
Translation updater bot [Thu, 16 Jun 2016 19:54:08 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic811056a74b4f7bff1494288258016d8e8d76a8d
Timo Tijhof [Thu, 9 Jun 2016 19:59:55 +0000 (20:59 +0100)]
mediawiki.action.edit: Merge with mediawiki.action.edit.stash
This module isn't used anywhere else. It was probably put into a
separate module due to the conditional loading. Though that can
be done client-side just as easily.
If we want to make it loaded conditionally, we could make the
module composition conditionally (which is straight-forward since
the condition doesn't vary on anything within the wiki).
* Follow-up
3a6c9d36: Remove 'jquery.getAttrs' from dependencies (unused).
Change-Id: Ic32da6f9b1c85eb106394b412fab9b22e0928323
jenkins-bot [Thu, 16 Jun 2016 16:58:29 +0000 (16:58 +0000)]
Merge "Fix handling of error messages from the 'SpecialPasswordResetOnSubmit' hook"
Dpatrick [Thu, 16 Jun 2016 16:04:40 +0000 (16:04 +0000)]
Merge "Add invalidateUserSessions.php maintenance script"
Brad Jorsch [Thu, 16 Jun 2016 16:03:59 +0000 (12:03 -0400)]
Fix handling of error messages from the 'SpecialPasswordResetOnSubmit' hook
$error might be an array of key + values, but wfMessage() treats that as
an array of alternative message keys instead so the values are lost.
Message::newFromSpecifier(), on the other hand, does exactly what we
want.
Change-Id: I25765869f6888ac793c2af9caaa9bbdf2224d51a
jenkins-bot [Thu, 16 Jun 2016 13:54:01 +0000 (13:54 +0000)]
Merge "Fix typo in 'log-action-filter-suppress-block'"
jenkins-bot [Thu, 16 Jun 2016 13:27:16 +0000 (13:27 +0000)]
Merge "Add hook to modify Special:Contributions lines"
Bartosz Dziewoński [Thu, 16 Jun 2016 13:10:30 +0000 (15:10 +0200)]
Fix typo in 'log-action-filter-suppress-block'
And some other instances of 'ppp'.
Bug: T137960
Change-Id: I3926873a79f297e0369d3c6c3300c29d2196d68f
Bartosz Dziewoński [Thu, 16 Jun 2016 13:07:50 +0000 (15:07 +0200)]
Rephrase 'upload-foreign-cant-load-config' for clarity
Bug: T137670
Change-Id: I105b9dd570745053c82f43d95c4b427788adacce
Gergő Tisza [Wed, 15 Jun 2016 18:01:31 +0000 (18:01 +0000)]
Add invalidateUserSessions.php maintenance script
Similar to resetUserTokens.php but uses AuthManager and takes a
list of users (a script for invalidating all users would be
mostly pointless with $wgAuthenticationTokenVersion).
resetUserTokens.php is deprecated, but kept around - mainly in case
we want to transform it into a fast token reset algorithm much like
I6b6e75db2a.
Change-Id: I81450c44a7af26393db7fc61fd5c05f13a13ac3f
amir [Wed, 8 Jun 2016 22:05:00 +0000 (22:05 +0000)]
Add hook to modify Special:Contributions lines
This gives finer-grained extensibility than the current ContributionsLineEnding
hook.
Bug: T122537
Change-Id: Ifca9f3f3b838a2915152f0200624ef40ee3f8a19
jenkins-bot [Thu, 16 Jun 2016 10:30:11 +0000 (10:30 +0000)]
Merge "Revert "wfShellExec: Work around PHP 5.3 stream_select() issue""
jenkins-bot [Thu, 16 Jun 2016 08:17:06 +0000 (08:17 +0000)]
Merge "Fix RSpec::Expectations::ExpectationNotMetError in Selenium tests"
Kevin Israel [Sat, 13 Feb 2016 00:40:49 +0000 (19:40 -0500)]
Revert "wfShellExec: Work around PHP 5.3 stream_select() issue"
No longer needed. Currently, MediaWiki supports neither PHP 5.3
nor HHVM 3.4 or lower. The minimum HHVM version stated in the
Compatibility section of the RELEASE-NOTES file is 3.6.5.
This reverts commit
8bd6f698ccb990c9a9d37f495b8b5b7620832018.
Change-Id: I2edd25c4ce00eb324f7f6e04b2034ad28f7c6964
Timo Tijhof [Mon, 6 Jun 2016 18:12:49 +0000 (19:12 +0100)]
resourceloader: Create 'site.styles' module
First step in migration for 'site' module per T92459.
Bug: T92459
Change-Id: Ic137cb494ba238facba4033f9c68a35e64f4916c
jenkins-bot [Thu, 16 Jun 2016 06:04:28 +0000 (06:04 +0000)]
Merge "Fix typo in mw-config/overrides/README"
Kunal Mehta [Thu, 16 Jun 2016 05:41:00 +0000 (22:41 -0700)]
Fix typo in mw-config/overrides/README
Change-Id: I1769753ad7e49b07977e15c369f479f8e42c6385
Aaron Schulz [Thu, 16 Jun 2016 05:34:23 +0000 (22:34 -0700)]
Set getCacheTTL() to 50 for SpecialRecentChanges
The extra 0 was a typo.
Change-Id: I8701d0b3e78d47776b9eefb563116c0a4def188b
jenkins-bot [Wed, 15 Jun 2016 22:39:50 +0000 (22:39 +0000)]
Merge "Simplify and cleanup maxIncludeCacheTime() code"
Aaron Schulz [Wed, 15 Jun 2016 04:19:43 +0000 (21:19 -0700)]
Simplify and cleanup maxIncludeCacheTime() code
* Follow-up to
7730dee6.
* Let subclasses avoid having to check $wgMiserMode themselves.
* Use the Config object instead of global variables.
Change-Id: Ic48f5f5a7ed8e1d04b13922375fb7873adfa0c60
Translation updater bot [Wed, 15 Jun 2016 19:54:34 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I44a4502de201f88016a40febed54effb746d23be
Aaron Schulz [Wed, 15 Jun 2016 16:40:34 +0000 (09:40 -0700)]
Fix WAN cache stashing bug due to missing list() call
Fixes regression from
0a38dbc809.
Bug: T137877
Change-Id: I4ea960966c084ada36dc54d4ec8729126c17ccdc
jenkins-bot [Wed, 15 Jun 2016 16:06:41 +0000 (16:06 +0000)]
Merge "Fix FakeTemplate usage in LoginSignupSpecialPage"
Gergő Tisza [Wed, 15 Jun 2016 15:33:22 +0000 (17:33 +0200)]
Fix FakeTemplate usage in LoginSignupSpecialPage
Despite the @return doctag, QuickTemplate::html does not return
template fields but prints them on stdout.
Also fix the doctags.
Bug: T137723
Change-Id: Ifb53ab5bdf3a4fac1e642fa6be1d88df6cef7bc7
jenkins-bot [Wed, 15 Jun 2016 14:49:08 +0000 (14:49 +0000)]
Merge "Make Selenium tests work with AuthManager"
Željko Filipin [Wed, 15 Jun 2016 11:38:46 +0000 (13:38 +0200)]
Fix RSpec::Expectations::ExpectationNotMetError in Selenium tests
The error was introduced by changes caused by AuthManager.
Bug: T137806
Change-Id: I5582159bde66ec3b39c30740876f0ce49f7ce3ff
Željko Filipin [Wed, 15 Jun 2016 14:04:16 +0000 (16:04 +0200)]
Make Selenium tests work with AuthManager
mediawiki_selenium 1.7.1 and mediawiki_api 0.6.0 are minimum required
versions.
Bug: T135884
Bug: T137885
Change-Id: I1d5fd6d317d674a89f9624bc2a1e64922f99c1b1
jenkins-bot [Wed, 15 Jun 2016 10:34:11 +0000 (10:34 +0000)]
Merge "Let EnhancedChangesListModifyLineData Hook change classes as well"
jenkins-bot [Wed, 15 Jun 2016 10:33:15 +0000 (10:33 +0000)]
Merge "update.php: Don't check for mbstring extension"
jenkins-bot [Wed, 15 Jun 2016 10:28:11 +0000 (10:28 +0000)]
Merge "Maintenance: Use __DIR__ instead of dirname( __FILE__ )"
Kevin Israel [Tue, 14 Jun 2016 23:38:35 +0000 (19:38 -0400)]
update.php: Don't check for mbstring extension
This check is redundant to the one in PHPVersionCheck.php which
was added in
41d1fa1c3a.
Change-Id: I32ab259939ca7e93ad6d08f2c04406ad8a973b5d
jenkins-bot [Wed, 15 Jun 2016 10:02:27 +0000 (10:02 +0000)]
Merge "Remove "jshint evil:true" where not required"
amir [Mon, 28 Mar 2016 04:58:11 +0000 (09:28 +0430)]
Let EnhancedChangesListModifyLineData Hook change classes as well
Change-Id: I7c2ae57bd3b18c26b12dd36e331deb6af5fa36c2
Leszek Manicki [Wed, 15 Jun 2016 09:03:18 +0000 (11:03 +0200)]
Use GenderCache service in ApiQueryWatchlistIntegrationTest
Change-Id: I5190c8c91fa4994fcce850067fa7d2a01ccc4424
Kevin Israel [Wed, 15 Jun 2016 03:49:44 +0000 (23:49 -0400)]
Remove "jshint evil:true" where not required
* resources/src/startup.js: No more document.write() since
d7905627fdc3b210.
* tests/qunit/data/testrunner.js: No more document.write()
since
05f6edc903f81993, and the TestSwarm agent loading
code was removed entirely in
0e9f24a169fdb9b9.
Change-Id: Iac61874e3ca04e1cad0d0fb2b7cebdc9fd4b237a
Brian Wolff [Fri, 20 Jun 2014 16:18:29 +0000 (13:18 -0300)]
Make transcluded special pages not disable cache in miser mode.
Previously {{Special:Foo}} would cause parser cache to be disabled,
now have a method in SpecialPage to control this behaviour and set
arbitrary caching times.
Note: This does not affect caching of direct views to the special page
The new default is now disabling cache if not in miser mode,
otherwise setting to 1 hour, except for Special:Recentchanges
and Special:Newpages which set to 5 minutes. These values are
possibly really low, but for now I think best to be close to the
old behaviour. We had 0 caching for these things for years, and
afaik it hasn't caused any big issues. Part of me wonders if
Special:Recentchanges should stay at 0, but that sounds crazy.
This change also causes transcluded special pages to not be
"per-user" if they are being cached (Specificly $wgUser et al
become 127.0.0.1).
Bug: 60561
Change-Id: Id9ce987adeaa69d886eb1c5cd74c01072583e84d
Aaron Schulz [Wed, 15 Jun 2016 00:48:04 +0000 (17:48 -0700)]
Use a low TTL for parser output when special pages are included
Previously, no TTL at all was used, which is quite harsh on
performance and had downstream effects like disabling edit
stashing for affected pages.
Bug: T136678
Change-Id: I2462057aa189cfb05fe65d0b3c081a9fd10066a2
Kevin Israel [Wed, 15 Jun 2016 00:14:20 +0000 (20:14 -0400)]
Maintenance: Use __DIR__ instead of dirname( __FILE__ )
dirname( __FILE__ ) was used because it worked in PHP 5.2, allowing
the version check to function correctly. However, Maintenance.php
now uses the short array syntax, which is a parse error before 5.4:
> Parse error: syntax error, unexpected '[' in maintenance/Maintenance.php
> on line 66
Also, do the same in install.php where it includes Maintenance.php.
Change-Id: I3373a02c684bb6cbde83d7bedc204818f3394602
jenkins-bot [Tue, 14 Jun 2016 22:05:30 +0000 (22:05 +0000)]
Merge "Use the specified page ID for LinksDeletionUpdate"
Ori Livneh [Tue, 14 Jun 2016 19:58:20 +0000 (12:58 -0700)]
Improve client-side edit stash change detection
The keypress event does not fire for backspace or delete in IE, Chrome, or
Safari, which means we are missing out on stash opportunities when the last
action is to delete some text. Fix that by listening for the keyup event
instead.
Also add an isChanged() check before calling pending.abort(), because there are
a lot of special keys that don't modify the text, and not all of them are coded
consistently on different platforms (think volume up/down, mute, function keys,
etc.), so we can't be exhaustive, and should instead fall back to actually
checking for changes. Otherwise we risk aborting stash requests when the user
has not changed the text.
Lastly, rename 'onTextChanged' to 'onEditorIdle', which is more accurate.
On undo / rollback, onTextChanged will return true the first time it is called,
even though the text had not changed in that case.
Useful sources:
* Key codes of keydown and keyup events:
http://www.javascripter.net/faq/keycodes.htm
* Quirksmode: detecting keystrokes
http://www.quirksmode.org/js/keys.html
* Why isn't backspace being detected using jquery keypress event?
http://stackoverflow.com/q/
4418562
Change-Id: Idfad8407c8e905d8de80bc54379545f1b586fc88
jenkins-bot [Tue, 14 Jun 2016 20:04:47 +0000 (20:04 +0000)]
Merge "Track deletion timestamp in LinksDeletionUpdate"
jenkins-bot [Tue, 14 Jun 2016 20:01:40 +0000 (20:01 +0000)]
Merge "Move fatal PHP functions checks to initialization"
Chad Horohoe [Tue, 14 Jun 2016 00:52:51 +0000 (17:52 -0700)]
Move fatal PHP functions checks to initialization
The installer is far too late of a place to be checking if
a function does or doesn't exist if we require it for operation.
Functions can very easily (T137509) be called prior to ever
getting to the installer check page.
Also, an old installation could've gotten past the checks if
they ran update.php --skip-compat-checks. What a scary setting!
Instead, fail hard, fast and early along with PHP version checks.
All entry points are required to go through this.
While we're here, also remove the check for mbstring.func_overload
since we already would've failed at WebStart.php
Change-Id: Ib9727979af2a4741f3cd952d13a3bb350fad43e4
Aaron Schulz [Fri, 10 Jun 2016 06:22:45 +0000 (23:22 -0700)]
Improvements to {{REVISIONUSER}} handling
* Do not change the result to a null editing user anymore.
* Use a new vary-user flag instead of vary-revision. This
will only cause a reparse on null edits. Normal edits
can still use the prepared output now.
* Edit stashing now applies for pages with this magic word.
* Fixed bug where the second prepareContentForEdit() call
(due to vary-X flags) would still check the edit stash.
Bug: T135261
Bug: T136678
Change-Id: Id1733443ac3bf053ca61e5ae25db3fbf4499e9f9
Aaron Schulz [Mon, 13 Jun 2016 18:04:33 +0000 (11:04 -0700)]
Track deletion timestamp in LinksDeletionUpdate
Use this to prevent deleting new RC entries at the title of page
deletion that were created since the deletion. This is useful if
an event performs a deletion and makes a new RC entry or if there
is high job queue lag.
Change-Id: I20f6a4aa0a660a24583c1d71f825b73daa748a24
Aaron Schulz [Tue, 14 Jun 2016 12:05:06 +0000 (05:05 -0700)]
Perform edit stashing when the edit preview or diff form is requested
* Users are likely to save after they inspect and review their changes.
The buttons to do so are also located below the edit summary box.
* This obsoletes the backend stashing on preview. Most of those parses
would have been useless due to being per-section only. Also, some
extensions like the Graph extension disable stashing for "preview"
output anyway. Simplify the code by removing that method.
Bug: T136678
Change-Id: Ied77bdbd191dd9267d4295b0fa7b942f65b062db
Arlo Breault [Tue, 14 Jun 2016 17:43:59 +0000 (10:43 -0700)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
969556c9cdc7f03dd02bcf985fc476b22e8053f0
Change-Id: Id124cc5aa32233e7b48578c0ddc4bb88c06fa893
jenkins-bot [Tue, 14 Jun 2016 16:57:54 +0000 (16:57 +0000)]
Merge "Remove unused and undocumented $wgUseMasterForMaintenance"
jenkins-bot [Tue, 14 Jun 2016 16:46:26 +0000 (16:46 +0000)]
Merge "Add an audio file parser test"
jenkins-bot [Tue, 14 Jun 2016 16:30:14 +0000 (16:30 +0000)]
Merge "Explicitly specify the width of the search input on Special:Search"
Florian [Fri, 10 Jun 2016 14:29:15 +0000 (16:29 +0200)]
Explicitly specify the width of the search input on Special:Search
This ensures that, even with float:left on the element, Firefox tries to render
the input field with as much space as possible (up to 50em).
Bug: T137535
Change-Id: I10fed035328d82f680d268f3bb116ca07d1ee576
Brad Jorsch [Tue, 14 Jun 2016 13:42:15 +0000 (09:42 -0400)]
Don't misname login button
Particularly don't name it "wpRemember", which is the name of a
completely different field.
Bug: T137799
Change-Id: I4b5f79ec59edf33b3ec91f019bf08ef5507ed55b
jenkins-bot [Tue, 14 Jun 2016 06:45:24 +0000 (06:45 +0000)]
Merge "FormatMetadata: Use binary integer literals instead of bindec()"
Kevin Israel [Tue, 14 Jun 2016 04:26:29 +0000 (00:26 -0400)]
FormatMetadata: Use binary integer literals instead of bindec()
We can do this now that we have dropped support for PHP 5.3.
Change-Id: I1e78249e244105496e976bf01e35f4067410b2f0
Chad Horohoe [Tue, 14 Jun 2016 02:24:48 +0000 (19:24 -0700)]
Remove unused and undocumented $wgUseMasterForMaintenance
Change-Id: I32b58a869c796f5170fc61d6cedca9b07b7f5762
Chad Horohoe [Tue, 14 Jun 2016 00:27:10 +0000 (17:27 -0700)]
Remove PHPVersionError, deprecated and unused since 1.25
Change-Id: Id6637886dc1d5ce3a13c9ba23dd23e76b2168eba
jenkins-bot [Mon, 13 Jun 2016 23:38:27 +0000 (23:38 +0000)]
Merge "Make it possible to disable the upload dialog functionality"
Timo Tijhof [Mon, 13 Jun 2016 23:26:37 +0000 (01:26 +0200)]
parser: Remove redundant comment about revisionsize cache vary
Follows-up
457431b.
Change-Id: Iac3e4d6c11de3737155e7f7ff35ec7a6a3873865
Aaron Schulz [Fri, 10 Jun 2016 04:46:54 +0000 (21:46 -0700)]
Avoid setting vary-revision for {{REVISIONSIZE}}
Just always use the input size for new revisions. If they are
saved, then that should be the revision size. If they are just
null edits, then the size must have matched the current revision.
This also enables edit stashing for this case.
Change-Id: I428c0cc87750eeddd1d7dcebd1a2b03817cec441