From bdac0911233f53855a3f4e84bb2e4a3b89479ae7 Mon Sep 17 00:00:00 2001 From: Sam Reed Date: Fri, 9 Apr 2010 20:02:29 +0000 Subject: [PATCH] Reuse created instance of UserrightsPage --- includes/api/ApiUserrights.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/includes/api/ApiUserrights.php b/includes/api/ApiUserrights.php index 25254d70a8..be6d76c2d0 100644 --- a/includes/api/ApiUserrights.php +++ b/includes/api/ApiUserrights.php @@ -40,8 +40,7 @@ class ApiUserrights extends ApiBase { $params = $this->extractRequestParams(); // User already validated in call to getTokenSalt from Main - $form = new UserrightsPage; - $user = $form->fetchUser( $params['user'] ); + $user = $this->mForm->fetchUser( $params['user'] ); $r['user'] = $user->getName(); list( $r['added'], $r['removed'] ) = @@ -108,8 +107,8 @@ class ApiUserrights extends ApiBase { $this->dieUsageMsg( array( 'missingparam', 'user' ) ); } - $form = new UserrightsPage; - $user = $form->fetchUser( $params['user'] ); + $this->mForm = new UserrightsPage; + $user = $this->mForm->fetchUser( $params['user'] ); if ( $user instanceof WikiErrorMsg ) { $this->dieUsageMsg( array_merge( (array)$user->getMessageKey(), $user->getMessageArgs() ) ); -- 2.20.1