From 6c50c0cb9eee62d8b1f1f2768773642fb743e9b4 Mon Sep 17 00:00:00 2001 From: Chad Horohoe Date: Thu, 28 Aug 2014 11:38:18 -0700 Subject: [PATCH] TitleTest: fix minor todo about test naming Change-Id: I1aa29b859cb1dcf0ff3c30c23f5d4c6b412f72f9 --- tests/phpunit/includes/TitleTest.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/phpunit/includes/TitleTest.php b/tests/phpunit/includes/TitleTest.php index d0f418b292..b2b0d34bc0 100644 --- a/tests/phpunit/includes/TitleTest.php +++ b/tests/phpunit/includes/TitleTest.php @@ -222,11 +222,10 @@ class TitleTest extends MediaWikiTestCase { } /** - * @dataProvider provideBug31100 + * @dataProvider provideSpecialNamesWithAndWithoutParameter * @covers Title::fixSpecialName - * @todo give this test a real name explaining what is being tested here */ - public function testBug31100FixSpecialName( $text, $expectedParam ) { + public function testFixSpecialNameRetainsParameter( $text, $expectedParam ) { $title = Title::newFromText( $text ); $fixed = $title->fixSpecialName(); $stuff = explode( '/', $fixed->getDBkey(), 2 ); @@ -242,7 +241,7 @@ class TitleTest extends MediaWikiTestCase { ); } - public static function provideBug31100() { + public static function provideSpecialNamesWithAndWithoutParameter() { return array( array( 'Special:Version', null ), array( 'Special:Version/', '' ), -- 2.20.1