Sam Reed [Wed, 20 Oct 2010 18:50:33 +0000 (18:50 +0000)]
Fix some method documentation
Fix some typos
Some explicit class members
Roan Kattouw [Wed, 20 Oct 2010 14:58:35 +0000 (14:58 +0000)]
Some comment fixes: be consistent between # and //, fix grammar, remove information about internals from Doxygen comment (those are about what the function does, not how). Also make $modules argument to makeModuleResponse() default to array() instead of null
Derk-Jan Hartman [Wed, 20 Oct 2010 14:50:30 +0000 (14:50 +0000)]
Add support to upload WebP files. Disabled by default and no thumbnailing support.
Relates to bug 25397
Jack Phoenix [Wed, 20 Oct 2010 12:11:46 +0000 (12:11 +0000)]
add some braces and trim trailing whitespace
Jack Phoenix [Wed, 20 Oct 2010 12:00:55 +0000 (12:00 +0000)]
coding style tweaks
Brion Vibber [Wed, 20 Oct 2010 06:10:02 +0000 (06:10 +0000)]
Add seleniumserverexecpath and example non-default-PATH Firefox paths for Mac & Win in selenium_settings.ini.sample
Brion Vibber [Wed, 20 Oct 2010 06:03:15 +0000 (06:03 +0000)]
Tweaks to let Selenium tests run on Mac OS X; also make sure we quote the server exec path, as not everybody keeps their directory trees free of spaces! :)
Mark A. Hershberger [Wed, 20 Oct 2010 02:50:36 +0000 (02:50 +0000)]
follow up r75046 — Add getStatus() method to HttpRequest
Trevor Parscal [Wed, 20 Oct 2010 00:25:20 +0000 (00:25 +0000)]
Whitespace, comments and general cleanup.
Trevor Parscal [Wed, 20 Oct 2010 00:22:25 +0000 (00:22 +0000)]
Whitespace, comments and general cleanup.
Trevor Parscal [Tue, 19 Oct 2010 23:47:56 +0000 (23:47 +0000)]
Some cleanup work
Trevor Parscal [Tue, 19 Oct 2010 23:02:15 +0000 (23:02 +0000)]
Whitespace adjustments
Trevor Parscal [Tue, 19 Oct 2010 23:00:52 +0000 (23:00 +0000)]
Fixed remaning use of $this->loaders to use the new naming of $this->loaderScripts
Trevor Parscal [Tue, 19 Oct 2010 22:53:53 +0000 (22:53 +0000)]
Fixed case where tryForKey can sometimes not return an array
Trevor Parscal [Tue, 19 Oct 2010 22:48:52 +0000 (22:48 +0000)]
Refactored ResourceLoaderFileModule, most notably removing the set* methods, which are not in use at the moment, and should only be added when we have a use case for them (API bloat = bad)
Trevor Parscal [Tue, 19 Oct 2010 21:05:07 +0000 (21:05 +0000)]
* Added extendable fallback closure to configuration prototype.
* Renamed configuration to map, since it's being used more generally than just for configurations.
Platonides [Tue, 19 Oct 2010 21:02:03 +0000 (21:02 +0000)]
Remove PHP Notice: Undefined index: usedomain in phase3/includes/templates/Userlogin.php on line 70
Add extradata data for adding fields from an extension.
Trevor Parscal [Tue, 19 Oct 2010 20:59:23 +0000 (20:59 +0000)]
Fixed ResourceLoaderFileModule constructor - collated lists were not being prefixed properly. Also did some renaming to improve consistency.
Antoine Musso [Tue, 19 Oct 2010 20:45:02 +0000 (20:45 +0000)]
documentation, a couple notes about code and some whitespaces adjustements to make code easier to read.
Markus Glaser [Tue, 19 Oct 2010 19:58:58 +0000 (19:58 +0000)]
Follow up r74753, removed pass-by-references and @ operator
Raimond Spekking [Tue, 19 Oct 2010 19:38:34 +0000 (19:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-19 19:03:00 UTC)
Markus Glaser [Tue, 19 Oct 2010 19:38:30 +0000 (19:38 +0000)]
Follow up r74750, array keys should be strings
Sam Reed [Tue, 19 Oct 2010 18:40:43 +0000 (18:40 +0000)]
Followup r74988, brion wins again ;D
Trevor Parscal [Tue, 19 Oct 2010 18:31:09 +0000 (18:31 +0000)]
Part 2 of 2, moved ResourceLoader*Module classes to their own files - this commit removes the non file specific code.
Trevor Parscal [Tue, 19 Oct 2010 18:25:42 +0000 (18:25 +0000)]
Part 1 of 2, moving ResourceLoader*Module classes to their own files - this commit copies the ResourceLoaderModules.php file to each of the new files, as to maintain revision history. The next revision will remove non file specific code.
Trevor Parscal [Tue, 19 Oct 2010 18:21:38 +0000 (18:21 +0000)]
Moved ResourceLoader classes to their own folder, preparing to also split ResourceLoaderModule.php into multiple files (it's getting a bit long now)
Trevor Parscal [Tue, 19 Oct 2010 17:52:01 +0000 (17:52 +0000)]
Reverts r75018, and does what that commit was supposed to do.
Trevor Parscal [Tue, 19 Oct 2010 17:48:41 +0000 (17:48 +0000)]
Improves on r74964 by including PHP warnings emitted during a ResourceLoader response in a comment at the end of the response - only while in debug mode.
Niklas Laxström [Tue, 19 Oct 2010 08:27:13 +0000 (08:27 +0000)]
Temp fix for r74966 to stop causing errors everywhere
Antoine Musso [Tue, 19 Oct 2010 06:27:25 +0000 (06:27 +0000)]
Follow up r74962, debug messages should be splitted.
This is to avoid log mess with concurrent accesses and to allow logging between the messages.
Makes the message more readeable:
Connecting to localhost wikidb...
Connected to localhost wikidb.
Connection failed to localhost wikidb.
Jure Kajzer [Tue, 19 Oct 2010 06:25:12 +0000 (06:25 +0000)]
* fixed r74949 remarks
* modified version lookup, added 9iR1 as minimum version for installation.
Sam Reed [Tue, 19 Oct 2010 00:44:28 +0000 (00:44 +0000)]
Swap usage of create_function for defined function as a callback
Sam Reed [Mon, 18 Oct 2010 23:50:33 +0000 (23:50 +0000)]
Per CR on r45418...
Explicitally define $refers = array();, as it being in a loop is just slight confusing with the isset
Purodha B Blissenbach [Mon, 18 Oct 2010 23:27:41 +0000 (23:27 +0000)]
Add link in message, similar to the similar ones in this group.
Chad Horohoe [Mon, 18 Oct 2010 22:37:44 +0000 (22:37 +0000)]
Followup r68760: add comment
Antoine Musso [Mon, 18 Oct 2010 21:36:58 +0000 (21:36 +0000)]
Add parser tests to the 'Parser' group
Makefile gets some additional targets
Roan Kattouw [Mon, 18 Oct 2010 20:35:56 +0000 (20:35 +0000)]
First shot at porting Monobook to Vector. The only non-straightforward part is moving from a separate rtl.css file to a main.css file we can safely Janus. This is half-done right now. Notable things:
* No longer including rtl.css, instead relying on Janused main.css
* Renamed external.png to external-ltr.png so Janus will pick up on external-rtl.png (already exists)
* Added @embed to all images, add @noflip where needed (may not have covered all cases)
* Pulled some things from rtl.css into main.css such that they're no-ops in LTR but are needed in RTL. Example: body { direction:ltr;
* Killed some RTL-specific rules in main.css that were superseded in main.css
* Changed padding: 0 foo; to padding-right: foo; so it gets Janused right
* Commented out loading of IE*Fixes.css. Still need to incorporate these into main.css somehow
Roan Kattouw [Mon, 18 Oct 2010 20:16:19 +0000 (20:16 +0000)]
ResourceLoader: Clear warnings before echo'ing output
Antoine Musso [Mon, 18 Oct 2010 19:56:33 +0000 (19:56 +0000)]
Make some wfDebug() messages nicer to look at in debug log file.
Raimond Spekking [Mon, 18 Oct 2010 19:42:19 +0000 (19:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-18 19:23:00 UTC)
Priyanka Dhanda [Mon, 18 Oct 2010 18:28:16 +0000 (18:28 +0000)]
Reverted accidental changes to DifferenceInterface in r74956
Priyanka Dhanda [Mon, 18 Oct 2010 18:20:19 +0000 (18:20 +0000)]
Added to DefaultSettings
Priyanka Dhanda [Mon, 18 Oct 2010 18:15:13 +0000 (18:15 +0000)]
Follow up to r74780. Set default for . did some sanity check around testSuiteNames. Some more code cleanup
Priyanka Dhanda [Mon, 18 Oct 2010 18:14:36 +0000 (18:14 +0000)]
Follow up to r74780. Set default for .
Platonides [Mon, 18 Oct 2010 17:42:14 +0000 (17:42 +0000)]
Double braces introduced in r74742 giving a fatal:
PHP Parse error: syntax error, unexpected $end in ./maintenance/purgeOldText.inc on line 63
Siebrand Mazeland [Mon, 18 Oct 2010 17:29:32 +0000 (17:29 +0000)]
Follow-up r74949: fix typo in UI message.
Raimond Spekking [Mon, 18 Oct 2010 16:41:13 +0000 (16:41 +0000)]
Follow-up r74949: Comment out a contentless message to avoid useless translation in Translatewiki
Re-enable this message when the help text is ready. Thanks.
Max Semenik [Mon, 18 Oct 2010 16:21:31 +0000 (16:21 +0000)]
Fixed ImageMagick detection on Windows
Jure Kajzer [Mon, 18 Oct 2010 16:09:18 +0000 (16:09 +0000)]
* Installer: works (beta). More testing tomorow.
* Updater: todo. For now it skips.
Roan Kattouw [Mon, 18 Oct 2010 15:15:32 +0000 (15:15 +0000)]
(bug 25535) Don't include empty JS/CSS messages at <Skinname.js>
Roan Kattouw [Mon, 18 Oct 2010 15:11:48 +0000 (15:11 +0000)]
Per r74946 CR, check whether realpath( $file ) returns false before using it
Roan Kattouw [Mon, 18 Oct 2010 14:59:42 +0000 (14:59 +0000)]
(bug 25546) Feed argument to finfo_file() through readpath() so it'll work on Windows
Chad Horohoe [Mon, 18 Oct 2010 14:28:51 +0000 (14:28 +0000)]
Revert most of r72335:
* wfRunMaintenance() had scope issues (Maintenance::run() would have the same issues). Also per CR, it doesn't really reduce the amount of code that users are writing
* Example maintenance script doesn't belong here. There's already an example in docs/maintenance.txt, as well as docs on mw.org. Suggest expanding those instead.
Roan Kattouw [Mon, 18 Oct 2010 09:19:20 +0000 (09:19 +0000)]
Revert r74810 (vary API help cache on $wgUser->isAnon()) and move the POST check into the purge module. Also fix the permissions check in action=purge, which was totally broken and based on a misunderstanding of what the 'purge' right means.
Sean Colombo [Mon, 18 Oct 2010 06:12:55 +0000 (06:12 +0000)]
Did some testing to beef up the documentation a bit in memcached-client.php
Platonides [Sun, 17 Oct 2010 22:47:24 +0000 (22:47 +0000)]
$wgUser is never a Stub since r70970.
Platonides [Sun, 17 Oct 2010 22:33:25 +0000 (22:33 +0000)]
$wgUser is never a Stub since r70970.
This means, the user data was innecessarily loaded here just for the debug message.
It also caused bug 24995 - "fallback" key missing from localization cache.
For languages other than English (short-circuitted in Language.php:2800) during
Language load, it gets the fallback from the localization cache, which used the db,
which then loaded here the User object, which called WebRequest caused unstubbing (again)
of ContentLanguage for unicode normalization, which loaded again the Language (a call
to loadItem( 'xx', 'fallback' ) under loadItem( 'xx', 'fallback' ) stack) and then
caused it to finally fail.
It wasn't an unstub loop, but was near.
Backtrace:
LocalisationCache::loadItem phase3/includes/LocalisationCache.php:205 <-- Second load of key fallback
LocalisationCache::getItem phase3/languages/Language.php:2802
Language::getFallbackFor phase3/languages/Language.php:169
Language::newFromCode phase3/languages/Language.php:140
Language::factory phase3/includes/StubObject.php:126
StubContLang::_newObject phase3/includes/StubObject.php:103
StubObject::_unstub phase3/includes/StubObject.php:57
StubObject::_call phase3/includes/StubObject.php:121
StubContLang::__call phase3/includes/WebRequest.php:204 <-- Second unstub
StubContLang::normalize phase3/includes/WebRequest.php:204
WebRequest::normalizeUnicode phase3/includes/WebRequest.php:231
WebRequest::getGPCVal phase3/includes/WebRequest.php:460
WebRequest::getCookie phase3/includes/User.php:835
User::loadFromSession phase3/includes/User.php:221
User::load phase3/includes/User.php:1501
User::getName phase3/includes/db/Database.php:658
DatabaseBase::query phase3/includes/db/DatabaseMysql.php:120
DatabaseMysql::open phase3/includes/db/Database.php:530
DatabaseBase::__construct phase3/includes/db/LoadBalancer.php:651
LoadBalancer::reallyOpenConnection phase3/includes/db/LoadBalancer.php:532
LoadBalancer::openConnection phase3/includes/db/LoadBalancer.php:455
LoadBalancer::getConnection phase3/includes/GlobalFunctions.php:3085
wfGetDB phase3/includes/LocalisationCache.php:772
LCStore_DB::get phase3/includes/LocalisationCache.php:326
LocalisationCache::isExpired phase3/includes/LocalisationCache.php:355
LocalisationCache::initLanguage phase3/includes/LocalisationCache.php:267
LocalisationCache::loadItem phase3/includes/LocalisationCache.php:205 <-- First load of key fallback
LocalisationCache::getItem phase3/languages/Language.php:2802
Language::getFallbackFor phase3/languages/Language.php:169
Language::newFromCode phase3/languages/Language.php:140
Language::factory phase3/includes/StubObject.php:126
StubContLang::_newObject phase3/includes/StubObject.php:103
StubObject::_unstub phase3/includes/StubObject.php:57
StubObject::_call phase3/includes/StubObject.php:121
StubContLang::__call phase3/includes/WebRequest.php:228 <-- First unstub
StubContLang::checkTitleEncoding phase3/includes/WebRequest.php:228
WebRequest::getGPCVal phase3/includes/WebRequest.php:250
WebRequest::getVal phase3/index.php:56
Sam Reed [Sun, 17 Oct 2010 21:18:04 +0000 (21:18 +0000)]
Revert r74913, caused many problems, and was only likely to cause more in the future
Raimond Spekking [Sun, 17 Oct 2010 20:36:41 +0000 (20:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-17 19:57:00 UTC)
Chad Horohoe [Sun, 17 Oct 2010 20:36:07 +0000 (20:36 +0000)]
Followup r74918, rm leftover debugging
Chad Horohoe [Sun, 17 Oct 2010 20:34:25 +0000 (20:34 +0000)]
* Revert r69013 (Use `` instead of wfShellExec() like the old installer). This fails for people in safe_mode and for people with shell_exec in disable_functions. wfShellExec() handles these scenarios. For installation, we'll set $wgMaxShellMemory at 0 to disable the ulimit.
* Make envCheckShellLocale() use wfShellExec() as well (also works on OSX :)
Chad Horohoe [Sun, 17 Oct 2010 19:35:13 +0000 (19:35 +0000)]
rm always-true isOK() check
Sam Reed [Sun, 17 Oct 2010 19:04:05 +0000 (19:04 +0000)]
Move profiler stuff to own folder, updater AutoLoader to match
ProfilerSimpleTrace isn't in AutoLoader. Neither is ProfilerStub
Profiler also says " * This file is only included if profiling is enabled"...
Chad Horohoe [Sun, 17 Oct 2010 19:02:59 +0000 (19:02 +0000)]
For some reason we're not calling preInstall() like we should
Sam Reed [Sun, 17 Oct 2010 18:54:39 +0000 (18:54 +0000)]
Followup r74392. Also cache result of getUser call (may be called twice)
Sam Reed [Sun, 17 Oct 2010 18:51:00 +0000 (18:51 +0000)]
Followup r69904, make call to getRandomString static in Parser->unserialiseHalfParsedText()
Platonides [Sun, 17 Oct 2010 17:28:25 +0000 (17:28 +0000)]
Deprecate User::getPageRenderingHash() as follow-up to r70783.
Chad Horohoe [Sun, 17 Oct 2010 17:20:12 +0000 (17:20 +0000)]
Followup r74847, reduce some more duplication by moving the foreach() logic to a common method.
Also move these functions together
Chad Horohoe [Sun, 17 Oct 2010 17:09:45 +0000 (17:09 +0000)]
Fixup r71449, can't use $var::method() in < 5.3 :(
Use call_user_func() instead
Derk-Jan Hartman [Sun, 17 Oct 2010 15:27:10 +0000 (15:27 +0000)]
Don't set the padding of all sides of links with icons, only set the one that is actually needed.
Fixes bug 25548
Derk-Jan Hartman [Sun, 17 Oct 2010 15:12:24 +0000 (15:12 +0000)]
Use getAttribute( 'href', 2), so we can preserve relative paths if we want.
Fixes bug 25549
Platonides [Sun, 17 Oct 2010 14:10:26 +0000 (14:10 +0000)]
Use the getter per r74822 CR.
Max Semenik [Sun, 17 Oct 2010 10:18:08 +0000 (10:18 +0000)]
And while I'm at it, one more tweak to --memory-limit: use 'max' instead of -1 for clarity
Max Semenik [Sun, 17 Oct 2010 08:59:34 +0000 (08:59 +0000)]
Fix for r74849: use 'default' instead of 0 to indicate no memory-limit change.
Alexandre Emsenhuber [Sat, 16 Oct 2010 22:13:28 +0000 (22:13 +0000)]
fixed some doxygen warnings
Raimond Spekking [Sat, 16 Oct 2010 19:18:14 +0000 (19:18 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-16 18:47:00 UTC)
Alexandre Emsenhuber [Sat, 16 Oct 2010 18:58:29 +0000 (18:58 +0000)]
Per Platonides, follow-up to r67834: fix doc and removed no more needed return-by-ref of Parser::getTitle()
Alexandre Emsenhuber [Sat, 16 Oct 2010 18:47:46 +0000 (18:47 +0000)]
svn:eol-style native
Max Semenik [Sat, 16 Oct 2010 18:33:45 +0000 (18:33 +0000)]
Follow-up r74841:
* Moved command line parsing up so that the first use of --memory-limit actually works
* Now limit of 0 means that we shouldn't attempt to change it at all
Chad Horohoe [Sat, 16 Oct 2010 18:19:00 +0000 (18:19 +0000)]
Make envCheckGraphics use locateExecutable(). Move path stuff to a single method
Chad Horohoe [Sat, 16 Oct 2010 18:01:20 +0000 (18:01 +0000)]
Followup r74841, RELEASE-NOTES
Chad Horohoe [Sat, 16 Oct 2010 17:30:34 +0000 (17:30 +0000)]
Allow overriding default memory limits in maintenance scripts (which is usually to disable it). Helpful for people on Suhosin which yells at you for trying to disable the limit ;-)
Roan Kattouw [Sat, 16 Oct 2010 16:53:10 +0000 (16:53 +0000)]
Fix r72905: don't run $endTime through wfTimestamp() twice
Max Semenik [Sat, 16 Oct 2010 15:07:55 +0000 (15:07 +0000)]
Renamed all setup() in tests to setUp(). Although PHP doesn't care, PHPUnit docs prefer the latter. Removed a pointless override in one case.
Antoine Musso [Sat, 16 Oct 2010 13:24:35 +0000 (13:24 +0000)]
* Fix r74790 by actually calling setup (using parent::setup)
* Replace inexistant markTestIgnored() method with markTestSkipped()
* Add comments
Antoine Musso [Sat, 16 Oct 2010 10:39:00 +0000 (10:39 +0000)]
If using PHPUnit version 3.5.0 or later, make use of its Autoloader
Platonides [Fri, 15 Oct 2010 23:16:11 +0000 (23:16 +0000)]
Create a new ParserOptions()
Platonides [Fri, 15 Oct 2010 23:10:05 +0000 (23:10 +0000)]
Use the accessor for getting mOptions.
I'm not touching the accesses from the preprocessors since
I don't know if the call could add a penalty.
Platonides [Fri, 15 Oct 2010 23:02:49 +0000 (23:02 +0000)]
Revert RELEASE-NOTES change from r68272, which was reverted in r68343.
Platonides [Fri, 15 Oct 2010 22:12:19 +0000 (22:12 +0000)]
Follow r69904. Make Parser::getRandomString real private.
Parser_DiffTest::dtUniqPrefix is now lazyloader.
I also fixed the typo in its declaration.
Platonides [Fri, 15 Oct 2010 19:48:21 +0000 (19:48 +0000)]
r71546 broke imagemagick usage in Windows, since cmd.exe takes the variable
names as the program name.
I'm just not exporting those variables here, but we need to support them in Windows, too.
We could use putenv() but that seems ugly (and risky). A better solution would be to have
wfShellExec() call proc_open() with a modified environment.
A POSIX shell is required to accept variable assignments before the command so we shouldn't
have problems on any UNIX-like system.
http://www.opengroup.org/onlinepubs/
009695399/utilities/xcu_chap02.html#tag_02_09_01
Raimond Spekking [Fri, 15 Oct 2010 19:18:12 +0000 (19:18 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-15 19:02:00 UTC)
Sam Reed [Fri, 15 Oct 2010 17:13:38 +0000 (17:13 +0000)]
* (bug 24792) API help caching doesn't vary on $wgUser->isAnon(), causes staleness
Greg Sabino Mullane [Fri, 15 Oct 2010 15:39:48 +0000 (15:39 +0000)]
cl_sortkey now back down to varbinary(230). Glad PG doesn't have this issue.
Max Semenik [Fri, 15 Oct 2010 14:11:59 +0000 (14:11 +0000)]
Fixed stupid copy+paste error from r74109
Platonides [Thu, 14 Oct 2010 22:13:43 +0000 (22:13 +0000)]
Follow up r74725. Also add $lang parameter to EditSectionLink.
Document the changes in hooks.txt
Aryeh Gregor [Thu, 14 Oct 2010 21:47:02 +0000 (21:47 +0000)]
cl_sortkey should be 230 bytes long, not 255
Bug 25503, reported by Dmitriy. When switching it to binary, I figured
that since it would always be one byte per character now, there would be
room to make it the full 255 bytes. In fact, if cl_to is utf8, the
(cl_to, cl_type, cl_sortkey, cl_from) index will be 255*3 + 1 + 255 + 4
= 1025 bytes, longer than the max of 1000. Shortening cl_sortkey to 230
bytes fixes this (fix tested by Dmitriy).
I didn't add an updater because if you're already running the current
schema without problems, you don't need this change.
Sam Reed [Thu, 14 Oct 2010 20:53:04 +0000 (20:53 +0000)]
Big attack on unused variables...
Sam Reed [Thu, 14 Oct 2010 20:34:01 +0000 (20:34 +0000)]
Another followup to r71426, $ni to $fieldRecord
Sam Reed [Thu, 14 Oct 2010 20:31:34 +0000 (20:31 +0000)]
Followup r71426, not $nc it's $fieldRecord