Jure Kajzer [Mon, 18 Oct 2010 16:09:18 +0000 (16:09 +0000)]
* Installer: works (beta). More testing tomorow.
* Updater: todo. For now it skips.
Roan Kattouw [Mon, 18 Oct 2010 15:15:32 +0000 (15:15 +0000)]
(bug 25535) Don't include empty JS/CSS messages at <Skinname.js>
Roan Kattouw [Mon, 18 Oct 2010 15:11:48 +0000 (15:11 +0000)]
Per r74946 CR, check whether realpath( $file ) returns false before using it
Roan Kattouw [Mon, 18 Oct 2010 14:59:42 +0000 (14:59 +0000)]
(bug 25546) Feed argument to finfo_file() through readpath() so it'll work on Windows
Chad Horohoe [Mon, 18 Oct 2010 14:28:51 +0000 (14:28 +0000)]
Revert most of r72335:
* wfRunMaintenance() had scope issues (Maintenance::run() would have the same issues). Also per CR, it doesn't really reduce the amount of code that users are writing
* Example maintenance script doesn't belong here. There's already an example in docs/maintenance.txt, as well as docs on mw.org. Suggest expanding those instead.
Roan Kattouw [Mon, 18 Oct 2010 09:19:20 +0000 (09:19 +0000)]
Revert r74810 (vary API help cache on $wgUser->isAnon()) and move the POST check into the purge module. Also fix the permissions check in action=purge, which was totally broken and based on a misunderstanding of what the 'purge' right means.
Sean Colombo [Mon, 18 Oct 2010 06:12:55 +0000 (06:12 +0000)]
Did some testing to beef up the documentation a bit in memcached-client.php
Platonides [Sun, 17 Oct 2010 22:47:24 +0000 (22:47 +0000)]
$wgUser is never a Stub since r70970.
Platonides [Sun, 17 Oct 2010 22:33:25 +0000 (22:33 +0000)]
$wgUser is never a Stub since r70970.
This means, the user data was innecessarily loaded here just for the debug message.
It also caused bug 24995 - "fallback" key missing from localization cache.
For languages other than English (short-circuitted in Language.php:2800) during
Language load, it gets the fallback from the localization cache, which used the db,
which then loaded here the User object, which called WebRequest caused unstubbing (again)
of ContentLanguage for unicode normalization, which loaded again the Language (a call
to loadItem( 'xx', 'fallback' ) under loadItem( 'xx', 'fallback' ) stack) and then
caused it to finally fail.
It wasn't an unstub loop, but was near.
Backtrace:
LocalisationCache::loadItem phase3/includes/LocalisationCache.php:205 <-- Second load of key fallback
LocalisationCache::getItem phase3/languages/Language.php:2802
Language::getFallbackFor phase3/languages/Language.php:169
Language::newFromCode phase3/languages/Language.php:140
Language::factory phase3/includes/StubObject.php:126
StubContLang::_newObject phase3/includes/StubObject.php:103
StubObject::_unstub phase3/includes/StubObject.php:57
StubObject::_call phase3/includes/StubObject.php:121
StubContLang::__call phase3/includes/WebRequest.php:204 <-- Second unstub
StubContLang::normalize phase3/includes/WebRequest.php:204
WebRequest::normalizeUnicode phase3/includes/WebRequest.php:231
WebRequest::getGPCVal phase3/includes/WebRequest.php:460
WebRequest::getCookie phase3/includes/User.php:835
User::loadFromSession phase3/includes/User.php:221
User::load phase3/includes/User.php:1501
User::getName phase3/includes/db/Database.php:658
DatabaseBase::query phase3/includes/db/DatabaseMysql.php:120
DatabaseMysql::open phase3/includes/db/Database.php:530
DatabaseBase::__construct phase3/includes/db/LoadBalancer.php:651
LoadBalancer::reallyOpenConnection phase3/includes/db/LoadBalancer.php:532
LoadBalancer::openConnection phase3/includes/db/LoadBalancer.php:455
LoadBalancer::getConnection phase3/includes/GlobalFunctions.php:3085
wfGetDB phase3/includes/LocalisationCache.php:772
LCStore_DB::get phase3/includes/LocalisationCache.php:326
LocalisationCache::isExpired phase3/includes/LocalisationCache.php:355
LocalisationCache::initLanguage phase3/includes/LocalisationCache.php:267
LocalisationCache::loadItem phase3/includes/LocalisationCache.php:205 <-- First load of key fallback
LocalisationCache::getItem phase3/languages/Language.php:2802
Language::getFallbackFor phase3/languages/Language.php:169
Language::newFromCode phase3/languages/Language.php:140
Language::factory phase3/includes/StubObject.php:126
StubContLang::_newObject phase3/includes/StubObject.php:103
StubObject::_unstub phase3/includes/StubObject.php:57
StubObject::_call phase3/includes/StubObject.php:121
StubContLang::__call phase3/includes/WebRequest.php:228 <-- First unstub
StubContLang::checkTitleEncoding phase3/includes/WebRequest.php:228
WebRequest::getGPCVal phase3/includes/WebRequest.php:250
WebRequest::getVal phase3/index.php:56
Sam Reed [Sun, 17 Oct 2010 21:18:04 +0000 (21:18 +0000)]
Revert r74913, caused many problems, and was only likely to cause more in the future
Raimond Spekking [Sun, 17 Oct 2010 20:36:41 +0000 (20:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-17 19:57:00 UTC)
Chad Horohoe [Sun, 17 Oct 2010 20:36:07 +0000 (20:36 +0000)]
Followup r74918, rm leftover debugging
Chad Horohoe [Sun, 17 Oct 2010 20:34:25 +0000 (20:34 +0000)]
* Revert r69013 (Use `` instead of wfShellExec() like the old installer). This fails for people in safe_mode and for people with shell_exec in disable_functions. wfShellExec() handles these scenarios. For installation, we'll set $wgMaxShellMemory at 0 to disable the ulimit.
* Make envCheckShellLocale() use wfShellExec() as well (also works on OSX :)
Chad Horohoe [Sun, 17 Oct 2010 19:35:13 +0000 (19:35 +0000)]
rm always-true isOK() check
Sam Reed [Sun, 17 Oct 2010 19:04:05 +0000 (19:04 +0000)]
Move profiler stuff to own folder, updater AutoLoader to match
ProfilerSimpleTrace isn't in AutoLoader. Neither is ProfilerStub
Profiler also says " * This file is only included if profiling is enabled"...
Chad Horohoe [Sun, 17 Oct 2010 19:02:59 +0000 (19:02 +0000)]
For some reason we're not calling preInstall() like we should
Sam Reed [Sun, 17 Oct 2010 18:54:39 +0000 (18:54 +0000)]
Followup r74392. Also cache result of getUser call (may be called twice)
Sam Reed [Sun, 17 Oct 2010 18:51:00 +0000 (18:51 +0000)]
Followup r69904, make call to getRandomString static in Parser->unserialiseHalfParsedText()
Platonides [Sun, 17 Oct 2010 17:28:25 +0000 (17:28 +0000)]
Deprecate User::getPageRenderingHash() as follow-up to r70783.
Chad Horohoe [Sun, 17 Oct 2010 17:20:12 +0000 (17:20 +0000)]
Followup r74847, reduce some more duplication by moving the foreach() logic to a common method.
Also move these functions together
Chad Horohoe [Sun, 17 Oct 2010 17:09:45 +0000 (17:09 +0000)]
Fixup r71449, can't use $var::method() in < 5.3 :(
Use call_user_func() instead
Derk-Jan Hartman [Sun, 17 Oct 2010 15:27:10 +0000 (15:27 +0000)]
Don't set the padding of all sides of links with icons, only set the one that is actually needed.
Fixes bug 25548
Derk-Jan Hartman [Sun, 17 Oct 2010 15:12:24 +0000 (15:12 +0000)]
Use getAttribute( 'href', 2), so we can preserve relative paths if we want.
Fixes bug 25549
Platonides [Sun, 17 Oct 2010 14:10:26 +0000 (14:10 +0000)]
Use the getter per r74822 CR.
Max Semenik [Sun, 17 Oct 2010 10:18:08 +0000 (10:18 +0000)]
And while I'm at it, one more tweak to --memory-limit: use 'max' instead of -1 for clarity
Max Semenik [Sun, 17 Oct 2010 08:59:34 +0000 (08:59 +0000)]
Fix for r74849: use 'default' instead of 0 to indicate no memory-limit change.
Alexandre Emsenhuber [Sat, 16 Oct 2010 22:13:28 +0000 (22:13 +0000)]
fixed some doxygen warnings
Raimond Spekking [Sat, 16 Oct 2010 19:18:14 +0000 (19:18 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-16 18:47:00 UTC)
Alexandre Emsenhuber [Sat, 16 Oct 2010 18:58:29 +0000 (18:58 +0000)]
Per Platonides, follow-up to r67834: fix doc and removed no more needed return-by-ref of Parser::getTitle()
Alexandre Emsenhuber [Sat, 16 Oct 2010 18:47:46 +0000 (18:47 +0000)]
svn:eol-style native
Max Semenik [Sat, 16 Oct 2010 18:33:45 +0000 (18:33 +0000)]
Follow-up r74841:
* Moved command line parsing up so that the first use of --memory-limit actually works
* Now limit of 0 means that we shouldn't attempt to change it at all
Chad Horohoe [Sat, 16 Oct 2010 18:19:00 +0000 (18:19 +0000)]
Make envCheckGraphics use locateExecutable(). Move path stuff to a single method
Chad Horohoe [Sat, 16 Oct 2010 18:01:20 +0000 (18:01 +0000)]
Followup r74841, RELEASE-NOTES
Chad Horohoe [Sat, 16 Oct 2010 17:30:34 +0000 (17:30 +0000)]
Allow overriding default memory limits in maintenance scripts (which is usually to disable it). Helpful for people on Suhosin which yells at you for trying to disable the limit ;-)
Roan Kattouw [Sat, 16 Oct 2010 16:53:10 +0000 (16:53 +0000)]
Fix r72905: don't run $endTime through wfTimestamp() twice
Max Semenik [Sat, 16 Oct 2010 15:07:55 +0000 (15:07 +0000)]
Renamed all setup() in tests to setUp(). Although PHP doesn't care, PHPUnit docs prefer the latter. Removed a pointless override in one case.
Antoine Musso [Sat, 16 Oct 2010 13:24:35 +0000 (13:24 +0000)]
* Fix r74790 by actually calling setup (using parent::setup)
* Replace inexistant markTestIgnored() method with markTestSkipped()
* Add comments
Antoine Musso [Sat, 16 Oct 2010 10:39:00 +0000 (10:39 +0000)]
If using PHPUnit version 3.5.0 or later, make use of its Autoloader
Platonides [Fri, 15 Oct 2010 23:16:11 +0000 (23:16 +0000)]
Create a new ParserOptions()
Platonides [Fri, 15 Oct 2010 23:10:05 +0000 (23:10 +0000)]
Use the accessor for getting mOptions.
I'm not touching the accesses from the preprocessors since
I don't know if the call could add a penalty.
Platonides [Fri, 15 Oct 2010 23:02:49 +0000 (23:02 +0000)]
Revert RELEASE-NOTES change from r68272, which was reverted in r68343.
Platonides [Fri, 15 Oct 2010 22:12:19 +0000 (22:12 +0000)]
Follow r69904. Make Parser::getRandomString real private.
Parser_DiffTest::dtUniqPrefix is now lazyloader.
I also fixed the typo in its declaration.
Platonides [Fri, 15 Oct 2010 19:48:21 +0000 (19:48 +0000)]
r71546 broke imagemagick usage in Windows, since cmd.exe takes the variable
names as the program name.
I'm just not exporting those variables here, but we need to support them in Windows, too.
We could use putenv() but that seems ugly (and risky). A better solution would be to have
wfShellExec() call proc_open() with a modified environment.
A POSIX shell is required to accept variable assignments before the command so we shouldn't
have problems on any UNIX-like system.
http://www.opengroup.org/onlinepubs/
009695399/utilities/xcu_chap02.html#tag_02_09_01
Raimond Spekking [Fri, 15 Oct 2010 19:18:12 +0000 (19:18 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-15 19:02:00 UTC)
Sam Reed [Fri, 15 Oct 2010 17:13:38 +0000 (17:13 +0000)]
* (bug 24792) API help caching doesn't vary on $wgUser->isAnon(), causes staleness
Greg Sabino Mullane [Fri, 15 Oct 2010 15:39:48 +0000 (15:39 +0000)]
cl_sortkey now back down to varbinary(230). Glad PG doesn't have this issue.
Max Semenik [Fri, 15 Oct 2010 14:11:59 +0000 (14:11 +0000)]
Fixed stupid copy+paste error from r74109
Platonides [Thu, 14 Oct 2010 22:13:43 +0000 (22:13 +0000)]
Follow up r74725. Also add $lang parameter to EditSectionLink.
Document the changes in hooks.txt
Aryeh Gregor [Thu, 14 Oct 2010 21:47:02 +0000 (21:47 +0000)]
cl_sortkey should be 230 bytes long, not 255
Bug 25503, reported by Dmitriy. When switching it to binary, I figured
that since it would always be one byte per character now, there would be
room to make it the full 255 bytes. In fact, if cl_to is utf8, the
(cl_to, cl_type, cl_sortkey, cl_from) index will be 255*3 + 1 + 255 + 4
= 1025 bytes, longer than the max of 1000. Shortening cl_sortkey to 230
bytes fixes this (fix tested by Dmitriy).
I didn't add an updater because if you're already running the current
schema without problems, you don't need this change.
Sam Reed [Thu, 14 Oct 2010 20:53:04 +0000 (20:53 +0000)]
Big attack on unused variables...
Sam Reed [Thu, 14 Oct 2010 20:34:01 +0000 (20:34 +0000)]
Another followup to r71426, $ni to $fieldRecord
Sam Reed [Thu, 14 Oct 2010 20:31:34 +0000 (20:31 +0000)]
Followup r71426, not $nc it's $fieldRecord
Raimond Spekking [Thu, 14 Oct 2010 19:36:21 +0000 (19:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-14 19:25:00 UTC)
Max Semenik [Thu, 14 Oct 2010 18:27:27 +0000 (18:27 +0000)]
Fixes for r74787:
* Don't call the check from every tests, there's setup() for that
* Check for FTS3 presence for SQLite, version is only partially relevant here as full-text search was added to default build options in 3.5.3, but it was accessible even before that. And even on 3.6 people can choose not to build with FTS.
Chad Horohoe [Thu, 14 Oct 2010 18:26:15 +0000 (18:26 +0000)]
spaces -> tabs
Antoine Musso [Thu, 14 Oct 2010 18:01:09 +0000 (18:01 +0000)]
* sqlite 3.3 fails, raising version to 3.6 just like parserTests.php
* skip tests that need DB support
Maybe someone could implements this using the magic __call method.
Priyanka Dhanda [Thu, 14 Oct 2010 17:56:52 +0000 (17:56 +0000)]
Cleanup of SimpleSeleniumTestCase. Removed unnecessary include.
Priyanka Dhanda [Thu, 14 Oct 2010 17:06:07 +0000 (17:06 +0000)]
Added missing file for r74780
Priyanka Dhanda [Thu, 14 Oct 2010 16:38:40 +0000 (16:38 +0000)]
* WebStart.php and SeleniumWebSettings.php allow include files and global config variables to be set based on the testsuite being run. See discussion in mediawiki.org/wiki/SeleniumFramework#Test_Wiki_configuration
* Let test suites run without logging in.
Niklas Laxström [Thu, 14 Oct 2010 15:59:20 +0000 (15:59 +0000)]
* (Bug 25451) Language::time() and ::date() misfunction when given timestamps in wrong format
Convert given times to correct format like ::timeandate() already does.
Based on patch by Thorsten Glaser <tg@debian.org>.
Niklas Laxström [Thu, 14 Oct 2010 09:14:45 +0000 (09:14 +0000)]
Add sgs code for Samogitian and deprecate bat-smg.
See also bug 25522.
Markus Glaser [Thu, 14 Oct 2010 00:42:38 +0000 (00:42 +0000)]
added support for junit log file output, which is neede by phpUnderControl
Markus Glaser [Thu, 14 Oct 2010 00:06:24 +0000 (00:06 +0000)]
* start / stop selenium server on Linux
* credits to Dan Nessett
Markus Glaser [Wed, 13 Oct 2010 23:57:28 +0000 (23:57 +0000)]
added credits to Priyanka Dhanda and Daniel Kinzler
Markus Glaser [Wed, 13 Oct 2010 23:52:42 +0000 (23:52 +0000)]
* handle PHP 5.2 ini files
* sample ini file for PHP 5.2
* credits to dan nessett
Trevor Parscal [Wed, 13 Oct 2010 23:52:37 +0000 (23:52 +0000)]
White space changes
Sam Reed [Wed, 13 Oct 2010 23:44:41 +0000 (23:44 +0000)]
Fixup tabs/whitespace
Sam Reed [Wed, 13 Oct 2010 23:43:21 +0000 (23:43 +0000)]
Fixup r74646
Remove unreachable return false;
Fix $tohis to $this
Sam Reed [Wed, 13 Oct 2010 23:28:34 +0000 (23:28 +0000)]
ResourceLoaderModule::concatStyles returns an Array, hence getPrimaryStyles does
Sam Reed [Wed, 13 Oct 2010 23:11:40 +0000 (23:11 +0000)]
Assignment in loop conditions suck
while ( $row = $dbw->fetchObject( $res ) ) { to foreach ( $res as $row ) in includes
Add some braces
Jack Phoenix [Wed, 13 Oct 2010 22:43:37 +0000 (22:43 +0000)]
follow-up to r74742: fix typos
Sam Reed [Wed, 13 Oct 2010 22:35:27 +0000 (22:35 +0000)]
Assignment in loop conditions suck
while ( $row = $dbw->fetchObject( $res ) ) { to foreach ( $res as $row ) in config
Sam Reed [Wed, 13 Oct 2010 22:34:25 +0000 (22:34 +0000)]
Assignment in loop conditions suck
while ( $row = $dbw->fetchObject( $res ) ) { to foreach ( $res as $row ) in maintenance stuffs (more to come)
Trevor Parscal [Wed, 13 Oct 2010 21:58:04 +0000 (21:58 +0000)]
Fixes bug in wikibits that causes addPortletLink to fail when adding tabs to the vector skin.
Raimond Spekking [Wed, 13 Oct 2010 19:36:44 +0000 (19:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-13 19:22:00 UTC)
Sam Reed [Wed, 13 Oct 2010 19:01:21 +0000 (19:01 +0000)]
Fixup "} elseif ( $cond[0] = '!' ) {" from r35983
NB, why are some revisions marked ok by no one? :S
Jack D. Pond [Wed, 13 Oct 2010 18:45:43 +0000 (18:45 +0000)]
Added $lang parameter to DoEditSectionLink hook. Allows extensions that add or modify links to use wfMsgExt to build those links consistent with parent function doEditSectionLink.
Neil Kandalgaonkar [Wed, 13 Oct 2010 00:27:03 +0000 (00:27 +0000)]
removing test file
Neil Kandalgaonkar [Wed, 13 Oct 2010 00:26:36 +0000 (00:26 +0000)]
testing if I can commit
Platonides [Tue, 12 Oct 2010 23:20:12 +0000 (23:20 +0000)]
Follow up r70940. This call should use the hook $result.
Sam Reed [Tue, 12 Oct 2010 22:48:22 +0000 (22:48 +0000)]
Remove unused array index, add a couple of braces
Trevor Parscal [Tue, 12 Oct 2010 21:28:17 +0000 (21:28 +0000)]
Finished what r67300 started, by using #ba0000 as the broken "red" link color.
Trevor Parscal [Tue, 12 Oct 2010 21:19:51 +0000 (21:19 +0000)]
Improves on r72776 by adding documentation about the limitations of ResourceLoaderWikiModule and making use of the MWNamespace::getCanonicalName method rather than depending on $wgCanonicalNamespaceNames.
Raimond Spekking [Tue, 12 Oct 2010 19:49:45 +0000 (19:49 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-12 19:36:00 UTC)
Derk-Jan Hartman [Tue, 12 Oct 2010 19:15:40 +0000 (19:15 +0000)]
* Test for the presence of addEventListener on the element on which we will actually use it.
Just in case someone messes with the normal environment.
Antoine Musso [Tue, 12 Oct 2010 18:20:48 +0000 (18:20 +0000)]
A note about symbolic link and dirname() / include() ...
Max Semenik [Tue, 12 Oct 2010 18:16:53 +0000 (18:16 +0000)]
Piece I was going to commit in r74681
Trevor Parscal [Tue, 12 Oct 2010 18:15:53 +0000 (18:15 +0000)]
Improves on r69445 by removing unneeded conditional. Also fixes a comment typo.
Max Semenik [Tue, 12 Oct 2010 18:14:36 +0000 (18:14 +0000)]
Follow-up r74628: convert two remaining calls of patchPath()
Trevor Parscal [Tue, 12 Oct 2010 17:52:32 +0000 (17:52 +0000)]
Simplifies r73680 by letting FormatJson::encode do it's magic with handling null and string values correctly.
Mark A. Hershberger [Tue, 12 Oct 2010 17:40:52 +0000 (17:40 +0000)]
Enumerate private member to fix build problem on CC
Mark A. Hershberger [Mon, 11 Oct 2010 22:50:06 +0000 (22:50 +0000)]
NOTE THAT THIS COMMIT REVEALS FAILING PARSER TESTS WHEN THEY ARE RUN IN PHPUnit. THE PHPUnit HARNESS NEEDS TO BE FIXED IN THIS CASE. Running parser tests by the traditional “php parserTests.php” verified to work without failures.
Committing this to get the parser tests running under PHPUnit on the whole. I expect to find fixes for the PHPUnit harness shortly.
* Construct ParserOptions with a user in ExtraParserTest and set up wgLang if it gets set to null — which *was* happening PHPUnit. Note that this probably shows a bug that I wasn't able to track down.
* Adjust phpunit tests so that they execute and report Parser test failures properly. Attempt to make parser test titles the test titles PHPUnit sees.
* Add E_STRICT reporting to PHPUnit testing.
* Provide PHPUnitParserTest as an exension of ParserTest to handle necessary PHPUnit calls for running parser tests under PHPUnit.
* Use dirname() instead of relative paths (i.e. “..”) where SearchEngineTest.php looks for bootstrap.php.
* Sprinkle teardownGlobals() in exit points for teardownDatabase()
* Make ParserTest::chomp() static.
Raimond Spekking [Mon, 11 Oct 2010 19:10:39 +0000 (19:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-11 19:00:00 UTC)
Max Semenik [Mon, 11 Oct 2010 15:29:48 +0000 (15:29 +0000)]
Turned Database::patchPath() into a member function, less globals to care about
Derk-Jan Hartman [Mon, 11 Oct 2010 15:20:57 +0000 (15:20 +0000)]
Remove $wgRemoteUploads. It was not well supported and superseded by $wgUploadNavigationUrl.
Follow up to r66566
Roan Kattouw [Mon, 11 Oct 2010 14:10:23 +0000 (14:10 +0000)]
When reading an old-style user_options blob, use the default value for any preferences not set in the blob. This'll hopefully fix bug 25416 ($options['editfont'] not set even though editfont is a legit pref)
Roan Kattouw [Mon, 11 Oct 2010 08:32:48 +0000 (08:32 +0000)]
(bug 25474) Fix wrong parameters in updateModule() call. r74525 tried to fix this, but missed the point. Patch by Borislav Manolov
Raimond Spekking [Sun, 10 Oct 2010 19:23:48 +0000 (19:23 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-10 19:07:00 UTC)
Alexandre Emsenhuber [Sun, 10 Oct 2010 18:18:08 +0000 (18:18 +0000)]
Removed error suppression operators
Platonides [Sun, 10 Oct 2010 14:45:00 +0000 (14:45 +0000)]
Space