From: Reedy <reedy@wikimedia.org>
Date: Fri, 1 Apr 2016 20:21:59 +0000 (+0100)
Subject: LoadBalancer::pickRandom() was removed
X-Git-Tag: 1.31.0-rc.0~7431
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=f6f40a096512dc019ea9fe7e4750f92f422af2b1;p=lhc%2Fweb%2Fwiklou.git

LoadBalancer::pickRandom() was removed

Bug: T122754
Change-Id: I85d0c4387195cb60c70e24a0a7ab338723e6e7f4
---

diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index edde628edd..12fb06e3b4 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -395,6 +395,7 @@ changes to languages because of Phabricator reports.
 * Skin::getCommonStylePath() was removed (deprecated since 1.24).
 * Skin::newFromKey() was removed (deprecated since 1.24).
 * Skin::getUsableSkins() was removed (deprecated since 1.23).
+* LoadBalancer::pickRandom() was removed (deprecated in 1.21).
 
 == Compatibility ==
 
diff --git a/includes/db/loadbalancer/LoadBalancer.php b/includes/db/loadbalancer/LoadBalancer.php
index 997efa672a..741999c53d 100644
--- a/includes/db/loadbalancer/LoadBalancer.php
+++ b/includes/db/loadbalancer/LoadBalancer.php
@@ -161,19 +161,6 @@ class LoadBalancer {
 		return wfSetVar( $this->mParentInfo, $x );
 	}
 
-	/**
-	 * Given an array of non-normalised probabilities, this function will select
-	 * an element and return the appropriate key
-	 *
-	 * @deprecated since 1.21, use ArrayUtils::pickRandom()
-	 *
-	 * @param array $weights
-	 * @return bool|int|string
-	 */
-	public function pickRandom( array $weights ) {
-		return ArrayUtils::pickRandom( $weights );
-	}
-
 	/**
 	 * @param array $loads
 	 * @param bool|string $wiki Wiki to get non-lagged for