From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Tue, 5 Apr 2016 20:09:40 +0000 (+0200)
Subject: SpecialLog: Don't put assignment within another expression
X-Git-Tag: 1.31.0-rc.0~7341^2
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=de931602e5fab4040ad0a6df17a5304e70bfa1d8;p=lhc%2Fweb%2Fwiklou.git

SpecialLog: Don't put assignment within another expression

Change-Id: I0a0cd9ee0647e8778d2e835cc02c571a83b3a8c2
---

diff --git a/includes/specials/SpecialLog.php b/includes/specials/SpecialLog.php
index 7132207e24..85728ef0d7 100644
--- a/includes/specials/SpecialLog.php
+++ b/includes/specials/SpecialLog.php
@@ -147,7 +147,8 @@ class SpecialLog extends SpecialPage {
 
 	private function parseParams( FormOptions $opts, $par ) {
 		# Get parameters
-		$parms = explode( '/', ( $par = ( $par !== null ) ? $par : '' ) );
+		$par = $par !== null ? $par : '';
+		$parms = explode( '/', $par );
 		$symsForAll = [ '*', 'all' ];
 		if ( $parms[0] != '' &&
 			( in_array( $par, $this->getConfig()->get( 'LogTypes' ) ) || in_array( $par, $symsForAll ) )