From: Stephane Bisson <sbisson@wikimedia.org>
Date: Tue, 2 Oct 2018 16:55:12 +0000 (-0400)
Subject: RCFilters: better vertical alignment of checkbox and text in menus
X-Git-Tag: 1.34.0-rc.0~3919^2
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=d1143076ca6e411bd2f562b56532a578577ba656;p=lhc%2Fweb%2Fwiklou.git

RCFilters: better vertical alignment of checkbox and text in menus

- Remove min-height so menu items are a little smaller and
  their content is vertically-aligned.

- Force `vertical-align: middle;` for checkboxes by overriding
  OOUI with extreme specificity.

Bug: T200364
Change-Id: If0b2b5c1b749f913badbd0c02a85852ec0007020
---

diff --git a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ItemMenuOptionWidget.less b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ItemMenuOptionWidget.less
index 1cc48e2b4f..bf855be970 100644
--- a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ItemMenuOptionWidget.less
+++ b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ItemMenuOptionWidget.less
@@ -3,7 +3,6 @@
 @import 'mw.rcfilters.variables';
 
 .mw-rcfilters-ui-itemMenuOptionWidget {
-	min-height: 3.5em;
 	padding: 0 0.5em;
 	.box-sizing( border-box );
 
@@ -53,12 +52,15 @@
 		.oo-ui-fieldLayout.oo-ui-fieldLayout-align-inline {
 			// Override margin-top and -bottom rules from FieldLayout
 			margin: 0 !important; /* stylelint-disable-line declaration-no-important */
+
+			.oo-ui-fieldLayout-body > .oo-ui-fieldLayout-field {
+				vertical-align: middle;
+			}
 		}
 
 		.oo-ui-checkboxInputWidget {
 			// Workaround for IE11 rendering issues. T162098
 			display: block;
-			padding-top: 1em;
 		}
 
 		label {