From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Mon, 1 Dec 2008 17:02:05 +0000 (+0000)
Subject: Remove extract() comment
X-Git-Tag: 1.31.0-rc.0~44156
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=be40995b132c56649ea5138ff0434f04d5225c3c;p=lhc%2Fweb%2Fwiklou.git

Remove extract() comment
---

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 537d6b77c4..e3f6d6899f 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -339,7 +339,6 @@ class OldChangesList extends ChangesList {
 		wfProfileIn( __METHOD__ );
 
 		# Extract DB fields into local scope
-		// FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
 		extract( $rc->mAttribs );
 
 		# Should patrol-related stuff be shown?
@@ -433,7 +432,6 @@ class EnhancedChangesList extends ChangesList {
 		$rc = RCCacheEntry::newFromParent( $baseRC );
 
 		# Extract fields from DB into the function scope (rc_xxxx variables)
-		// FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
 		extract( $rc->mAttribs );
 		$curIdEq = 'curid=' . $rc_cur_id;
 
@@ -722,7 +720,6 @@ class EnhancedChangesList extends ChangesList {
 		$r .= '<table cellpadding="0" cellspacing="0"  border="0" style="background: none">';
 		foreach( $block as $rcObj ) {
 			# Get rc_xxxx variables
-			// FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
 			extract( $rcObj->mAttribs );
 
 			#$r .= '<tr><td valign="top">'.$this->spacerArrow();
@@ -842,7 +839,6 @@ class EnhancedChangesList extends ChangesList {
 	protected function recentChangesBlockLine( $rcObj ) {
 		global $wgContLang, $wgRCShowChangedSize;
 		# Get rc_xxxx variables
-		// FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
 		extract( $rcObj->mAttribs );
 		$curIdEq = "curid={$rc_cur_id}";