From: mainframe98 <k.s.werf@hotmail.com>
Date: Tue, 19 Feb 2019 15:01:59 +0000 (+0100)
Subject: Follow-up 262fd58: Correctly apply the ORDER BY in ActiveUsersPager
X-Git-Tag: 1.34.0-rc.0~2787
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=b4cdfaa09557db9144c1d84f2ea3cc57810c8374;p=lhc%2Fweb%2Fwiklou.git

Follow-up 262fd58: Correctly apply the ORDER BY in ActiveUsersPager

In 262fd58, an ORDER BY clause was added, but the direction it
is supposed to use was not loaded correctly from the $data array.
It is available under the key 'order', not 'dir'.

Bug: T216200
Change-Id: I5e675c98820813cd9107865e11e82ae57828a974
---

diff --git a/includes/specials/pagers/ActiveUsersPager.php b/includes/specials/pagers/ActiveUsersPager.php
index 3fac73c77f..aedb9e6b94 100644
--- a/includes/specials/pagers/ActiveUsersPager.php
+++ b/includes/specials/pagers/ActiveUsersPager.php
@@ -99,7 +99,7 @@ class ActiveUsersPager extends UsersPager {
 		];
 		$options = [];
 		if ( $data !== null ) {
-			$options['ORDER BY'] = 'qcc_title ' . $data['dir'];
+			$options['ORDER BY'] = 'qcc_title ' . $data['order'];
 			$options['LIMIT'] = $data['limit'];
 			$conds = array_merge( $conds, $data['conds'] );
 		}