From: Chad Horohoe <demon@users.mediawiki.org>
Date: Thu, 7 Jul 2011 16:59:25 +0000 (+0000)
Subject: (bug 27410) The tag filter on a history page should be within a <label> element.... 
X-Git-Tag: 1.31.0-rc.0~29013
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=8e77c121aff417874848fa3d041267215793ea26;p=lhc%2Fweb%2Fwiklou.git

(bug 27410) The tag filter on a history page should be within a <label> element. Patch by The Evil IP Address.

Also remove inclusion protection for the 800th time: if a file only has classes, you don't need to do this :)
---

diff --git a/CREDITS b/CREDITS
index bf9faab863..dfde8873af 100644
--- a/CREDITS
+++ b/CREDITS
@@ -148,6 +148,7 @@ following names for their contribution to the product.
 * Stefano Codari
 * Str4nd
 * svip
+* The Evil IP address
 * Tisane
 * Tobias Müller
 * Umherirrender
diff --git a/RELEASE-NOTES-1.19 b/RELEASE-NOTES-1.19
index e0da1678f8..7e3b454121 100644
--- a/RELEASE-NOTES-1.19
+++ b/RELEASE-NOTES-1.19
@@ -145,6 +145,7 @@ production.
   unneeded CSS flipping of quickbar. Instead, introduce option 5 which sets
   left/right according to the directionality of your interface language.
 * (bug 19514) Unordered list list-style-image should be IE6-compatible (8-bit)
+* (bug 27410) The tag filter on a history page is now within a <label> element
 
 === API changes in 1.19 ===
 * BREAKING CHANGE: action=watch now requires POST and token.
diff --git a/includes/ChangeTags.php b/includes/ChangeTags.php
index 76662dab52..6c8f4cbafa 100644
--- a/includes/ChangeTags.php
+++ b/includes/ChangeTags.php
@@ -1,8 +1,5 @@
 <?php
 
-if( !defined( 'MEDIAWIKI' ) )
-	die;
-
 class ChangeTags {
 	static function formatSummaryRow( $tags, $page ) {
 		if( !$tags )
@@ -165,7 +162,8 @@ class ChangeTags {
 		if ( !$wgUseTagFilter || !count( self::listDefinedTags() ) )
 			return $fullForm ? '' : array();
 
-		$data = array( wfMsgExt( 'tag-filter', 'parseinline' ), Xml::input( 'tagfilter', 20, $selected ) );
+		$data = array( Xml::label( wfMsgExt( 'tag-filter', 'parseinline' ), 'tagfilter' ),
+			Xml::input( 'tagfilter', 20, $selected ) );
 
 		if ( !$fullForm ) {
 			return $data;