From: Brad Jorsch <bjorsch@wikimedia.org>
Date: Fri, 16 May 2014 15:11:55 +0000 (-0400)
Subject: Use type hinting in ApiBase
X-Git-Tag: 1.31.0-rc.0~15388
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=68ce4da189813c734900e556b1b2a2382f54b6e9;p=lhc%2Fweb%2Fwiklou.git

Use type hinting in ApiBase

For ideological reasons this was not included in Ie6bf1915.

Change-Id: I5f7119665746eb6fcf86c3a403caa2dcb67904eb
---

diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index b649adf4e1..0313141b15 100644
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -87,17 +87,19 @@ abstract class ApiBase extends ContextSource {
 	 */
 	const GET_VALUES_FOR_HELP = 1;
 
-	private $mMainModule, $mModuleName, $mModulePrefix;
+	/** @var ApiMain */
+	private $mMainModule;
+	/** @var string */
+	private $mModuleName, $mModulePrefix;
 	private $mSlaveDB = null;
 	private $mParamCache = array();
 
 	/**
-	 * Constructor
 	 * @param ApiMain $mainModule
 	 * @param string $moduleName Name of this module
 	 * @param string $modulePrefix Prefix to use for parameter names
 	 */
-	public function __construct( $mainModule, $moduleName, $modulePrefix = '' ) {
+	public function __construct( ApiMain $mainModule, $moduleName, $modulePrefix = '' ) {
 		$this->mMainModule = $mainModule;
 		$this->mModuleName = $moduleName;
 		$this->mModulePrefix = $modulePrefix;