From: Timo Tijhof <krinklemail@gmail.com>
Date: Wed, 16 Jul 2014 02:12:12 +0000 (+0200)
Subject: mw.loader: Don't create addScript() callback if we don't need one
X-Git-Tag: 1.31.0-rc.0~14869
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=589bba9582ca5fe9c1dd9bc83b76e90f21ef4826;p=lhc%2Fweb%2Fwiklou.git

mw.loader: Don't create addScript() callback if we don't need one

$.Deferred#always ($.Callbacks#add) ignores undefined/null. No
need to create an inline function that does nothing.

Change-Id: Ifd96ac13e03242279e7d584cf91d899adadfed91
---

diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js
index b22e24019e..57838d47db 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -1069,11 +1069,7 @@
 						crossDomain: true,
 						cache: true,
 						async: true
-					} ).always( function () {
-						if ( callback  ) {
-							callback();
-						}
-					} );
+					} ).always( callback );
 				} else {
 					/*jshint evil:true */
 					document.write( mw.html.element( 'script', { 'src': src }, '' ) );