From: Kevin Israel <pleasestand@live.com>
Date: Sat, 21 Jun 2014 01:21:46 +0000 (-0400)
Subject: Fix some findHooks.php errors
X-Git-Tag: 1.31.0-rc.0~15308
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=4bbd1c44d90f4d9b7a1b1048aa408ec3534deb37;p=lhc%2Fweb%2Fwiklou.git

Fix some findHooks.php errors

* Correct typo in docs/hooks.txt.
* Add a few directories.

Left unfixed is "Undocumented: Special{$this->getName()}BeforeFormDisplay",
which will be addressed separately.

Change-Id: I4fda8960642c23500bd20e0b89c1d1327456313b
---

diff --git a/docs/hooks.txt b/docs/hooks.txt
index 4c2fd897c7..80ac174fb5 100644
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -1041,11 +1041,11 @@ yourself. Alternatively, modifying $error and returning true will cause the
 contents of $error to be echoed at the top of the edit form as wikitext.
 Return true without altering $error to allow the edit to proceed.
 
-'EditPage::showReadOnlyForm:initial: similar to EditPage::showEditForm:initial
-but for the readonly 'view source' variant of the edit form.
+'EditPage::showReadOnlyForm:initial': similar to EditPage::showEditForm:initial
+but for the read-only 'view source' variant of the edit form.
 $editor: EditPage instance (object)
 &$out: an OutputPage instance to write to
-return value is ignored (should alway return true)
+return value is ignored (should always return true)
 
 'EditPage::showStandardInputs:options': allows injection of form fields into
 the editOptions area
diff --git a/maintenance/findHooks.php b/maintenance/findHooks.php
index 86c01f4c40..043aed2f53 100644
--- a/maintenance/findHooks.php
+++ b/maintenance/findHooks.php
@@ -63,6 +63,8 @@ class FindHooks extends Maintenance {
 		$documented = $this->getHooksFromDoc( $IP . '/docs/hooks.txt' );
 		$potential = array();
 		$bad = array();
+
+		// TODO: Don't hardcode the list of directories
 		$pathinc = array(
 			$IP . '/',
 			$IP . '/includes/',
@@ -99,6 +101,7 @@ class FindHooks extends Maintenance {
 			$IP . '/includes/specialpage/',
 			$IP . '/includes/specials/',
 			$IP . '/includes/upload/',
+			$IP . '/includes/utils/',
 			$IP . '/languages/',
 			$IP . '/maintenance/',
 			$IP . '/maintenance/language/',
@@ -106,6 +109,8 @@ class FindHooks extends Maintenance {
 			$IP . '/tests/parser/',
 			$IP . '/tests/phpunit/suites/',
 			$IP . '/skins/',
+			$IP . '/skins/monobook/',
+			$IP . '/skins/Vector/',
 		);
 
 		foreach ( $pathinc as $dir ) {