From: Aryeh Gregor <simetrical@users.mediawiki.org>
Date: Mon, 5 Jan 2009 15:59:17 +0000 (+0000)
Subject: Add comment on urlencoding fragments
X-Git-Tag: 1.31.0-rc.0~43564
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=3272f4a08a1965a0a9e2c7bd2261b16300bdadfa;p=lhc%2Fweb%2Fwiklou.git

Add comment on urlencoding fragments
---

diff --git a/includes/Title.php b/includes/Title.php
index 95b2e51476..9fd4c79c85 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -452,6 +452,10 @@ class Title {
 	 */
 	static function escapeFragmentForURL( $fragment ) {
 		global $wgEnforceHtmlIds;
+		# Note that we don't urlencode the fragment.  urlencoded Unicode
+		# fragments appear not to work in IE (at least up to 7) or in at least
+		# one version of Opera 9.x.  The W3C validator, for one, doesn't seem
+		# to care if they aren't encoded.
 		return Sanitizer::escapeId( $fragment,
 			$wgEnforceHtmlIds ? array() : 'xml' );
 	}