From: Roan Kattouw <catrope@users.mediawiki.org>
Date: Thu, 9 Feb 2012 00:10:50 +0000 (+0000)
Subject: (bug 31676) Group dynamically inserted CSS into a single <style> tag, because IE... 
X-Git-Tag: 1.31.0-rc.0~24849
X-Git-Url: http://git.cyclocoop.org/data/Fool?a=commitdiff_plain;h=171bf290c8416043f88c91a88ba82c7edb4fe16c;p=lhc%2Fweb%2Fwiklou.git

(bug 31676) Group dynamically inserted CSS into a single <style> tag, because IE limits the number of styles it'll apply to 32 (seriously?!?). 3rd party users were complaining about IE not applying some modules' CSS when many modules were loaded; this wasn't a problem on WMF wikis as far as I know
---

diff --git a/RELEASE-NOTES-1.19 b/RELEASE-NOTES-1.19
index ce0c471c27..c7a33871bc 100644
--- a/RELEASE-NOTES-1.19
+++ b/RELEASE-NOTES-1.19
@@ -245,6 +245,8 @@ production.
 * It is now possible to delete images that have no corresponding description pages.
 * (bug 33165) GlobalFunctions.php line 1312: Call to a member function
   getText() on a non-object
+* (bug 31676) Group dynamically inserted CSS into a single <style> tag, to work
+  around a bug where not all styles were applied in Internet Explorer
 
 === API changes in 1.19 ===
 * Made action=edit less likely to return "unknownerror", by returning the actual error
diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js
index bac53b6ab9..ccd3407b13 100644
--- a/resources/mediawiki/mediawiki.js
+++ b/resources/mediawiki/mediawiki.js
@@ -375,7 +375,7 @@ var mw = ( function ( $, undefined ) {
 	
 			/* Private methods */
 	
-			function getMarker(){
+			function getMarker() {
 				// Cached ?
 				if ( $marker ) {
 					return $marker;
@@ -389,6 +389,27 @@ var mw = ( function ( $, undefined ) {
 					return $marker;
 				}
 			}
+			
+			function addInlineCSS( css, media ) {
+				var $style = getMarker().prev();
+				if ( $style.is( 'style' ) && $style.data( 'ResourceLoaderDynamicStyleTag' ) === true ) {
+					// There's already a dynamic <style> tag present, append to it
+					// This recycling of <style> tags is for bug 31676 (can't have
+					// more than 32 <style> tags in IE)
+					
+					// Do cdata sanitization on the provided CSS, and prepend a double newline
+					css = $( mw.html.element( 'style', {}, new mw.html.Cdata( "\n\n" + css ) ) ).html();
+					$style.append( css );
+				} else {
+					// Create a new <style> tag and insert it
+					$style = $( mw.html.element( 'style', {
+							'type': 'text/css',
+							'media': media
+						}, new mw.html.Cdata( css ) ) );
+					$style.data( 'ResourceLoaderDynamicStyleTag', true );
+					getMarker().before( $style );
+				}
+			}
 	
 			function compare( a, b ) {
 				var i;
@@ -686,10 +707,7 @@ var mw = ( function ( $, undefined ) {
 								} ) );
 							}
 						} else if ( typeof style === 'string' ) {
-							getMarker().before( mw.html.element( 'style', {
-								'type': 'text/css',
-								'media': media
-							}, new mw.html.Cdata( style ) ) );
+							addInlineCSS( style, media );
 						}
 					}
 				}