From: Aaron Schulz <aschulz@wikimedia.org>
Date: Wed, 8 May 2019 20:32:19 +0000 (-0700)
Subject: Make powersearch form use POST if JS is disabled
X-Git-Tag: 1.34.0-rc.0~1749^2
X-Git-Url: http://git.cyclocoop.org/data/File:Image2.gif?a=commitdiff_plain;h=8f9e8b3f0eac01d9fb99bfbea8f9675c05acd073;p=lhc%2Fweb%2Fwiklou.git

Make powersearch form use POST if JS is disabled

This means that the rememberme checkbox will not result in DB
writes on HTTP GET. If JS is enabled, it becomes GET initially.

Bug: T151903
Change-Id: If700ba9d6d1fe582d3d7c5660fcefd6d2639e4ee
---

diff --git a/includes/widget/search/SearchFormWidget.php b/includes/widget/search/SearchFormWidget.php
index 66b65667c2..7c28b5efe7 100644
--- a/includes/widget/search/SearchFormWidget.php
+++ b/includes/widget/search/SearchFormWidget.php
@@ -50,12 +50,15 @@ class SearchFormWidget {
 		$offset,
 		$isPowerSearch
 	) {
+		$user = $this->specialSearch->getUser();
+
 		return '<div class="mw-search-form-wrapper">' .
 			Xml::openElement(
 				'form',
 				[
 					'id' => $isPowerSearch ? 'powersearch' : 'search',
-					'method' => 'get',
+					// T151903: default to POST in case JS is disabled
+					'method' => ( $isPowerSearch && $user->isLoggedIn() ) ? 'post' : 'get',
 					'action' => wfScript(),
 				]
 			) .