From: Aaron Schulz <aschulz@wikimedia.org>
Date: Fri, 29 Mar 2019 01:06:59 +0000 (-0700)
Subject: Avoid calling setTransactionTicket() on a non-DataUpdate for sanity
X-Git-Tag: 1.34.0-rc.0~2256
X-Git-Url: http://git.cyclocoop.org/data/File:Image2.gif?a=commitdiff_plain;h=27f5535e208b26e4aa9eddbe133939c9833af9a9;p=lhc%2Fweb%2Fwiklou.git

Avoid calling setTransactionTicket() on a non-DataUpdate for sanity

Change-Id: Idbdb8bb2b8d065c8c86308ef8964e64fcd8dc7fb
---

diff --git a/includes/Storage/DerivedPageDataUpdater.php b/includes/Storage/DerivedPageDataUpdater.php
index 9ce12b4b13..d5c1656505 100644
--- a/includes/Storage/DerivedPageDataUpdater.php
+++ b/includes/Storage/DerivedPageDataUpdater.php
@@ -1590,8 +1590,9 @@ class DerivedPageDataUpdater implements IDBAccessObject {
 				$update->setRevision( $legacyRevision );
 				$update->setTriggeringUser( $triggeringUser );
 			}
+
 			if ( $options['defer'] === false ) {
-				if ( $options['transactionTicket'] !== null ) {
+				if ( $update instanceof DataUpdate && $options['transactionTicket'] !== null ) {
 					$update->setTransactionTicket( $options['transactionTicket'] );
 				}
 				$update->doUpdate();