From f5a31f5be0c23bb14a754032803aa226ce761411 Mon Sep 17 00:00:00 2001
From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Tue, 19 Feb 2019 15:18:12 +0100
Subject: [PATCH] Remove comments literally documenting unit tests being unit
 tests

The name of the test class and method as well as the @covers tags already
explain well enough which code a test is testing. Repeating this does not
provide additional information.

Change-Id: Ieec4ec131e5925d11704a11e1df46bc00c9fad9b
---
 tests/phpunit/includes/DiffHistoryBlobTest.php                 | 1 -
 tests/phpunit/includes/FauxResponseTest.php                    | 2 --
 tests/phpunit/includes/HtmlTest.php                            | 1 -
 tests/phpunit/includes/MultiHttpClientTest.php                 | 2 --
 .../includes/htmlform/HTMLAutoCompleteSelectFieldTest.php      | 2 --
 tests/phpunit/includes/htmlform/HTMLCheckMatrixTest.php        | 1 -
 tests/phpunit/includes/installer/OracleInstallerTest.php       | 2 --
 tests/phpunit/includes/libs/IEUrlExtensionTest.php             | 3 ---
 tests/phpunit/includes/libs/ProcessCacheLRUTest.php            | 2 --
 tests/phpunit/includes/site/DBSiteStoreTest.php                | 2 --
 tests/phpunit/includes/site/MediaWikiSiteTest.php              | 2 --
 tests/phpunit/includes/site/SiteExporterTest.php               | 2 --
 tests/phpunit/includes/site/SiteImporterTest.php               | 2 --
 tests/phpunit/includes/site/SiteListTest.php                   | 2 --
 tests/phpunit/includes/site/SiteTest.php                       | 2 --
 tests/phpunit/maintenance/backupPrefetchTest.php               | 2 --
 16 files changed, 30 deletions(-)

diff --git a/tests/phpunit/includes/DiffHistoryBlobTest.php b/tests/phpunit/includes/DiffHistoryBlobTest.php
index c267a30e05..b75862ea0c 100644
--- a/tests/phpunit/includes/DiffHistoryBlobTest.php
+++ b/tests/phpunit/includes/DiffHistoryBlobTest.php
@@ -15,7 +15,6 @@ class DiffHistoryBlobTest extends MediaWikiTestCase {
 	}
 
 	/**
-	 * Test for DiffHistoryBlob::xdiffAdler32()
 	 * @dataProvider provideXdiffAdler32
 	 * @covers DiffHistoryBlob::xdiffAdler32
 	 */
diff --git a/tests/phpunit/includes/FauxResponseTest.php b/tests/phpunit/includes/FauxResponseTest.php
index eac56fb841..8085bc710c 100644
--- a/tests/phpunit/includes/FauxResponseTest.php
+++ b/tests/phpunit/includes/FauxResponseTest.php
@@ -1,7 +1,5 @@
 <?php
 /**
- * Tests for the FauxResponse class
- *
  * Copyright @ 2011 Alexandre Emsenhuber
  *
  * This program is free software; you can redistribute it and/or modify
diff --git a/tests/phpunit/includes/HtmlTest.php b/tests/phpunit/includes/HtmlTest.php
index 1d687e517c..999e0bb56c 100644
--- a/tests/phpunit/includes/HtmlTest.php
+++ b/tests/phpunit/includes/HtmlTest.php
@@ -212,7 +212,6 @@ class HtmlTest extends MediaWikiTestCase {
 	}
 
 	/**
-	 * Test for Html::expandAttributes()
 	 * Please note it output a string prefixed with a space!
 	 * @covers Html::expandAttributes
 	 */
diff --git a/tests/phpunit/includes/MultiHttpClientTest.php b/tests/phpunit/includes/MultiHttpClientTest.php
index 7073b71023..1c7e62d092 100644
--- a/tests/phpunit/includes/MultiHttpClientTest.php
+++ b/tests/phpunit/includes/MultiHttpClientTest.php
@@ -1,8 +1,6 @@
 <?php
 
 /**
- * Tests for MultiHttpClient
- *
  * The urls herein are not actually called, because we mock the return results.
  *
  * @covers MultiHttpClient
diff --git a/tests/phpunit/includes/htmlform/HTMLAutoCompleteSelectFieldTest.php b/tests/phpunit/includes/htmlform/HTMLAutoCompleteSelectFieldTest.php
index 99bea68dbf..eaba22d7fb 100644
--- a/tests/phpunit/includes/htmlform/HTMLAutoCompleteSelectFieldTest.php
+++ b/tests/phpunit/includes/htmlform/HTMLAutoCompleteSelectFieldTest.php
@@ -1,7 +1,5 @@
 <?php
 /**
- * Unit tests for HTMLAutoCompleteSelectField
- *
  * @covers HTMLAutoCompleteSelectField
  */
 class HTMLAutoCompleteSelectFieldTest extends MediaWikiTestCase {
diff --git a/tests/phpunit/includes/htmlform/HTMLCheckMatrixTest.php b/tests/phpunit/includes/htmlform/HTMLCheckMatrixTest.php
index 4089470ef5..05c567df75 100644
--- a/tests/phpunit/includes/htmlform/HTMLCheckMatrixTest.php
+++ b/tests/phpunit/includes/htmlform/HTMLCheckMatrixTest.php
@@ -1,7 +1,6 @@
 <?php
 
 /**
- * Unit tests for the HTMLCheckMatrix
  * @covers HTMLCheckMatrix
  */
 class HTMLCheckMatrixTest extends MediaWikiTestCase {
diff --git a/tests/phpunit/includes/installer/OracleInstallerTest.php b/tests/phpunit/includes/installer/OracleInstallerTest.php
index 2811a9cf41..e255089de4 100644
--- a/tests/phpunit/includes/installer/OracleInstallerTest.php
+++ b/tests/phpunit/includes/installer/OracleInstallerTest.php
@@ -1,8 +1,6 @@
 <?php
 
 /**
- * Tests for OracleInstaller
- *
  * @group Database
  * @group Installer
  */
diff --git a/tests/phpunit/includes/libs/IEUrlExtensionTest.php b/tests/phpunit/includes/libs/IEUrlExtensionTest.php
index 9ec660e2c5..e04b2e21bf 100644
--- a/tests/phpunit/includes/libs/IEUrlExtensionTest.php
+++ b/tests/phpunit/includes/libs/IEUrlExtensionTest.php
@@ -1,8 +1,5 @@
 <?php
 
-/**
- * Tests for IEUrlExtension::findIE6Extension
- */
 class IEUrlExtensionTest extends PHPUnit\Framework\TestCase {
 
 	use MediaWikiCoversValidator;
diff --git a/tests/phpunit/includes/libs/ProcessCacheLRUTest.php b/tests/phpunit/includes/libs/ProcessCacheLRUTest.php
index c9fa3205fe..8e91e70cb0 100644
--- a/tests/phpunit/includes/libs/ProcessCacheLRUTest.php
+++ b/tests/phpunit/includes/libs/ProcessCacheLRUTest.php
@@ -1,8 +1,6 @@
 <?php
 
 /**
- * Test for ProcessCacheLRU class.
- *
  * Note that it uses the ProcessCacheLRUTestable class which extends some
  * properties and methods visibility. That class is defined at the end of the
  * file containing this class.
diff --git a/tests/phpunit/includes/site/DBSiteStoreTest.php b/tests/phpunit/includes/site/DBSiteStoreTest.php
index da6e9f9305..14ee15b635 100644
--- a/tests/phpunit/includes/site/DBSiteStoreTest.php
+++ b/tests/phpunit/includes/site/DBSiteStoreTest.php
@@ -3,8 +3,6 @@
 use MediaWiki\MediaWikiServices;
 
 /**
- * Tests for the DBSiteStore class.
- *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
diff --git a/tests/phpunit/includes/site/MediaWikiSiteTest.php b/tests/phpunit/includes/site/MediaWikiSiteTest.php
index d198462368..a9732d1c3d 100644
--- a/tests/phpunit/includes/site/MediaWikiSiteTest.php
+++ b/tests/phpunit/includes/site/MediaWikiSiteTest.php
@@ -1,8 +1,6 @@
 <?php
 
 /**
- * Tests for the MediaWikiSite class.
- *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
diff --git a/tests/phpunit/includes/site/SiteExporterTest.php b/tests/phpunit/includes/site/SiteExporterTest.php
index db900da914..97a43f8d5b 100644
--- a/tests/phpunit/includes/site/SiteExporterTest.php
+++ b/tests/phpunit/includes/site/SiteExporterTest.php
@@ -1,8 +1,6 @@
 <?php
 
 /**
- * Tests for the SiteExporter class.
- *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
diff --git a/tests/phpunit/includes/site/SiteImporterTest.php b/tests/phpunit/includes/site/SiteImporterTest.php
index bd95a501be..dbdbd6fcc2 100644
--- a/tests/phpunit/includes/site/SiteImporterTest.php
+++ b/tests/phpunit/includes/site/SiteImporterTest.php
@@ -1,8 +1,6 @@
 <?php
 
 /**
- * Tests for the SiteImporter class.
- *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
diff --git a/tests/phpunit/includes/site/SiteListTest.php b/tests/phpunit/includes/site/SiteListTest.php
index a4a171c941..3c4a4bf0d4 100644
--- a/tests/phpunit/includes/site/SiteListTest.php
+++ b/tests/phpunit/includes/site/SiteListTest.php
@@ -1,8 +1,6 @@
 <?php
 
 /**
- * Tests for the SiteList class.
- *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
diff --git a/tests/phpunit/includes/site/SiteTest.php b/tests/phpunit/includes/site/SiteTest.php
index ac5f956e7a..9ad61b2359 100644
--- a/tests/phpunit/includes/site/SiteTest.php
+++ b/tests/phpunit/includes/site/SiteTest.php
@@ -1,8 +1,6 @@
 <?php
 
 /**
- * Tests for the Site class.
- *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
diff --git a/tests/phpunit/maintenance/backupPrefetchTest.php b/tests/phpunit/maintenance/backupPrefetchTest.php
index 8824c7af58..747d2bfa13 100644
--- a/tests/phpunit/maintenance/backupPrefetchTest.php
+++ b/tests/phpunit/maintenance/backupPrefetchTest.php
@@ -6,8 +6,6 @@ use BaseDump;
 use MediaWikiTestCase;
 
 /**
- * Tests for BaseDump
- *
  * @group Dump
  * @covers BaseDump
  */
-- 
2.20.1