From: Kosta Harlan <kharlan@wikimedia.org>
Date: Wed, 2 Jan 2019 16:24:20 +0000 (-0500)
Subject: Temporarily make ContribsPager properties public to unblock Flow
X-Git-Tag: 1.34.0-rc.0~3145^2
X-Git-Url: http://git.cyclocoop.org/data/%7BGarradin/WEBSITE%7D?a=commitdiff_plain;h=e22be242941b30d03a43bda0e98e21707677b859;p=lhc%2Fweb%2Fwiklou.git

Temporarily make ContribsPager properties public to unblock Flow

This partially "reverts" Ic2367ca by explicitely marking the properties
Flow depends on as public. Before, these properties have not been
declared, but dynamically created. PHP marks dynamically created
properties as public by default.

Note that before Ic2367ca it was not even documented that these properties
exist. Flow was using undocumented code.

This revert is done to unblock the currently broken Beta cluster and
give us more time to find cleaner solutions. Some much more sustainable
solutions are discussed in T212771.

Bug: T212771
Change-Id: I2295a3fefe874a59458e6ea7edd2cfdd9e912096
---

diff --git a/includes/specials/pagers/ContribsPager.php b/includes/specials/pagers/ContribsPager.php
index ca13f3de85..92581a3c5b 100644
--- a/includes/specials/pagers/ContribsPager.php
+++ b/includes/specials/pagers/ContribsPager.php
@@ -37,24 +37,32 @@ class ContribsPager extends RangeChronologicalPager {
 
 	/**
 	 * @var string User name, or a string describing an IP address range
+	 * @private
+	 * @fixme Make private again after Flow got fixed.
 	 */
-	private $target;
+	public $target;
 
 	/**
 	 * @var string Set to "newbie" to list contributions from the most recent 1% registered users.
 	 *  $this->target is ignored then. Defaults to "users".
+	 * @private
+	 * @fixme Make private again after Flow got fixed.
 	 */
-	private $contribs;
+	public $contribs;
 
 	/**
 	 * @var string|int A single namespace number, or an empty string for all namespaces
+	 * @private
+	 * @fixme Make private again after Flow got fixed.
 	 */
-	private $namespace = '';
+	public $namespace = '';
 
 	/**
 	 * @var string|false Name of tag to filter, or false to ignore tags
+	 * @private
+	 * @fixme Make private again after Flow got fixed.
 	 */
-	private $tagFilter;
+	public $tagFilter;
 
 	/**
 	 * @var bool Set to true to invert the namespace selection
@@ -79,8 +87,10 @@ class ContribsPager extends RangeChronologicalPager {
 
 	/**
 	 * @var bool Set to true to show only new pages
+	 * @private
+	 * @fixme Make private again after Flow got fixed.
 	 */
-	private $newOnly;
+	public $newOnly;
 
 	/**
 	 * @var bool Set to true to hide edits marked as minor by the user