From 568631af97fdde99d1b218776c94b298c0fb171e Mon Sep 17 00:00:00 2001 From: Lucas Werkmeister Date: Wed, 11 Sep 2019 18:54:19 +0200 Subject: [PATCH] =?utf8?q?FauxRequest:=20don=E2=80=99t=20override=20getVal?= =?utf8?q?ues()?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit As far as I can tell, the override is not necessary (the only other method that the original implementation uses is getGPCVal(), which FauxRequest still uses elsewhere), and it breaks tests that rely on the filtering behavior. Change-Id: I7dd0a8dd36e31cc6784364d56e460b55bff6ea59 --- includes/FauxRequest.php | 8 -------- 1 file changed, 8 deletions(-) diff --git a/includes/FauxRequest.php b/includes/FauxRequest.php index 78f6ca9afa..9337270303 100644 --- a/includes/FauxRequest.php +++ b/includes/FauxRequest.php @@ -86,14 +86,6 @@ class FauxRequest extends WebRequest { return (string)$this->getVal( $name, $default ); } - /** - * @return array - * @suppress PhanParamSignatureMismatch - */ - public function getValues() { - return $this->data; - } - /** * @return array */ -- 2.20.1