From: Roan Kattouw <catrope@users.mediawiki.org>
Date: Sat, 23 Jul 2011 03:48:35 +0000 (+0000)
Subject: Change != {} to !$.isEmptyObject(): the former always returned true because objects... 
X-Git-Tag: 1.31.0-rc.0~28672
X-Git-Url: http://git.cyclocoop.org/data/%7B%24admin_url%7Dmembres/fiche.php?a=commitdiff_plain;h=a2ecfbc9452987c020c3c72c902f273954685cfd;p=lhc%2Fweb%2Fwiklou.git

Change != {} to !$.isEmptyObject(): the former always returned true because objects are compared by reference. This didn't cause any realistic problems, though: the worst that could happen is that if you have a module name longer than the query string request limit (which is extremely unusual), mediawiki.js would probably go into an infinite loop.
---

diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js
index 28a57a285f..1644f1c2e8 100644
--- a/resources/mediawiki/mediawiki.js
+++ b/resources/mediawiki/mediawiki.js
@@ -788,7 +788,7 @@ window.mediaWiki = new ( function( $ ) {
 
 					// If the request would become too long, create a new one,
 					// but don't create empty requests
-					if ( limit > 0 &&  reqs[r] != {} && l + bytesAdded > limit ) {
+					if ( limit > 0 && !$.isEmptyObject( reqs[r] ) && l + bytesAdded > limit ) {
 						// This request would become too long, create a new one
 						r++;
 						reqs[r] = {};